Uh oh!
There was an error while loading. Please reload this page.
doc: document net Socket server property - #64364
Merged
Merged
Conversation
nodejs-github-bot
commented
Jul 8, 2026
Collaborator
Review requested:
|
efekrskl
commented
Jul 8, 2026
MemberAuthor
Herrtian
commented
Jul 8, 2026
Contributor
@efekrskl Thanks for reviewing, I would appreciate if you add me as a co-author. |
Based on nodejs#63458. Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com> Signed-off-by: Efe Karasakal <hi@efe.dev> Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
efekrsklforce-pushed
the
doc/socket-server-doc
branch
from
July 8, 2026 21:16
1a91367 to
2f9130eCompareefekrskl
commented
Jul 8, 2026
MemberAuthor
I added you as co-author, thanks a lot for your contribution! |
lpinca
approved these changes
Jul 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 13, 2026
Collaborator
Landed in e84b517 |
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Based on #63458. Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com> Signed-off-by: Efe Karasakal <hi@efe.dev> Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com> PR-URL: #64364 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Based on #63458. Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com> Signed-off-by: Efe Karasakal <hi@efe.dev> Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com> PR-URL: #64364 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
Based on #63458. Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com> Signed-off-by: Efe Karasakal <hi@efe.dev> Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com> PR-URL: #64364 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
Based on #63458. Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com> Signed-off-by: Efe Karasakal <hi@efe.dev> Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com> PR-URL: #64364 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#47148, based on the change proposed in #63458.
Original patch and investigation by @Herrtian