http: remove unused n arg from IncomingMessage._read - #64370

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:http/remove-unused-arg-incoming-message
Jul 11, 2026
Merged

http: remove unused n arg from IncomingMessage._read#64370
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:http/remove-unused-arg-incoming-message

Conversation

@efekrskl

@efekrsklefekrskl commented Jul 8, 2026

Copy link
Copy Markdown
Member

Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed

Benchmarks look fine, no regression

node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http

http/incoming_headers.js w=0 new: 92,861.1 req/s old: 92,683.8 req/s Δ +0.19%
http/incoming_headers.js w=6 new: 92,280.2 req/s old: 92,099.9 req/s Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 8, 2026
@efekrskl
http: remove unused n arg from IncomingMessage._read
eb01019
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrsklforce-pushed the http/remove-unused-arg-incoming-message branch from 5df3874 to eb01019CompareJuly 8, 2026 18:27
@codecov

codecovBot commented Jul 8, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64370 +/- ##
=======================================
Coverage 90.25% 90.25% =======================================
Files 741 741 Lines 241165 241157 -8 Branches 45428 45427 -1 =======================================
- Hits 217667 217660 -7 
Misses 15069 15069 + Partials 8429 8428 -1
Files with missing linesCoverage Δ
lib/_http_incoming.js99.37% <100.00%> (-0.02%)⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterrypimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74680/

@pimterrypimterry added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 11, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 11, 2026
@nodejs-github-bot
nodejs-github-bot merged commit abe2545 into nodejs:mainJul 11, 2026
71 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Landed in abe2545

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
08ecdda
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
de5b734
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
@efekrskl@RafaelGSS
http: remove unused n arg from IncomingMessage._read
0047ad7
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
b57350f
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@badgerbeesbadgerbees mentioned this pull request Aug 13, 2026
Merged
@github-actionsgithub-actionsBot mentioned this pull request Aug 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes
+1 more reviewer
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

httpIssues and PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efekrskl@nodejs-github-bot@lpinca@pimterry@bjohansebas
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
http: remove unused n arg from IncomingMessage._read - #64370
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Jul 11, 2026
Merged
http: remove unused n arg from IncomingMessage._read#64370
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Conversation
@efekrskl
@efekrsklefekrskl
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed
Benchmarks look fine, no regression
node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http
http/incoming_headers.js w=0 new: 92,861.1 req/s old: 92,683.8 req/s Δ +0.19%
http/incoming_headers.js w=6 new: 92,280.2 req/s old: 92,099.9 req/s Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/http
  •  @nodejs/net
@nodejs-github-botnodejs-github-bot
added

http
Issues and PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 8, 2026
@efekrskl
http: remove unused n arg from IncomingMessage._read
eb01019
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrsklforce-pushed
the
http/remove-unused-arg-incoming-message
branch
from
5df3874 to
eb01019CompareJuly 8, 2026 18:27
@codecov
codecovBot
commented
Jul 8, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 18 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64370 +/- ##
=======================================
Coverage 90.25% 90.25% =======================================
Files 741 741 Lines 241165 241157 -8 Branches 45428 45427 -1 =======================================
- Hits 217667 217660 -7 
Misses 15069 15069 + Partials 8429 8428 -1 
Files with missing linesCoverage Δ
lib/_http_incoming.js99.37% <100.00%> (-0.02%)⬇️
... and 23 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74680/
@pimterrypimterry
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit abe2545
into
nodejs:mainJul 11, 2026

71 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 11, 2026

Copy link


Copy Markdown

Collaborator
Landed in abe2545
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
08ecdda
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
de5b734
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@efekrskl@RafaelGSS
http: remove unused n arg from IncomingMessage._read
0047ad7
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
b57350f
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@badgerbeesbadgerbees
mentioned this pull request
Aug 13, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@efekrskl@nodejs-github-bot@lpinca@pimterry@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
http: remove unused n arg from IncomingMessage._read - #64370
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Jul 11, 2026
Merged
http: remove unused n arg from IncomingMessage._read#64370
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Conversation
@efekrskl
@efekrsklefekrskl
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed
Benchmarks look fine, no regression
node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http
http/incoming_headers.js w=0 new: 92,861.1 req/s old: 92,683.8 req/s Δ +0.19%
http/incoming_headers.js w=6 new: 92,280.2 req/s old: 92,099.9 req/s Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/http
  •  @nodejs/net
@nodejs-github-botnodejs-github-bot
added

http
Issues and PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 8, 2026
@efekrskl
http: remove unused n arg from IncomingMessage._read
eb01019
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrsklforce-pushed
the
http/remove-unused-arg-incoming-message
branch
from
5df3874 to
eb01019CompareJuly 8, 2026 18:27
@codecov
codecovBot
commented
Jul 8, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 18 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64370 +/- ##
=======================================
Coverage 90.25% 90.25% =======================================
Files 741 741 Lines 241165 241157 -8 Branches 45428 45427 -1 =======================================
- Hits 217667 217660 -7 
Misses 15069 15069 + Partials 8429 8428 -1 
Files with missing linesCoverage Δ
lib/_http_incoming.js99.37% <100.00%> (-0.02%)⬇️
... and 23 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74680/
@pimterrypimterry
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit abe2545
into
nodejs:mainJul 11, 2026

71 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 11, 2026

Copy link


Copy Markdown

Collaborator
Landed in abe2545
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
08ecdda
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
de5b734
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@efekrskl@RafaelGSS
http: remove unused n arg from IncomingMessage._read
0047ad7
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
b57350f
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@badgerbeesbadgerbees
mentioned this pull request
Aug 13, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@efekrskl@nodejs-github-bot@lpinca@pimterry@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
http: remove unused n arg from IncomingMessage._read - #64370
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Jul 11, 2026
Merged
http: remove unused n arg from IncomingMessage._read#64370
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Conversation
@efekrskl
@efekrsklefekrskl
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed
Benchmarks look fine, no regression
node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http
http/incoming_headers.js w=0 new: 92,861.1 req/s old: 92,683.8 req/s Δ +0.19%
http/incoming_headers.js w=6 new: 92,280.2 req/s old: 92,099.9 req/s Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/http
  •  @nodejs/net
@nodejs-github-botnodejs-github-bot
added

http
Issues and PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 8, 2026
@efekrskl
http: remove unused n arg from IncomingMessage._read
eb01019
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrsklforce-pushed
the
http/remove-unused-arg-incoming-message
branch
from
5df3874 to
eb01019CompareJuly 8, 2026 18:27
@codecov
codecovBot
commented
Jul 8, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 18 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64370 +/- ##
=======================================
Coverage 90.25% 90.25% =======================================
Files 741 741 Lines 241165 241157 -8 Branches 45428 45427 -1 =======================================
- Hits 217667 217660 -7 
Misses 15069 15069 + Partials 8429 8428 -1 
Files with missing linesCoverage Δ
lib/_http_incoming.js99.37% <100.00%> (-0.02%)⬇️
... and 23 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74680/
@pimterrypimterry
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit abe2545
into
nodejs:mainJul 11, 2026

71 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 11, 2026

Copy link


Copy Markdown

Collaborator
Landed in abe2545
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
08ecdda
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
de5b734
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@efekrskl@RafaelGSS
http: remove unused n arg from IncomingMessage._read
0047ad7
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
b57350f
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@badgerbeesbadgerbees
mentioned this pull request
Aug 13, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@efekrskl@nodejs-github-bot@lpinca@pimterry@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
http: remove unused n arg from IncomingMessage._read - #64370
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Jul 11, 2026
Merged
http: remove unused n arg from IncomingMessage._read#64370
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Conversation
@efekrskl
@efekrsklefekrskl
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed
Benchmarks look fine, no regression
node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http
http/incoming_headers.js w=0 new: 92,861.1 req/s old: 92,683.8 req/s Δ +0.19%
http/incoming_headers.js w=6 new: 92,280.2 req/s old: 92,099.9 req/s Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/http
  •  @nodejs/net
@nodejs-github-botnodejs-github-bot
added

http
Issues and PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 8, 2026
@efekrskl
http: remove unused n arg from IncomingMessage._read
eb01019
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrsklforce-pushed
the
http/remove-unused-arg-incoming-message
branch
from
5df3874 to
eb01019CompareJuly 8, 2026 18:27
@codecov
codecovBot
commented
Jul 8, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 18 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64370 +/- ##
=======================================
Coverage 90.25% 90.25% =======================================
Files 741 741 Lines 241165 241157 -8 Branches 45428 45427 -1 =======================================
- Hits 217667 217660 -7 
Misses 15069 15069 + Partials 8429 8428 -1 
Files with missing linesCoverage Δ
lib/_http_incoming.js99.37% <100.00%> (-0.02%)⬇️
... and 23 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74680/
@pimterrypimterry
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit abe2545
into
nodejs:mainJul 11, 2026

71 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 11, 2026

Copy link


Copy Markdown

Collaborator
Landed in abe2545
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
08ecdda
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
de5b734
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@efekrskl@RafaelGSS
http: remove unused n arg from IncomingMessage._read
0047ad7
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
b57350f
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@badgerbeesbadgerbees
mentioned this pull request
Aug 13, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@efekrskl@nodejs-github-bot@lpinca@pimterry@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
http: remove unused n arg from IncomingMessage._read - #64370
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Jul 11, 2026
Merged
http: remove unused n arg from IncomingMessage._read#64370
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Conversation
@efekrskl
@efekrsklefekrskl
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed
Benchmarks look fine, no regression
node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http
http/incoming_headers.js w=0 new: 92,861.1 req/s old: 92,683.8 req/s Δ +0.19%
http/incoming_headers.js w=6 new: 92,280.2 req/s old: 92,099.9 req/s Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/http
  •  @nodejs/net
@nodejs-github-botnodejs-github-bot
added

http
Issues and PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 8, 2026
@efekrskl
http: remove unused n arg from IncomingMessage._read
eb01019
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrsklforce-pushed
the
http/remove-unused-arg-incoming-message
branch
from
5df3874 to
eb01019CompareJuly 8, 2026 18:27
@codecov
codecovBot
commented
Jul 8, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 18 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64370 +/- ##
=======================================
Coverage 90.25% 90.25% =======================================
Files 741 741 Lines 241165 241157 -8 Branches 45428 45427 -1 =======================================
- Hits 217667 217660 -7 
Misses 15069 15069 + Partials 8429 8428 -1 
Files with missing linesCoverage Δ
lib/_http_incoming.js99.37% <100.00%> (-0.02%)⬇️
... and 23 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74680/
@pimterrypimterry
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit abe2545
into
nodejs:mainJul 11, 2026

71 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 11, 2026

Copy link


Copy Markdown

Collaborator
Landed in abe2545
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
08ecdda
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
de5b734
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@efekrskl@RafaelGSS
http: remove unused n arg from IncomingMessage._read
0047ad7
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
b57350f
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@badgerbeesbadgerbees
mentioned this pull request
Aug 13, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@efekrskl@nodejs-github-bot@lpinca@pimterry@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
http: remove unused n arg from IncomingMessage._read - #64370
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Jul 11, 2026
Merged
http: remove unused n arg from IncomingMessage._read#64370
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Conversation
@efekrskl
@efekrsklefekrskl
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed
Benchmarks look fine, no regression
node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http
http/incoming_headers.js w=0 new: 92,861.1 req/s old: 92,683.8 req/s Δ +0.19%
http/incoming_headers.js w=6 new: 92,280.2 req/s old: 92,099.9 req/s Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/http
  •  @nodejs/net
@nodejs-github-botnodejs-github-bot
added

http
Issues and PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 8, 2026
@efekrskl
http: remove unused n arg from IncomingMessage._read
eb01019
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrsklforce-pushed
the
http/remove-unused-arg-incoming-message
branch
from
5df3874 to
eb01019CompareJuly 8, 2026 18:27
@codecov
codecovBot
commented
Jul 8, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 18 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64370 +/- ##
=======================================
Coverage 90.25% 90.25% =======================================
Files 741 741 Lines 241165 241157 -8 Branches 45428 45427 -1 =======================================
- Hits 217667 217660 -7 
Misses 15069 15069 + Partials 8429 8428 -1 
Files with missing linesCoverage Δ
lib/_http_incoming.js99.37% <100.00%> (-0.02%)⬇️
... and 23 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74680/
@pimterrypimterry
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit abe2545
into
nodejs:mainJul 11, 2026

71 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 11, 2026

Copy link


Copy Markdown

Collaborator
Landed in abe2545
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
08ecdda
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
de5b734
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@efekrskl@RafaelGSS
http: remove unused n arg from IncomingMessage._read
0047ad7
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
b57350f
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@badgerbeesbadgerbees
mentioned this pull request
Aug 13, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@efekrskl@nodejs-github-bot@lpinca@pimterry@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
http: remove unused n arg from IncomingMessage._read - #64370
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Jul 11, 2026
Merged
http: remove unused n arg from IncomingMessage._read#64370
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
efekrskl:http/remove-unused-arg-incoming-message
Conversation
@efekrskl
@efekrsklefekrskl
commented
Jul 8, 2026

Copy link


Copy Markdown

Member
Something I came across while reading the code. We are on V8 version 14.6 and https://bugs.chromium.org/p/v8/issues/detail?id=10201 seems to be long fixed
Benchmarks look fine, no regression
node benchmark/compare.js --runs 20 --old /tmp/node-before --new ./out/Release/node --filter incoming_headers http
http/incoming_headers.js w=0 new: 92,861.1 req/s old: 92,683.8 req/s Δ +0.19%
http/incoming_headers.js w=6 new: 92,280.2 req/s old: 92,099.9 req/s Δ +0.20%

"binary","filename","configuration","rate","time"
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88216,5.033902166
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91706,5.032816750
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92340,5.030441417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92358,5.032705292
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92810,5.032385083
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91917,5.032915125
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",95465,5.035307834
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94378,5.032257708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91278,5.030846958
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91491,5.032964208
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93601,5.032840333
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91972,5.030918709
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92830,5.030898750
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93305,5.033278459
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92541,5.030804209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93280,5.034695291
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93667,5.031394291
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92082,5.033757250
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",98752,5.032255875
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93297,5.031768750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93255,5.032932458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93808,5.034575917
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91068,5.031090833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92804,5.036295958
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91687,5.031114000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92187,5.033795209
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92487,5.030943500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.032132375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",96481,5.032132458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92391,5.032676667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93567,5.034867000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92793,5.033667750
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93374,5.032243500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91300,5.033162291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92952,5.031299625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91788,5.032875833
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92984,5.030787000
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92553,5.033792291
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92685,5.032433000
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93327,5.034474708
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93767,5.032476959
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91779,5.033934792
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92912,5.032719500
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93419,5.036553375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93720,5.033281458
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93450,5.033137417
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92272,5.031763125
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92573,5.034340792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93181,5.033145250
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93393,5.032651166
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92785,5.030968208
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92127,5.033030667
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92631,5.033490542
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91117,5.033555083
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93560,5.033145417
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92785,5.033146792
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93619,5.033333709
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92852,5.032217875
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92003,5.031525458
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",91929,5.033460375
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",91029,5.032543667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90248,5.034893667
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",89940,5.032874750
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88542,5.033250333
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90748,5.032593125
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90293,5.034885000
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",88850,5.032433708
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",88772,5.031771625
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",90696,5.031554792
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",90362,5.033429416
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92834,5.032394209
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92095,5.032017166
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",94268,5.031772667
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92035,5.033010458
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",92885,5.035188625
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",92955,5.034318459
"old","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93434,5.032026500
"old","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",93730,5.030823625
"new","http/incoming_headers.js","duration=5 w=0 headers=20 connections=50 benchmarker='test-double-http'",93722,5.036334833
"new","http/incoming_headers.js","duration=5 w=6 headers=20 connections=50 benchmarker='test-double-http'",94163,5.033176917

@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/http
  •  @nodejs/net
@nodejs-github-botnodejs-github-bot
added

http
Issues and PRs related to the http subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 8, 2026
@efekrskl
http: remove unused n arg from IncomingMessage._read
eb01019
Signed-off-by: Efe Karasakal <hi@efe.dev>
@efekrskl
efekrsklforce-pushed
the
http/remove-unused-arg-incoming-message
branch
from
5df3874 to
eb01019CompareJuly 8, 2026 18:27
@codecov
codecovBot
commented
Jul 8, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.25%. Comparing base (799e910) to head (eb01019).
⚠️ Report is 18 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64370 +/- ##
=======================================
Coverage 90.25% 90.25% =======================================
Files 741 741 Lines 241165 241157 -8 Branches 45428 45427 -1 =======================================
- Hits 217667 217660 -7 
Misses 15069 15069 + Partials 8429 8428 -1 
Files with missing linesCoverage Δ
lib/_http_incoming.js99.37% <100.00%> (-0.02%)⬇️
... and 23 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pimterrypimterry
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 8, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/74680/
@pimterrypimterry
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Jul 11, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit abe2545
into
nodejs:mainJul 11, 2026

71 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Jul 11, 2026

Copy link


Copy Markdown

Collaborator
Landed in abe2545
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
08ecdda
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Jul 21, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
de5b734
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
@efekrskl@RafaelGSS
http: remove unused n arg from IncomingMessage._read
0047ad7
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@efekrskl@aduh95
http: remove unused n arg from IncomingMessage._read
b57350f
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64370
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@badgerbeesbadgerbees
mentioned this pull request
Aug 13, 2026
 Merged

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@efekrskl@nodejs-github-bot@lpinca@pimterry@bjohansebas