Skip to content

test: fix 2nd flaky blob test case - #64391

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pimterry:fix-test-blob-flake
Jul 12, 2026
Merged

test: fix 2nd flaky blob test case#64391
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pimterry:fix-test-blob-flake

Conversation

@pimterry

Copy link
Copy Markdown
Member

#64106 fixed the flake for one test in this file, but it's still flaking (see nodejs/reliability#1596) due to the same issue in this very similar test below.

Signed-off-by: Tim Perry <pimterry@gmail.com>
@pimterry
pimterry requested a review from trivikrJuly 9, 2026 12:19
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 9, 2026
@codecov

codecovBot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (7036199) to head (5ccc830).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64391 +/- ##
==========================================
- Coverage 90.25% 90.24% -0.01% 
==========================================
Files 741 741 Lines 241207 241207 Branches 45424 45429 +5 ==========================================
- Hits 217696 217687 -9 + Misses 15087 15083 -4 - Partials 8424 8437 +13 

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry

Copy link
Copy Markdown
MemberAuthor

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 9, 2026
@pimterrypimterry added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2026
@nodejs-github-bot
nodejs-github-bot merged commit dca0fd1 into nodejs:mainJul 12, 2026
89 of 92 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in dca0fd1

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: #64391
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: #64391
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: #64391
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: #64391
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pimterry@nodejs-github-bot@jasnell@trivikr