stream: update iterable streams to use budget backpressure - #64464

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/iter-streams-backpressure-new
Closed

stream: update iterable streams to use budget backpressure#64464
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/iter-streams-backpressure-new

Conversation

@jasnell

@jasnelljasnell commented Jul 13, 2026

Copy link
Copy Markdown
Member

WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.

Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Opencode/Opus

@jasnell
jasnell requested review from mcollina and trivikrJuly 13, 2026 00:27
@jasnelljasnell added stream Issues and PRs related to Node.js streams. experimental Issues and PRs related to experimental features. labels Jul 13, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jul 13, 2026
@trivikr
trivikr requested a review from pimterryJuly 13, 2026 01:43
@trivikrtrivikr mentioned this pull request Jul 13, 2026
Closed
@codecov

codecovBot commented Jul 13, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (efc0a14) to head (da87db0).
⚠️ Report is 16 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/streams/iter/share.js77.04%14 Missing ⚠️
lib/internal/streams/iter/broadcast.js93.33%3 Missing ⚠️
lib/internal/streams/iter/classic.js66.66%1 Missing and 1 partial ⚠️
lib/internal/streams/iter/push.js96.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01% 
==========================================
Files 741 741 Lines 242196 242159 -37 Branches 45606 45611 +5 ==========================================
- Hits 218246 218237 -9 
Misses 15438 15438 + Partials 8512 8484 -28
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
lib/internal/quic/state.js100.00% <100.00%> (ø)
lib/internal/streams/iter/duplex.js96.35% <100.00%> (ø)
lib/internal/streams/iter/pull.js84.12% <100.00%> (+0.25%)⬆️
lib/internal/streams/iter/utils.js98.22% <100.00%> (-0.06%)⬇️
lib/internal/streams/iter/classic.js89.31% <66.66%> (-0.02%)⬇️
lib/internal/streams/iter/push.js90.92% <96.66%> (-0.26%)⬇️
lib/internal/streams/iter/broadcast.js86.24% <93.33%> (+0.24%)⬆️
lib/internal/streams/iter/share.js85.31% <77.04%> (+0.31%)⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pimterry
pimterry reviewed Jul 13, 2026
View reviewed changes
Comment threaddoc/api/stream_iter.md Outdated
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/broadcast.js Outdated
Comment threadlib/internal/streams/iter/push.js Outdated
Comment threadlib/internal/streams/iter/utils.js Outdated
@jasnell
jasnellforce-pushed the jasnell/iter-streams-backpressure-new branch from 939e46e to 9ae61ffCompareJuly 20, 2026 22:31
@jasnell
jasnell requested a review from pimterryJuly 20, 2026 22:34
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed the jasnell/iter-streams-backpressure-new branch from 9ae61ff to c55171fCompareJuly 20, 2026 22:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed the jasnell/iter-streams-backpressure-new branch from c55171f to efe85eeCompareJuly 21, 2026 13:31
@nodejs-github-bot

This comment was marked as low quality.

Sign in to view
@jasnell
jasnellforce-pushed the jasnell/iter-streams-backpressure-new branch from efe85ee to 5f41022CompareJuly 21, 2026 23:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
trivikr
trivikr approved these changes Jul 22, 2026
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 22, 2026
Merged
Merged
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@trivikr

This comment was marked as outdated.

Sign in to view
@jasnell
stream: update iterable streams to use budget backpressure
626aa29
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
stream, quic: update iterable streams backpressure
32925df
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
test: update quic tests for stream/iter update
da87db0
@jasnell
jasnellforce-pushed the jasnell/iter-streams-backpressure-new branch from f059d7e to da87db0CompareJuly 22, 2026 17:43
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2026•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75032/ 💚

Ethan-Arrowood
Ethan-Arrowood approved these changes Jul 23, 2026
View reviewed changes

@Ethan-ArrowoodEthan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.

@trivikr

trivikr commented Jul 23, 2026

Copy link
Copy Markdown
Member

From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers.

The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason.

@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
jasnell added a commit that referenced this pull request Jul 23, 2026
@jasnell
stream: update iterable streams to use budget backpressure
b9ed467
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit that referenced this pull request Jul 23, 2026
@jasnell
stream, quic: update iterable streams backpressure
64c1150
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit that referenced this pull request Jul 23, 2026
@jasnell
test: update quic tests for stream/iter update
3437feb
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell

jasnell commented Jul 23, 2026

Copy link
Copy Markdown
MemberAuthor

Landed in 82c823e...3437feb

@jasnelljasnell closed this Jul 23, 2026
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
0488d02
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
7331118
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
46b1177
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95aduh95 mentioned this pull request Jul 30, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
193091f
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
125c19d
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
dd1e713
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot mentioned this pull request Aug 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@trivikrtrivikrtrivikr approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@mcollinamcollinaAwaiting requested review from mcollina
+1 more reviewer
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@trivikr@pimterry@Ethan-Arrowood@bjohansebas
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
stream: update iterable streams to use budget backpressure - #64464
Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Closed
stream: update iterable streams to use budget backpressure#64464
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Conversation
@jasnell
@jasnelljasnell
commented
Jul 13, 2026

Copy link


Copy Markdown

Member
WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.
Signed-off-by: James M Snell jasnell@gmail.com

Assisted-by: Opencode/Opus
@jasnell
jasnell
requested review from
mcollina and trivikrJuly 13, 2026 00:27
@jasnelljasnell
added

stream
Issues and PRs related to Node.js streams.
experimental
Issues and PRs related to experimental features.
labels
Jul 13, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 13, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
Jul 13, 2026
@trivikr
trivikr
requested a review
from pimterryJuly 13, 2026 01:43
@trivikrtrivikr
mentioned this pull request
Jul 13, 2026

Closed

@codecov
codecovBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.12%. Comparing base (efc0a14) to head (da87db0).
⚠️ Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/streams/iter/share.js77.04%14 Missing ⚠️
lib/internal/streams/iter/broadcast.js93.33%3 Missing ⚠️
lib/internal/streams/iter/classic.js66.66%1 Missing and 1 partial ⚠️
lib/internal/streams/iter/push.js96.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01% 
==========================================
Files 741 741 Lines 242196 242159 -37 Branches 45606 45611 +5 ==========================================
- Hits 218246 218237 -9 
Misses 15438 15438 + Partials 8512 8484 -28 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
lib/internal/quic/state.js100.00% <100.00%> (ø)
lib/internal/streams/iter/duplex.js96.35% <100.00%> (ø)
lib/internal/streams/iter/pull.js84.12% <100.00%> (+0.25%)⬆️
lib/internal/streams/iter/utils.js98.22% <100.00%> (-0.06%)⬇️
lib/internal/streams/iter/classic.js89.31% <66.66%> (-0.02%)⬇️
lib/internal/streams/iter/push.js90.92% <96.66%> (-0.26%)⬇️
lib/internal/streams/iter/broadcast.js86.24% <93.33%> (+0.24%)⬆️
lib/internal/streams/iter/share.js85.31% <77.04%> (+0.31%)⬆️
... and 35 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
pimterry
pimterry
reviewed
Jul 13, 2026
View reviewed changes
Comment threaddoc/api/stream_iter.md
Outdated

Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/broadcast.js
Outdated

Comment threadlib/internal/streams/iter/push.js
Outdated

Comment threadlib/internal/streams/iter/utils.js
Outdated

@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
939e46e to
9ae61ffCompareJuly 20, 2026 22:31
@jasnell
jasnell
requested a review
from pimterryJuly 20, 2026 22:34
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
9ae61ff to
c55171fCompareJuly 20, 2026 22:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
c55171f to
efe85eeCompareJuly 21, 2026 13:31
@nodejs-github-bot

This comment was marked as low quality.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
efe85ee to
5f41022CompareJuly 21, 2026 23:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
trivikr
trivikr
approved these changes
Jul 22, 2026
View reviewed changes
@trivikrtrivikr
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 22, 2026
 Merged

 Merged

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@trivikr

This comment was marked as outdated.

Sign in to view
@jasnell
stream: update iterable streams to use budget backpressure
626aa29
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
stream, quic: update iterable streams backpressure
32925df
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
test: update quic tests for stream/iter update
da87db0
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
f059d7e to
da87db0CompareJuly 22, 2026 17:43
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 23, 2026•

edited by jasnell

Loading

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75032/ 💚
Ethan-Arrowood
Ethan-Arrowood
approved these changes
Jul 23, 2026
View reviewed changes
@Ethan-ArrowoodEthan-Arrowood
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.
@trivikr
trivikr
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers.
The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason.
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream: update iterable streams to use budget backpressure
b9ed467
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream, quic: update iterable streams backpressure
64c1150
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
test: update quic tests for stream/iter update
3437feb
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell
jasnell
commented
Jul 23, 2026

Copy link


Copy Markdown

MemberAuthor
Landed in 82c823e...3437feb
@jasnelljasnell
closed this
Jul 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
0488d02
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
7331118
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
46b1177
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95aduh95
mentioned this pull request
Jul 30, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
193091f
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
125c19d
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
dd1e713
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@trivikrtrivikrtrivikr approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@trivikr@pimterry@Ethan-Arrowood@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
stream: update iterable streams to use budget backpressure - #64464
Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Closed
stream: update iterable streams to use budget backpressure#64464
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Conversation
@jasnell
@jasnelljasnell
commented
Jul 13, 2026

Copy link


Copy Markdown

Member
WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.
Signed-off-by: James M Snell jasnell@gmail.com

Assisted-by: Opencode/Opus
@jasnell
jasnell
requested review from
mcollina and trivikrJuly 13, 2026 00:27
@jasnelljasnell
added

stream
Issues and PRs related to Node.js streams.
experimental
Issues and PRs related to experimental features.
labels
Jul 13, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 13, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
Jul 13, 2026
@trivikr
trivikr
requested a review
from pimterryJuly 13, 2026 01:43
@trivikrtrivikr
mentioned this pull request
Jul 13, 2026

Closed

@codecov
codecovBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.12%. Comparing base (efc0a14) to head (da87db0).
⚠️ Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/streams/iter/share.js77.04%14 Missing ⚠️
lib/internal/streams/iter/broadcast.js93.33%3 Missing ⚠️
lib/internal/streams/iter/classic.js66.66%1 Missing and 1 partial ⚠️
lib/internal/streams/iter/push.js96.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01% 
==========================================
Files 741 741 Lines 242196 242159 -37 Branches 45606 45611 +5 ==========================================
- Hits 218246 218237 -9 
Misses 15438 15438 + Partials 8512 8484 -28 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
lib/internal/quic/state.js100.00% <100.00%> (ø)
lib/internal/streams/iter/duplex.js96.35% <100.00%> (ø)
lib/internal/streams/iter/pull.js84.12% <100.00%> (+0.25%)⬆️
lib/internal/streams/iter/utils.js98.22% <100.00%> (-0.06%)⬇️
lib/internal/streams/iter/classic.js89.31% <66.66%> (-0.02%)⬇️
lib/internal/streams/iter/push.js90.92% <96.66%> (-0.26%)⬇️
lib/internal/streams/iter/broadcast.js86.24% <93.33%> (+0.24%)⬆️
lib/internal/streams/iter/share.js85.31% <77.04%> (+0.31%)⬆️
... and 35 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
pimterry
pimterry
reviewed
Jul 13, 2026
View reviewed changes
Comment threaddoc/api/stream_iter.md
Outdated

Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/broadcast.js
Outdated

Comment threadlib/internal/streams/iter/push.js
Outdated

Comment threadlib/internal/streams/iter/utils.js
Outdated

@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
939e46e to
9ae61ffCompareJuly 20, 2026 22:31
@jasnell
jasnell
requested a review
from pimterryJuly 20, 2026 22:34
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
9ae61ff to
c55171fCompareJuly 20, 2026 22:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
c55171f to
efe85eeCompareJuly 21, 2026 13:31
@nodejs-github-bot

This comment was marked as low quality.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
efe85ee to
5f41022CompareJuly 21, 2026 23:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
trivikr
trivikr
approved these changes
Jul 22, 2026
View reviewed changes
@trivikrtrivikr
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 22, 2026
 Merged

 Merged

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@trivikr

This comment was marked as outdated.

Sign in to view
@jasnell
stream: update iterable streams to use budget backpressure
626aa29
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
stream, quic: update iterable streams backpressure
32925df
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
test: update quic tests for stream/iter update
da87db0
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
f059d7e to
da87db0CompareJuly 22, 2026 17:43
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 23, 2026•

edited by jasnell

Loading

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75032/ 💚
Ethan-Arrowood
Ethan-Arrowood
approved these changes
Jul 23, 2026
View reviewed changes
@Ethan-ArrowoodEthan-Arrowood
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.
@trivikr
trivikr
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers.
The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason.
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream: update iterable streams to use budget backpressure
b9ed467
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream, quic: update iterable streams backpressure
64c1150
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
test: update quic tests for stream/iter update
3437feb
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell
jasnell
commented
Jul 23, 2026

Copy link


Copy Markdown

MemberAuthor
Landed in 82c823e...3437feb
@jasnelljasnell
closed this
Jul 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
0488d02
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
7331118
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
46b1177
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95aduh95
mentioned this pull request
Jul 30, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
193091f
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
125c19d
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
dd1e713
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@trivikrtrivikrtrivikr approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@trivikr@pimterry@Ethan-Arrowood@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
stream: update iterable streams to use budget backpressure - #64464
Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Closed
stream: update iterable streams to use budget backpressure#64464
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Conversation
@jasnell
@jasnelljasnell
commented
Jul 13, 2026

Copy link


Copy Markdown

Member
WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.
Signed-off-by: James M Snell jasnell@gmail.com

Assisted-by: Opencode/Opus
@jasnell
jasnell
requested review from
mcollina and trivikrJuly 13, 2026 00:27
@jasnelljasnell
added

stream
Issues and PRs related to Node.js streams.
experimental
Issues and PRs related to experimental features.
labels
Jul 13, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 13, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
Jul 13, 2026
@trivikr
trivikr
requested a review
from pimterryJuly 13, 2026 01:43
@trivikrtrivikr
mentioned this pull request
Jul 13, 2026

Closed

@codecov
codecovBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.12%. Comparing base (efc0a14) to head (da87db0).
⚠️ Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/streams/iter/share.js77.04%14 Missing ⚠️
lib/internal/streams/iter/broadcast.js93.33%3 Missing ⚠️
lib/internal/streams/iter/classic.js66.66%1 Missing and 1 partial ⚠️
lib/internal/streams/iter/push.js96.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01% 
==========================================
Files 741 741 Lines 242196 242159 -37 Branches 45606 45611 +5 ==========================================
- Hits 218246 218237 -9 
Misses 15438 15438 + Partials 8512 8484 -28 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
lib/internal/quic/state.js100.00% <100.00%> (ø)
lib/internal/streams/iter/duplex.js96.35% <100.00%> (ø)
lib/internal/streams/iter/pull.js84.12% <100.00%> (+0.25%)⬆️
lib/internal/streams/iter/utils.js98.22% <100.00%> (-0.06%)⬇️
lib/internal/streams/iter/classic.js89.31% <66.66%> (-0.02%)⬇️
lib/internal/streams/iter/push.js90.92% <96.66%> (-0.26%)⬇️
lib/internal/streams/iter/broadcast.js86.24% <93.33%> (+0.24%)⬆️
lib/internal/streams/iter/share.js85.31% <77.04%> (+0.31%)⬆️
... and 35 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
pimterry
pimterry
reviewed
Jul 13, 2026
View reviewed changes
Comment threaddoc/api/stream_iter.md
Outdated

Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/broadcast.js
Outdated

Comment threadlib/internal/streams/iter/push.js
Outdated

Comment threadlib/internal/streams/iter/utils.js
Outdated

@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
939e46e to
9ae61ffCompareJuly 20, 2026 22:31
@jasnell
jasnell
requested a review
from pimterryJuly 20, 2026 22:34
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
9ae61ff to
c55171fCompareJuly 20, 2026 22:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
c55171f to
efe85eeCompareJuly 21, 2026 13:31
@nodejs-github-bot

This comment was marked as low quality.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
efe85ee to
5f41022CompareJuly 21, 2026 23:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
trivikr
trivikr
approved these changes
Jul 22, 2026
View reviewed changes
@trivikrtrivikr
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 22, 2026
 Merged

 Merged

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@trivikr

This comment was marked as outdated.

Sign in to view
@jasnell
stream: update iterable streams to use budget backpressure
626aa29
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
stream, quic: update iterable streams backpressure
32925df
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
test: update quic tests for stream/iter update
da87db0
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
f059d7e to
da87db0CompareJuly 22, 2026 17:43
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 23, 2026•

edited by jasnell

Loading

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75032/ 💚
Ethan-Arrowood
Ethan-Arrowood
approved these changes
Jul 23, 2026
View reviewed changes
@Ethan-ArrowoodEthan-Arrowood
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.
@trivikr
trivikr
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers.
The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason.
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream: update iterable streams to use budget backpressure
b9ed467
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream, quic: update iterable streams backpressure
64c1150
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
test: update quic tests for stream/iter update
3437feb
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell
jasnell
commented
Jul 23, 2026

Copy link


Copy Markdown

MemberAuthor
Landed in 82c823e...3437feb
@jasnelljasnell
closed this
Jul 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
0488d02
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
7331118
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
46b1177
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95aduh95
mentioned this pull request
Jul 30, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
193091f
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
125c19d
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
dd1e713
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@trivikrtrivikrtrivikr approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@trivikr@pimterry@Ethan-Arrowood@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
stream: update iterable streams to use budget backpressure - #64464
Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Closed
stream: update iterable streams to use budget backpressure#64464
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Conversation
@jasnell
@jasnelljasnell
commented
Jul 13, 2026

Copy link


Copy Markdown

Member
WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.
Signed-off-by: James M Snell jasnell@gmail.com

Assisted-by: Opencode/Opus
@jasnell
jasnell
requested review from
mcollina and trivikrJuly 13, 2026 00:27
@jasnelljasnell
added

stream
Issues and PRs related to Node.js streams.
experimental
Issues and PRs related to experimental features.
labels
Jul 13, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 13, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
Jul 13, 2026
@trivikr
trivikr
requested a review
from pimterryJuly 13, 2026 01:43
@trivikrtrivikr
mentioned this pull request
Jul 13, 2026

Closed

@codecov
codecovBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.12%. Comparing base (efc0a14) to head (da87db0).
⚠️ Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/streams/iter/share.js77.04%14 Missing ⚠️
lib/internal/streams/iter/broadcast.js93.33%3 Missing ⚠️
lib/internal/streams/iter/classic.js66.66%1 Missing and 1 partial ⚠️
lib/internal/streams/iter/push.js96.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01% 
==========================================
Files 741 741 Lines 242196 242159 -37 Branches 45606 45611 +5 ==========================================
- Hits 218246 218237 -9 
Misses 15438 15438 + Partials 8512 8484 -28 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
lib/internal/quic/state.js100.00% <100.00%> (ø)
lib/internal/streams/iter/duplex.js96.35% <100.00%> (ø)
lib/internal/streams/iter/pull.js84.12% <100.00%> (+0.25%)⬆️
lib/internal/streams/iter/utils.js98.22% <100.00%> (-0.06%)⬇️
lib/internal/streams/iter/classic.js89.31% <66.66%> (-0.02%)⬇️
lib/internal/streams/iter/push.js90.92% <96.66%> (-0.26%)⬇️
lib/internal/streams/iter/broadcast.js86.24% <93.33%> (+0.24%)⬆️
lib/internal/streams/iter/share.js85.31% <77.04%> (+0.31%)⬆️
... and 35 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
pimterry
pimterry
reviewed
Jul 13, 2026
View reviewed changes
Comment threaddoc/api/stream_iter.md
Outdated

Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/broadcast.js
Outdated

Comment threadlib/internal/streams/iter/push.js
Outdated

Comment threadlib/internal/streams/iter/utils.js
Outdated

@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
939e46e to
9ae61ffCompareJuly 20, 2026 22:31
@jasnell
jasnell
requested a review
from pimterryJuly 20, 2026 22:34
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
9ae61ff to
c55171fCompareJuly 20, 2026 22:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
c55171f to
efe85eeCompareJuly 21, 2026 13:31
@nodejs-github-bot

This comment was marked as low quality.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
efe85ee to
5f41022CompareJuly 21, 2026 23:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
trivikr
trivikr
approved these changes
Jul 22, 2026
View reviewed changes
@trivikrtrivikr
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 22, 2026
 Merged

 Merged

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@trivikr

This comment was marked as outdated.

Sign in to view
@jasnell
stream: update iterable streams to use budget backpressure
626aa29
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
stream, quic: update iterable streams backpressure
32925df
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
test: update quic tests for stream/iter update
da87db0
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
f059d7e to
da87db0CompareJuly 22, 2026 17:43
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 23, 2026•

edited by jasnell

Loading

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75032/ 💚
Ethan-Arrowood
Ethan-Arrowood
approved these changes
Jul 23, 2026
View reviewed changes
@Ethan-ArrowoodEthan-Arrowood
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.
@trivikr
trivikr
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers.
The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason.
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream: update iterable streams to use budget backpressure
b9ed467
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream, quic: update iterable streams backpressure
64c1150
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
test: update quic tests for stream/iter update
3437feb
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell
jasnell
commented
Jul 23, 2026

Copy link


Copy Markdown

MemberAuthor
Landed in 82c823e...3437feb
@jasnelljasnell
closed this
Jul 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
0488d02
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
7331118
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
46b1177
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95aduh95
mentioned this pull request
Jul 30, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
193091f
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
125c19d
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
dd1e713
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@trivikrtrivikrtrivikr approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@trivikr@pimterry@Ethan-Arrowood@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
stream: update iterable streams to use budget backpressure - #64464
Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Closed
stream: update iterable streams to use budget backpressure#64464
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Conversation
@jasnell
@jasnelljasnell
commented
Jul 13, 2026

Copy link


Copy Markdown

Member
WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.
Signed-off-by: James M Snell jasnell@gmail.com

Assisted-by: Opencode/Opus
@jasnell
jasnell
requested review from
mcollina and trivikrJuly 13, 2026 00:27
@jasnelljasnell
added

stream
Issues and PRs related to Node.js streams.
experimental
Issues and PRs related to experimental features.
labels
Jul 13, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 13, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
Jul 13, 2026
@trivikr
trivikr
requested a review
from pimterryJuly 13, 2026 01:43
@trivikrtrivikr
mentioned this pull request
Jul 13, 2026

Closed

@codecov
codecovBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.12%. Comparing base (efc0a14) to head (da87db0).
⚠️ Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/streams/iter/share.js77.04%14 Missing ⚠️
lib/internal/streams/iter/broadcast.js93.33%3 Missing ⚠️
lib/internal/streams/iter/classic.js66.66%1 Missing and 1 partial ⚠️
lib/internal/streams/iter/push.js96.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01% 
==========================================
Files 741 741 Lines 242196 242159 -37 Branches 45606 45611 +5 ==========================================
- Hits 218246 218237 -9 
Misses 15438 15438 + Partials 8512 8484 -28 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
lib/internal/quic/state.js100.00% <100.00%> (ø)
lib/internal/streams/iter/duplex.js96.35% <100.00%> (ø)
lib/internal/streams/iter/pull.js84.12% <100.00%> (+0.25%)⬆️
lib/internal/streams/iter/utils.js98.22% <100.00%> (-0.06%)⬇️
lib/internal/streams/iter/classic.js89.31% <66.66%> (-0.02%)⬇️
lib/internal/streams/iter/push.js90.92% <96.66%> (-0.26%)⬇️
lib/internal/streams/iter/broadcast.js86.24% <93.33%> (+0.24%)⬆️
lib/internal/streams/iter/share.js85.31% <77.04%> (+0.31%)⬆️
... and 35 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
pimterry
pimterry
reviewed
Jul 13, 2026
View reviewed changes
Comment threaddoc/api/stream_iter.md
Outdated

Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/broadcast.js
Outdated

Comment threadlib/internal/streams/iter/push.js
Outdated

Comment threadlib/internal/streams/iter/utils.js
Outdated

@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
939e46e to
9ae61ffCompareJuly 20, 2026 22:31
@jasnell
jasnell
requested a review
from pimterryJuly 20, 2026 22:34
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
9ae61ff to
c55171fCompareJuly 20, 2026 22:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
c55171f to
efe85eeCompareJuly 21, 2026 13:31
@nodejs-github-bot

This comment was marked as low quality.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
efe85ee to
5f41022CompareJuly 21, 2026 23:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
trivikr
trivikr
approved these changes
Jul 22, 2026
View reviewed changes
@trivikrtrivikr
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 22, 2026
 Merged

 Merged

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@trivikr

This comment was marked as outdated.

Sign in to view
@jasnell
stream: update iterable streams to use budget backpressure
626aa29
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
stream, quic: update iterable streams backpressure
32925df
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
test: update quic tests for stream/iter update
da87db0
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
f059d7e to
da87db0CompareJuly 22, 2026 17:43
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 23, 2026•

edited by jasnell

Loading

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75032/ 💚
Ethan-Arrowood
Ethan-Arrowood
approved these changes
Jul 23, 2026
View reviewed changes
@Ethan-ArrowoodEthan-Arrowood
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.
@trivikr
trivikr
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers.
The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason.
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream: update iterable streams to use budget backpressure
b9ed467
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream, quic: update iterable streams backpressure
64c1150
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
test: update quic tests for stream/iter update
3437feb
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell
jasnell
commented
Jul 23, 2026

Copy link


Copy Markdown

MemberAuthor
Landed in 82c823e...3437feb
@jasnelljasnell
closed this
Jul 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
0488d02
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
7331118
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
46b1177
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95aduh95
mentioned this pull request
Jul 30, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
193091f
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
125c19d
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
dd1e713
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@trivikrtrivikrtrivikr approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@trivikr@pimterry@Ethan-Arrowood@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
stream: update iterable streams to use budget backpressure - #64464
Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Closed
stream: update iterable streams to use budget backpressure#64464
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Conversation
@jasnell
@jasnelljasnell
commented
Jul 13, 2026

Copy link


Copy Markdown

Member
WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.
Signed-off-by: James M Snell jasnell@gmail.com

Assisted-by: Opencode/Opus
@jasnell
jasnell
requested review from
mcollina and trivikrJuly 13, 2026 00:27
@jasnelljasnell
added

stream
Issues and PRs related to Node.js streams.
experimental
Issues and PRs related to experimental features.
labels
Jul 13, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 13, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
Jul 13, 2026
@trivikr
trivikr
requested a review
from pimterryJuly 13, 2026 01:43
@trivikrtrivikr
mentioned this pull request
Jul 13, 2026

Closed

@codecov
codecovBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.12%. Comparing base (efc0a14) to head (da87db0).
⚠️ Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/streams/iter/share.js77.04%14 Missing ⚠️
lib/internal/streams/iter/broadcast.js93.33%3 Missing ⚠️
lib/internal/streams/iter/classic.js66.66%1 Missing and 1 partial ⚠️
lib/internal/streams/iter/push.js96.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01% 
==========================================
Files 741 741 Lines 242196 242159 -37 Branches 45606 45611 +5 ==========================================
- Hits 218246 218237 -9 
Misses 15438 15438 + Partials 8512 8484 -28 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
lib/internal/quic/state.js100.00% <100.00%> (ø)
lib/internal/streams/iter/duplex.js96.35% <100.00%> (ø)
lib/internal/streams/iter/pull.js84.12% <100.00%> (+0.25%)⬆️
lib/internal/streams/iter/utils.js98.22% <100.00%> (-0.06%)⬇️
lib/internal/streams/iter/classic.js89.31% <66.66%> (-0.02%)⬇️
lib/internal/streams/iter/push.js90.92% <96.66%> (-0.26%)⬇️
lib/internal/streams/iter/broadcast.js86.24% <93.33%> (+0.24%)⬆️
lib/internal/streams/iter/share.js85.31% <77.04%> (+0.31%)⬆️
... and 35 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
pimterry
pimterry
reviewed
Jul 13, 2026
View reviewed changes
Comment threaddoc/api/stream_iter.md
Outdated

Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/broadcast.js
Outdated

Comment threadlib/internal/streams/iter/push.js
Outdated

Comment threadlib/internal/streams/iter/utils.js
Outdated

@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
939e46e to
9ae61ffCompareJuly 20, 2026 22:31
@jasnell
jasnell
requested a review
from pimterryJuly 20, 2026 22:34
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
9ae61ff to
c55171fCompareJuly 20, 2026 22:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
c55171f to
efe85eeCompareJuly 21, 2026 13:31
@nodejs-github-bot

This comment was marked as low quality.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
efe85ee to
5f41022CompareJuly 21, 2026 23:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
trivikr
trivikr
approved these changes
Jul 22, 2026
View reviewed changes
@trivikrtrivikr
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 22, 2026
 Merged

 Merged

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@trivikr

This comment was marked as outdated.

Sign in to view
@jasnell
stream: update iterable streams to use budget backpressure
626aa29
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
stream, quic: update iterable streams backpressure
32925df
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
test: update quic tests for stream/iter update
da87db0
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
f059d7e to
da87db0CompareJuly 22, 2026 17:43
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 23, 2026•

edited by jasnell

Loading

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75032/ 💚
Ethan-Arrowood
Ethan-Arrowood
approved these changes
Jul 23, 2026
View reviewed changes
@Ethan-ArrowoodEthan-Arrowood
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.
@trivikr
trivikr
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers.
The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason.
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream: update iterable streams to use budget backpressure
b9ed467
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream, quic: update iterable streams backpressure
64c1150
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
test: update quic tests for stream/iter update
3437feb
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell
jasnell
commented
Jul 23, 2026

Copy link


Copy Markdown

MemberAuthor
Landed in 82c823e...3437feb
@jasnelljasnell
closed this
Jul 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
0488d02
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
7331118
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
46b1177
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95aduh95
mentioned this pull request
Jul 30, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
193091f
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
125c19d
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
dd1e713
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@trivikrtrivikrtrivikr approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@trivikr@pimterry@Ethan-Arrowood@bjohansebas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
stream: update iterable streams to use budget backpressure - #64464
Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Closed
stream: update iterable streams to use budget backpressure#64464
jasnell wants to merge 3 commits into
nodejs:mainfrom 
jasnell:jasnell/iter-streams-backpressure-new
Conversation
@jasnell
@jasnelljasnell
commented
Jul 13, 2026

Copy link


Copy Markdown

Member
WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.
Signed-off-by: James M Snell jasnell@gmail.com

Assisted-by: Opencode/Opus
@jasnell
jasnell
requested review from
mcollina and trivikrJuly 13, 2026 00:27
@jasnelljasnell
added

stream
Issues and PRs related to Node.js streams.
experimental
Issues and PRs related to experimental features.
labels
Jul 13, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 13, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/quic
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
Jul 13, 2026
@trivikr
trivikr
requested a review
from pimterryJuly 13, 2026 01:43
@trivikrtrivikr
mentioned this pull request
Jul 13, 2026

Closed

@codecov
codecovBot
commented
Jul 13, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.12%. Comparing base (efc0a14) to head (da87db0).
⚠️ Report is 16 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/streams/iter/share.js77.04%14 Missing ⚠️
lib/internal/streams/iter/broadcast.js93.33%3 Missing ⚠️
lib/internal/streams/iter/classic.js66.66%1 Missing and 1 partial ⚠️
lib/internal/streams/iter/push.js96.66%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01% 
==========================================
Files 741 741 Lines 242196 242159 -37 Branches 45606 45611 +5 ==========================================
- Hits 218246 218237 -9 
Misses 15438 15438 + Partials 8512 8484 -28 
Files with missing linesCoverage Δ
lib/internal/quic/quic.js100.00% <100.00%> (ø)
lib/internal/quic/state.js100.00% <100.00%> (ø)
lib/internal/streams/iter/duplex.js96.35% <100.00%> (ø)
lib/internal/streams/iter/pull.js84.12% <100.00%> (+0.25%)⬆️
lib/internal/streams/iter/utils.js98.22% <100.00%> (-0.06%)⬇️
lib/internal/streams/iter/classic.js89.31% <66.66%> (-0.02%)⬇️
lib/internal/streams/iter/push.js90.92% <96.66%> (-0.26%)⬇️
lib/internal/streams/iter/broadcast.js86.24% <93.33%> (+0.24%)⬆️
lib/internal/streams/iter/share.js85.31% <77.04%> (+0.31%)⬆️
... and 35 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
pimterry
pimterry
reviewed
Jul 13, 2026
View reviewed changes
Comment threaddoc/api/stream_iter.md
Outdated

Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/push.js
Comment threadlib/internal/streams/iter/broadcast.js
Outdated

Comment threadlib/internal/streams/iter/push.js
Outdated

Comment threadlib/internal/streams/iter/utils.js
Outdated

@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
939e46e to
9ae61ffCompareJuly 20, 2026 22:31
@jasnell
jasnell
requested a review
from pimterryJuly 20, 2026 22:34
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
9ae61ff to
c55171fCompareJuly 20, 2026 22:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
c55171f to
efe85eeCompareJuly 21, 2026 13:31
@nodejs-github-bot

This comment was marked as low quality.

Sign in to view
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
efe85ee to
5f41022CompareJuly 21, 2026 23:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
trivikr
trivikr
approved these changes
Jul 22, 2026
View reviewed changes
@trivikrtrivikr
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 22, 2026
 Merged

 Merged

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@trivikr

This comment was marked as outdated.

Sign in to view
@jasnell
stream: update iterable streams to use budget backpressure
626aa29
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
stream, quic: update iterable streams backpressure
32925df
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@jasnell
test: update quic tests for stream/iter update
da87db0
@jasnell
jasnellforce-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
f059d7e to
da87db0CompareJuly 22, 2026 17:43
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Jul 23, 2026•

edited by jasnell

Loading

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75032/ 💚
Ethan-Arrowood
Ethan-Arrowood
approved these changes
Jul 23, 2026
View reviewed changes
@Ethan-ArrowoodEthan-Arrowood
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.
@trivikr
trivikr
commented
Jul 23, 2026

Copy link


Copy Markdown

Member
From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers.
The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason.
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream: update iterable streams to use budget backpressure
b9ed467
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
stream, quic: update iterable streams backpressure
64c1150
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell added a commit
that referenced
this pull request
Jul 23, 2026
@jasnell
test: update quic tests for stream/iter update
3437feb
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@jasnell
jasnell
commented
Jul 23, 2026

Copy link


Copy Markdown

MemberAuthor
Landed in 82c823e...3437feb
@jasnelljasnell
closed this
Jul 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
0488d02
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
7331118
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Jul 30, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
46b1177
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@aduh95aduh95
mentioned this pull request
Jul 30, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream: update iterable streams to use budget backpressure
193091f
Updates the implementation to use the updated backpressure
model that landed here: WinterTC55/iter-streams#23
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
stream, quic: update iterable streams backpressure
125c19d
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
@jasnell@aduh95
test: update quic tests for stream/iter update
dd1e713
PR-URL: #64464
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 21, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pimterrypimterrypimterry approved these changes
@trivikrtrivikrtrivikr approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

+1 more reviewer

@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

experimentalIssues and PRs related to experimental features.lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@trivikr@pimterry@Ethan-Arrowood@bjohansebas