Uh oh!
There was an error while loading. Please reload this page.
src: fix comment typos - #64509
Conversation
Correct typos in builtin, platform, and QUIC source comments. Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
nodejs-github-bot
commented
Jul 15, 2026
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #64509 +/- ##
=======================================
Coverage 90.24% 90.24% =======================================
Files 739 739 Lines 241669 241669 Branches 45543 45552 +9 =======================================
+ Hits 218087 218098 +11 + Misses 15150 15110 -40 - Partials 8432 8461 +29
🚀 New features to boost your workflow:
|
pimterry
commented
Jul 15, 2026
Thanks @sjungwon03. In future though, there's no need to open a new PR if a CI job fails. Just check the cause: if it seems like it's a flaky test issue unrelated to the change then somebody can re-run it to get it passing. Alternatively if it's an actual issue in the change you can push another commit to fix the problem. |
sjungwon03
commented
Jul 15, 2026
Thanks for the clarification. I’ll check the failure first next time and keep the existing PR open if it is unrelated to the change. I’ll push a follow-up commit only when the failure is caused by my change. |
nodejs-github-bot
commented
Jul 15, 2026
nodejs-github-bot
commented
Jul 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 17, 2026
Landed in 358adc8 |
Correct typos in builtin, platform, and QUIC source comments. Signed-off-by: sjungwon03 <sjungwon03@gmail.com> PR-URL: #64509 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Correct typos in builtin, platform, and QUIC source comments. Signed-off-by: sjungwon03 <sjungwon03@gmail.com> PR-URL: #64509 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Correct typos in builtin, platform, and QUIC source comments. Signed-off-by: sjungwon03 <sjungwon03@gmail.com> PR-URL: #64509 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Correct typos in builtin, platform, and QUIC source comments. Signed-off-by: sjungwon03 <sjungwon03@gmail.com> PR-URL: #64509 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fix typos in source comments.
This supersedes #64488, which was closed after an unrelated macOS
test-debugger-exectimeout. This PR is based on the currentmainbranch.