Skip to content

Revert "http: do not emit socket errors after complete response" - #64511

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:revert-17163ead
Jul 15, 2026
Merged

Revert "http: do not emit socket errors after complete response"#64511
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:revert-17163ead

Conversation

@mcollina

@mcollinamcollina commented Jul 15, 2026•
edited
Loading

Copy link
Copy Markdown
Member

This reverts commit 17163ea / #64278.

This landed too quickly #64278 (comment). Alternative to #64507.

@mcollina
Revert "http: do not emit socket errors after complete response"
fd66d5a
This reverts commit 17163ea.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 15, 2026
@mcollina
mcollina requested review from lpinca and pimterryJuly 15, 2026 07:07
@mcollinamcollina added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 15, 2026
@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.

@mcollina

mcollina commented Jul 15, 2026

Copy link
Copy Markdown
MemberAuthor

@pimterry@lpinca PTAL

@pimterry

pimterry commented Jul 15, 2026

Copy link
Copy Markdown
Member

Fair enough, I'm on board. #64507 has indeed hit CI issues with Mac, so it doesn't look like it's the easy tiny quick fix I was hoping. I'll it finish it up on top of this afterwards to bring the fix back correctly.

@pimterrypimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026
@Archkon

This comment was marked as spam.

Sign in to view
ShogunPanda
ShogunPanda approved these changes Jul 15, 2026
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74827/

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026
@mcollina

mcollina commented Jul 15, 2026

Copy link
Copy Markdown
MemberAuthor

@Archkon can you please send this change again so we can reapply it/rediscuss it? Sorry.

@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@codecov

codecovBot commented Jul 15, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (7a11a9b) to head (fd66d5a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64511 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01% 
==========================================
Files 739 739 Lines 241669 241655 -14 Branches 45543 45545 +2 ==========================================
- Hits 218087 218072 -15 + Misses 15150 15114 -36 - Partials 8432 8469 +37
Files with missing linesCoverage Δ
lib/_http_client.js97.61% <100.00%> (-0.03%)⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74829/

@pimterrypimterry mentioned this pull request Jul 15, 2026
Open
@pimterrypimterry added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 34c28d5 into nodejs:mainJul 15, 2026
87 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Landed in 34c28d5

@aduh95aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Jul 21, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@lpincalpincalpinca approved these changes
@pimterrypimterrypimterry approved these changes

Assignees

No one assigned

Labels

dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.dont-land-on-v26.xPRs that should not land on the v26.x-staging branch and should not be released in v26.x.fast-trackPRs that do not need to wait for 48 hours to land.httpIssues or PRs related to the http subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mcollina@nodejs-github-bot@pimterry@Archkon@ShogunPanda@lpinca@aduh95