repl: keep entries added while history file is loading by mhayk · Pull Request #64513 · nodejs/node

mhayk · 2026-07-15T10:23:01Z

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.

This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).

Reproduction on main before this change:

importreplfrom'node:repl';importfsfrom'node:fs';import{Stream,Writable}from'node:stream';classInextendsStream{resume(){}pause(){}}In.prototype.readable=true;constfile='/tmp/history.txt';fs.writeFileSync(file,'persisted entry');constr=repl.start({input: newIn(),output: newWritable({write(c,e,n){n();}}),terminal: true,});r.setupHistory(file,()=>{console.log(r.history);// ['persisted entry'] — evaluated lines lost});r.input.emit('data','const a = 1\nconst b = 2\n');

After this change, r.history is ['const b = 2', 'const a = 1', 'persisted entry'] and the file is flushed accordingly.

Refs: #64508

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>

codecov · 2026-07-18T20:27:34Z

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7a11a9b) to head (59aa7e7).
⚠️ Report is 587 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/repl/history.js	80.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64513 +/- ##
==========================================
- Coverage 90.24% 90.13% -0.12% 
==========================================
Files 739 751 +12 Lines 241669 252437 +10768 Branches 45543 47474 +1931 ==========================================
+ Hits 218087 227524 +9437 - Misses 15150 16210 +1060 - Partials 8432 8703 +271

Files with missing lines	Coverage Δ
lib/internal/repl/history.js	`93.12% <80.00%> (-0.50%)`	⬇️

... and 334 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-20T23:52:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76089/

trivikr · 2026-08-22T02:27:21Z

node-test-commit-linux-containered CI is failing on ubuntu2404_sharedlibs_withoutssl_x64

not ok 3104 parallel/test-repl-history-load-preserves-pending-entries --- duration_ms: 211.13300 severity: fail exitcode: 1 stack: |- node:internal/repl/inspector:255 throw new ERR_INSPECTOR_NOT_AVAILABLE(); ^ Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available at getReplInspector (node:internal/repl/inspector:255:11) at createReplEval (node:internal/repl/eval:79:21) at new REPLServer (node:repl:333:15) at Object.start (node:repl:1030:10) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-history-load-preserves-pending-entries.js:39:16) at Module._compile (node:internal/modules/cjs/loader:1937:14) at Object..js (node:internal/modules/cjs/loader:2077:10) at Module.load (node:internal/modules/cjs/loader:1659:32) at Module._load (node:internal/modules/cjs/loader:1451:12) at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) { code: 'ERR_INSPECTOR_NOT_AVAILABLE' } Node.js v27.0.0-pre ...

The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

mhayk · 2026-08-22T07:14:27Z

@trivikr Thanks for the report! Fixed in 59aa7e7 — the test now calls common.skipIfInspectorDisabled() like the other REPL history tests, since the REPL eval depends on the inspector and it is not available on --without-ssl builds.

mhayk · 2026-08-23T08:15:22Z

The last CI run is green everywhere except node-test-commit-windows-fanned (79509), which looks like an infra flake — this PR only touches the REPL history code and a JS test, nothing platform-specific. Could a collaborator re-run the CI when they get a chance? Thanks!

nodejs-github-bot · 2026-08-23T15:45:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76301/

nodejs-github-bot · 2026-08-23T17:29:03Z

Landed in 453f47a

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: #64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com> PR-URL: #64513 Reviewed-By: Aviv Keller <me@aviv.sh>

mhayk · 2026-07-15T10:23:01Z

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.

This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).

Reproduction on main before this change:

importreplfrom'node:repl';importfsfrom'node:fs';import{Stream,Writable}from'node:stream';classInextendsStream{resume(){}pause(){}}In.prototype.readable=true;constfile='/tmp/history.txt';fs.writeFileSync(file,'persisted entry');constr=repl.start({input: newIn(),output: newWritable({write(c,e,n){n();}}),terminal: true,});r.setupHistory(file,()=>{console.log(r.history);// ['persisted entry'] — evaluated lines lost});r.input.emit('data','const a = 1\nconst b = 2\n');

After this change, r.history is ['const b = 2', 'const a = 1', 'persisted entry'] and the file is flushed accordingly.

Refs: #64508

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>

codecov · 2026-07-18T20:27:34Z

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7a11a9b) to head (59aa7e7).
⚠️ Report is 587 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/repl/history.js	80.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64513 +/- ##
==========================================
- Coverage 90.24% 90.13% -0.12% 
==========================================
Files 739 751 +12 Lines 241669 252437 +10768 Branches 45543 47474 +1931 ==========================================
+ Hits 218087 227524 +9437 - Misses 15150 16210 +1060 - Partials 8432 8703 +271

Files with missing lines	Coverage Δ
lib/internal/repl/history.js	`93.12% <80.00%> (-0.50%)`	⬇️

... and 334 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-20T23:52:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76089/

trivikr · 2026-08-22T02:27:21Z

node-test-commit-linux-containered CI is failing on ubuntu2404_sharedlibs_withoutssl_x64

not ok 3104 parallel/test-repl-history-load-preserves-pending-entries --- duration_ms: 211.13300 severity: fail exitcode: 1 stack: |- node:internal/repl/inspector:255 throw new ERR_INSPECTOR_NOT_AVAILABLE(); ^ Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available at getReplInspector (node:internal/repl/inspector:255:11) at createReplEval (node:internal/repl/eval:79:21) at new REPLServer (node:repl:333:15) at Object.start (node:repl:1030:10) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-history-load-preserves-pending-entries.js:39:16) at Module._compile (node:internal/modules/cjs/loader:1937:14) at Object..js (node:internal/modules/cjs/loader:2077:10) at Module.load (node:internal/modules/cjs/loader:1659:32) at Module._load (node:internal/modules/cjs/loader:1451:12) at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) { code: 'ERR_INSPECTOR_NOT_AVAILABLE' } Node.js v27.0.0-pre ...

The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

mhayk · 2026-08-22T07:14:27Z

@trivikr Thanks for the report! Fixed in 59aa7e7 — the test now calls common.skipIfInspectorDisabled() like the other REPL history tests, since the REPL eval depends on the inspector and it is not available on --without-ssl builds.

mhayk · 2026-08-23T08:15:22Z

The last CI run is green everywhere except node-test-commit-windows-fanned (79509), which looks like an infra flake — this PR only touches the REPL history code and a JS test, nothing platform-specific. Could a collaborator re-run the CI when they get a chance? Thanks!

nodejs-github-bot · 2026-08-23T15:45:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76301/

nodejs-github-bot · 2026-08-23T17:29:03Z

Landed in 453f47a

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: #64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com> PR-URL: #64513 Reviewed-By: Aviv Keller <me@aviv.sh>

mhayk · 2026-07-15T10:23:01Z

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.

This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).

Reproduction on main before this change:

importreplfrom'node:repl';importfsfrom'node:fs';import{Stream,Writable}from'node:stream';classInextendsStream{resume(){}pause(){}}In.prototype.readable=true;constfile='/tmp/history.txt';fs.writeFileSync(file,'persisted entry');constr=repl.start({input: newIn(),output: newWritable({write(c,e,n){n();}}),terminal: true,});r.setupHistory(file,()=>{console.log(r.history);// ['persisted entry'] — evaluated lines lost});r.input.emit('data','const a = 1\nconst b = 2\n');

After this change, r.history is ['const b = 2', 'const a = 1', 'persisted entry'] and the file is flushed accordingly.

Refs: #64508

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>

codecov · 2026-07-18T20:27:34Z

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7a11a9b) to head (59aa7e7).
⚠️ Report is 587 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/repl/history.js	80.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64513 +/- ##
==========================================
- Coverage 90.24% 90.13% -0.12% 
==========================================
Files 739 751 +12 Lines 241669 252437 +10768 Branches 45543 47474 +1931 ==========================================
+ Hits 218087 227524 +9437 - Misses 15150 16210 +1060 - Partials 8432 8703 +271

Files with missing lines	Coverage Δ
lib/internal/repl/history.js	`93.12% <80.00%> (-0.50%)`	⬇️

... and 334 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-20T23:52:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76089/

trivikr · 2026-08-22T02:27:21Z

node-test-commit-linux-containered CI is failing on ubuntu2404_sharedlibs_withoutssl_x64

not ok 3104 parallel/test-repl-history-load-preserves-pending-entries --- duration_ms: 211.13300 severity: fail exitcode: 1 stack: |- node:internal/repl/inspector:255 throw new ERR_INSPECTOR_NOT_AVAILABLE(); ^ Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available at getReplInspector (node:internal/repl/inspector:255:11) at createReplEval (node:internal/repl/eval:79:21) at new REPLServer (node:repl:333:15) at Object.start (node:repl:1030:10) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-history-load-preserves-pending-entries.js:39:16) at Module._compile (node:internal/modules/cjs/loader:1937:14) at Object..js (node:internal/modules/cjs/loader:2077:10) at Module.load (node:internal/modules/cjs/loader:1659:32) at Module._load (node:internal/modules/cjs/loader:1451:12) at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) { code: 'ERR_INSPECTOR_NOT_AVAILABLE' } Node.js v27.0.0-pre ...

The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

mhayk · 2026-08-22T07:14:27Z

@trivikr Thanks for the report! Fixed in 59aa7e7 — the test now calls common.skipIfInspectorDisabled() like the other REPL history tests, since the REPL eval depends on the inspector and it is not available on --without-ssl builds.

mhayk · 2026-08-23T08:15:22Z

The last CI run is green everywhere except node-test-commit-windows-fanned (79509), which looks like an infra flake — this PR only touches the REPL history code and a JS test, nothing platform-specific. Could a collaborator re-run the CI when they get a chance? Thanks!

nodejs-github-bot · 2026-08-23T15:45:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76301/

nodejs-github-bot · 2026-08-23T17:29:03Z

Landed in 453f47a

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: #64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com> PR-URL: #64513 Reviewed-By: Aviv Keller <me@aviv.sh>

mhayk · 2026-07-15T10:23:01Z

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.

This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).

Reproduction on main before this change:

importreplfrom'node:repl';importfsfrom'node:fs';import{Stream,Writable}from'node:stream';classInextendsStream{resume(){}pause(){}}In.prototype.readable=true;constfile='/tmp/history.txt';fs.writeFileSync(file,'persisted entry');constr=repl.start({input: newIn(),output: newWritable({write(c,e,n){n();}}),terminal: true,});r.setupHistory(file,()=>{console.log(r.history);// ['persisted entry'] — evaluated lines lost});r.input.emit('data','const a = 1\nconst b = 2\n');

After this change, r.history is ['const b = 2', 'const a = 1', 'persisted entry'] and the file is flushed accordingly.

Refs: #64508

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>

codecov · 2026-07-18T20:27:34Z

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7a11a9b) to head (59aa7e7).
⚠️ Report is 587 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/repl/history.js	80.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64513 +/- ##
==========================================
- Coverage 90.24% 90.13% -0.12% 
==========================================
Files 739 751 +12 Lines 241669 252437 +10768 Branches 45543 47474 +1931 ==========================================
+ Hits 218087 227524 +9437 - Misses 15150 16210 +1060 - Partials 8432 8703 +271

Files with missing lines	Coverage Δ
lib/internal/repl/history.js	`93.12% <80.00%> (-0.50%)`	⬇️

... and 334 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-20T23:52:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76089/

trivikr · 2026-08-22T02:27:21Z

node-test-commit-linux-containered CI is failing on ubuntu2404_sharedlibs_withoutssl_x64

not ok 3104 parallel/test-repl-history-load-preserves-pending-entries --- duration_ms: 211.13300 severity: fail exitcode: 1 stack: |- node:internal/repl/inspector:255 throw new ERR_INSPECTOR_NOT_AVAILABLE(); ^ Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available at getReplInspector (node:internal/repl/inspector:255:11) at createReplEval (node:internal/repl/eval:79:21) at new REPLServer (node:repl:333:15) at Object.start (node:repl:1030:10) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-history-load-preserves-pending-entries.js:39:16) at Module._compile (node:internal/modules/cjs/loader:1937:14) at Object..js (node:internal/modules/cjs/loader:2077:10) at Module.load (node:internal/modules/cjs/loader:1659:32) at Module._load (node:internal/modules/cjs/loader:1451:12) at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) { code: 'ERR_INSPECTOR_NOT_AVAILABLE' } Node.js v27.0.0-pre ...

The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

mhayk · 2026-08-22T07:14:27Z

@trivikr Thanks for the report! Fixed in 59aa7e7 — the test now calls common.skipIfInspectorDisabled() like the other REPL history tests, since the REPL eval depends on the inspector and it is not available on --without-ssl builds.

mhayk · 2026-08-23T08:15:22Z

The last CI run is green everywhere except node-test-commit-windows-fanned (79509), which looks like an infra flake — this PR only touches the REPL history code and a JS test, nothing platform-specific. Could a collaborator re-run the CI when they get a chance? Thanks!

nodejs-github-bot · 2026-08-23T15:45:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76301/

nodejs-github-bot · 2026-08-23T17:29:03Z

Landed in 453f47a

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: #64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com> PR-URL: #64513 Reviewed-By: Aviv Keller <me@aviv.sh>

mhayk · 2026-07-15T10:23:01Z

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.

This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).

Reproduction on main before this change:

importreplfrom'node:repl';importfsfrom'node:fs';import{Stream,Writable}from'node:stream';classInextendsStream{resume(){}pause(){}}In.prototype.readable=true;constfile='/tmp/history.txt';fs.writeFileSync(file,'persisted entry');constr=repl.start({input: newIn(),output: newWritable({write(c,e,n){n();}}),terminal: true,});r.setupHistory(file,()=>{console.log(r.history);// ['persisted entry'] — evaluated lines lost});r.input.emit('data','const a = 1\nconst b = 2\n');

After this change, r.history is ['const b = 2', 'const a = 1', 'persisted entry'] and the file is flushed accordingly.

Refs: #64508

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>

codecov · 2026-07-18T20:27:34Z

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7a11a9b) to head (59aa7e7).
⚠️ Report is 587 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/repl/history.js	80.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64513 +/- ##
==========================================
- Coverage 90.24% 90.13% -0.12% 
==========================================
Files 739 751 +12 Lines 241669 252437 +10768 Branches 45543 47474 +1931 ==========================================
+ Hits 218087 227524 +9437 - Misses 15150 16210 +1060 - Partials 8432 8703 +271

Files with missing lines	Coverage Δ
lib/internal/repl/history.js	`93.12% <80.00%> (-0.50%)`	⬇️

... and 334 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-20T23:52:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76089/

trivikr · 2026-08-22T02:27:21Z

node-test-commit-linux-containered CI is failing on ubuntu2404_sharedlibs_withoutssl_x64

not ok 3104 parallel/test-repl-history-load-preserves-pending-entries --- duration_ms: 211.13300 severity: fail exitcode: 1 stack: |- node:internal/repl/inspector:255 throw new ERR_INSPECTOR_NOT_AVAILABLE(); ^ Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available at getReplInspector (node:internal/repl/inspector:255:11) at createReplEval (node:internal/repl/eval:79:21) at new REPLServer (node:repl:333:15) at Object.start (node:repl:1030:10) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-history-load-preserves-pending-entries.js:39:16) at Module._compile (node:internal/modules/cjs/loader:1937:14) at Object..js (node:internal/modules/cjs/loader:2077:10) at Module.load (node:internal/modules/cjs/loader:1659:32) at Module._load (node:internal/modules/cjs/loader:1451:12) at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) { code: 'ERR_INSPECTOR_NOT_AVAILABLE' } Node.js v27.0.0-pre ...

The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

mhayk · 2026-08-22T07:14:27Z

@trivikr Thanks for the report! Fixed in 59aa7e7 — the test now calls common.skipIfInspectorDisabled() like the other REPL history tests, since the REPL eval depends on the inspector and it is not available on --without-ssl builds.

mhayk · 2026-08-23T08:15:22Z

The last CI run is green everywhere except node-test-commit-windows-fanned (79509), which looks like an infra flake — this PR only touches the REPL history code and a JS test, nothing platform-specific. Could a collaborator re-run the CI when they get a chance? Thanks!

nodejs-github-bot · 2026-08-23T15:45:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76301/

nodejs-github-bot · 2026-08-23T17:29:03Z

Landed in 453f47a

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: #64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com> PR-URL: #64513 Reviewed-By: Aviv Keller <me@aviv.sh>

mhayk · 2026-07-15T10:23:01Z

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.

This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).

Reproduction on main before this change:

importreplfrom'node:repl';importfsfrom'node:fs';import{Stream,Writable}from'node:stream';classInextendsStream{resume(){}pause(){}}In.prototype.readable=true;constfile='/tmp/history.txt';fs.writeFileSync(file,'persisted entry');constr=repl.start({input: newIn(),output: newWritable({write(c,e,n){n();}}),terminal: true,});r.setupHistory(file,()=>{console.log(r.history);// ['persisted entry'] — evaluated lines lost});r.input.emit('data','const a = 1\nconst b = 2\n');

After this change, r.history is ['const b = 2', 'const a = 1', 'persisted entry'] and the file is flushed accordingly.

Refs: #64508

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>

codecov · 2026-07-18T20:27:34Z

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7a11a9b) to head (59aa7e7).
⚠️ Report is 587 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/repl/history.js	80.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64513 +/- ##
==========================================
- Coverage 90.24% 90.13% -0.12% 
==========================================
Files 739 751 +12 Lines 241669 252437 +10768 Branches 45543 47474 +1931 ==========================================
+ Hits 218087 227524 +9437 - Misses 15150 16210 +1060 - Partials 8432 8703 +271

Files with missing lines	Coverage Δ
lib/internal/repl/history.js	`93.12% <80.00%> (-0.50%)`	⬇️

... and 334 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-20T23:52:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76089/

trivikr · 2026-08-22T02:27:21Z

node-test-commit-linux-containered CI is failing on ubuntu2404_sharedlibs_withoutssl_x64

not ok 3104 parallel/test-repl-history-load-preserves-pending-entries --- duration_ms: 211.13300 severity: fail exitcode: 1 stack: |- node:internal/repl/inspector:255 throw new ERR_INSPECTOR_NOT_AVAILABLE(); ^ Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available at getReplInspector (node:internal/repl/inspector:255:11) at createReplEval (node:internal/repl/eval:79:21) at new REPLServer (node:repl:333:15) at Object.start (node:repl:1030:10) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-history-load-preserves-pending-entries.js:39:16) at Module._compile (node:internal/modules/cjs/loader:1937:14) at Object..js (node:internal/modules/cjs/loader:2077:10) at Module.load (node:internal/modules/cjs/loader:1659:32) at Module._load (node:internal/modules/cjs/loader:1451:12) at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) { code: 'ERR_INSPECTOR_NOT_AVAILABLE' } Node.js v27.0.0-pre ...

The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

mhayk · 2026-08-22T07:14:27Z

@trivikr Thanks for the report! Fixed in 59aa7e7 — the test now calls common.skipIfInspectorDisabled() like the other REPL history tests, since the REPL eval depends on the inspector and it is not available on --without-ssl builds.

mhayk · 2026-08-23T08:15:22Z

The last CI run is green everywhere except node-test-commit-windows-fanned (79509), which looks like an infra flake — this PR only touches the REPL history code and a JS test, nothing platform-specific. Could a collaborator re-run the CI when they get a chance? Thanks!

nodejs-github-bot · 2026-08-23T15:45:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76301/

nodejs-github-bot · 2026-08-23T17:29:03Z

Landed in 453f47a

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: #64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com> PR-URL: #64513 Reviewed-By: Aviv Keller <me@aviv.sh>

mhayk · 2026-07-15T10:23:01Z

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.

This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).

Reproduction on main before this change:

importreplfrom'node:repl';importfsfrom'node:fs';import{Stream,Writable}from'node:stream';classInextendsStream{resume(){}pause(){}}In.prototype.readable=true;constfile='/tmp/history.txt';fs.writeFileSync(file,'persisted entry');constr=repl.start({input: newIn(),output: newWritable({write(c,e,n){n();}}),terminal: true,});r.setupHistory(file,()=>{console.log(r.history);// ['persisted entry'] — evaluated lines lost});r.input.emit('data','const a = 1\nconst b = 2\n');

After this change, r.history is ['const b = 2', 'const a = 1', 'persisted entry'] and the file is flushed accordingly.

Refs: #64508

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>

codecov · 2026-07-18T20:27:34Z

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7a11a9b) to head (59aa7e7).
⚠️ Report is 587 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/repl/history.js	80.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64513 +/- ##
==========================================
- Coverage 90.24% 90.13% -0.12% 
==========================================
Files 739 751 +12 Lines 241669 252437 +10768 Branches 45543 47474 +1931 ==========================================
+ Hits 218087 227524 +9437 - Misses 15150 16210 +1060 - Partials 8432 8703 +271

Files with missing lines	Coverage Δ
lib/internal/repl/history.js	`93.12% <80.00%> (-0.50%)`	⬇️

... and 334 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-20T23:52:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76089/

trivikr · 2026-08-22T02:27:21Z

node-test-commit-linux-containered CI is failing on ubuntu2404_sharedlibs_withoutssl_x64

not ok 3104 parallel/test-repl-history-load-preserves-pending-entries --- duration_ms: 211.13300 severity: fail exitcode: 1 stack: |- node:internal/repl/inspector:255 throw new ERR_INSPECTOR_NOT_AVAILABLE(); ^ Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available at getReplInspector (node:internal/repl/inspector:255:11) at createReplEval (node:internal/repl/eval:79:21) at new REPLServer (node:repl:333:15) at Object.start (node:repl:1030:10) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-history-load-preserves-pending-entries.js:39:16) at Module._compile (node:internal/modules/cjs/loader:1937:14) at Object..js (node:internal/modules/cjs/loader:2077:10) at Module.load (node:internal/modules/cjs/loader:1659:32) at Module._load (node:internal/modules/cjs/loader:1451:12) at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) { code: 'ERR_INSPECTOR_NOT_AVAILABLE' } Node.js v27.0.0-pre ...

The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

mhayk · 2026-08-22T07:14:27Z

@trivikr Thanks for the report! Fixed in 59aa7e7 — the test now calls common.skipIfInspectorDisabled() like the other REPL history tests, since the REPL eval depends on the inspector and it is not available on --without-ssl builds.

mhayk · 2026-08-23T08:15:22Z

The last CI run is green everywhere except node-test-commit-windows-fanned (79509), which looks like an infra flake — this PR only touches the REPL history code and a JS test, nothing platform-specific. Could a collaborator re-run the CI when they get a chance? Thanks!

nodejs-github-bot · 2026-08-23T15:45:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76301/

nodejs-github-bot · 2026-08-23T17:29:03Z

Landed in 453f47a

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: #64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com> PR-URL: #64513 Reviewed-By: Aviv Keller <me@aviv.sh>

mhayk · 2026-07-15T10:23:01Z

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.

This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).

Reproduction on main before this change:

importreplfrom'node:repl';importfsfrom'node:fs';import{Stream,Writable}from'node:stream';classInextendsStream{resume(){}pause(){}}In.prototype.readable=true;constfile='/tmp/history.txt';fs.writeFileSync(file,'persisted entry');constr=repl.start({input: newIn(),output: newWritable({write(c,e,n){n();}}),terminal: true,});r.setupHistory(file,()=>{console.log(r.history);// ['persisted entry'] — evaluated lines lost});r.input.emit('data','const a = 1\nconst b = 2\n');

After this change, r.history is ['const b = 2', 'const a = 1', 'persisted entry'] and the file is flushed accordingly.

Refs: #64508

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>

codecov · 2026-07-18T20:27:34Z

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (7a11a9b) to head (59aa7e7).
⚠️ Report is 587 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/repl/history.js	80.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64513 +/- ##
==========================================
- Coverage 90.24% 90.13% -0.12% 
==========================================
Files 739 751 +12 Lines 241669 252437 +10768 Branches 45543 47474 +1931 ==========================================
+ Hits 218087 227524 +9437 - Misses 15150 16210 +1060 - Partials 8432 8703 +271

Files with missing lines	Coverage Δ
lib/internal/repl/history.js	`93.12% <80.00%> (-0.50%)`	⬇️

... and 334 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-20T23:52:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76089/

trivikr · 2026-08-22T02:27:21Z

node-test-commit-linux-containered CI is failing on ubuntu2404_sharedlibs_withoutssl_x64

not ok 3104 parallel/test-repl-history-load-preserves-pending-entries --- duration_ms: 211.13300 severity: fail exitcode: 1 stack: |- node:internal/repl/inspector:255 throw new ERR_INSPECTOR_NOT_AVAILABLE(); ^ Error [ERR_INSPECTOR_NOT_AVAILABLE]: Inspector is not available at getReplInspector (node:internal/repl/inspector:255:11) at createReplEval (node:internal/repl/eval:79:21) at new REPLServer (node:repl:333:15) at Object.start (node:repl:1030:10) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-history-load-preserves-pending-entries.js:39:16) at Module._compile (node:internal/modules/cjs/loader:1937:14) at Object..js (node:internal/modules/cjs/loader:2077:10) at Module.load (node:internal/modules/cjs/loader:1659:32) at Module._load (node:internal/modules/cjs/loader:1451:12) at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) { code: 'ERR_INSPECTOR_NOT_AVAILABLE' } Node.js v27.0.0-pre ...

The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

mhayk · 2026-08-22T07:14:27Z

@trivikr Thanks for the report! Fixed in 59aa7e7 — the test now calls common.skipIfInspectorDisabled() like the other REPL history tests, since the REPL eval depends on the inspector and it is not available on --without-ssl builds.

mhayk · 2026-08-23T08:15:22Z

The last CI run is green everywhere except node-test-commit-windows-fanned (79509), which looks like an infra flake — this PR only touches the REPL history code and a JS test, nothing platform-specific. Could a collaborator re-run the CI when they get a chance? Thanks!

nodejs-github-bot · 2026-08-23T15:45:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76301/

nodejs-github-bot · 2026-08-23T17:29:03Z

Landed in 453f47a

Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: #64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com> PR-URL: #64513 Reviewed-By: Aviv Keller <me@aviv.sh>

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jul 15, 2026

mhayk force-pushed the fix-repl-history-init-race branch from f9f897d to 76d0f74Compare July 15, 2026 10:25

avivkeller approved these changes Jul 15, 2026
View reviewed changes

trivikr added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Jul 21, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2026

This comment was marked as outdated.
Sign in to view

trivikr removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 22, 2026

test: skip repl history test without inspector
59aa7e7
The REPL eval depends on the inspector, so the test fails with ERR_INSPECTOR_NOT_AVAILABLE on builds configured --without-ssl. Skip it like the other REPL history tests do. Refs: nodejs#64513 (comment)

trivikr requested a review from avivkeller August 22, 2026 17:16

avivkeller approved these changes Aug 22, 2026
View reviewed changes

trivikr added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 22, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2026

This comment was marked as resolved.
Sign in to view

trivikr added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 23, 2026

nodejs-github-bot merged commit 453f47a into nodejs:mainAug 23, 2026
89 of 90 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged