Skip to content

doc: fix typos in contributing docs - #64520

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
HoonDongKang:doc-fix-typos
Jul 17, 2026
Merged

doc: fix typos in contributing docs#64520
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
HoonDongKang:doc-fix-typos

Conversation

@HoonDongKang

@HoonDongKangHoonDongKang commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Fixes a few typos in the contributing documentation.

Updated:

  • doc/contributing/first-contributions.md
- or along side your pull request+ or alongside your pull request
  • doc/contributing/pull-requests.md
- may be close for inactivity+ may be closed for inactivity
  • doc/contributing/writing-tests.md
- when its added+ when it's added

Signed-off-by: HoonDongKang <d159123@naver.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 15, 2026

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 050fc39 into nodejs:mainJul 17, 2026
23 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 050fc39

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Signed-off-by: HoonDongKang <d159123@naver.com>
PR-URL: #64520
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Signed-off-by: HoonDongKang <d159123@naver.com>
PR-URL: #64520
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Signed-off-by: HoonDongKang <d159123@naver.com>
PR-URL: #64520
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
Signed-off-by: HoonDongKang <d159123@naver.com>
PR-URL: #64520
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@HoonDongKang@nodejs-github-bot@mcollina@lpinca@cjihrig@UlisesGascon@RafaelGSS