Skip to content

vfs: fix RealFSProvider watchFile listener - #64537

Open
Y1D7NG wants to merge 1 commit into
nodejs:mainfrom
Y1D7NG:fix-vfs-realfs-watch
Open

vfs: fix RealFSProvider watchFile listener#64537
Y1D7NG wants to merge 1 commit into
nodejs:mainfrom
Y1D7NG:fix-vfs-realfs-watch

Conversation

@Y1D7NG

Copy link
Copy Markdown
Contributor

Fixes: #64536

RealFSProvider.watchFile ignored the listener, so changes never reached code.

Fixes: nodejs#64536
Signed-off-by: y1d7ng <y1d7ng@yeah.net>
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Jul 16, 2026
@codecov

codecovBot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (7a11a9b) to head (7e9e436).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64537 +/- ##
=======================================
Coverage 90.24% 90.24% =======================================
Files 739 739 Lines 241669 241668 -1 Branches 45543 45546 +3 =======================================
+ Hits 218087 218099 +12 + Misses 15150 15108 -42 - Partials 8432 8461 +29 
Files with missing linesCoverage Δ
lib/internal/vfs/provider.js98.38% <100.00%> (+<0.01%)⬆️
lib/internal/vfs/providers/real.js96.07% <100.00%> (ø)

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.vfsIssues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

watchFile never fires when vfs uses a real dir

2 participants

@Y1D7NG@nodejs-github-bot