sqlite: expose prepared statement statistics by geeksilva97 · Pull Request #64541 · nodejs/node

geeksilva97 · 2026-07-16T18:30:17Z

Closes#64540

nodejs-github-bot · 2026-07-16T18:30:22Z

Review requested:

@nodejs/sqlite

bakkot · 2026-07-16T20:12:57Z

I'm a little uncomfortable with getters that create an object every time they're read.

codecov · 2026-07-16T20:25:07Z

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (d996610) to head (7d21604).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.24%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64541 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01% 
==========================================
Files 751 751 Lines 249116 249152 +36 Branches 47043 47065 +22 ==========================================
+ Hits 224974 224986 +12 - Misses 15509 15556 +47 + Partials 8633 8610 -23

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.33% <ø> (ø)`
src/node_sqlite.cc	`81.63% <90.24%> (+0.16%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2026-07-23T15:13:46Z

Please @nodejs/sqlite , share your thoughts

araujogui

Another method to reset stats would be nice to have

araujogui · 2026-07-23T16:16:12Z

+ {"reprepare", SQLITE_STMTSTATUS_REPREPARE},
+ {"run", SQLITE_STMTSTATUS_RUN},
+ {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS},
+ {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT},


SQLITE_STMTSTATUS_FILTER_MISS and SQLITE_STMTSTATUS_FILTER_HIT was introduced in SQLite 3.38.0.
3.37.2: https://github.com/sqlite/sqlite/blob/version-3.37.2/src/sqlite.h.in
3.38.0: https://github.com/sqlite/sqlite/blob/version-3.38.0/src/sqlite.h.in

So maybe we need to enforce a minimum SQLite version on --shared-sqlite

What do u suggest? A CHECK or something?

I added some ifdefs. Let's see what the team says

geeksilva97 · 2026-08-11T17:09:33Z

Please @araujogui . Let me know if you have any other concerns

trivikr

Verified against a rebuilt PR head. One issue is a reproducible native crash; the other comments correct the documented SQLite semantics.

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

nodejs-github-bot · 2026-08-13T05:55:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75807/

nodejs-github-bot · 2026-08-13T07:53:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75808/

nodejs-github-bot · 2026-08-13T13:59:58Z

Landed in f46e96f

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 · 2026-07-16T18:30:17Z

Closes#64540

nodejs-github-bot · 2026-07-16T18:30:22Z

Review requested:

@nodejs/sqlite

bakkot · 2026-07-16T20:12:57Z

I'm a little uncomfortable with getters that create an object every time they're read.

codecov · 2026-07-16T20:25:07Z

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (d996610) to head (7d21604).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.24%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64541 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01% 
==========================================
Files 751 751 Lines 249116 249152 +36 Branches 47043 47065 +22 ==========================================
+ Hits 224974 224986 +12 - Misses 15509 15556 +47 + Partials 8633 8610 -23

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.33% <ø> (ø)`
src/node_sqlite.cc	`81.63% <90.24%> (+0.16%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2026-07-23T15:13:46Z

Please @nodejs/sqlite , share your thoughts

araujogui

Another method to reset stats would be nice to have

araujogui · 2026-07-23T16:16:12Z

+ {"reprepare", SQLITE_STMTSTATUS_REPREPARE},
+ {"run", SQLITE_STMTSTATUS_RUN},
+ {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS},
+ {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT},


SQLITE_STMTSTATUS_FILTER_MISS and SQLITE_STMTSTATUS_FILTER_HIT was introduced in SQLite 3.38.0.
3.37.2: https://github.com/sqlite/sqlite/blob/version-3.37.2/src/sqlite.h.in
3.38.0: https://github.com/sqlite/sqlite/blob/version-3.38.0/src/sqlite.h.in

So maybe we need to enforce a minimum SQLite version on --shared-sqlite

What do u suggest? A CHECK or something?

I added some ifdefs. Let's see what the team says

geeksilva97 · 2026-08-11T17:09:33Z

Please @araujogui . Let me know if you have any other concerns

trivikr

Verified against a rebuilt PR head. One issue is a reproducible native crash; the other comments correct the documented SQLite semantics.

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

nodejs-github-bot · 2026-08-13T05:55:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75807/

nodejs-github-bot · 2026-08-13T07:53:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75808/

nodejs-github-bot · 2026-08-13T13:59:58Z

Landed in f46e96f

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 · 2026-07-16T18:30:17Z

Closes#64540

nodejs-github-bot · 2026-07-16T18:30:22Z

Review requested:

@nodejs/sqlite

bakkot · 2026-07-16T20:12:57Z

I'm a little uncomfortable with getters that create an object every time they're read.

codecov · 2026-07-16T20:25:07Z

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (d996610) to head (7d21604).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.24%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64541 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01% 
==========================================
Files 751 751 Lines 249116 249152 +36 Branches 47043 47065 +22 ==========================================
+ Hits 224974 224986 +12 - Misses 15509 15556 +47 + Partials 8633 8610 -23

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.33% <ø> (ø)`
src/node_sqlite.cc	`81.63% <90.24%> (+0.16%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2026-07-23T15:13:46Z

Please @nodejs/sqlite , share your thoughts

araujogui

Another method to reset stats would be nice to have

araujogui · 2026-07-23T16:16:12Z

+ {"reprepare", SQLITE_STMTSTATUS_REPREPARE},
+ {"run", SQLITE_STMTSTATUS_RUN},
+ {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS},
+ {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT},


SQLITE_STMTSTATUS_FILTER_MISS and SQLITE_STMTSTATUS_FILTER_HIT was introduced in SQLite 3.38.0.
3.37.2: https://github.com/sqlite/sqlite/blob/version-3.37.2/src/sqlite.h.in
3.38.0: https://github.com/sqlite/sqlite/blob/version-3.38.0/src/sqlite.h.in

So maybe we need to enforce a minimum SQLite version on --shared-sqlite

What do u suggest? A CHECK or something?

I added some ifdefs. Let's see what the team says

geeksilva97 · 2026-08-11T17:09:33Z

Please @araujogui . Let me know if you have any other concerns

trivikr

Verified against a rebuilt PR head. One issue is a reproducible native crash; the other comments correct the documented SQLite semantics.

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

nodejs-github-bot · 2026-08-13T05:55:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75807/

nodejs-github-bot · 2026-08-13T07:53:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75808/

nodejs-github-bot · 2026-08-13T13:59:58Z

Landed in f46e96f

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 · 2026-07-16T18:30:17Z

Closes#64540

nodejs-github-bot · 2026-07-16T18:30:22Z

Review requested:

@nodejs/sqlite

bakkot · 2026-07-16T20:12:57Z

I'm a little uncomfortable with getters that create an object every time they're read.

codecov · 2026-07-16T20:25:07Z

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (d996610) to head (7d21604).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.24%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64541 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01% 
==========================================
Files 751 751 Lines 249116 249152 +36 Branches 47043 47065 +22 ==========================================
+ Hits 224974 224986 +12 - Misses 15509 15556 +47 + Partials 8633 8610 -23

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.33% <ø> (ø)`
src/node_sqlite.cc	`81.63% <90.24%> (+0.16%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2026-07-23T15:13:46Z

Please @nodejs/sqlite , share your thoughts

araujogui

Another method to reset stats would be nice to have

araujogui · 2026-07-23T16:16:12Z

+ {"reprepare", SQLITE_STMTSTATUS_REPREPARE},
+ {"run", SQLITE_STMTSTATUS_RUN},
+ {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS},
+ {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT},


SQLITE_STMTSTATUS_FILTER_MISS and SQLITE_STMTSTATUS_FILTER_HIT was introduced in SQLite 3.38.0.
3.37.2: https://github.com/sqlite/sqlite/blob/version-3.37.2/src/sqlite.h.in
3.38.0: https://github.com/sqlite/sqlite/blob/version-3.38.0/src/sqlite.h.in

So maybe we need to enforce a minimum SQLite version on --shared-sqlite

What do u suggest? A CHECK or something?

I added some ifdefs. Let's see what the team says

geeksilva97 · 2026-08-11T17:09:33Z

Please @araujogui . Let me know if you have any other concerns

trivikr

Verified against a rebuilt PR head. One issue is a reproducible native crash; the other comments correct the documented SQLite semantics.

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

nodejs-github-bot · 2026-08-13T05:55:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75807/

nodejs-github-bot · 2026-08-13T07:53:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75808/

nodejs-github-bot · 2026-08-13T13:59:58Z

Landed in f46e96f

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 · 2026-07-16T18:30:17Z

Closes#64540

nodejs-github-bot · 2026-07-16T18:30:22Z

Review requested:

@nodejs/sqlite

bakkot · 2026-07-16T20:12:57Z

I'm a little uncomfortable with getters that create an object every time they're read.

codecov · 2026-07-16T20:25:07Z

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (d996610) to head (7d21604).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.24%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64541 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01% 
==========================================
Files 751 751 Lines 249116 249152 +36 Branches 47043 47065 +22 ==========================================
+ Hits 224974 224986 +12 - Misses 15509 15556 +47 + Partials 8633 8610 -23

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.33% <ø> (ø)`
src/node_sqlite.cc	`81.63% <90.24%> (+0.16%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2026-07-23T15:13:46Z

Please @nodejs/sqlite , share your thoughts

araujogui

Another method to reset stats would be nice to have

araujogui · 2026-07-23T16:16:12Z

+ {"reprepare", SQLITE_STMTSTATUS_REPREPARE},
+ {"run", SQLITE_STMTSTATUS_RUN},
+ {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS},
+ {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT},


SQLITE_STMTSTATUS_FILTER_MISS and SQLITE_STMTSTATUS_FILTER_HIT was introduced in SQLite 3.38.0.
3.37.2: https://github.com/sqlite/sqlite/blob/version-3.37.2/src/sqlite.h.in
3.38.0: https://github.com/sqlite/sqlite/blob/version-3.38.0/src/sqlite.h.in

So maybe we need to enforce a minimum SQLite version on --shared-sqlite

What do u suggest? A CHECK or something?

I added some ifdefs. Let's see what the team says

geeksilva97 · 2026-08-11T17:09:33Z

Please @araujogui . Let me know if you have any other concerns

trivikr

Verified against a rebuilt PR head. One issue is a reproducible native crash; the other comments correct the documented SQLite semantics.

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

nodejs-github-bot · 2026-08-13T05:55:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75807/

nodejs-github-bot · 2026-08-13T07:53:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75808/

nodejs-github-bot · 2026-08-13T13:59:58Z

Landed in f46e96f

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 · 2026-07-16T18:30:17Z

Closes#64540

nodejs-github-bot · 2026-07-16T18:30:22Z

Review requested:

@nodejs/sqlite

bakkot · 2026-07-16T20:12:57Z

I'm a little uncomfortable with getters that create an object every time they're read.

codecov · 2026-07-16T20:25:07Z

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (d996610) to head (7d21604).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.24%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64541 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01% 
==========================================
Files 751 751 Lines 249116 249152 +36 Branches 47043 47065 +22 ==========================================
+ Hits 224974 224986 +12 - Misses 15509 15556 +47 + Partials 8633 8610 -23

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.33% <ø> (ø)`
src/node_sqlite.cc	`81.63% <90.24%> (+0.16%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2026-07-23T15:13:46Z

Please @nodejs/sqlite , share your thoughts

araujogui

Another method to reset stats would be nice to have

araujogui · 2026-07-23T16:16:12Z

+ {"reprepare", SQLITE_STMTSTATUS_REPREPARE},
+ {"run", SQLITE_STMTSTATUS_RUN},
+ {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS},
+ {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT},


SQLITE_STMTSTATUS_FILTER_MISS and SQLITE_STMTSTATUS_FILTER_HIT was introduced in SQLite 3.38.0.
3.37.2: https://github.com/sqlite/sqlite/blob/version-3.37.2/src/sqlite.h.in
3.38.0: https://github.com/sqlite/sqlite/blob/version-3.38.0/src/sqlite.h.in

So maybe we need to enforce a minimum SQLite version on --shared-sqlite

What do u suggest? A CHECK or something?

I added some ifdefs. Let's see what the team says

geeksilva97 · 2026-08-11T17:09:33Z

Please @araujogui . Let me know if you have any other concerns

trivikr

Verified against a rebuilt PR head. One issue is a reproducible native crash; the other comments correct the documented SQLite semantics.

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

nodejs-github-bot · 2026-08-13T05:55:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75807/

nodejs-github-bot · 2026-08-13T07:53:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75808/

nodejs-github-bot · 2026-08-13T13:59:58Z

Landed in f46e96f

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 · 2026-07-16T18:30:17Z

Closes#64540

nodejs-github-bot · 2026-07-16T18:30:22Z

Review requested:

@nodejs/sqlite

bakkot · 2026-07-16T20:12:57Z

I'm a little uncomfortable with getters that create an object every time they're read.

codecov · 2026-07-16T20:25:07Z

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (d996610) to head (7d21604).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.24%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64541 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01% 
==========================================
Files 751 751 Lines 249116 249152 +36 Branches 47043 47065 +22 ==========================================
+ Hits 224974 224986 +12 - Misses 15509 15556 +47 + Partials 8633 8610 -23

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.33% <ø> (ø)`
src/node_sqlite.cc	`81.63% <90.24%> (+0.16%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2026-07-23T15:13:46Z

Please @nodejs/sqlite , share your thoughts

araujogui

Another method to reset stats would be nice to have

araujogui · 2026-07-23T16:16:12Z

+ {"reprepare", SQLITE_STMTSTATUS_REPREPARE},
+ {"run", SQLITE_STMTSTATUS_RUN},
+ {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS},
+ {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT},


SQLITE_STMTSTATUS_FILTER_MISS and SQLITE_STMTSTATUS_FILTER_HIT was introduced in SQLite 3.38.0.
3.37.2: https://github.com/sqlite/sqlite/blob/version-3.37.2/src/sqlite.h.in
3.38.0: https://github.com/sqlite/sqlite/blob/version-3.38.0/src/sqlite.h.in

So maybe we need to enforce a minimum SQLite version on --shared-sqlite

What do u suggest? A CHECK or something?

I added some ifdefs. Let's see what the team says

geeksilva97 · 2026-08-11T17:09:33Z

Please @araujogui . Let me know if you have any other concerns

trivikr

Verified against a rebuilt PR head. One issue is a reproducible native crash; the other comments correct the documented SQLite semantics.

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

nodejs-github-bot · 2026-08-13T05:55:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75807/

nodejs-github-bot · 2026-08-13T07:53:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75808/

nodejs-github-bot · 2026-08-13T13:59:58Z

Landed in f46e96f

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 · 2026-07-16T18:30:17Z

Closes#64540

nodejs-github-bot · 2026-07-16T18:30:22Z

Review requested:

@nodejs/sqlite

bakkot · 2026-07-16T20:12:57Z

I'm a little uncomfortable with getters that create an object every time they're read.

codecov · 2026-07-16T20:25:07Z

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (d996610) to head (7d21604).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	90.24%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64541 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01% 
==========================================
Files 751 751 Lines 249116 249152 +36 Branches 47043 47065 +22 ==========================================
+ Hits 224974 224986 +12 - Misses 15509 15556 +47 + Partials 8633 8610 -23

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.33% <ø> (ø)`
src/node_sqlite.cc	`81.63% <90.24%> (+0.16%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2026-07-23T15:13:46Z

Please @nodejs/sqlite , share your thoughts

araujogui

Another method to reset stats would be nice to have

araujogui · 2026-07-23T16:16:12Z

+ {"reprepare", SQLITE_STMTSTATUS_REPREPARE},
+ {"run", SQLITE_STMTSTATUS_RUN},
+ {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS},
+ {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT},


SQLITE_STMTSTATUS_FILTER_MISS and SQLITE_STMTSTATUS_FILTER_HIT was introduced in SQLite 3.38.0.
3.37.2: https://github.com/sqlite/sqlite/blob/version-3.37.2/src/sqlite.h.in
3.38.0: https://github.com/sqlite/sqlite/blob/version-3.38.0/src/sqlite.h.in

So maybe we need to enforce a minimum SQLite version on --shared-sqlite

What do u suggest? A CHECK or something?

I added some ifdefs. Let's see what the team says

geeksilva97 · 2026-08-11T17:09:33Z

Please @araujogui . Let me know if you have any other concerns

trivikr

Verified against a rebuilt PR head. One issue is a reproducible native crash; the other comments correct the documented SQLite semantics.

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

nodejs-github-bot · 2026-08-13T05:55:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75807/

nodejs-github-bot · 2026-08-13T07:53:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75808/

nodejs-github-bot · 2026-08-13T13:59:58Z

Landed in f46e96f

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jul 16, 2026

geeksilva97 force-pushed the sqlite-statement-statistics branch 2 times, most recently from f5e8fcb to 2195e97Compare July 16, 2026 18:42

geeksilva97 marked this pull request as ready for review July 16, 2026 18:43

geeksilva97 added the wip Issues and PRs that are still a work in progress. label Jul 16, 2026

geeksilva97 force-pushed the sqlite-statement-statistics branch 2 times, most recently from bbbbeec to bef2511Compare July 16, 2026 21:12

araujogui reviewed Jul 16, 2026
View reviewed changes

Comment threadsrc/node_sqlite.h

geeksilva97 force-pushed the sqlite-statement-statistics branch from bef2511 to fd5654cCompare July 17, 2026 16:25

geeksilva97 removed the wip Issues and PRs that are still a work in progress. label Jul 17, 2026

araujogui suggested changes Jul 23, 2026
View reviewed changes

trivikr added the sqlite Issues and PRs related to the SQLite subsystem. label Aug 3, 2026

geeksilva97 force-pushed the sqlite-statement-statistics branch from fd5654c to b0a266eCompare August 11, 2026 12:44

geeksilva97 requested review from Renegade334 and cjihrig August 11, 2026 13:24

trivikr requested changes Aug 12, 2026
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated
Comment threaddoc/api/sqlite.md Outdated
Comment threaddoc/api/sqlite.md Outdated

trivikr reviewed Aug 12, 2026
View reviewed changes

Comment threadtest/parallel/test-sqlite-statement-sync.js

geeksilva97 added 6 commits August 12, 2026 18:12

sqlite: expose prepared statement statistics
e75cedb
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

sqlite: consolidate map lookup
6f2a5fc
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

sqlite: add method to rest statuses
33c7091
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

sqlite: handle older sqlite versions
849d773
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

sqlite: fix stale column name cache in resetStats()
5ff1f16
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

fixup: make linter happy
5a86587
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

fixup: rebase
7d21604
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>

geeksilva97 force-pushed the sqlite-statement-statistics branch from 46d8994 to 7d21604Compare August 12, 2026 21:20

trivikr approved these changes Aug 13, 2026
View reviewed changes

trivikr added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 13, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2026

cjihrig approved these changes Aug 13, 2026
View reviewed changes

trivikr added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 13, 2026

nodejs-github-bot merged commit f46e96f into nodejs:mainAug 13, 2026
79 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 13, 2026

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
sqlite: expose prepared statement statistics
7d28c98
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
sqlite: expose prepared statement statistics
72c37b1
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: #64541 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged