Skip to content

deps: update temporal_rs to 0.2.3 - #64543

Closed
Renegade334 wants to merge 3 commits into
nodejs:mainfrom
Renegade334:temporal-0.2.3
Closed

deps: update temporal_rs to 0.2.3#64543
Renegade334 wants to merge 3 commits into
nodejs:mainfrom
Renegade334:temporal-0.2.3

Conversation

@Renegade334

@Renegade334Renegade334 commented Jul 16, 2026

Copy link
Copy Markdown
Member

Updates temporal_rs via a standalone run of the crates updater from nodejs/node-core-utils#1117. As mentioned previously, temporal_rs 0.2 contains a bunch of fixes for bugs and spec compliance issues (boa-dev/temporal@v0.1.2...v0.2.3) which means we should really upgrade before v26 goes LTS.

deps: V8: backport 7d9b7e03141d

Updates to the third_party/rust dependency of V8 14.9.6, which corresponds to temporal_rs 0.2.3.

deps: update Rust crates for V8 14.6.202.34-node.26

There is an additional 20MiB checked into the deps/crates/vendor directory as a result of the dependency changes. Most of this is locale data and ICU4X tests, which doesn't get compiled into the rust build; the final Node.js binary size is only around 10KiB larger.

build: bump rustc requirement to >=1.86

Updates BUILDING.md and the GHA workflows.

Manishearthand others added 2 commits July 16, 2026 19:50
@Manishearth@Renegade334
deps: V8: backport 7d9b7e03141d
cb727ce
Original commit message:
Update DEPS for ICU4X/temporal_rs changes
Change-Id: I22328bcc0f50e3dd0aa955021d090f466a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7727682
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106257}
Refs: v8/v8@7d9b7e0
@Renegade334
deps: update Rust crates for V8 14.6.202.34-node.26
d1d8917
Fixes: nodejs#63145
@Renegade334Renegade334 added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jul 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/build
  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Jul 16, 2026
@Renegade334
build: bump rustc requirement to >=1.86
4d2613d
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@Renegade334Renegade334 mentioned this pull request Jul 16, 2026
Merged
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75014/

@Renegade334
Renegade334 marked this pull request as ready for review July 22, 2026 12:26
targos
targos reviewed Jul 22, 2026
View reviewed changes
Comment threaddeps/crates/Cargo.lock
targos
targos reviewed Jul 22, 2026
View reviewed changes
Comment threaddeps/crates/vendor/core_maths-v0_1/.cargo-checksum.json
@targos

targos commented Jul 23, 2026

Copy link
Copy Markdown
Member

AIX status is pending but the CI is over and green.

@Renegade334Renegade334 self-assigned this Jul 23, 2026
@targos

targos commented Jul 27, 2026

Copy link
Copy Markdown
Member

Any blockers?

@Renegade334

Renegade334 commented Jul 27, 2026

Copy link
Copy Markdown
MemberAuthor

Figured I'd let it bake for a bit longer as a large PR, but all the requirements are met so may as well get this merged.

@Renegade334Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2026
@Renegade334Renegade334 removed their assignment Jul 27, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Landed in 58795e9...ea48ad3

nodejs-github-bot pushed a commit that referenced this pull request Jul 27, 2026
@Manishearth@nodejs-github-bot
deps: V8: backport 7d9b7e03141d
8ba8981
Original commit message:
Update DEPS for ICU4X/temporal_rs changes
Change-Id: I22328bcc0f50e3dd0aa955021d090f466a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7727682
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106257}
Refs: v8/v8@7d9b7e0
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 27, 2026
@Renegade334@nodejs-github-bot
deps: update Rust crates for V8 14.6.202.34-node.26
cb3add2
Fixes: #63145
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 27, 2026
@Renegade334@nodejs-github-bot
build: bump rustc requirement to >=1.86
ea48ad3
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@Renegade334
Renegade334 deleted the temporal-0.2.3 branch July 27, 2026 13:00
aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@Manishearth@aduh95
deps: V8: backport 7d9b7e03141d
977a26e
Original commit message:
Update DEPS for ICU4X/temporal_rs changes
Change-Id: I22328bcc0f50e3dd0aa955021d090f466a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7727682
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106257}
Refs: v8/v8@7d9b7e0
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@Renegade334@aduh95
deps: update Rust crates for V8 14.6.202.34-node.26
f7a3237
Fixes: #63145
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@Renegade334@aduh95
build: bump rustc requirement to >=1.86
ee65bb2
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@Manishearth@aduh95
deps: V8: backport 7d9b7e03141d
308c6b2
Original commit message:
Update DEPS for ICU4X/temporal_rs changes
Change-Id: I22328bcc0f50e3dd0aa955021d090f466a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7727682
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106257}
Refs: v8/v8@7d9b7e0
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@Renegade334@aduh95
deps: update Rust crates for V8 14.6.202.34-node.26
7bc4c17
Fixes: #63145
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@Renegade334@aduh95
build: bump rustc requirement to >=1.86
ab5f076
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 4, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.dependenciesPull requests that update a dependency file.docIssues and PRs related to the documentations.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x.metaIssues and PRs related to the general management of the project.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Renegade334@nodejs-github-bot@targos@legendecas@Manishearth