src: avoid redundant DataPointer reallocations by panva · Pull Request #64552 · nodejs/node

panva · 2026-07-17T08:27:32Z

DataPointer::resize() checked for an unchanged size only after release() had reset the stored length to zero. As a result, every non-empty resize called OPENSSL_realloc(), even when the allocation was already the right size.

Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.

Keep the explicit zero-length path to preserve successful empty crypto outputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-07-17T08:27:37Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2026-07-17T10:19:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74867/

nodejs-github-bot · 2026-07-21T15:46:29Z

Landed in 0b7aa61

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

panva · 2026-07-17T08:27:32Z

DataPointer::resize() checked for an unchanged size only after release() had reset the stored length to zero. As a result, every non-empty resize called OPENSSL_realloc(), even when the allocation was already the right size.

Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.

Keep the explicit zero-length path to preserve successful empty crypto outputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-07-17T08:27:37Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2026-07-17T10:19:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74867/

nodejs-github-bot · 2026-07-21T15:46:29Z

Landed in 0b7aa61

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

panva · 2026-07-17T08:27:32Z

DataPointer::resize() checked for an unchanged size only after release() had reset the stored length to zero. As a result, every non-empty resize called OPENSSL_realloc(), even when the allocation was already the right size.

Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.

Keep the explicit zero-length path to preserve successful empty crypto outputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-07-17T08:27:37Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2026-07-17T10:19:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74867/

nodejs-github-bot · 2026-07-21T15:46:29Z

Landed in 0b7aa61

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

panva · 2026-07-17T08:27:32Z

DataPointer::resize() checked for an unchanged size only after release() had reset the stored length to zero. As a result, every non-empty resize called OPENSSL_realloc(), even when the allocation was already the right size.

Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.

Keep the explicit zero-length path to preserve successful empty crypto outputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-07-17T08:27:37Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2026-07-17T10:19:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74867/

nodejs-github-bot · 2026-07-21T15:46:29Z

Landed in 0b7aa61

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

panva · 2026-07-17T08:27:32Z

DataPointer::resize() checked for an unchanged size only after release() had reset the stored length to zero. As a result, every non-empty resize called OPENSSL_realloc(), even when the allocation was already the right size.

Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.

Keep the explicit zero-length path to preserve successful empty crypto outputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-07-17T08:27:37Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2026-07-17T10:19:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74867/

nodejs-github-bot · 2026-07-21T15:46:29Z

Landed in 0b7aa61

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

panva · 2026-07-17T08:27:32Z

DataPointer::resize() checked for an unchanged size only after release() had reset the stored length to zero. As a result, every non-empty resize called OPENSSL_realloc(), even when the allocation was already the right size.

Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.

Keep the explicit zero-length path to preserve successful empty crypto outputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-07-17T08:27:37Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2026-07-17T10:19:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74867/

nodejs-github-bot · 2026-07-21T15:46:29Z

Landed in 0b7aa61

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

panva · 2026-07-17T08:27:32Z

DataPointer::resize() checked for an unchanged size only after release() had reset the stored length to zero. As a result, every non-empty resize called OPENSSL_realloc(), even when the allocation was already the right size.

Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.

Keep the explicit zero-length path to preserve successful empty crypto outputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-07-17T08:27:37Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2026-07-17T10:19:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74867/

nodejs-github-bot · 2026-07-21T15:46:29Z

Landed in 0b7aa61

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

panva · 2026-07-17T08:27:32Z

DataPointer::resize() checked for an unchanged size only after release() had reset the stored length to zero. As a result, every non-empty resize called OPENSSL_realloc(), even when the allocation was already the right size.

Check for the no-op before releasing the buffer. This avoids an allocator call and, with BoringSSL, a new allocation, copy, cleanse, and free.

Keep the explicit zero-length path to preserve successful empty crypto outputs.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-07-17T08:27:37Z

Review requested:

@nodejs/crypto
@nodejs/security-wg

nodejs-github-bot · 2026-07-17T10:19:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74867/

nodejs-github-bot · 2026-07-21T15:46:29Z

Landed in 0b7aa61

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

src: avoid redundant DataPointer reallocations
165a2e9
Signed-off-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Jul 17, 2026

panva requested a review from jasnell July 17, 2026 08:41

jasnell approved these changes Jul 19, 2026
View reviewed changes

panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 19, 2026

anonrig approved these changes Jul 21, 2026
View reviewed changes

panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 21, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 21, 2026

nodejs-github-bot merged commit 0b7aa61 into nodejs:mainJul 21, 2026
78 of 79 checks passed

panva deleted the datapointer-resize branch July 21, 2026 15:50

panva mentioned this pull request Jul 21, 2026
[v26.x backport] crypto: split OpenSSL 3, BoringSSL, and legacy backends & followups #64657
Merged

panva added the backport-open-v26.x Indicate that the PR has an open backport label Jul 21, 2026

aduh95 pushed a commit that referenced this pull request Jul 30, 2026
src: avoid redundant DataPointer reallocations
5380bf2
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 mentioned this pull request Jul 30, 2026
2026-07-22, Version 26.6.0 (Current) #64655
Merged

panva added backported-to-v26.x PRs backported to the v26.x-staging branch. and removed backport-open-v26.x Indicate that the PR has an open backport labels Aug 3, 2026

aduh95 pushed a commit that referenced this pull request Aug 6, 2026
src: avoid redundant DataPointer reallocations
308a589
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

github-actionsBot mentioned this pull request Aug 21, 2026
2026-08-26, Version 24.20.0 'Krypton' (LTS) #65461
Merged