Skip to content

crypto: limit KangarooTwelveParams customization to 512 bytes - #64557

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:limit-kt-customization
Jul 19, 2026
Merged

crypto: limit KangarooTwelveParams customization to 512 bytes#64557
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:limit-kt-customization

Conversation

@panva

@panvapanva commented Jul 17, 2026•
edited
Loading

Copy link
Copy Markdown
Member

To align with a future OpenSSL-imposed limit this limits the customization of KT128 and KT256 Web Cryptography algorithms to 512 bytes (same as cSHAKE).

This is an experimentalIssues and PRs related to experimental features. algorithm.

@panvapanva added the experimental Issues and PRs related to experimental features. label Jul 17, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jul 17, 2026
@panva
panvaforce-pushed the limit-kt-customization branch from 9568492 to 184f0c1CompareJuly 17, 2026 13:48
@panva
crypto: limit KangarooTwelveParams customization to 512 bytes
c2b48ee
To align with a future OpenSSL-imposed limit.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panvaforce-pushed the limit-kt-customization branch from 184f0c1 to c2b48eeCompareJuly 17, 2026 13:50
@panva
panva marked this pull request as ready for review July 17, 2026 13:51
@codecov

codecovBot commented Jul 17, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (a27fe21) to head (c2b48ee).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64557 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01% 
==========================================
Files 739 739 Lines 241698 241741 +43 Branches 45556 45566 +10 ==========================================
+ Hits 218129 218157 +28 - Misses 15103 15114 +11 - Partials 8466 8470 +4
Files with missing linesCoverage Δ
lib/internal/crypto/webidl.js97.96% <100.00%> (-0.01%)⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 17, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74872/

@panva
panva requested a review from jasnellJuly 18, 2026 09:17
@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2026
@nodejs-github-bot
nodejs-github-bot merged commit d90d9d5 into nodejs:mainJul 19, 2026
95 of 96 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Landed in d90d9d5

@panva
panva deleted the limit-kt-customization branch July 19, 2026 16:07
@panvapanva mentioned this pull request Jul 21, 2026
Merged
@panvapanva added the backport-open-v26.x Indicate that the PR has an open backport label Jul 21, 2026
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@panva@aduh95
crypto: limit KangarooTwelveParams customization to 512 bytes
6e30204
To align with a future OpenSSL-imposed limit.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64557
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Jul 30, 2026
Merged
@panvapanva added backported-to-v26.x PRs backported to the v26.x-staging branch. and removed backport-open-v26.x Indicate that the PR has an open backport labels Aug 3, 2026
@panvapanva mentioned this pull request Aug 6, 2026
Open
27 tasks
@panvapanva added the backport-open-v24.x Indicate that the PR has an open backport label Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backport-open-v24.xIndicate that the PR has an open backportbackported-to-v26.xPRs backported to the v26.x-staging branch.cryptoIssues and PRs related to the crypto subsystem.experimentalIssues and PRs related to experimental features.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@jasnell@lpinca