Uh oh!
There was an error while loading. Please reload this page.
doc: replace large tables in crypto.md and webcrypto.md with lists - #64582
Merged
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
nodejs-github-bot
commented
Jul 18, 2026
Collaborator
Review requested:
|
avivkeller
approved these changes
Jul 18, 2026
lpinca
approved these changes
Jul 18, 2026
Trott
reviewed
Jul 19, 2026
| [`KeyObject`][] API by the complete set of formats supported for importing and | ||
| exporting each type. | ||
| **Formats:** `'pem'`, `'der'` |
Member
There was a problem hiding this comment.
Non-blocking observation: For semantic and accessibility purposes I think it would be better if these bold-text pseudo-headers were themselves bullet items and then the current bullet items could be indented under them. That would be likely to preserve accessibility and would certainly be more semantically intelligible. But I don't know if it would be as visually appealing. Right now, there's nothing associating these headers with the list semantically. However this can be something for subsequent discussion.
Another option is to make them headers, but that might make weird table-of-contents entries and stuff like that if we're not careful.
jasnell
approved these changes
Jul 19, 2026
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 20, 2026
Collaborator
Landed in 5b27fb9 |
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64582 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64582 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64582 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64582 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the current tables aren't compatible with the (subjective opinion trigger warning⚠️ ) overly narrow main content section of the doc redesign.