zlib: validate pledgedSrcSize for sync zstd - #64601

Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:zlib2
Closed

zlib: validate pledgedSrcSize for sync zstd#64601
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:zlib2

Conversation

@Archkon

@ArchkonArchkon commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64600

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib module and its compression dependencies. labels Jul 19, 2026
@Archkon
Archkonforce-pushed the zlib2 branch 2 times, most recently from 56b199b to ef6ad04CompareJuly 19, 2026 15:17
@Archkon

This comment was marked as spam.

Sign in to view
@codecov

codecovBot commented Jul 19, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (4a5eb1c) to head (a23d7a9).
⚠️ Report is 202 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64601 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03% 
==========================================
Files 744 744 Lines 242517 242534 +17 Branches 45688 45698 +10 ==========================================
- Hits 218642 218589 -53 - Misses 15358 15437 +79 + Partials 8517 8508 -9
Files with missing linesCoverage Δ
src/node_zlib.cc79.15% <100.00%> (-0.05%)⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archkon
Archkonforce-pushed the zlib2 branch 2 times, most recently from 95703df to aa63d44CompareJuly 20, 2026 13:58
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 20, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 20, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
zlib: validate pledgedSrcSize for sync zstd
a23d7a9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon
Archkonforce-pushed the zlib2 branch 3 times, most recently from ee70dc3 to a23d7a9CompareJuly 26, 2026 14:59
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Renegade334

Renegade334 commented Aug 4, 2026

Copy link
Copy Markdown
Member

You killed the runner apparently 😉

07:29:41 Agent went offline during the build

@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75463/

@avivkelleravivkeller added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 5, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 5, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[TypeError: Cannot read properties of null (reading 'oid')]
https://github.com/nodejs/node/actions/runs/30968647815

@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller

avivkeller commented Aug 7, 2026

Copy link
Copy Markdown
Member

I'm not sure that's the issue, cc @nodejs/node-core-utils

@avivkeller

avivkeller commented Aug 7, 2026

Copy link
Copy Markdown
Member

Maybe it was, however, the error message should be clearer, IMO

@avivkelleravivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2026
@panvapanva removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Aug 8, 2026
@Archkon

This comment was marked as spam.

Sign in to view
@panvapanva added commit-queue PRs queued for automated landing through the Commit Queue. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 8, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Jul 2026 14:30:06 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64601#pullrequestreview-4731028151
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64601#pullrequestreview-4879565446
✘ 2 GitHub CI job(s) failed:
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30204628282/job/89800606890)
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30205617244/job/89803411290)
✘ 13 GitHub CI job(s) cancelled:
✘ - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628218/job/89800769656)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628224/job/89800445824)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445627)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445648)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628239/job/89800445756)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628245/job/89800445631)
✘ - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571409)
✘ - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571452)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617143/job/89803043791)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501621)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501631)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617153/job/89803053112)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617155/job/89803043995)
ℹ Last Full PR CI on 2026-08-04T14:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/75463/
- Querying data for job/node-test-pull-request/75463/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31256774273

@Archkon

This comment was marked as spam.

Sign in to view
avivkeller pushed a commit that referenced this pull request Aug 8, 2026
@Archkon@avivkeller
zlib: validate pledgedSrcSize for sync zstd
c3de450
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller

avivkeller commented Aug 8, 2026

Copy link
Copy Markdown
Member

Landed in c3de450

@Archkon
Archkon deleted the zlib2 branch August 8, 2026 13:17
@ArchkonArchkon mentioned this pull request Aug 8, 2026
Open
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
0c1d1e9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
ee7bf09
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95 mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
5858c2b
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller approved these changes

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.zlibIssues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

zlib: zstdCompressSync() does not validate pledgedSrcSize

7 participants

@Archkon@nodejs-github-bot@Renegade334@avivkeller@jasnell@panva@lpinca
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
zlib: validate pledgedSrcSize for sync zstd - #64601
Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Closed
zlib: validate pledgedSrcSize for sync zstd#64601
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Conversation
@Archkon
@ArchkonArchkon
commented
Jul 19, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64600
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
zlib
Issues and PRs related to the zlib module and its compression dependencies.
labels
Jul 19, 2026
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
56b199b to
ef6ad04CompareJuly 19, 2026 15:17
@Archkon

This comment was marked as spam.

Sign in to view
@codecov
codecovBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (4a5eb1c) to head (a23d7a9).
⚠️ Report is 202 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64601 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03% 
==========================================
Files 744 744 Lines 242517 242534 +17 Branches 45688 45698 +10 ==========================================
- Hits 218642 218589 -53 - Misses 15358 15437 +79 + Partials 8517 8508 -9 
Files with missing linesCoverage Δ
src/node_zlib.cc79.15% <100.00%> (-0.05%)⬇️
... and 33 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
95703df to
aa63d44CompareJuly 20, 2026 13:58
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
zlib: validate pledgedSrcSize for sync zstd
a23d7a9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon
Archkonforce-pushed
the
zlib2
branch
3 times, most recently
from
ee70dc3 to
a23d7a9CompareJuly 26, 2026 14:59
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Renegade334
Renegade334
commented
Aug 4, 2026

Copy link


Copy Markdown

Member
You killed the runner apparently 😉
07:29:41 Agent went offline during the build

@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75463/
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[TypeError: Cannot read properties of null (reading 'oid')]
https://github.com/nodejs/node/actions/runs/30968647815
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
I'm not sure that's the issue, cc @nodejs/node-core-utils
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
Maybe it was, however, the error message should be clearer, IMO
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@panvapanva
removed
the 
commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
label
Aug 8, 2026
@Archkon

This comment was marked as spam.

Sign in to view
@panvapanva
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Jul 2026 14:30:06 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64601#pullrequestreview-4731028151
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64601#pullrequestreview-4879565446
✘ 2 GitHub CI job(s) failed:
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30204628282/job/89800606890)
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30205617244/job/89803411290)
✘ 13 GitHub CI job(s) cancelled:
✘ - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628218/job/89800769656)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628224/job/89800445824)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445627)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445648)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628239/job/89800445756)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628245/job/89800445631)
✘ - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571409)
✘ - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571452)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617143/job/89803043791)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501621)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501631)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617153/job/89803053112)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617155/job/89803043995)
ℹ Last Full PR CI on 2026-08-04T14:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/75463/
- Querying data for job/node-test-pull-request/75463/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31256774273
@Archkon

This comment was marked as spam.

Sign in to view
avivkeller pushed a commit
that referenced
this pull request
Aug 8, 2026
@Archkon@avivkeller
zlib: validate pledgedSrcSize for sync zstd
c3de450
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Landed in c3de450
@Archkon
Archkon
deleted the

zlib2

branch
August 8, 2026 13:17
@ArchkonArchkon
mentioned this pull request
Aug 8, 2026

Open

aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
0c1d1e9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
ee7bf09
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
5858c2b
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.zlibIssues and PRs related to the zlib module and its compression dependencies.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

zlib: zstdCompressSync() does not validate pledgedSrcSize


7 participants

@Archkon@nodejs-github-bot@Renegade334@avivkeller@jasnell@panva@lpinca

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
zlib: validate pledgedSrcSize for sync zstd - #64601
Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Closed
zlib: validate pledgedSrcSize for sync zstd#64601
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Conversation
@Archkon
@ArchkonArchkon
commented
Jul 19, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64600
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
zlib
Issues and PRs related to the zlib module and its compression dependencies.
labels
Jul 19, 2026
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
56b199b to
ef6ad04CompareJuly 19, 2026 15:17
@Archkon

This comment was marked as spam.

Sign in to view
@codecov
codecovBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (4a5eb1c) to head (a23d7a9).
⚠️ Report is 202 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64601 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03% 
==========================================
Files 744 744 Lines 242517 242534 +17 Branches 45688 45698 +10 ==========================================
- Hits 218642 218589 -53 - Misses 15358 15437 +79 + Partials 8517 8508 -9 
Files with missing linesCoverage Δ
src/node_zlib.cc79.15% <100.00%> (-0.05%)⬇️
... and 33 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
95703df to
aa63d44CompareJuly 20, 2026 13:58
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
zlib: validate pledgedSrcSize for sync zstd
a23d7a9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon
Archkonforce-pushed
the
zlib2
branch
3 times, most recently
from
ee70dc3 to
a23d7a9CompareJuly 26, 2026 14:59
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Renegade334
Renegade334
commented
Aug 4, 2026

Copy link


Copy Markdown

Member
You killed the runner apparently 😉
07:29:41 Agent went offline during the build

@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75463/
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[TypeError: Cannot read properties of null (reading 'oid')]
https://github.com/nodejs/node/actions/runs/30968647815
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
I'm not sure that's the issue, cc @nodejs/node-core-utils
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
Maybe it was, however, the error message should be clearer, IMO
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@panvapanva
removed
the 
commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
label
Aug 8, 2026
@Archkon

This comment was marked as spam.

Sign in to view
@panvapanva
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Jul 2026 14:30:06 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64601#pullrequestreview-4731028151
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64601#pullrequestreview-4879565446
✘ 2 GitHub CI job(s) failed:
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30204628282/job/89800606890)
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30205617244/job/89803411290)
✘ 13 GitHub CI job(s) cancelled:
✘ - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628218/job/89800769656)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628224/job/89800445824)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445627)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445648)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628239/job/89800445756)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628245/job/89800445631)
✘ - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571409)
✘ - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571452)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617143/job/89803043791)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501621)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501631)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617153/job/89803053112)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617155/job/89803043995)
ℹ Last Full PR CI on 2026-08-04T14:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/75463/
- Querying data for job/node-test-pull-request/75463/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31256774273
@Archkon

This comment was marked as spam.

Sign in to view
avivkeller pushed a commit
that referenced
this pull request
Aug 8, 2026
@Archkon@avivkeller
zlib: validate pledgedSrcSize for sync zstd
c3de450
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Landed in c3de450
@Archkon
Archkon
deleted the

zlib2

branch
August 8, 2026 13:17
@ArchkonArchkon
mentioned this pull request
Aug 8, 2026

Open

aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
0c1d1e9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
ee7bf09
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
5858c2b
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.zlibIssues and PRs related to the zlib module and its compression dependencies.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

zlib: zstdCompressSync() does not validate pledgedSrcSize


7 participants

@Archkon@nodejs-github-bot@Renegade334@avivkeller@jasnell@panva@lpinca

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
zlib: validate pledgedSrcSize for sync zstd - #64601
Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Closed
zlib: validate pledgedSrcSize for sync zstd#64601
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Conversation
@Archkon
@ArchkonArchkon
commented
Jul 19, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64600
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
zlib
Issues and PRs related to the zlib module and its compression dependencies.
labels
Jul 19, 2026
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
56b199b to
ef6ad04CompareJuly 19, 2026 15:17
@Archkon

This comment was marked as spam.

Sign in to view
@codecov
codecovBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (4a5eb1c) to head (a23d7a9).
⚠️ Report is 202 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64601 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03% 
==========================================
Files 744 744 Lines 242517 242534 +17 Branches 45688 45698 +10 ==========================================
- Hits 218642 218589 -53 - Misses 15358 15437 +79 + Partials 8517 8508 -9 
Files with missing linesCoverage Δ
src/node_zlib.cc79.15% <100.00%> (-0.05%)⬇️
... and 33 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
95703df to
aa63d44CompareJuly 20, 2026 13:58
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
zlib: validate pledgedSrcSize for sync zstd
a23d7a9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon
Archkonforce-pushed
the
zlib2
branch
3 times, most recently
from
ee70dc3 to
a23d7a9CompareJuly 26, 2026 14:59
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Renegade334
Renegade334
commented
Aug 4, 2026

Copy link


Copy Markdown

Member
You killed the runner apparently 😉
07:29:41 Agent went offline during the build

@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75463/
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[TypeError: Cannot read properties of null (reading 'oid')]
https://github.com/nodejs/node/actions/runs/30968647815
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
I'm not sure that's the issue, cc @nodejs/node-core-utils
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
Maybe it was, however, the error message should be clearer, IMO
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@panvapanva
removed
the 
commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
label
Aug 8, 2026
@Archkon

This comment was marked as spam.

Sign in to view
@panvapanva
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Jul 2026 14:30:06 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64601#pullrequestreview-4731028151
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64601#pullrequestreview-4879565446
✘ 2 GitHub CI job(s) failed:
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30204628282/job/89800606890)
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30205617244/job/89803411290)
✘ 13 GitHub CI job(s) cancelled:
✘ - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628218/job/89800769656)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628224/job/89800445824)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445627)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445648)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628239/job/89800445756)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628245/job/89800445631)
✘ - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571409)
✘ - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571452)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617143/job/89803043791)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501621)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501631)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617153/job/89803053112)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617155/job/89803043995)
ℹ Last Full PR CI on 2026-08-04T14:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/75463/
- Querying data for job/node-test-pull-request/75463/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31256774273
@Archkon

This comment was marked as spam.

Sign in to view
avivkeller pushed a commit
that referenced
this pull request
Aug 8, 2026
@Archkon@avivkeller
zlib: validate pledgedSrcSize for sync zstd
c3de450
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Landed in c3de450
@Archkon
Archkon
deleted the

zlib2

branch
August 8, 2026 13:17
@ArchkonArchkon
mentioned this pull request
Aug 8, 2026

Open

aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
0c1d1e9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
ee7bf09
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
5858c2b
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.zlibIssues and PRs related to the zlib module and its compression dependencies.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

zlib: zstdCompressSync() does not validate pledgedSrcSize


7 participants

@Archkon@nodejs-github-bot@Renegade334@avivkeller@jasnell@panva@lpinca

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
zlib: validate pledgedSrcSize for sync zstd - #64601
Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Closed
zlib: validate pledgedSrcSize for sync zstd#64601
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Conversation
@Archkon
@ArchkonArchkon
commented
Jul 19, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64600
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
zlib
Issues and PRs related to the zlib module and its compression dependencies.
labels
Jul 19, 2026
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
56b199b to
ef6ad04CompareJuly 19, 2026 15:17
@Archkon

This comment was marked as spam.

Sign in to view
@codecov
codecovBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (4a5eb1c) to head (a23d7a9).
⚠️ Report is 202 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64601 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03% 
==========================================
Files 744 744 Lines 242517 242534 +17 Branches 45688 45698 +10 ==========================================
- Hits 218642 218589 -53 - Misses 15358 15437 +79 + Partials 8517 8508 -9 
Files with missing linesCoverage Δ
src/node_zlib.cc79.15% <100.00%> (-0.05%)⬇️
... and 33 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
95703df to
aa63d44CompareJuly 20, 2026 13:58
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
zlib: validate pledgedSrcSize for sync zstd
a23d7a9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon
Archkonforce-pushed
the
zlib2
branch
3 times, most recently
from
ee70dc3 to
a23d7a9CompareJuly 26, 2026 14:59
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Renegade334
Renegade334
commented
Aug 4, 2026

Copy link


Copy Markdown

Member
You killed the runner apparently 😉
07:29:41 Agent went offline during the build

@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75463/
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[TypeError: Cannot read properties of null (reading 'oid')]
https://github.com/nodejs/node/actions/runs/30968647815
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
I'm not sure that's the issue, cc @nodejs/node-core-utils
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
Maybe it was, however, the error message should be clearer, IMO
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@panvapanva
removed
the 
commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
label
Aug 8, 2026
@Archkon

This comment was marked as spam.

Sign in to view
@panvapanva
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Jul 2026 14:30:06 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64601#pullrequestreview-4731028151
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64601#pullrequestreview-4879565446
✘ 2 GitHub CI job(s) failed:
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30204628282/job/89800606890)
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30205617244/job/89803411290)
✘ 13 GitHub CI job(s) cancelled:
✘ - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628218/job/89800769656)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628224/job/89800445824)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445627)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445648)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628239/job/89800445756)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628245/job/89800445631)
✘ - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571409)
✘ - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571452)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617143/job/89803043791)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501621)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501631)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617153/job/89803053112)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617155/job/89803043995)
ℹ Last Full PR CI on 2026-08-04T14:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/75463/
- Querying data for job/node-test-pull-request/75463/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31256774273
@Archkon

This comment was marked as spam.

Sign in to view
avivkeller pushed a commit
that referenced
this pull request
Aug 8, 2026
@Archkon@avivkeller
zlib: validate pledgedSrcSize for sync zstd
c3de450
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Landed in c3de450
@Archkon
Archkon
deleted the

zlib2

branch
August 8, 2026 13:17
@ArchkonArchkon
mentioned this pull request
Aug 8, 2026

Open

aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
0c1d1e9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
ee7bf09
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
5858c2b
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.zlibIssues and PRs related to the zlib module and its compression dependencies.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

zlib: zstdCompressSync() does not validate pledgedSrcSize


7 participants

@Archkon@nodejs-github-bot@Renegade334@avivkeller@jasnell@panva@lpinca

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
zlib: validate pledgedSrcSize for sync zstd - #64601
Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Closed
zlib: validate pledgedSrcSize for sync zstd#64601
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Conversation
@Archkon
@ArchkonArchkon
commented
Jul 19, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64600
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
zlib
Issues and PRs related to the zlib module and its compression dependencies.
labels
Jul 19, 2026
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
56b199b to
ef6ad04CompareJuly 19, 2026 15:17
@Archkon

This comment was marked as spam.

Sign in to view
@codecov
codecovBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (4a5eb1c) to head (a23d7a9).
⚠️ Report is 202 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64601 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03% 
==========================================
Files 744 744 Lines 242517 242534 +17 Branches 45688 45698 +10 ==========================================
- Hits 218642 218589 -53 - Misses 15358 15437 +79 + Partials 8517 8508 -9 
Files with missing linesCoverage Δ
src/node_zlib.cc79.15% <100.00%> (-0.05%)⬇️
... and 33 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
95703df to
aa63d44CompareJuly 20, 2026 13:58
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
zlib: validate pledgedSrcSize for sync zstd
a23d7a9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon
Archkonforce-pushed
the
zlib2
branch
3 times, most recently
from
ee70dc3 to
a23d7a9CompareJuly 26, 2026 14:59
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Renegade334
Renegade334
commented
Aug 4, 2026

Copy link


Copy Markdown

Member
You killed the runner apparently 😉
07:29:41 Agent went offline during the build

@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75463/
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[TypeError: Cannot read properties of null (reading 'oid')]
https://github.com/nodejs/node/actions/runs/30968647815
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
I'm not sure that's the issue, cc @nodejs/node-core-utils
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
Maybe it was, however, the error message should be clearer, IMO
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@panvapanva
removed
the 
commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
label
Aug 8, 2026
@Archkon

This comment was marked as spam.

Sign in to view
@panvapanva
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Jul 2026 14:30:06 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64601#pullrequestreview-4731028151
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64601#pullrequestreview-4879565446
✘ 2 GitHub CI job(s) failed:
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30204628282/job/89800606890)
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30205617244/job/89803411290)
✘ 13 GitHub CI job(s) cancelled:
✘ - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628218/job/89800769656)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628224/job/89800445824)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445627)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445648)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628239/job/89800445756)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628245/job/89800445631)
✘ - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571409)
✘ - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571452)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617143/job/89803043791)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501621)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501631)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617153/job/89803053112)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617155/job/89803043995)
ℹ Last Full PR CI on 2026-08-04T14:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/75463/
- Querying data for job/node-test-pull-request/75463/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31256774273
@Archkon

This comment was marked as spam.

Sign in to view
avivkeller pushed a commit
that referenced
this pull request
Aug 8, 2026
@Archkon@avivkeller
zlib: validate pledgedSrcSize for sync zstd
c3de450
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Landed in c3de450
@Archkon
Archkon
deleted the

zlib2

branch
August 8, 2026 13:17
@ArchkonArchkon
mentioned this pull request
Aug 8, 2026

Open

aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
0c1d1e9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
ee7bf09
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
5858c2b
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.zlibIssues and PRs related to the zlib module and its compression dependencies.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

zlib: zstdCompressSync() does not validate pledgedSrcSize


7 participants

@Archkon@nodejs-github-bot@Renegade334@avivkeller@jasnell@panva@lpinca

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
zlib: validate pledgedSrcSize for sync zstd - #64601
Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Closed
zlib: validate pledgedSrcSize for sync zstd#64601
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Conversation
@Archkon
@ArchkonArchkon
commented
Jul 19, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64600
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
zlib
Issues and PRs related to the zlib module and its compression dependencies.
labels
Jul 19, 2026
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
56b199b to
ef6ad04CompareJuly 19, 2026 15:17
@Archkon

This comment was marked as spam.

Sign in to view
@codecov
codecovBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (4a5eb1c) to head (a23d7a9).
⚠️ Report is 202 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64601 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03% 
==========================================
Files 744 744 Lines 242517 242534 +17 Branches 45688 45698 +10 ==========================================
- Hits 218642 218589 -53 - Misses 15358 15437 +79 + Partials 8517 8508 -9 
Files with missing linesCoverage Δ
src/node_zlib.cc79.15% <100.00%> (-0.05%)⬇️
... and 33 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
95703df to
aa63d44CompareJuly 20, 2026 13:58
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
zlib: validate pledgedSrcSize for sync zstd
a23d7a9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon
Archkonforce-pushed
the
zlib2
branch
3 times, most recently
from
ee70dc3 to
a23d7a9CompareJuly 26, 2026 14:59
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Renegade334
Renegade334
commented
Aug 4, 2026

Copy link


Copy Markdown

Member
You killed the runner apparently 😉
07:29:41 Agent went offline during the build

@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75463/
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[TypeError: Cannot read properties of null (reading 'oid')]
https://github.com/nodejs/node/actions/runs/30968647815
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
I'm not sure that's the issue, cc @nodejs/node-core-utils
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
Maybe it was, however, the error message should be clearer, IMO
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@panvapanva
removed
the 
commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
label
Aug 8, 2026
@Archkon

This comment was marked as spam.

Sign in to view
@panvapanva
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Jul 2026 14:30:06 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64601#pullrequestreview-4731028151
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64601#pullrequestreview-4879565446
✘ 2 GitHub CI job(s) failed:
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30204628282/job/89800606890)
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30205617244/job/89803411290)
✘ 13 GitHub CI job(s) cancelled:
✘ - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628218/job/89800769656)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628224/job/89800445824)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445627)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445648)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628239/job/89800445756)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628245/job/89800445631)
✘ - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571409)
✘ - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571452)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617143/job/89803043791)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501621)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501631)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617153/job/89803053112)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617155/job/89803043995)
ℹ Last Full PR CI on 2026-08-04T14:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/75463/
- Querying data for job/node-test-pull-request/75463/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31256774273
@Archkon

This comment was marked as spam.

Sign in to view
avivkeller pushed a commit
that referenced
this pull request
Aug 8, 2026
@Archkon@avivkeller
zlib: validate pledgedSrcSize for sync zstd
c3de450
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Landed in c3de450
@Archkon
Archkon
deleted the

zlib2

branch
August 8, 2026 13:17
@ArchkonArchkon
mentioned this pull request
Aug 8, 2026

Open

aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
0c1d1e9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
ee7bf09
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
5858c2b
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.zlibIssues and PRs related to the zlib module and its compression dependencies.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

zlib: zstdCompressSync() does not validate pledgedSrcSize


7 participants

@Archkon@nodejs-github-bot@Renegade334@avivkeller@jasnell@panva@lpinca

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
zlib: validate pledgedSrcSize for sync zstd - #64601
Closed
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Closed
zlib: validate pledgedSrcSize for sync zstd#64601
Archkon wants to merge 1 commit into
nodejs:mainfrom 
Archkon:zlib2
Conversation
@Archkon
@ArchkonArchkon
commented
Jul 19, 2026

Copy link


Copy Markdown

Contributor
Fixes: #64600
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
zlib
Issues and PRs related to the zlib module and its compression dependencies.
labels
Jul 19, 2026
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
56b199b to
ef6ad04CompareJuly 19, 2026 15:17
@Archkon

This comment was marked as spam.

Sign in to view
@codecov
codecovBot
commented
Jul 19, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (4a5eb1c) to head (a23d7a9).
⚠️ Report is 202 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64601 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.03% 
==========================================
Files 744 744 Lines 242517 242534 +17 Branches 45688 45698 +10 ==========================================
- Hits 218642 218589 -53 - Misses 15358 15437 +79 + Partials 8517 8508 -9 
Files with missing linesCoverage Δ
src/node_zlib.cc79.15% <100.00%> (-0.05%)⬇️
... and 33 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Archkon
Archkonforce-pushed
the
zlib2
branch
2 times, most recently
from
95703df to
aa63d44CompareJuly 20, 2026 13:58
@lpincalpinca
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 20, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
zlib: validate pledgedSrcSize for sync zstd
a23d7a9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon
Archkonforce-pushed
the
zlib2
branch
3 times, most recently
from
ee70dc3 to
a23d7a9CompareJuly 26, 2026 14:59
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@Renegade334
Renegade334
commented
Aug 4, 2026

Copy link


Copy Markdown

Member
You killed the runner apparently 😉
07:29:41 Agent went offline during the build

@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75463/
@avivkelleravivkeller
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
[TypeError: Cannot read properties of null (reading 'oid')]
https://github.com/nodejs/node/actions/runs/30968647815
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon

This comment was marked as spam.

Sign in to view
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
I'm not sure that's the issue, cc @nodejs/node-core-utils
@avivkeller
avivkeller
commented
Aug 7, 2026

Copy link


Copy Markdown

Member
Maybe it was, however, the error message should be clearer, IMO
@avivkelleravivkeller
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@panvapanva
removed
the 
commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
label
Aug 8, 2026
@Archkon

This comment was marked as spam.

Sign in to view
@panvapanva
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 8, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 8, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 8, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64601
✔ Done loading data for nodejs/node/pull/64601
----------------------------------- PR info ------------------------------------
Title zlib: validate pledgedSrcSize for sync zstd (#64601)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Archkon:zlib2 -> nodejs:main
Labels c++, zlib, author ready, needs-ci
Commits 1
- zlib: validate pledgedSrcSize for sync zstd
Committers 1
- Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64601
Fixes: https://github.com/nodejs/node/issues/64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Jul 2026 14:30:06 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64601#pullrequestreview-4731028151
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64601#pullrequestreview-4879565446
✘ 2 GitHub CI job(s) failed:
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30204628282/job/89800606890)
✘ - aarch64-linux: with shared boringssl-0.20260526.0 / build: FAILURE (https://github.com/nodejs/node/actions/runs/30205617244/job/89803411290)
✘ 13 GitHub CI job(s) cancelled:
✘ - test-tarball-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628218/job/89800769656)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628224/job/89800445824)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445627)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30204628225/job/89800445648)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628239/job/89800445756)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628245/job/89800445631)
✘ - x86_64-linux: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571409)
✘ - x86_64-darwin: with shared libraries / build: CANCELLED (https://github.com/nodejs/node/actions/runs/30204628282/job/89800571452)
✘ - test-macOS: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617143/job/89803043791)
✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501621)
✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/30205617152/job/89803501631)
✘ - coverage-windows: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617153/job/89803053112)
✘ - coverage-linux: CANCELLED (https://github.com/nodejs/node/actions/runs/30205617155/job/89803043995)
ℹ Last Full PR CI on 2026-08-04T14:50:42Z: https://ci.nodejs.org/job/node-test-pull-request/75463/
- Querying data for job/node-test-pull-request/75463/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31256774273
@Archkon

This comment was marked as spam.

Sign in to view
avivkeller pushed a commit
that referenced
this pull request
Aug 8, 2026
@Archkon@avivkeller
zlib: validate pledgedSrcSize for sync zstd
c3de450
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller
avivkeller
commented
Aug 8, 2026

Copy link


Copy Markdown

Member
Landed in c3de450
@Archkon
Archkon
deleted the

zlib2

branch
August 8, 2026 13:17
@ArchkonArchkon
mentioned this pull request
Aug 8, 2026

Open

aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
0c1d1e9
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
ee7bf09
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95aduh95
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@Archkon@aduh95
zlib: validate pledgedSrcSize for sync zstd
5858c2b
Zstd replaces a configured pledged source size with the input size when
the first call to ZSTD_compressStream2() uses ZSTD_e_end. Track consumed
input in Node and report ZSTD_error_srcSize_wrong when the completed
frame does not match the original pledge.
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64601Fixes: #64600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.zlibIssues and PRs related to the zlib module and its compression dependencies.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

zlib: zstdCompressSync() does not validate pledgedSrcSize


7 participants

@Archkon@nodejs-github-bot@Renegade334@avivkeller@jasnell@panva@lpinca