net: handle undefined parent in _unrefTimer and _destroy

[haggholm]

The fix and approach are from #64491 by @Shivay-98; opening from a fresh branch to land it, since that PR stalled awaiting the requested changes (unrelated commit dropped, failing test addressed, Signed-off-by added).

Socket.prototype._unrefTimer and Socket.prototype._destroy both walk the socket _parent chain with a strict !== null check. When teardown leaves a socket's _parent as undefined (for example a TLS socket layered over another stream), the loop steps onto undefined and throws

TypeError: Cannot read properties of undefined (reading 'Symbol(timeout)')
at TLSSocket._unrefTimer (node:net)
at TLSWrap.onStreamRead (node:internal/stream_base_commons)

from an uncaught I/O callback, crashing the process. Switching both loops to a nullish != null check stops the walk on undefined as well.

The original PR fixed only _unrefTimer; its regression test also calls destroy(), which hits the same unpatched loop in _destroy, so that path is fixed and covered here too.

Fixes: #64490
Refs: #64491

Checklist

• make -j4 test (UNIX) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

Review requested:

• @nodejs/net

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (ed63b19) to head (0fff075).
⚠️ Report is 248 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #64644 +/- ##
==========================================
- Coverage 92.01% 90.14% -1.87% 
==========================================
Files 381 741 +360 Lines 170167 242137 +71970 Branches 26075 45568 +19493 ==========================================
+ Hits 156585 218286 +61701 - Misses 13291 15368 +2077 - Partials 291 8483 +8192 

Files with missing lines	Coverage Δ
lib/net.js	94.37% <100.00%> (+3.37%)	⬆️

... and 513 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[haggholm]

Cc. @aduh95 who was active in the original PR.

Note: I've never contributed to Node and basically do not know what I am doing.

[pimterry]

Note: I've never contributed to Node and basically do not know what I am doing.

Thanks for the PR @haggholm, no worries, this looks good to me and all going in the right direction. Very helpful picking up stalled work like this. I have a minor comment here that it'd be nice to clean up (you can just push another commit and they'll be squashed together at merge automatically) but otherwise everything looks great.

Don't worry too much about the test-internet failure, I strongly suspect something flaky is going on there... Could be us, could be github actions, hard to say.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75002/

[mcollina]

lgtm

[pimterry]

Don't worry too much about the test-internet failure, I strongly suspect something flaky is going on there... Could be us, could be github actions, hard to say.

More specifically, I see now it's been broken on main but will be fixed by #64624 imminently, we'll just need to wait until that's merged then rebase this.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75010/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75075/

[pimterry]

More specifically, I see now it's been broken on main but will be fixed by #64624 imminently, we'll just need to wait until that's merged then rebase this.

#64624 has now been merged to fix test-internet. If you rebase and force push, this should be good to go.

[lpinca]

My only observation is that _parent is a "private" property so its value should not be changed by user code.