Skip to content

src: implement MemoryRetainer protocol for ByteSource - #64660

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:bytesource-memory-retainer-protocol
Jul 29, 2026
Merged

src: implement MemoryRetainer protocol for ByteSource#64660
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:bytesource-memory-retainer-protocol

Conversation

@panva

@panvapanva commented Jul 21, 2026

Copy link
Copy Markdown
Member

cc @addaleax, one of your self-proposed TODOs

@panva
src: implement MemoryRetainer protocol for ByteSource
83df2b9
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva requested a review from addaleaxJuly 21, 2026 18:18
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2026
@codecov

codecovBot commented Jul 21, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.32990% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.15%. Comparing base (db3a8d8) to head (83df2b9).
⚠️ Report is 95 commits behind head on main.

Files with missing linesPatch %Lines
src/crypto/crypto_keys.cc0.00%11 Missing ⚠️
src/crypto/crypto_argon2.cc14.28%6 Missing ⚠️
src/crypto/crypto_hash.cc28.57%5 Missing ⚠️
src/crypto/crypto_hkdf.cc16.66%5 Missing ⚠️
src/crypto/crypto_kem.cc75.00%3 Missing ⚠️
src/crypto/crypto_kmac.cc25.00%3 Missing ⚠️
src/crypto/crypto_sig.cc25.00%3 Missing ⚠️
src/crypto/crypto_turboshake.cc40.00%3 Missing ⚠️
src/crypto/crypto_aes.cc33.33%2 Missing ⚠️
src/crypto/crypto_chacha20_poly1305.cc33.33%2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@ Coverage Diff @@## main #64660 +/- ##
==========================================
+ Coverage 90.14% 90.15% +0.01% 
==========================================
Files 741 741 Lines 242133 242079 -54 Branches 45568 45552 -16 ==========================================
- Hits 218265 218258 -7 + Misses 15371 15325 -46 + Partials 8497 8496 -1
Files with missing linesCoverage Δ
src/crypto/crypto_aes.h33.33% <ø> (ø)
src/crypto/crypto_argon2.h50.00% <ø> (ø)
src/crypto/crypto_chacha20_poly1305.h33.33% <ø> (ø)
src/crypto/crypto_hash.h25.00% <ø> (ø)
src/crypto/crypto_hkdf.h33.33% <ø> (ø)
src/crypto/crypto_hmac.h20.00% <ø> (ø)
src/crypto/crypto_kem.h25.00% <ø> (ø)
src/crypto/crypto_kmac.h33.33% <ø> (ø)
src/crypto/crypto_pbkdf2.h100.00% <ø> (ø)
src/crypto/crypto_rsa.h54.54% <ø> (-3.79%)⬇️
... and 22 more

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 22, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74997/

@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75011/

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 29d183d into nodejs:mainJul 29, 2026
87 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Landed in 29d183d

@panva
panva deleted the bytesource-memory-retainer-protocol branch August 3, 2026 07:50
aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@panva@aduh95
src: implement MemoryRetainer protocol for ByteSource
3379544
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64660
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@panva@aduh95
src: implement MemoryRetainer protocol for ByteSource
c299d2e
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64660
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 4, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 5, 2026
@panva@aduh95
src: implement MemoryRetainer protocol for ByteSource
6cd643a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64660
Reviewed-By: James M Snell <jasnell@gmail.com>
panva added a commit to panva/node that referenced this pull request Aug 6, 2026
@panva
src: implement MemoryRetainer protocol for ByteSource
dabb485
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#64660
Reviewed-By: James M Snell <jasnell@gmail.com>
@panvapanva mentioned this pull request Aug 6, 2026
Closed
27 tasks
@panvapanva added the backport-open-v24.x Indicate that the PR has an open backport label Aug 6, 2026
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@panva@aduh95
src: implement MemoryRetainer protocol for ByteSource
782ad5d
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64660
Backport-PR-URL: #65087
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxAwaiting requested review from addaleax

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backport-open-v24.xIndicate that the PR has an open backportc++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panva@nodejs-github-bot@jasnell