src: add SetAbortHandler - #64684

Closed
maxhfisher wants to merge 8 commits into
nodejs:mainfrom
maxhfisher:aborthandler
Closed

src: add SetAbortHandler#64684
maxhfisher wants to merge 8 commits into
nodejs:mainfrom
maxhfisher:aborthandler

Conversation

@maxhfisher

@maxhfishermaxhfisher commented Jul 22, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

This adds SetAbortHandler, which allows embedders to specify custom behavior in situations where ABORT() is called. The current behavior of ABORT() is to stream both the native and JS backtraces to stderr and exit with platform specific behavior. Some embedders may want to change this behavior, such as changing where the backtrace is provided. Embedders can also use the handler to exit with their own behavior, but node will still guarantee an exit if the provided abort handler returns.

A DefaultAbortHandler is used to ensure existing behavior does not change unless an abort handler is explicitly provided. The only difference with this design is an additional stack frame in the backtrace for the abort handler, but this behavior was never guaranteed.

A new ABORT_WITH_DETAILS macro is also added for cases where a location and message can be passed describing the abort. This new macro replaces existing calls to ABORT in various error handlers in node_errors.cc where a message is already available. This message is then propagated to the abort handler, but no changes are made to the default abort handler. That behavior does not change here.

@maxhfisher
src: add SetAbortHandler
c5548d3
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 22, 2026
legendecas
legendecas reviewed Jul 23, 2026
View reviewed changes
Comment threadtest/abort/test-addon-abort-handler.js Outdated
Comment threadsrc/node.h Outdated
Comment threadsrc/node.h Outdated
Comment threadsrc/node.h Outdated
Comment threadsrc/node_errors.cc Outdated
Comment threadsrc/node_errors.cc Outdated
legendecas
legendecas reviewed Jul 23, 2026
View reviewed changes
Comment threadsrc/node.h Outdated
@codecov

codecovBot commented Jul 23, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.28%. Comparing base (efc0a14) to head (6b87c15).
⚠️ Report is 231 commits behind head on main.

Files with missing linesPatch %Lines
src/node_errors.cc38.46%8 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64684 +/- ##
==========================================
+ Coverage 90.11% 90.28% +0.17% 
==========================================
Files 741 759 +18 Lines 242196 247639 +5443 Branches 45606 46691 +1085 ==========================================
+ Hits 218246 223581 +5335 - Misses 15438 15520 +82 - Partials 8512 8538 +26
Files with missing linesCoverage Δ
src/node.h92.30% <ø> (ø)
src/util.h90.98% <ø> (ø)
src/node_errors.cc62.58% <38.46%> (-0.18%)⬇️

... and 196 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxhfisher
fix: respond to PR comments
309902e
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
legendecas
legendecas reviewed Jul 24, 2026
View reviewed changes
Comment threadsrc/util.h Outdated
@maxhfisher@legendecas
fix: Update default abort message
71e66f8
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecaslegendecas added the review wanted PRs that need review. label Jul 29, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@maxhfisher
maxhfisher marked this pull request as draft August 5, 2026 15:28
@maxhfisher
maxhfisher marked this pull request as ready for review August 5, 2026 19:44
legendecas
legendecas reviewed Aug 6, 2026
View reviewed changes
Comment threadsrc/util.h
@legendecaslegendecas added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 7, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75684/

@legendecaslegendecas added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 11, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 11, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64684
✔ Done loading data for nodejs/node/pull/64684
----------------------------------- PR info ------------------------------------
Title src: add SetAbortHandler (#64684)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch maxhfisher:aborthandler -> nodejs:main
Labels c++, author ready, needs-ci, review wanted, commit-queue, commit-queue-squash
Commits 8
- src: add SetAbortHandler
- fix: fix lint
- fix: respond to PR comments
- fix: Update default abort message
- fix: Split handler arguments into location and message
- Merge branch 'nodejs:main' into aborthandler
- fix: Be more clear about null arguments in abort handler
- fix: Prose
Committers 2
- Max H Fisher <mfisher187@bloomberg.net>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Jul 2026 20:52:39 GMT
✔ Approvals: 1
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/64684#pullrequestreview-4883277125
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T07:55:41Z: https://ci.nodejs.org/job/node-test-pull-request/75684/
- Querying data for job/node-test-pull-request/75684/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 64684
From https://github.com/nodejs/node
* branch refs/pull/64684/merge -> FETCH_HEAD
✔ Fetched commits as 2749388e44ac..455cbed91694
--------------------------------------------------------------------------------
Auto-merging src/util.h
[main 8c9e8f5a6d] src: add SetAbortHandler
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 16:07:43 2026 -0400
8 files changed, 148 insertions(+), 3 deletions(-)
create mode 100644 test/abort/test-addon-abort-handler.js
create mode 100644 test/addons/abort-handler/binding.cc
create mode 100644 test/addons/abort-handler/binding.gyp
create mode 100644 test/addons/abort-handler/test.js
[main f64686a503] fix: fix lint
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 17:48:50 2026 -0400
1 file changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/util.h
[main ca1cadebfb] fix: respond to PR comments
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Thu Jul 23 17:16:39 2026 -0400
7 files changed, 55 insertions(+), 45 deletions(-)
delete mode 100644 test/abort/test-addon-abort-handler.js
Auto-merging src/util.h
[main deac2a26a1] fix: Update default abort message
Author: Max Fisher <66274614+maxhfisher@users.noreply.github.com>
Date: Fri Jul 24 16:58:44 2026 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/util.h
error: commit f579940a11b9a8d0afb94a9b6d7353bc2b348ebe is a merge but no -m option was given.
fatal: cherry-pick failed
[main c0979cfc85] fix: Split handler arguments into location and message
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Aug 5 15:26:31 2026 -0400
5 files changed, 29 insertions(+), 22 deletions(-)
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31535700850

legendecas pushed a commit that referenced this pull request Aug 11, 2026
@maxhfisher@legendecas
src: add SetAbortHandler
559afb1
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas

legendecas commented Aug 11, 2026

Copy link
Copy Markdown
Member

Landed in 559afb1

aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
5c3c9ed
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
b7a2342
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
c8625a4
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.review wantedPRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxhfisher@nodejs-github-bot@legendecas
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
src: add SetAbortHandler - #64684
Closed
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Closed
src: add SetAbortHandler#64684
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Conversation
@maxhfisher
@maxhfishermaxhfisher
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
This adds SetAbortHandler, which allows embedders to specify custom behavior in situations where ABORT() is called. The current behavior of ABORT() is to stream both the native and JS backtraces to stderr and exit with platform specific behavior. Some embedders may want to change this behavior, such as changing where the backtrace is provided. Embedders can also use the handler to exit with their own behavior, but node will still guarantee an exit if the provided abort handler returns.
A DefaultAbortHandler is used to ensure existing behavior does not change unless an abort handler is explicitly provided. The only difference with this design is an additional stack frame in the backtrace for the abort handler, but this behavior was never guaranteed.
A new ABORT_WITH_DETAILS macro is also added for cases where a location and message can be passed describing the abort. This new macro replaces existing calls to ABORT in various error handlers in node_errors.cc where a message is already available. This message is then propagated to the abort handler, but no changes are made to the default abort handler. That behavior does not change here.
@maxhfisher
src: add SetAbortHandler
c5548d3
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
@nodejs-github-bot
nodejs-github-bot
commented
Jul 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jul 22, 2026
legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/abort/test-addon-abort-handler.js
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node_errors.cc
Outdated

Comment threadsrc/node_errors.cc
Outdated

legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node.h
Outdated

@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (efc0a14) to head (6b87c15).
⚠️ Report is 231 commits behind head on main.
Files with missing linesPatch %Lines
src/node_errors.cc38.46%8 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64684 +/- ##
==========================================
+ Coverage 90.11% 90.28% +0.17% 
==========================================
Files 741 759 +18 Lines 242196 247639 +5443 Branches 45606 46691 +1085 ==========================================
+ Hits 218246 223581 +5335 - Misses 15438 15520 +82 - Partials 8512 8538 +26 
Files with missing linesCoverage Δ
src/node.h92.30% <ø> (ø)
src/util.h90.98% <ø> (ø)
src/node_errors.cc62.58% <38.46%> (-0.18%)⬇️
... and 196 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@maxhfisher
fix: respond to PR comments
309902e
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
legendecas
legendecas
reviewed
Jul 24, 2026
View reviewed changes
Comment threadsrc/util.h
Outdated

@maxhfisher@legendecas
fix: Update default abort message
71e66f8
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecaslegendecas
added
the 
review wanted
PRs that need review.
label
Jul 29, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@maxhfisher
maxhfisher
marked this pull request as draft
August 5, 2026 15:28
@maxhfisher
maxhfisher
marked this pull request as ready for review
August 5, 2026 19:44
legendecas
legendecas
reviewed
Aug 6, 2026
View reviewed changes
Comment threadsrc/util.h
@legendecaslegendecas
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75684/
@legendecaslegendecas
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Aug 11, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 11, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64684
✔ Done loading data for nodejs/node/pull/64684
----------------------------------- PR info ------------------------------------
Title src: add SetAbortHandler (#64684)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch maxhfisher:aborthandler -> nodejs:main
Labels c++, author ready, needs-ci, review wanted, commit-queue, commit-queue-squash
Commits 8
- src: add SetAbortHandler
- fix: fix lint
- fix: respond to PR comments
- fix: Update default abort message
- fix: Split handler arguments into location and message
- Merge branch 'nodejs:main' into aborthandler
- fix: Be more clear about null arguments in abort handler
- fix: Prose
Committers 2
- Max H Fisher <mfisher187@bloomberg.net>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Jul 2026 20:52:39 GMT
✔ Approvals: 1
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/64684#pullrequestreview-4883277125
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T07:55:41Z: https://ci.nodejs.org/job/node-test-pull-request/75684/
- Querying data for job/node-test-pull-request/75684/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 64684
From https://github.com/nodejs/node
* branch refs/pull/64684/merge -> FETCH_HEAD
✔ Fetched commits as 2749388e44ac..455cbed91694
--------------------------------------------------------------------------------
Auto-merging src/util.h
[main 8c9e8f5a6d] src: add SetAbortHandler
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 16:07:43 2026 -0400
8 files changed, 148 insertions(+), 3 deletions(-)
create mode 100644 test/abort/test-addon-abort-handler.js
create mode 100644 test/addons/abort-handler/binding.cc
create mode 100644 test/addons/abort-handler/binding.gyp
create mode 100644 test/addons/abort-handler/test.js
[main f64686a503] fix: fix lint
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 17:48:50 2026 -0400
1 file changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/util.h
[main ca1cadebfb] fix: respond to PR comments
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Thu Jul 23 17:16:39 2026 -0400
7 files changed, 55 insertions(+), 45 deletions(-)
delete mode 100644 test/abort/test-addon-abort-handler.js
Auto-merging src/util.h
[main deac2a26a1] fix: Update default abort message
Author: Max Fisher <66274614+maxhfisher@users.noreply.github.com>
Date: Fri Jul 24 16:58:44 2026 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/util.h
error: commit f579940a11b9a8d0afb94a9b6d7353bc2b348ebe is a merge but no -m option was given.
fatal: cherry-pick failed
[main c0979cfc85] fix: Split handler arguments into location and message
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Aug 5 15:26:31 2026 -0400
5 files changed, 29 insertions(+), 22 deletions(-)
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31535700850
legendecas pushed a commit
that referenced
this pull request
Aug 11, 2026
@maxhfisher@legendecas
src: add SetAbortHandler
559afb1
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas
legendecas
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
Landed in 559afb1
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
5c3c9ed
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
b7a2342
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
c8625a4
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.review wantedPRs that need review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@maxhfisher@nodejs-github-bot@legendecas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
src: add SetAbortHandler - #64684
Closed
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Closed
src: add SetAbortHandler#64684
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Conversation
@maxhfisher
@maxhfishermaxhfisher
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
This adds SetAbortHandler, which allows embedders to specify custom behavior in situations where ABORT() is called. The current behavior of ABORT() is to stream both the native and JS backtraces to stderr and exit with platform specific behavior. Some embedders may want to change this behavior, such as changing where the backtrace is provided. Embedders can also use the handler to exit with their own behavior, but node will still guarantee an exit if the provided abort handler returns.
A DefaultAbortHandler is used to ensure existing behavior does not change unless an abort handler is explicitly provided. The only difference with this design is an additional stack frame in the backtrace for the abort handler, but this behavior was never guaranteed.
A new ABORT_WITH_DETAILS macro is also added for cases where a location and message can be passed describing the abort. This new macro replaces existing calls to ABORT in various error handlers in node_errors.cc where a message is already available. This message is then propagated to the abort handler, but no changes are made to the default abort handler. That behavior does not change here.
@maxhfisher
src: add SetAbortHandler
c5548d3
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
@nodejs-github-bot
nodejs-github-bot
commented
Jul 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jul 22, 2026
legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/abort/test-addon-abort-handler.js
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node_errors.cc
Outdated

Comment threadsrc/node_errors.cc
Outdated

legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node.h
Outdated

@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (efc0a14) to head (6b87c15).
⚠️ Report is 231 commits behind head on main.
Files with missing linesPatch %Lines
src/node_errors.cc38.46%8 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64684 +/- ##
==========================================
+ Coverage 90.11% 90.28% +0.17% 
==========================================
Files 741 759 +18 Lines 242196 247639 +5443 Branches 45606 46691 +1085 ==========================================
+ Hits 218246 223581 +5335 - Misses 15438 15520 +82 - Partials 8512 8538 +26 
Files with missing linesCoverage Δ
src/node.h92.30% <ø> (ø)
src/util.h90.98% <ø> (ø)
src/node_errors.cc62.58% <38.46%> (-0.18%)⬇️
... and 196 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@maxhfisher
fix: respond to PR comments
309902e
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
legendecas
legendecas
reviewed
Jul 24, 2026
View reviewed changes
Comment threadsrc/util.h
Outdated

@maxhfisher@legendecas
fix: Update default abort message
71e66f8
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecaslegendecas
added
the 
review wanted
PRs that need review.
label
Jul 29, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@maxhfisher
maxhfisher
marked this pull request as draft
August 5, 2026 15:28
@maxhfisher
maxhfisher
marked this pull request as ready for review
August 5, 2026 19:44
legendecas
legendecas
reviewed
Aug 6, 2026
View reviewed changes
Comment threadsrc/util.h
@legendecaslegendecas
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75684/
@legendecaslegendecas
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Aug 11, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 11, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64684
✔ Done loading data for nodejs/node/pull/64684
----------------------------------- PR info ------------------------------------
Title src: add SetAbortHandler (#64684)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch maxhfisher:aborthandler -> nodejs:main
Labels c++, author ready, needs-ci, review wanted, commit-queue, commit-queue-squash
Commits 8
- src: add SetAbortHandler
- fix: fix lint
- fix: respond to PR comments
- fix: Update default abort message
- fix: Split handler arguments into location and message
- Merge branch 'nodejs:main' into aborthandler
- fix: Be more clear about null arguments in abort handler
- fix: Prose
Committers 2
- Max H Fisher <mfisher187@bloomberg.net>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Jul 2026 20:52:39 GMT
✔ Approvals: 1
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/64684#pullrequestreview-4883277125
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T07:55:41Z: https://ci.nodejs.org/job/node-test-pull-request/75684/
- Querying data for job/node-test-pull-request/75684/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 64684
From https://github.com/nodejs/node
* branch refs/pull/64684/merge -> FETCH_HEAD
✔ Fetched commits as 2749388e44ac..455cbed91694
--------------------------------------------------------------------------------
Auto-merging src/util.h
[main 8c9e8f5a6d] src: add SetAbortHandler
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 16:07:43 2026 -0400
8 files changed, 148 insertions(+), 3 deletions(-)
create mode 100644 test/abort/test-addon-abort-handler.js
create mode 100644 test/addons/abort-handler/binding.cc
create mode 100644 test/addons/abort-handler/binding.gyp
create mode 100644 test/addons/abort-handler/test.js
[main f64686a503] fix: fix lint
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 17:48:50 2026 -0400
1 file changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/util.h
[main ca1cadebfb] fix: respond to PR comments
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Thu Jul 23 17:16:39 2026 -0400
7 files changed, 55 insertions(+), 45 deletions(-)
delete mode 100644 test/abort/test-addon-abort-handler.js
Auto-merging src/util.h
[main deac2a26a1] fix: Update default abort message
Author: Max Fisher <66274614+maxhfisher@users.noreply.github.com>
Date: Fri Jul 24 16:58:44 2026 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/util.h
error: commit f579940a11b9a8d0afb94a9b6d7353bc2b348ebe is a merge but no -m option was given.
fatal: cherry-pick failed
[main c0979cfc85] fix: Split handler arguments into location and message
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Aug 5 15:26:31 2026 -0400
5 files changed, 29 insertions(+), 22 deletions(-)
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31535700850
legendecas pushed a commit
that referenced
this pull request
Aug 11, 2026
@maxhfisher@legendecas
src: add SetAbortHandler
559afb1
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas
legendecas
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
Landed in 559afb1
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
5c3c9ed
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
b7a2342
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
c8625a4
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.review wantedPRs that need review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@maxhfisher@nodejs-github-bot@legendecas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
src: add SetAbortHandler - #64684
Closed
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Closed
src: add SetAbortHandler#64684
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Conversation
@maxhfisher
@maxhfishermaxhfisher
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
This adds SetAbortHandler, which allows embedders to specify custom behavior in situations where ABORT() is called. The current behavior of ABORT() is to stream both the native and JS backtraces to stderr and exit with platform specific behavior. Some embedders may want to change this behavior, such as changing where the backtrace is provided. Embedders can also use the handler to exit with their own behavior, but node will still guarantee an exit if the provided abort handler returns.
A DefaultAbortHandler is used to ensure existing behavior does not change unless an abort handler is explicitly provided. The only difference with this design is an additional stack frame in the backtrace for the abort handler, but this behavior was never guaranteed.
A new ABORT_WITH_DETAILS macro is also added for cases where a location and message can be passed describing the abort. This new macro replaces existing calls to ABORT in various error handlers in node_errors.cc where a message is already available. This message is then propagated to the abort handler, but no changes are made to the default abort handler. That behavior does not change here.
@maxhfisher
src: add SetAbortHandler
c5548d3
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
@nodejs-github-bot
nodejs-github-bot
commented
Jul 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jul 22, 2026
legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/abort/test-addon-abort-handler.js
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node_errors.cc
Outdated

Comment threadsrc/node_errors.cc
Outdated

legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node.h
Outdated

@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (efc0a14) to head (6b87c15).
⚠️ Report is 231 commits behind head on main.
Files with missing linesPatch %Lines
src/node_errors.cc38.46%8 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64684 +/- ##
==========================================
+ Coverage 90.11% 90.28% +0.17% 
==========================================
Files 741 759 +18 Lines 242196 247639 +5443 Branches 45606 46691 +1085 ==========================================
+ Hits 218246 223581 +5335 - Misses 15438 15520 +82 - Partials 8512 8538 +26 
Files with missing linesCoverage Δ
src/node.h92.30% <ø> (ø)
src/util.h90.98% <ø> (ø)
src/node_errors.cc62.58% <38.46%> (-0.18%)⬇️
... and 196 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@maxhfisher
fix: respond to PR comments
309902e
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
legendecas
legendecas
reviewed
Jul 24, 2026
View reviewed changes
Comment threadsrc/util.h
Outdated

@maxhfisher@legendecas
fix: Update default abort message
71e66f8
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecaslegendecas
added
the 
review wanted
PRs that need review.
label
Jul 29, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@maxhfisher
maxhfisher
marked this pull request as draft
August 5, 2026 15:28
@maxhfisher
maxhfisher
marked this pull request as ready for review
August 5, 2026 19:44
legendecas
legendecas
reviewed
Aug 6, 2026
View reviewed changes
Comment threadsrc/util.h
@legendecaslegendecas
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75684/
@legendecaslegendecas
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Aug 11, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 11, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64684
✔ Done loading data for nodejs/node/pull/64684
----------------------------------- PR info ------------------------------------
Title src: add SetAbortHandler (#64684)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch maxhfisher:aborthandler -> nodejs:main
Labels c++, author ready, needs-ci, review wanted, commit-queue, commit-queue-squash
Commits 8
- src: add SetAbortHandler
- fix: fix lint
- fix: respond to PR comments
- fix: Update default abort message
- fix: Split handler arguments into location and message
- Merge branch 'nodejs:main' into aborthandler
- fix: Be more clear about null arguments in abort handler
- fix: Prose
Committers 2
- Max H Fisher <mfisher187@bloomberg.net>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Jul 2026 20:52:39 GMT
✔ Approvals: 1
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/64684#pullrequestreview-4883277125
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T07:55:41Z: https://ci.nodejs.org/job/node-test-pull-request/75684/
- Querying data for job/node-test-pull-request/75684/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 64684
From https://github.com/nodejs/node
* branch refs/pull/64684/merge -> FETCH_HEAD
✔ Fetched commits as 2749388e44ac..455cbed91694
--------------------------------------------------------------------------------
Auto-merging src/util.h
[main 8c9e8f5a6d] src: add SetAbortHandler
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 16:07:43 2026 -0400
8 files changed, 148 insertions(+), 3 deletions(-)
create mode 100644 test/abort/test-addon-abort-handler.js
create mode 100644 test/addons/abort-handler/binding.cc
create mode 100644 test/addons/abort-handler/binding.gyp
create mode 100644 test/addons/abort-handler/test.js
[main f64686a503] fix: fix lint
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 17:48:50 2026 -0400
1 file changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/util.h
[main ca1cadebfb] fix: respond to PR comments
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Thu Jul 23 17:16:39 2026 -0400
7 files changed, 55 insertions(+), 45 deletions(-)
delete mode 100644 test/abort/test-addon-abort-handler.js
Auto-merging src/util.h
[main deac2a26a1] fix: Update default abort message
Author: Max Fisher <66274614+maxhfisher@users.noreply.github.com>
Date: Fri Jul 24 16:58:44 2026 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/util.h
error: commit f579940a11b9a8d0afb94a9b6d7353bc2b348ebe is a merge but no -m option was given.
fatal: cherry-pick failed
[main c0979cfc85] fix: Split handler arguments into location and message
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Aug 5 15:26:31 2026 -0400
5 files changed, 29 insertions(+), 22 deletions(-)
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31535700850
legendecas pushed a commit
that referenced
this pull request
Aug 11, 2026
@maxhfisher@legendecas
src: add SetAbortHandler
559afb1
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas
legendecas
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
Landed in 559afb1
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
5c3c9ed
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
b7a2342
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
c8625a4
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.review wantedPRs that need review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@maxhfisher@nodejs-github-bot@legendecas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
src: add SetAbortHandler - #64684
Closed
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Closed
src: add SetAbortHandler#64684
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Conversation
@maxhfisher
@maxhfishermaxhfisher
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
This adds SetAbortHandler, which allows embedders to specify custom behavior in situations where ABORT() is called. The current behavior of ABORT() is to stream both the native and JS backtraces to stderr and exit with platform specific behavior. Some embedders may want to change this behavior, such as changing where the backtrace is provided. Embedders can also use the handler to exit with their own behavior, but node will still guarantee an exit if the provided abort handler returns.
A DefaultAbortHandler is used to ensure existing behavior does not change unless an abort handler is explicitly provided. The only difference with this design is an additional stack frame in the backtrace for the abort handler, but this behavior was never guaranteed.
A new ABORT_WITH_DETAILS macro is also added for cases where a location and message can be passed describing the abort. This new macro replaces existing calls to ABORT in various error handlers in node_errors.cc where a message is already available. This message is then propagated to the abort handler, but no changes are made to the default abort handler. That behavior does not change here.
@maxhfisher
src: add SetAbortHandler
c5548d3
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
@nodejs-github-bot
nodejs-github-bot
commented
Jul 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jul 22, 2026
legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/abort/test-addon-abort-handler.js
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node_errors.cc
Outdated

Comment threadsrc/node_errors.cc
Outdated

legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node.h
Outdated

@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (efc0a14) to head (6b87c15).
⚠️ Report is 231 commits behind head on main.
Files with missing linesPatch %Lines
src/node_errors.cc38.46%8 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64684 +/- ##
==========================================
+ Coverage 90.11% 90.28% +0.17% 
==========================================
Files 741 759 +18 Lines 242196 247639 +5443 Branches 45606 46691 +1085 ==========================================
+ Hits 218246 223581 +5335 - Misses 15438 15520 +82 - Partials 8512 8538 +26 
Files with missing linesCoverage Δ
src/node.h92.30% <ø> (ø)
src/util.h90.98% <ø> (ø)
src/node_errors.cc62.58% <38.46%> (-0.18%)⬇️
... and 196 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@maxhfisher
fix: respond to PR comments
309902e
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
legendecas
legendecas
reviewed
Jul 24, 2026
View reviewed changes
Comment threadsrc/util.h
Outdated

@maxhfisher@legendecas
fix: Update default abort message
71e66f8
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecaslegendecas
added
the 
review wanted
PRs that need review.
label
Jul 29, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@maxhfisher
maxhfisher
marked this pull request as draft
August 5, 2026 15:28
@maxhfisher
maxhfisher
marked this pull request as ready for review
August 5, 2026 19:44
legendecas
legendecas
reviewed
Aug 6, 2026
View reviewed changes
Comment threadsrc/util.h
@legendecaslegendecas
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75684/
@legendecaslegendecas
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Aug 11, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 11, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64684
✔ Done loading data for nodejs/node/pull/64684
----------------------------------- PR info ------------------------------------
Title src: add SetAbortHandler (#64684)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch maxhfisher:aborthandler -> nodejs:main
Labels c++, author ready, needs-ci, review wanted, commit-queue, commit-queue-squash
Commits 8
- src: add SetAbortHandler
- fix: fix lint
- fix: respond to PR comments
- fix: Update default abort message
- fix: Split handler arguments into location and message
- Merge branch 'nodejs:main' into aborthandler
- fix: Be more clear about null arguments in abort handler
- fix: Prose
Committers 2
- Max H Fisher <mfisher187@bloomberg.net>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Jul 2026 20:52:39 GMT
✔ Approvals: 1
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/64684#pullrequestreview-4883277125
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T07:55:41Z: https://ci.nodejs.org/job/node-test-pull-request/75684/
- Querying data for job/node-test-pull-request/75684/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 64684
From https://github.com/nodejs/node
* branch refs/pull/64684/merge -> FETCH_HEAD
✔ Fetched commits as 2749388e44ac..455cbed91694
--------------------------------------------------------------------------------
Auto-merging src/util.h
[main 8c9e8f5a6d] src: add SetAbortHandler
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 16:07:43 2026 -0400
8 files changed, 148 insertions(+), 3 deletions(-)
create mode 100644 test/abort/test-addon-abort-handler.js
create mode 100644 test/addons/abort-handler/binding.cc
create mode 100644 test/addons/abort-handler/binding.gyp
create mode 100644 test/addons/abort-handler/test.js
[main f64686a503] fix: fix lint
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 17:48:50 2026 -0400
1 file changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/util.h
[main ca1cadebfb] fix: respond to PR comments
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Thu Jul 23 17:16:39 2026 -0400
7 files changed, 55 insertions(+), 45 deletions(-)
delete mode 100644 test/abort/test-addon-abort-handler.js
Auto-merging src/util.h
[main deac2a26a1] fix: Update default abort message
Author: Max Fisher <66274614+maxhfisher@users.noreply.github.com>
Date: Fri Jul 24 16:58:44 2026 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/util.h
error: commit f579940a11b9a8d0afb94a9b6d7353bc2b348ebe is a merge but no -m option was given.
fatal: cherry-pick failed
[main c0979cfc85] fix: Split handler arguments into location and message
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Aug 5 15:26:31 2026 -0400
5 files changed, 29 insertions(+), 22 deletions(-)
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31535700850
legendecas pushed a commit
that referenced
this pull request
Aug 11, 2026
@maxhfisher@legendecas
src: add SetAbortHandler
559afb1
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas
legendecas
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
Landed in 559afb1
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
5c3c9ed
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
b7a2342
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
c8625a4
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.review wantedPRs that need review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@maxhfisher@nodejs-github-bot@legendecas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
src: add SetAbortHandler - #64684
Closed
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Closed
src: add SetAbortHandler#64684
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Conversation
@maxhfisher
@maxhfishermaxhfisher
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
This adds SetAbortHandler, which allows embedders to specify custom behavior in situations where ABORT() is called. The current behavior of ABORT() is to stream both the native and JS backtraces to stderr and exit with platform specific behavior. Some embedders may want to change this behavior, such as changing where the backtrace is provided. Embedders can also use the handler to exit with their own behavior, but node will still guarantee an exit if the provided abort handler returns.
A DefaultAbortHandler is used to ensure existing behavior does not change unless an abort handler is explicitly provided. The only difference with this design is an additional stack frame in the backtrace for the abort handler, but this behavior was never guaranteed.
A new ABORT_WITH_DETAILS macro is also added for cases where a location and message can be passed describing the abort. This new macro replaces existing calls to ABORT in various error handlers in node_errors.cc where a message is already available. This message is then propagated to the abort handler, but no changes are made to the default abort handler. That behavior does not change here.
@maxhfisher
src: add SetAbortHandler
c5548d3
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
@nodejs-github-bot
nodejs-github-bot
commented
Jul 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jul 22, 2026
legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/abort/test-addon-abort-handler.js
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node_errors.cc
Outdated

Comment threadsrc/node_errors.cc
Outdated

legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node.h
Outdated

@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (efc0a14) to head (6b87c15).
⚠️ Report is 231 commits behind head on main.
Files with missing linesPatch %Lines
src/node_errors.cc38.46%8 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64684 +/- ##
==========================================
+ Coverage 90.11% 90.28% +0.17% 
==========================================
Files 741 759 +18 Lines 242196 247639 +5443 Branches 45606 46691 +1085 ==========================================
+ Hits 218246 223581 +5335 - Misses 15438 15520 +82 - Partials 8512 8538 +26 
Files with missing linesCoverage Δ
src/node.h92.30% <ø> (ø)
src/util.h90.98% <ø> (ø)
src/node_errors.cc62.58% <38.46%> (-0.18%)⬇️
... and 196 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@maxhfisher
fix: respond to PR comments
309902e
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
legendecas
legendecas
reviewed
Jul 24, 2026
View reviewed changes
Comment threadsrc/util.h
Outdated

@maxhfisher@legendecas
fix: Update default abort message
71e66f8
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecaslegendecas
added
the 
review wanted
PRs that need review.
label
Jul 29, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@maxhfisher
maxhfisher
marked this pull request as draft
August 5, 2026 15:28
@maxhfisher
maxhfisher
marked this pull request as ready for review
August 5, 2026 19:44
legendecas
legendecas
reviewed
Aug 6, 2026
View reviewed changes
Comment threadsrc/util.h
@legendecaslegendecas
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75684/
@legendecaslegendecas
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Aug 11, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 11, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64684
✔ Done loading data for nodejs/node/pull/64684
----------------------------------- PR info ------------------------------------
Title src: add SetAbortHandler (#64684)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch maxhfisher:aborthandler -> nodejs:main
Labels c++, author ready, needs-ci, review wanted, commit-queue, commit-queue-squash
Commits 8
- src: add SetAbortHandler
- fix: fix lint
- fix: respond to PR comments
- fix: Update default abort message
- fix: Split handler arguments into location and message
- Merge branch 'nodejs:main' into aborthandler
- fix: Be more clear about null arguments in abort handler
- fix: Prose
Committers 2
- Max H Fisher <mfisher187@bloomberg.net>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Jul 2026 20:52:39 GMT
✔ Approvals: 1
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/64684#pullrequestreview-4883277125
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T07:55:41Z: https://ci.nodejs.org/job/node-test-pull-request/75684/
- Querying data for job/node-test-pull-request/75684/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 64684
From https://github.com/nodejs/node
* branch refs/pull/64684/merge -> FETCH_HEAD
✔ Fetched commits as 2749388e44ac..455cbed91694
--------------------------------------------------------------------------------
Auto-merging src/util.h
[main 8c9e8f5a6d] src: add SetAbortHandler
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 16:07:43 2026 -0400
8 files changed, 148 insertions(+), 3 deletions(-)
create mode 100644 test/abort/test-addon-abort-handler.js
create mode 100644 test/addons/abort-handler/binding.cc
create mode 100644 test/addons/abort-handler/binding.gyp
create mode 100644 test/addons/abort-handler/test.js
[main f64686a503] fix: fix lint
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 17:48:50 2026 -0400
1 file changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/util.h
[main ca1cadebfb] fix: respond to PR comments
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Thu Jul 23 17:16:39 2026 -0400
7 files changed, 55 insertions(+), 45 deletions(-)
delete mode 100644 test/abort/test-addon-abort-handler.js
Auto-merging src/util.h
[main deac2a26a1] fix: Update default abort message
Author: Max Fisher <66274614+maxhfisher@users.noreply.github.com>
Date: Fri Jul 24 16:58:44 2026 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/util.h
error: commit f579940a11b9a8d0afb94a9b6d7353bc2b348ebe is a merge but no -m option was given.
fatal: cherry-pick failed
[main c0979cfc85] fix: Split handler arguments into location and message
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Aug 5 15:26:31 2026 -0400
5 files changed, 29 insertions(+), 22 deletions(-)
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31535700850
legendecas pushed a commit
that referenced
this pull request
Aug 11, 2026
@maxhfisher@legendecas
src: add SetAbortHandler
559afb1
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas
legendecas
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
Landed in 559afb1
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
5c3c9ed
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
b7a2342
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
c8625a4
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.review wantedPRs that need review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@maxhfisher@nodejs-github-bot@legendecas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
src: add SetAbortHandler - #64684
Closed
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Closed
src: add SetAbortHandler#64684
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Conversation
@maxhfisher
@maxhfishermaxhfisher
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
This adds SetAbortHandler, which allows embedders to specify custom behavior in situations where ABORT() is called. The current behavior of ABORT() is to stream both the native and JS backtraces to stderr and exit with platform specific behavior. Some embedders may want to change this behavior, such as changing where the backtrace is provided. Embedders can also use the handler to exit with their own behavior, but node will still guarantee an exit if the provided abort handler returns.
A DefaultAbortHandler is used to ensure existing behavior does not change unless an abort handler is explicitly provided. The only difference with this design is an additional stack frame in the backtrace for the abort handler, but this behavior was never guaranteed.
A new ABORT_WITH_DETAILS macro is also added for cases where a location and message can be passed describing the abort. This new macro replaces existing calls to ABORT in various error handlers in node_errors.cc where a message is already available. This message is then propagated to the abort handler, but no changes are made to the default abort handler. That behavior does not change here.
@maxhfisher
src: add SetAbortHandler
c5548d3
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
@nodejs-github-bot
nodejs-github-bot
commented
Jul 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jul 22, 2026
legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/abort/test-addon-abort-handler.js
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node_errors.cc
Outdated

Comment threadsrc/node_errors.cc
Outdated

legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node.h
Outdated

@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (efc0a14) to head (6b87c15).
⚠️ Report is 231 commits behind head on main.
Files with missing linesPatch %Lines
src/node_errors.cc38.46%8 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64684 +/- ##
==========================================
+ Coverage 90.11% 90.28% +0.17% 
==========================================
Files 741 759 +18 Lines 242196 247639 +5443 Branches 45606 46691 +1085 ==========================================
+ Hits 218246 223581 +5335 - Misses 15438 15520 +82 - Partials 8512 8538 +26 
Files with missing linesCoverage Δ
src/node.h92.30% <ø> (ø)
src/util.h90.98% <ø> (ø)
src/node_errors.cc62.58% <38.46%> (-0.18%)⬇️
... and 196 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@maxhfisher
fix: respond to PR comments
309902e
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
legendecas
legendecas
reviewed
Jul 24, 2026
View reviewed changes
Comment threadsrc/util.h
Outdated

@maxhfisher@legendecas
fix: Update default abort message
71e66f8
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecaslegendecas
added
the 
review wanted
PRs that need review.
label
Jul 29, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@maxhfisher
maxhfisher
marked this pull request as draft
August 5, 2026 15:28
@maxhfisher
maxhfisher
marked this pull request as ready for review
August 5, 2026 19:44
legendecas
legendecas
reviewed
Aug 6, 2026
View reviewed changes
Comment threadsrc/util.h
@legendecaslegendecas
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75684/
@legendecaslegendecas
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Aug 11, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 11, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64684
✔ Done loading data for nodejs/node/pull/64684
----------------------------------- PR info ------------------------------------
Title src: add SetAbortHandler (#64684)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch maxhfisher:aborthandler -> nodejs:main
Labels c++, author ready, needs-ci, review wanted, commit-queue, commit-queue-squash
Commits 8
- src: add SetAbortHandler
- fix: fix lint
- fix: respond to PR comments
- fix: Update default abort message
- fix: Split handler arguments into location and message
- Merge branch 'nodejs:main' into aborthandler
- fix: Be more clear about null arguments in abort handler
- fix: Prose
Committers 2
- Max H Fisher <mfisher187@bloomberg.net>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Jul 2026 20:52:39 GMT
✔ Approvals: 1
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/64684#pullrequestreview-4883277125
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T07:55:41Z: https://ci.nodejs.org/job/node-test-pull-request/75684/
- Querying data for job/node-test-pull-request/75684/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 64684
From https://github.com/nodejs/node
* branch refs/pull/64684/merge -> FETCH_HEAD
✔ Fetched commits as 2749388e44ac..455cbed91694
--------------------------------------------------------------------------------
Auto-merging src/util.h
[main 8c9e8f5a6d] src: add SetAbortHandler
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 16:07:43 2026 -0400
8 files changed, 148 insertions(+), 3 deletions(-)
create mode 100644 test/abort/test-addon-abort-handler.js
create mode 100644 test/addons/abort-handler/binding.cc
create mode 100644 test/addons/abort-handler/binding.gyp
create mode 100644 test/addons/abort-handler/test.js
[main f64686a503] fix: fix lint
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 17:48:50 2026 -0400
1 file changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/util.h
[main ca1cadebfb] fix: respond to PR comments
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Thu Jul 23 17:16:39 2026 -0400
7 files changed, 55 insertions(+), 45 deletions(-)
delete mode 100644 test/abort/test-addon-abort-handler.js
Auto-merging src/util.h
[main deac2a26a1] fix: Update default abort message
Author: Max Fisher <66274614+maxhfisher@users.noreply.github.com>
Date: Fri Jul 24 16:58:44 2026 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/util.h
error: commit f579940a11b9a8d0afb94a9b6d7353bc2b348ebe is a merge but no -m option was given.
fatal: cherry-pick failed
[main c0979cfc85] fix: Split handler arguments into location and message
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Aug 5 15:26:31 2026 -0400
5 files changed, 29 insertions(+), 22 deletions(-)
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31535700850
legendecas pushed a commit
that referenced
this pull request
Aug 11, 2026
@maxhfisher@legendecas
src: add SetAbortHandler
559afb1
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas
legendecas
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
Landed in 559afb1
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
5c3c9ed
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
b7a2342
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
c8625a4
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.review wantedPRs that need review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@maxhfisher@nodejs-github-bot@legendecas

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
src: add SetAbortHandler - #64684
Closed
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Closed
src: add SetAbortHandler#64684
maxhfisher wants to merge 8 commits into
nodejs:mainfrom 
maxhfisher:aborthandler
Conversation
@maxhfisher
@maxhfishermaxhfisher
commented
Jul 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
This adds SetAbortHandler, which allows embedders to specify custom behavior in situations where ABORT() is called. The current behavior of ABORT() is to stream both the native and JS backtraces to stderr and exit with platform specific behavior. Some embedders may want to change this behavior, such as changing where the backtrace is provided. Embedders can also use the handler to exit with their own behavior, but node will still guarantee an exit if the provided abort handler returns.
A DefaultAbortHandler is used to ensure existing behavior does not change unless an abort handler is explicitly provided. The only difference with this design is an additional stack frame in the backtrace for the abort handler, but this behavior was never guaranteed.
A new ABORT_WITH_DETAILS macro is also added for cases where a location and message can be passed describing the abort. This new macro replaces existing calls to ABORT in various error handlers in node_errors.cc where a message is already available. This message is then propagated to the abort handler, but no changes are made to the default abort handler. That behavior does not change here.
@maxhfisher
src: add SetAbortHandler
c5548d3
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
@nodejs-github-bot
nodejs-github-bot
commented
Jul 22, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/gyp
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jul 22, 2026
legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/abort/test-addon-abort-handler.js
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node.h
Outdated

Comment threadsrc/node_errors.cc
Outdated

Comment threadsrc/node_errors.cc
Outdated

legendecas
legendecas
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node.h
Outdated

@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.28%. Comparing base (efc0a14) to head (6b87c15).
⚠️ Report is 231 commits behind head on main.
Files with missing linesPatch %Lines
src/node_errors.cc38.46%8 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64684 +/- ##
==========================================
+ Coverage 90.11% 90.28% +0.17% 
==========================================
Files 741 759 +18 Lines 242196 247639 +5443 Branches 45606 46691 +1085 ==========================================
+ Hits 218246 223581 +5335 - Misses 15438 15520 +82 - Partials 8512 8538 +26 
Files with missing linesCoverage Δ
src/node.h92.30% <ø> (ø)
src/util.h90.98% <ø> (ø)
src/node_errors.cc62.58% <38.46%> (-0.18%)⬇️
... and 196 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@maxhfisher
fix: respond to PR comments
309902e
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
legendecas
legendecas
reviewed
Jul 24, 2026
View reviewed changes
Comment threadsrc/util.h
Outdated

@maxhfisher@legendecas
fix: Update default abort message
71e66f8
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@legendecaslegendecas
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecaslegendecas
added
the 
review wanted
PRs that need review.
label
Jul 29, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@maxhfisher
maxhfisher
marked this pull request as draft
August 5, 2026 15:28
@maxhfisher
maxhfisher
marked this pull request as ready for review
August 5, 2026 19:44
legendecas
legendecas
reviewed
Aug 6, 2026
View reviewed changes
Comment threadsrc/util.h
@legendecaslegendecas
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 7, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75684/
@legendecaslegendecas
added

commit-queue
PRs queued for automated landing through the Commit Queue.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
labels
Aug 11, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 11, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64684
✔ Done loading data for nodejs/node/pull/64684
----------------------------------- PR info ------------------------------------
Title src: add SetAbortHandler (#64684)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch maxhfisher:aborthandler -> nodejs:main
Labels c++, author ready, needs-ci, review wanted, commit-queue, commit-queue-squash
Commits 8
- src: add SetAbortHandler
- fix: fix lint
- fix: respond to PR comments
- fix: Update default abort message
- fix: Split handler arguments into location and message
- Merge branch 'nodejs:main' into aborthandler
- fix: Be more clear about null arguments in abort handler
- fix: Prose
Committers 2
- Max H Fisher <mfisher187@bloomberg.net>
- GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Jul 2026 20:52:39 GMT
✔ Approvals: 1
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/64684#pullrequestreview-4883277125
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T07:55:41Z: https://ci.nodejs.org/job/node-test-pull-request/75684/
- Querying data for job/node-test-pull-request/75684/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 64684
From https://github.com/nodejs/node
* branch refs/pull/64684/merge -> FETCH_HEAD
✔ Fetched commits as 2749388e44ac..455cbed91694
--------------------------------------------------------------------------------
Auto-merging src/util.h
[main 8c9e8f5a6d] src: add SetAbortHandler
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 16:07:43 2026 -0400
8 files changed, 148 insertions(+), 3 deletions(-)
create mode 100644 test/abort/test-addon-abort-handler.js
create mode 100644 test/addons/abort-handler/binding.cc
create mode 100644 test/addons/abort-handler/binding.gyp
create mode 100644 test/addons/abort-handler/test.js
[main f64686a503] fix: fix lint
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Jul 22 17:48:50 2026 -0400
1 file changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/util.h
[main ca1cadebfb] fix: respond to PR comments
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Thu Jul 23 17:16:39 2026 -0400
7 files changed, 55 insertions(+), 45 deletions(-)
delete mode 100644 test/abort/test-addon-abort-handler.js
Auto-merging src/util.h
[main deac2a26a1] fix: Update default abort message
Author: Max Fisher <66274614+maxhfisher@users.noreply.github.com>
Date: Fri Jul 24 16:58:44 2026 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/util.h
error: commit f579940a11b9a8d0afb94a9b6d7353bc2b348ebe is a merge but no -m option was given.
fatal: cherry-pick failed
[main c0979cfc85] fix: Split handler arguments into location and message
Author: Max H Fisher <mfisher187@bloomberg.net>
Date: Wed Aug 5 15:26:31 2026 -0400
5 files changed, 29 insertions(+), 22 deletions(-)
✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31535700850
legendecas pushed a commit
that referenced
this pull request
Aug 11, 2026
@maxhfisher@legendecas
src: add SetAbortHandler
559afb1
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas
legendecas
commented
Aug 11, 2026

Copy link


Copy Markdown

Member
Landed in 559afb1
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
5c3c9ed
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
b7a2342
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@maxhfisher@aduh95
src: add SetAbortHandler
c8625a4
Signed-off-by: Max H Fisher <mfisher187@bloomberg.net>
PR-URL: #64684
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@legendecaslegendecaslegendecas approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.commit-queue-squashPRs the Commit Queue should land as one squashed commit.needs-ciPRs that need a full CI run.review wantedPRs that need review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@maxhfisher@nodejs-github-bot@legendecas