Uh oh!
There was an error while loading. Please reload this page.
test: increase timeout in probe-failure-hang-during-evaluate - #64719
Merged
Conversation
On slower CI machines, the probed process may take longer time to bootstrap and establish connection to. Increase the timeout so it's more likely to finish testing before timing out. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
avivkeller
approved these changes
Jul 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #64719 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 743 743 Lines 242306 242306 Branches 45618 45627 +9 =======================================
+ Hits 218366 218377 +11 + Misses 15445 15435 -10 + Partials 8495 8494 -1 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Jul 24, 2026
nodejs-github-bot
commented
Jul 24, 2026
Collaborator
legendecas
approved these changes
Jul 24, 2026
nodejs-github-bot
commented
Aug 4, 2026
Collaborator
nodejs-github-bot
commented
Aug 5, 2026
Collaborator
nodejs-github-bot
commented
Aug 6, 2026
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Aug 6, 2026
Collaborator
Landed in fd06ed6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On slower CI machines, the probed process may take longer time to bootstrap and establish connection to. Increase the timeout so it's more likely to finish testing before timing out.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-07-24.md
Also see the logs of https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos23-x64/66791/consoleFull where other probe tests take ~1s to finish end to end, and the logs of flaked probe-failure-hang-during-evaluate showed that it timing out before finishing testing.