Uh oh!
There was an error while loading. Please reload this page.
async_hooks: use validateBoolean for trackPromises - #64731
Merged
nodejs-github-bot merged 1 commit intoJul 29, 2026
Conversation
The `trackPromises` check duplicated `validateBoolean()` exactly: same error code, same expected type string, same argument order. Replace it with the validator, matching how this file already validates `type` and `fn` via `validateString()`/`validateFunction()`. `ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the thrown error is unchanged from a caller's perspective. Signed-off-by: Soul Lee <alus20x@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #64731 +/- ##
==========================================
- Coverage 90.14% 90.14% -0.01%
==========================================
Files 743 743 Lines 242408 242408 Branches 45656 45650 -6 ==========================================
- Hits 218520 218507 -13
Misses 15387 15387 - Partials 8501 8514 +13
🚀 New features to boost your workflow:
|
soulee-dev
commented
Jul 25, 2026
ContributorAuthor
@daeyeon Thanks for approving the CI run! The only failing check is The same
|
daeyeon
approved these changes
Jul 26, 2026
avivkeller
approved these changes
Jul 26, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jul 28, 2026
Collaborator
soulee-dev
commented
Jul 28, 2026
ContributorAuthor
The failures look unrelated to this change. Could you re-trigger CI? Thanks! |
nodejs-github-bot
commented
Jul 29, 2026
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 29, 2026
Collaborator
Landed in 41525ab |
aduh95 pushed a commit
that referenced
this pull request
Aug 3, 2026
The `trackPromises` check duplicated `validateBoolean()` exactly: same error code, same expected type string, same argument order. Replace it with the validator, matching how this file already validates `type` and `fn` via `validateString()`/`validateFunction()`. `ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the thrown error is unchanged from a caller's perspective. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #64731 Refs: #61415 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 4, 2026
The `trackPromises` check duplicated `validateBoolean()` exactly: same error code, same expected type string, same argument order. Replace it with the validator, matching how this file already validates `type` and `fn` via `validateString()`/`validateFunction()`. `ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the thrown error is unchanged from a caller's perspective. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #64731 Refs: #61415 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 5, 2026
The `trackPromises` check duplicated `validateBoolean()` exactly: same error code, same expected type string, same argument order. Replace it with the validator, matching how this file already validates `type` and `fn` via `validateString()`/`validateFunction()`. `ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the thrown error is unchanged from a caller's perspective. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #64731 Refs: #61415 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 6, 2026
The `trackPromises` check duplicated `validateBoolean()` exactly: same error code, same expected type string, same argument order. Replace it with the validator, matching how this file already validates `type` and `fn` via `validateString()`/`validateFunction()`. `ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the thrown error is unchanged from a caller's perspective. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #64731 Refs: #61415 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
trackPromisesvalidation added in #61415 hand-rolls a check thatvalidateBoolean()already performs — same error code, same expected type string, same argument order. This replaces it with the validator.lib/async_hooks.jsalready importsvalidateString()andvalidateFunction()and uses them fortypeandfn, so this also makes the file internally consistent. With the last manual check gone, theERR_INVALID_ARG_TYPEimport is dropped as well.No behavior change:
validateBoolean()is wrapped inhideStackFrames(), so the thrown error is identical from a caller's perspective, including the top stack frame. The existing coverage intest/async-hooks/test-track-promises-validation.jsalready asserts this, so no new tests are added.Refs: #61415