Uh oh!
There was an error while loading. Please reload this page.
buffer: use Clamp conversion in Blob slice - #64739
Merged
Merged
Conversation
nodejs-github-bot
commented
Jul 25, 2026
Collaborator
Review requested:
|
Align Blob.prototype.slice() with the File API Web IDL definition by using [Clamp] conversion for the start and end arguments. This fixes the Blob-slice.any.js WPT expected failures for fractional start and end values. Refs: https://www.w3.org/TR/FileAPI/#dfn-Blob Signed-off-by: HoonDongKang <d159123@naver.com>
HoonDongKangforce-pushed
the
fix-blob-slice-clamp
branch
from
July 25, 2026 15:07
e284bd7 to
6c536b1CompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #64739 +/- ##
==========================================
+ Coverage 90.14% 90.15% +0.01%
==========================================
Files 743 743 Lines 242408 242507 +99 Branches 45656 45776 +120 ==========================================
+ Hits 218520 218643 +123 + Misses 15387 15379 -8 + Partials 8501 8485 -16
🚀 New features to boost your workflow:
|
panva
approved these changes
Jul 25, 2026
KhafraDev
approved these changes
Jul 25, 2026
nodejs-github-bot
commented
Jul 25, 2026
Collaborator
avivkeller
approved these changes
Jul 25, 2026
ContributorAuthor
This looks like a Jenkins infra failure: (I accidentally closed the PR, so I reopened it. 🥲) |
nodejs-github-bot
commented
Jul 26, 2026
Collaborator
lpinca
approved these changes
Jul 26, 2026
nodejs-github-bot
commented
Jul 26, 2026
Collaborator
jazelly
approved these changes
Jul 26, 2026
nodejs-github-bot
commented
Jul 26, 2026
Collaborator
nodejs-github-bot
commented
Jul 27, 2026
Collaborator
nodejs-github-bot
commented
Jul 28, 2026
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 29, 2026
Collaborator
Landed in a0dd71e |
aduh95 pushed a commit
that referenced
this pull request
Aug 3, 2026
Align Blob.prototype.slice() with the File API Web IDL definition by using [Clamp] conversion for the start and end arguments. This fixes the Blob-slice.any.js WPT expected failures for fractional start and end values. Refs: https://www.w3.org/TR/FileAPI/#dfn-Blob Signed-off-by: HoonDongKang <d159123@naver.com> PR-URL: #64739 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 4, 2026
Align Blob.prototype.slice() with the File API Web IDL definition by using [Clamp] conversion for the start and end arguments. This fixes the Blob-slice.any.js WPT expected failures for fractional start and end values. Refs: https://www.w3.org/TR/FileAPI/#dfn-Blob Signed-off-by: HoonDongKang <d159123@naver.com> PR-URL: #64739 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 5, 2026
Align Blob.prototype.slice() with the File API Web IDL definition by using [Clamp] conversion for the start and end arguments. This fixes the Blob-slice.any.js WPT expected failures for fractional start and end values. Refs: https://www.w3.org/TR/FileAPI/#dfn-Blob Signed-off-by: HoonDongKang <d159123@naver.com> PR-URL: #64739 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns
Blob.prototype.slice()with the File API Web IDL definition:The
startandendarguments should use Web IDL[Clamp]conversion.This fixes the expected failures in
Blob-slice.any.jsfor fractional start/end values.Refs: https://www.w3.org/TR/FileAPI/#dfn-Blob
Testing