sqlite: prevent database close during callbacks by mcollina · Pull Request #64743 · nodejs/node

mcollina · 2026-07-25T20:21:56Z

Prevent DatabaseSync.close() from finalizing SQLite resources while a JavaScript callback is executing.

SQLite invokes user-defined functions, aggregate functions, authorizers, and changeset callbacks synchronously during database operations. Previously, calling database.close() from one of these callbacks could finalize active statements or the connection while native code was still using them.

This change tracks callback depth and rejects reentrant closes with ERR_INVALID_STATE. It also adds regression coverage for StatementSync.all(), get(), run(), and iterate().

nodejs-github-bot · 2026-07-25T20:22:01Z

Review requested:

@nodejs/sqlite

codecov · 2026-07-25T22:00:33Z

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (a477a99).
⚠️ Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	50.00%	8 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64743 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 746 746 Lines 242760 242784 +24 Branches 45765 45766 +1 =======================================
+ Hits 218875 218902 +27 + Misses 15375 15367 -8 - Partials 8510 8515 +5

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <100.00%> (+1.96%)`	⬆️
src/node_sqlite.cc	`80.43% <50.00%> (-0.25%)`	⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

I checked the guards in the base functions, and the window functions are covered too

and I looked fail test, this fail unrelated this pr

nodejs-github-bot · 2026-07-27T00:59:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75190/

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-04T06:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75449/

nodejs-github-bot · 2026-08-04T11:05:49Z

Landed in 5cef767

Closing a database from inside a callback now reports "database cannot be closed while in a callback" instead of "database cannot be closed inside a user-defined function callback", the wording upstream adopted in nodejs/node#64743. The error code (ERR_INVALID_STATE) is unchanged, so only tests matching the old string are affected. The upstream test that pins this message, test-sqlite-udf-close.js, had been downloaded to test/upstream/ but never adapted into test/node-compat/, so its four cases never ran. Generating it required making sync-node-tests.ts run its sync only when invoked directly -- it already exported adaptTest() for reuse, but importing the module kicked off a full network sync.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64743 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

mcollina · 2026-07-25T20:21:56Z

Prevent DatabaseSync.close() from finalizing SQLite resources while a JavaScript callback is executing.

SQLite invokes user-defined functions, aggregate functions, authorizers, and changeset callbacks synchronously during database operations. Previously, calling database.close() from one of these callbacks could finalize active statements or the connection while native code was still using them.

This change tracks callback depth and rejects reentrant closes with ERR_INVALID_STATE. It also adds regression coverage for StatementSync.all(), get(), run(), and iterate().

nodejs-github-bot · 2026-07-25T20:22:01Z

Review requested:

@nodejs/sqlite

codecov · 2026-07-25T22:00:33Z

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (a477a99).
⚠️ Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	50.00%	8 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64743 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 746 746 Lines 242760 242784 +24 Branches 45765 45766 +1 =======================================
+ Hits 218875 218902 +27 + Misses 15375 15367 -8 - Partials 8510 8515 +5

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <100.00%> (+1.96%)`	⬆️
src/node_sqlite.cc	`80.43% <50.00%> (-0.25%)`	⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

I checked the guards in the base functions, and the window functions are covered too

and I looked fail test, this fail unrelated this pr

nodejs-github-bot · 2026-07-27T00:59:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75190/

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-04T06:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75449/

nodejs-github-bot · 2026-08-04T11:05:49Z

Landed in 5cef767

Closing a database from inside a callback now reports "database cannot be closed while in a callback" instead of "database cannot be closed inside a user-defined function callback", the wording upstream adopted in nodejs/node#64743. The error code (ERR_INVALID_STATE) is unchanged, so only tests matching the old string are affected. The upstream test that pins this message, test-sqlite-udf-close.js, had been downloaded to test/upstream/ but never adapted into test/node-compat/, so its four cases never ran. Generating it required making sync-node-tests.ts run its sync only when invoked directly -- it already exported adaptTest() for reuse, but importing the module kicked off a full network sync.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64743 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

mcollina · 2026-07-25T20:21:56Z

Prevent DatabaseSync.close() from finalizing SQLite resources while a JavaScript callback is executing.

SQLite invokes user-defined functions, aggregate functions, authorizers, and changeset callbacks synchronously during database operations. Previously, calling database.close() from one of these callbacks could finalize active statements or the connection while native code was still using them.

This change tracks callback depth and rejects reentrant closes with ERR_INVALID_STATE. It also adds regression coverage for StatementSync.all(), get(), run(), and iterate().

nodejs-github-bot · 2026-07-25T20:22:01Z

Review requested:

@nodejs/sqlite

codecov · 2026-07-25T22:00:33Z

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (a477a99).
⚠️ Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	50.00%	8 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64743 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 746 746 Lines 242760 242784 +24 Branches 45765 45766 +1 =======================================
+ Hits 218875 218902 +27 + Misses 15375 15367 -8 - Partials 8510 8515 +5

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <100.00%> (+1.96%)`	⬆️
src/node_sqlite.cc	`80.43% <50.00%> (-0.25%)`	⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

I checked the guards in the base functions, and the window functions are covered too

and I looked fail test, this fail unrelated this pr

nodejs-github-bot · 2026-07-27T00:59:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75190/

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-04T06:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75449/

nodejs-github-bot · 2026-08-04T11:05:49Z

Landed in 5cef767

Closing a database from inside a callback now reports "database cannot be closed while in a callback" instead of "database cannot be closed inside a user-defined function callback", the wording upstream adopted in nodejs/node#64743. The error code (ERR_INVALID_STATE) is unchanged, so only tests matching the old string are affected. The upstream test that pins this message, test-sqlite-udf-close.js, had been downloaded to test/upstream/ but never adapted into test/node-compat/, so its four cases never ran. Generating it required making sync-node-tests.ts run its sync only when invoked directly -- it already exported adaptTest() for reuse, but importing the module kicked off a full network sync.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64743 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

mcollina · 2026-07-25T20:21:56Z

Prevent DatabaseSync.close() from finalizing SQLite resources while a JavaScript callback is executing.

SQLite invokes user-defined functions, aggregate functions, authorizers, and changeset callbacks synchronously during database operations. Previously, calling database.close() from one of these callbacks could finalize active statements or the connection while native code was still using them.

This change tracks callback depth and rejects reentrant closes with ERR_INVALID_STATE. It also adds regression coverage for StatementSync.all(), get(), run(), and iterate().

nodejs-github-bot · 2026-07-25T20:22:01Z

Review requested:

@nodejs/sqlite

codecov · 2026-07-25T22:00:33Z

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (a477a99).
⚠️ Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	50.00%	8 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64743 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 746 746 Lines 242760 242784 +24 Branches 45765 45766 +1 =======================================
+ Hits 218875 218902 +27 + Misses 15375 15367 -8 - Partials 8510 8515 +5

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <100.00%> (+1.96%)`	⬆️
src/node_sqlite.cc	`80.43% <50.00%> (-0.25%)`	⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

I checked the guards in the base functions, and the window functions are covered too

and I looked fail test, this fail unrelated this pr

nodejs-github-bot · 2026-07-27T00:59:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75190/

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-04T06:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75449/

nodejs-github-bot · 2026-08-04T11:05:49Z

Landed in 5cef767

Closing a database from inside a callback now reports "database cannot be closed while in a callback" instead of "database cannot be closed inside a user-defined function callback", the wording upstream adopted in nodejs/node#64743. The error code (ERR_INVALID_STATE) is unchanged, so only tests matching the old string are affected. The upstream test that pins this message, test-sqlite-udf-close.js, had been downloaded to test/upstream/ but never adapted into test/node-compat/, so its four cases never ran. Generating it required making sync-node-tests.ts run its sync only when invoked directly -- it already exported adaptTest() for reuse, but importing the module kicked off a full network sync.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64743 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

mcollina · 2026-07-25T20:21:56Z

Prevent DatabaseSync.close() from finalizing SQLite resources while a JavaScript callback is executing.

SQLite invokes user-defined functions, aggregate functions, authorizers, and changeset callbacks synchronously during database operations. Previously, calling database.close() from one of these callbacks could finalize active statements or the connection while native code was still using them.

This change tracks callback depth and rejects reentrant closes with ERR_INVALID_STATE. It also adds regression coverage for StatementSync.all(), get(), run(), and iterate().

nodejs-github-bot · 2026-07-25T20:22:01Z

Review requested:

@nodejs/sqlite

codecov · 2026-07-25T22:00:33Z

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (a477a99).
⚠️ Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	50.00%	8 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64743 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 746 746 Lines 242760 242784 +24 Branches 45765 45766 +1 =======================================
+ Hits 218875 218902 +27 + Misses 15375 15367 -8 - Partials 8510 8515 +5

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <100.00%> (+1.96%)`	⬆️
src/node_sqlite.cc	`80.43% <50.00%> (-0.25%)`	⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

I checked the guards in the base functions, and the window functions are covered too

and I looked fail test, this fail unrelated this pr

nodejs-github-bot · 2026-07-27T00:59:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75190/

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-04T06:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75449/

nodejs-github-bot · 2026-08-04T11:05:49Z

Landed in 5cef767

Closing a database from inside a callback now reports "database cannot be closed while in a callback" instead of "database cannot be closed inside a user-defined function callback", the wording upstream adopted in nodejs/node#64743. The error code (ERR_INVALID_STATE) is unchanged, so only tests matching the old string are affected. The upstream test that pins this message, test-sqlite-udf-close.js, had been downloaded to test/upstream/ but never adapted into test/node-compat/, so its four cases never ran. Generating it required making sync-node-tests.ts run its sync only when invoked directly -- it already exported adaptTest() for reuse, but importing the module kicked off a full network sync.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64743 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

mcollina · 2026-07-25T20:21:56Z

Prevent DatabaseSync.close() from finalizing SQLite resources while a JavaScript callback is executing.

SQLite invokes user-defined functions, aggregate functions, authorizers, and changeset callbacks synchronously during database operations. Previously, calling database.close() from one of these callbacks could finalize active statements or the connection while native code was still using them.

This change tracks callback depth and rejects reentrant closes with ERR_INVALID_STATE. It also adds regression coverage for StatementSync.all(), get(), run(), and iterate().

nodejs-github-bot · 2026-07-25T20:22:01Z

Review requested:

@nodejs/sqlite

codecov · 2026-07-25T22:00:33Z

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (a477a99).
⚠️ Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	50.00%	8 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64743 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 746 746 Lines 242760 242784 +24 Branches 45765 45766 +1 =======================================
+ Hits 218875 218902 +27 + Misses 15375 15367 -8 - Partials 8510 8515 +5

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <100.00%> (+1.96%)`	⬆️
src/node_sqlite.cc	`80.43% <50.00%> (-0.25%)`	⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

I checked the guards in the base functions, and the window functions are covered too

and I looked fail test, this fail unrelated this pr

nodejs-github-bot · 2026-07-27T00:59:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75190/

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-04T06:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75449/

nodejs-github-bot · 2026-08-04T11:05:49Z

Landed in 5cef767

Closing a database from inside a callback now reports "database cannot be closed while in a callback" instead of "database cannot be closed inside a user-defined function callback", the wording upstream adopted in nodejs/node#64743. The error code (ERR_INVALID_STATE) is unchanged, so only tests matching the old string are affected. The upstream test that pins this message, test-sqlite-udf-close.js, had been downloaded to test/upstream/ but never adapted into test/node-compat/, so its four cases never ran. Generating it required making sync-node-tests.ts run its sync only when invoked directly -- it already exported adaptTest() for reuse, but importing the module kicked off a full network sync.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64743 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

mcollina · 2026-07-25T20:21:56Z

Prevent DatabaseSync.close() from finalizing SQLite resources while a JavaScript callback is executing.

SQLite invokes user-defined functions, aggregate functions, authorizers, and changeset callbacks synchronously during database operations. Previously, calling database.close() from one of these callbacks could finalize active statements or the connection while native code was still using them.

This change tracks callback depth and rejects reentrant closes with ERR_INVALID_STATE. It also adds regression coverage for StatementSync.all(), get(), run(), and iterate().

nodejs-github-bot · 2026-07-25T20:22:01Z

Review requested:

@nodejs/sqlite

codecov · 2026-07-25T22:00:33Z

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (a477a99).
⚠️ Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	50.00%	8 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64743 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 746 746 Lines 242760 242784 +24 Branches 45765 45766 +1 =======================================
+ Hits 218875 218902 +27 + Misses 15375 15367 -8 - Partials 8510 8515 +5

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <100.00%> (+1.96%)`	⬆️
src/node_sqlite.cc	`80.43% <50.00%> (-0.25%)`	⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

I checked the guards in the base functions, and the window functions are covered too

and I looked fail test, this fail unrelated this pr

nodejs-github-bot · 2026-07-27T00:59:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75190/

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-04T06:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75449/

nodejs-github-bot · 2026-08-04T11:05:49Z

Landed in 5cef767

Closing a database from inside a callback now reports "database cannot be closed while in a callback" instead of "database cannot be closed inside a user-defined function callback", the wording upstream adopted in nodejs/node#64743. The error code (ERR_INVALID_STATE) is unchanged, so only tests matching the old string are affected. The upstream test that pins this message, test-sqlite-udf-close.js, had been downloaded to test/upstream/ but never adapted into test/node-compat/, so its four cases never ran. Generating it required making sync-node-tests.ts run its sync only when invoked directly -- it already exported adaptTest() for reuse, but importing the module kicked off a full network sync.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64743 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

mcollina · 2026-07-25T20:21:56Z

Prevent DatabaseSync.close() from finalizing SQLite resources while a JavaScript callback is executing.

SQLite invokes user-defined functions, aggregate functions, authorizers, and changeset callbacks synchronously during database operations. Previously, calling database.close() from one of these callbacks could finalize active statements or the connection while native code was still using them.

This change tracks callback depth and rejects reentrant closes with ERR_INVALID_STATE. It also adds regression coverage for StatementSync.all(), get(), run(), and iterate().

nodejs-github-bot · 2026-07-25T20:22:01Z

Review requested:

@nodejs/sqlite

codecov · 2026-07-25T22:00:33Z

Codecov Report

❌ Patch coverage is 61.29032% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (c8e2a82) to head (a477a99).
⚠️ Report is 82 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	50.00%	8 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64743 +/- ##
=======================================
Coverage 90.16% 90.16% =======================================
Files 746 746 Lines 242760 242784 +24 Branches 45765 45766 +1 =======================================
+ Hits 218875 218902 +27 + Misses 15375 15367 -8 - Partials 8510 8515 +5

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <100.00%> (+1.96%)`	⬆️
src/node_sqlite.cc	`80.43% <50.00%> (-0.25%)`	⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin

I checked the guards in the base functions, and the window functions are covered too

and I looked fail test, this fail unrelated this pr

nodejs-github-bot · 2026-07-27T00:59:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75190/

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-08-04T06:05:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75449/

nodejs-github-bot · 2026-08-04T11:05:49Z

Landed in 5cef767

Closing a database from inside a callback now reports "database cannot be closed while in a callback" instead of "database cannot be closed inside a user-defined function callback", the wording upstream adopted in nodejs/node#64743. The error code (ERR_INVALID_STATE) is unchanged, so only tests matching the old string are affected. The upstream test that pins this message, test-sqlite-udf-close.js, had been downloaded to test/upstream/ but never adapted into test/node-compat/, so its four cases never ran. Generating it required making sync-node-tests.ts run its sync only when invoked directly -- it already exported adaptTest() for reuse, but importing the module kicked off a full network sync.

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64743 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #65090 Refs: #64743 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jul 25, 2026

mcollina force-pushed the fix-sqlite-close-during-callback branch 2 times, most recently from d3160fe to 822fbefCompare July 26, 2026 07:31

mertcanaltin approved these changes Jul 26, 2026
View reviewed changes

anonrig approved these changes Jul 26, 2026
View reviewed changes

geeksilva97 approved these changes Jul 27, 2026
View reviewed changes

geeksilva97 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 27, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2026

sqlite: prevent database close during callbacks
a477a99
Co-authored-by: Asroy Cristian Sitorus <asroycristiansitorus@gmail.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina force-pushed the fix-sqlite-close-during-callback branch from 822fbef to a477a99Compare July 30, 2026 20:21

jasnell approved these changes Aug 2, 2026
View reviewed changes

trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026

mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 5cef767 into nodejs:mainAug 4, 2026
70 checks passed

TrevorBurnham mentioned this pull request Aug 6, 2026
sqlite: reject deserialize() while in a callback #64796
Merged

trivikr mentioned this pull request Aug 6, 2026
doc: document close() error when in a sqlite callback #65090
Merged

TrevorBurnham mentioned this pull request Aug 7, 2026
node:sqlite segfaults when db.close() is called from a user-defined function callback during query execution #63180
Closed

mceachen mentioned this pull request Aug 7, 2026
sqlite: fix crash on db.close() from inside a user function #63183
Closed

This was referenced Aug 7, 2026
sqlite: reentrancy into a running statement from a user-defined function is unguarded #65102
Closed
stabilization of node:sqlite module #57445
Open

TrevorBurnham mentioned this pull request Aug 7, 2026
sqlite: reject reentry into a running statement #65106
Closed

trivikr mentioned this pull request Aug 9, 2026
sqlite: prevent reentrant statement finalization from callbacks #64795
Closed

coderabbitaiBot mentioned this pull request Aug 10, 2026
perf(orchestration): remove mutation receipt capacity scans stablyai/orca#13647
Merged

coderabbitaiBot mentioned this pull request Aug 17, 2026
feat: add local MCP task orchestration ApptoAI/deskto#36
Merged

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged