Skip to content

src: update repeated use strings to env - #64760

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/minor-string-uses
Aug 5, 2026
Merged

src: update repeated use strings to env#64760
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/minor-string-uses

Conversation

@jasnell

Copy link
Copy Markdown
Member

Move strings that are repeated multiple times to env properties

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/ffi
  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 26, 2026
@jasnell
jasnellforce-pushed the jasnell/minor-string-uses branch from 6ee7f78 to 0179359CompareJuly 26, 2026 15:18
@jasnell
jasnellforce-pushed the jasnell/minor-string-uses branch from 0179359 to 8f79ab7CompareJuly 27, 2026 13:56
@nodejs-github-bot

This comment was marked as outdated.

Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
jasnellforce-pushed the jasnell/minor-string-uses branch from 8f79ab7 to 7090b96CompareAugust 4, 2026 13:38
@nodejs-github-bot

This comment was marked as outdated.

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 4, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecovBot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (31cde9f) to head (7090b96).
⚠️ Report is 14 commits behind head on main.

Files with missing linesPatch %Lines
src/crypto/crypto_keys.cc50.00%1 Missing and 4 partials ⚠️
src/crypto/crypto_context.cc0.00%0 Missing and 3 partials ⚠️
src/crypto/crypto_util.cc33.33%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #64760 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247621 247609 -12 Branches 46672 46682 +10 =======================================
+ Hits 223603 223605 +2 + Misses 15473 15471 -2 + Partials 8545 8533 -12 
Files with missing linesCoverage Δ
src/crypto/crypto_ec.cc68.54% <100.00%> (ø)
src/crypto/crypto_util.h67.43% <100.00%> (ø)
src/node_ffi.cc70.71% <100.00%> (ø)
src/permission/permission.cc82.56% <100.00%> (ø)
src/crypto/crypto_util.cc73.37% <33.33%> (+0.19%)⬆️
src/crypto/crypto_context.cc72.35% <0.00%> (+0.01%)⬆️
src/crypto/crypto_keys.cc70.27% <50.00%> (+0.03%)⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

@jasnelljasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 41afbd3 into nodejs:mainAug 5, 2026
70 of 71 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 41afbd3

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@nodejs-github-bot@panva@anonrig