Skip to content

doc: remove references to ca/crl as per-context QuicSession options - #64769

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:doc-quic-sni-ca-crl
Aug 3, 2026
Merged

doc: remove references to ca/crl as per-context QuicSession options#64769
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:doc-quic-sni-ca-crl

Conversation

@Renegade334

Copy link
Copy Markdown
Member

Refs: #62876

These were changed to shared session options, but the documentation wasn't updated to reflect this.

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jul 26, 2026
@Renegade334Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 27, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 28, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64769
✔ Done loading data for nodejs/node/pull/64769
----------------------------------- PR info ------------------------------------
Title doc: remove references to `ca`/`crl` as per-context QuicSession options (#64769)
Author René <contact.9a5d6388@renegade334.me.uk> (@Renegade334)
Branch Renegade334:doc-quic-sni-ca-crl -> nodejs:main
Labels doc, author ready, quic
Commits 1
- doc: remove references to `ca`/`crl` as per-context QuicSession options
Committers 1
- Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: https://github.com/nodejs/node/pull/64769
Refs: https://github.com/nodejs/node/pull/62876
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64769
Refs: https://github.com/nodejs/node/pull/62876
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 26 Jul 2026 20:52:57 GMT
✔ Approvals: 1
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64769#pullrequestreview-4783081723
✘ This PR needs to wait 120 more hours to land (or 0 minutes if there is one more approval)
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/30398925633

@Renegade334Renegade334 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 3, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 99a7ef6 into nodejs:mainAug 3, 2026
39 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 99a7ef6

@Renegade334
Renegade334 deleted the doc-quic-sni-ca-crl branch August 3, 2026 21:54
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #64769
Refs: #62876
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 5, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #64769
Refs: #62876
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.quicIssues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Renegade334@nodejs-github-bot@avivkeller@bjohansebas