Skip to content

doc: remove all scrollbar styling - #6479

Closed
claudiorodriguez wants to merge 1 commit into
nodejs:masterfrom
claudiorodriguez:doc-native-scrollbar
Closed

doc: remove all scrollbar styling#6479
claudiorodriguez wants to merge 1 commit into
nodejs:masterfrom
claudiorodriguez:doc-native-scrollbar

Conversation

@claudiorodriguez

@claudiorodriguezclaudiorodriguez commented Apr 29, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Returns the scrollbar to native style.
Alternative to #6474 and #6445

Fixes: #6443

@claudiorodriguez
doc: remove all scrollbar styling
45f421b
Returns the scrollbar to native style.
Fixes: nodejs#6443
@claudiorodriguezclaudiorodriguez added the doc Issues and PRs related to the documentations. label Apr 29, 2016
This was referenced Apr 29, 2016
Closed
Closed
@jasnell

jasnell commented Apr 29, 2016

Copy link
Copy Markdown
Member

@nodejs/documentation @nodejs/website

@ChALkeR

ChALkeR commented Apr 29, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Actually, that would be a perfect solution.

@eljefedelrodeodeljefe

eljefedelrodeodeljefe commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

Let's do it. LGTM

@ghost

ghost commented Apr 29, 2016

Copy link
Copy Markdown

LGTM!

@silverwind

silverwind commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

Eh, I think we've bikeshedded this to death, so LGTM. Bit of a shame that this won't emulate OS X scrollbars on Windows anymore, but I guess we let Browsers solve that "issue".

@eljefedelrodeodeljefe

eljefedelrodeodeljefe commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

Bikesheds are built on weekends :)

@jasnell

jasnell commented Apr 29, 2016•
edited
Loading

Copy link
Copy Markdown
Member

I'm gonna create a bikeshed-this label so people know where the really good bikeshed conversations are happening. Good idea or no? ;-)

@ghost

ghost commented Apr 29, 2016

Copy link
Copy Markdown

@jasnell 👍 hell yeah

@eljefedelrodeodeljefe

eljefedelrodeodeljefe commented Apr 29, 2016

Copy link
Copy Markdown
Contributor

+1 -1 +1 -1 +1 -1 +1 -1 +1 -1 +1 -1

@ChALkeR

ChALkeR commented Apr 29, 2016

Copy link
Copy Markdown
Member

LGTM.

@claudiorodriguez

claudiorodriguez commented Apr 30, 2016

Copy link
Copy Markdown
ContributorAuthor

Merging this tomorrow if there's no objections

@claudiorodriguez

claudiorodriguez commented May 1, 2016

Copy link
Copy Markdown
ContributorAuthor

Landed in 7fdffb6

claudiorodriguez added a commit that referenced this pull request May 1, 2016
@claudiorodriguez
doc: remove all scrollbar styling
7fdffb6
Returns the doc custom scrollbar to native style.
Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
@claudiorodriguez@Fishrock123
doc: remove all scrollbar styling
4ae39f9
Returns the doc custom scrollbar to native style.
Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This was referenced May 4, 2016
Closed
Merged
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
@claudiorodriguez@joelostrowski
doc: remove all scrollbar styling
8096759
Returns the doc custom scrollbar to native style.
Fixes: nodejs#6443
PR-URL: nodejs#6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@zertosh

zertosh commented May 8, 2016

Copy link
Copy Markdown
Contributor

Chrome (at least on a Mac) will give you indicators on the scrollbar of where cmd+f results are. Using custom styles on the scrollbar breaks this – so I'm glad to see it works again in the narrow view. However, in the wide view, since the content area's scrollbars are not on the body, they still don't work there:

scrollbars-find

@ChALkeR

ChALkeR commented May 8, 2016

Copy link
Copy Markdown
Member

@zertosh I suggest filing a separate issue for this, if there isn't one already.

@eljefedelrodeodeljefeeljefedelrodeodeljefe mentioned this pull request May 8, 2016
Closed
@eljefedelrodeodeljefe

eljefedelrodeodeljefe commented May 8, 2016

Copy link
Copy Markdown
Contributor

Did one for you. Couldn't find any... #6637 Thanks for reporting, this bugged me for a while too.

MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
@claudiorodriguezMyles Borins
doc: remove all scrollbar styling
adad721
Returns the doc custom scrollbar to native style.
Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@claudiorodriguezMyles Borins
doc: remove all scrollbar styling
de20235
Returns the doc custom scrollbar to native style.
Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@claudiorodriguezMyles Borins
doc: remove all scrollbar styling
619dc19
Returns the doc custom scrollbar to native style.
Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Scrollbar width

7 participants

@claudiorodriguez@jasnell@ChALkeR@eljefedelrodeodeljefe@silverwind@zertosh@MylesBorins