Skip to content

deps: update ada to 4.0.0 - #64790

Closed
nodejs-github-bot wants to merge 4 commits into
mainfrom
actions/truetools-update-ada
Closed

deps: update ada to 4.0.0#64790
nodejs-github-bot wants to merge 4 commits into
mainfrom
actions/truetools-update-ada

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 4.0.0.

@nodejs-github-botnodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jul 27, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/security-wg
  • @nodejs/url

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 27, 2026
@avivkelleravivkeller added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 27, 2026
@avivkeller

avivkeller commented Jul 27, 2026

Copy link
Copy Markdown
Member

Bump from v3 -> v4, semver-major, I presume

@anonrig

anonrig commented Jul 28, 2026

Copy link
Copy Markdown
Member

This is not a semver major change. It's a major bump because we started providing a new API to limit the max size of a URL which was 4gb.

@anonriganonrig removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 28, 2026
@Renegade334

Renegade334 commented Jul 28, 2026

Copy link
Copy Markdown
Member

This goes hand-in-hand with #64177, which updates the invalid punycode tests.

@Renegade334
Renegade334force-pushed the actions/truetools-update-ada branch from 7634ed8 to cab619dCompareJuly 28, 2026 15:01
@anonrig

anonrig commented Jul 28, 2026

Copy link
Copy Markdown
Member

Some of the tests in this repo needs to be removed as well. We shouldn't have unique tests related to URL when WPT is already covering it. It makes maintenance hell..

anonrig
anonrig reviewed Jul 28, 2026
View reviewed changes
Comment threadtest/benchmark/test-benchmark-url.js Outdated
@codecov

codecovBot commented Jul 28, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (6a3d80f) to head (6a64de2).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64790 +/- ##
==========================================
- Coverage 90.16% 90.14% -0.03% 
==========================================
Files 744 746 +2 Lines 242518 242648 +130 Branches 45705 45722 +17 ==========================================
+ Hits 218670 218730 +60 - Misses 15357 15437 +80 + Partials 8491 8481 -10

see 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 28, 2026
Renegade334
Renegade334 approved these changes Jul 28, 2026
View reviewed changes

@Renegade334Renegade334 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Renegade334Renegade334 added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jul 28, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2026

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/75265/

@panvapanva added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 28, 2026
aduh95
aduh95 reviewed Jul 29, 2026
View reviewed changes
Comment threadtest/benchmark/test-benchmark-url.js
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 29, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Landed in 29d183d...cec16a0

nodejs-github-bot added a commit that referenced this pull request Jul 29, 2026
@nodejs-github-bot
deps: update ada to 4.0.0
eb1a49b
PR-URL: #64790
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
nodejs-github-bot added a commit that referenced this pull request Jul 29, 2026
@nodejs-github-bot
test: update WPT for url to b63305b743
cec16a0
PR-URL: #64790
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
@panva
panva deleted the actions/truetools-update-ada branch July 30, 2026 19:16
aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@nodejs-github-bot@aduh95
deps: update ada to 4.0.0
4b4a8b2
PR-URL: #64790
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@nodejs-github-bot@aduh95
test: update WPT for url to b63305b743
064e2ee
PR-URL: #64790
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
@whispersofthedawnwhispersofthedawn mentioned this pull request Aug 3, 2026
Open
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@nodejs-github-bot@aduh95
deps: update ada to 4.0.0
cd95d5c
PR-URL: #64790
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@nodejs-github-bot@aduh95
test: update WPT for url to b63305b743
37dee17
PR-URL: #64790
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
@github-actionsgithub-actionsBot mentioned this pull request Aug 4, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 5, 2026
@nodejs-github-bot@aduh95
deps: update ada to 4.0.0
b839af9
PR-URL: #64790
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
aduh95 pushed a commit that referenced this pull request Aug 5, 2026
@nodejs-github-bot@aduh95
test: update WPT for url to b63305b743
75b80d0
PR-URL: #64790
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 left review comments
@panvapanvapanva approved these changes
@anonriganonriganonrig approved these changes
@Renegade334Renegade334Renegade334 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nodejs-github-bot@avivkeller@anonrig@Renegade334@panva@aduh95