crypto: improve argument validation and error messages - #64852

Closed

panva wants to merge 4 commits into

nodejs:mainfrom

panva:fixes-lib

panva commented Jul 30, 2026

Member

Report the correct parameter name for invalid optional inputs in parseKeyEncoding.
Reject null options with ERR_INVALID_ARG_TYPE in generateKeyPair(Sync).
Avoid a second native call when reading the issuer certificate in X509Certificate.
Explain that a cipher is required when a passphrase is provided in parseKeyEncoding.

panva added 4 commits

July 30, 2026 22:15

crypto: fix Argon2 validation errors

2e62e1d

Report the correct parameter name for invalid optional inputs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>

crypto: validate key generation options

97a7d92

Reject null options with ERR_INVALID_ARG_TYPE.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>

crypto: reuse X509 issuer result

f5df725

Avoid a second native call when reading the issuer certificate.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>

crypto: clarify missing cipher error

3eebfb7

Explain that a cipher is required when a passphrase is provided.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>

panva requested review from anonrig and jasnell

July 30, 2026 20:22

panva added the commit-queue-rebase label

nodejs-github-bot commented Jul 30, 2026

Collaborator

Review requested:

@nodejs/crypto

nodejs-github-bot added crypto needs-ci labels

jasnell approved these changes

View reviewed changes

panva added author ready request-ci labels

github-actionsBot removed the request-ci label

This comment was marked as outdated.

Sign in to view

codecovBot commented Jul 30, 2026•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (e7904d4) to head (3eebfb7).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #64852 +/- ##
==========================================
+ Coverage 90.14% 90.16% +0.02% 
==========================================
Files 746 746 Lines 242764 242762 -2 Branches 45739 45761 +22 ==========================================
+ Hits 218848 218895 +47 + Misses 15426 15332 -94 - Partials 8490 8535 +45

Files with missing lines	Coverage Δ
lib/internal/crypto/argon2.js	`98.70% <100.00%> (ø)`
lib/internal/crypto/keygen.js	`93.49% <100.00%> (ø)`
lib/internal/crypto/keys.js	`97.84% <100.00%> (+<0.01%)`	⬆️
lib/internal/crypto/x509.js	`91.70% <100.00%> (ø)`

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jul 31, 2026

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75335/

anonrig approved these changes

View reviewed changes

panva added the commit-queue label

nodejs-github-bot removed the commit-queue label

nodejs-github-bot commented Aug 1, 2026

Collaborator

Landed in f9e21ae...276fe2b

nodejs-github-bot pushed a commit that referenced this pull request

crypto: fix Argon2 validation errors

f2c4ea3

Report the correct parameter name for invalid optional inputs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot pushed a commit that referenced this pull request

crypto: validate key generation options

b02343d

Reject null options with ERR_INVALID_ARG_TYPE.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot pushed a commit that referenced this pull request

crypto: reuse X509 issuer result

9c0255b

Avoid a second native call when reading the issuer certificate.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot closed this

nodejs-github-bot pushed a commit that referenced this pull request

crypto: clarify missing cipher error

276fe2b

Explain that a cipher is required when a passphrase is provided.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

panva deleted the fixes-lib branch

August 1, 2026 20:40

aduh95 pushed a commit that referenced this pull request

crypto: fix Argon2 validation errors

dc5922a

Report the correct parameter name for invalid optional inputs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: validate key generation options

29fce4c

Reject null options with ERR_INVALID_ARG_TYPE.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: reuse X509 issuer result

426b65b

Avoid a second native call when reading the issuer certificate.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: clarify missing cipher error

c58816c

Explain that a cipher is required when a passphrase is provided.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: fix Argon2 validation errors

1b48a5c

Report the correct parameter name for invalid optional inputs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: validate key generation options

d57a0de

Reject null options with ERR_INVALID_ARG_TYPE.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: reuse X509 issuer result

bf8b8e4

Avoid a second native call when reading the issuer certificate.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: clarify missing cipher error

ca4b1e8

Explain that a cipher is required when a passphrase is provided.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: fix Argon2 validation errors

a8a4e66

Report the correct parameter name for invalid optional inputs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: validate key generation options

ac954d2

Reject null options with ERR_INVALID_ARG_TYPE.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: reuse X509 issuer result

efa22e7

Avoid a second native call when reading the issuer certificate.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: clarify missing cipher error

31f8c91

Explain that a cipher is required when a passphrase is provided.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

github-actionsBot mentioned this pull request

2026-08-05, Version 26.7.0 (Current) #65027

Merged

aduh95 pushed a commit that referenced this pull request

crypto: fix Argon2 validation errors

c36bb1d

Report the correct parameter name for invalid optional inputs.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: validate key generation options

c68c7d0

Reject null options with ERR_INVALID_ARG_TYPE.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: reuse X509 issuer result

c604d88

Avoid a second native call when reading the issuer certificate.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request

crypto: clarify missing cipher error

fde8523

Explain that a cipher is required when a passphrase is provided.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64852
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readycommit-queue-rebasecryptoneeds-ci