src: use UTF-8 for task runner filesystem paths by Archkon · Pull Request #64868 · nodejs/node

Archkon · 2026-07-31T11:36:21Z

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.

codecov · 2026-07-31T13:12:33Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (bec3d0b) to head (a91aeff).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	83.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02% 
==========================================
Files 746 746 Lines 242763 242763 Branches 45761 45765 +4 ==========================================
+ Hits 218848 218901 +53 + Misses 15402 15346 -56 - Partials 8513 8516 +3

Files with missing lines	Coverage Δ
src/node_task_runner.cc	`89.32% <83.33%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig

Please add a test case

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

StefanStojanovic

Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.

nodejs-github-bot · 2026-08-03T09:12:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75420/

nodejs-github-bot · 2026-08-04T12:33:15Z

Landed in 793a6ec

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

Archkon · 2026-07-31T11:36:21Z

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.

codecov · 2026-07-31T13:12:33Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (bec3d0b) to head (a91aeff).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	83.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02% 
==========================================
Files 746 746 Lines 242763 242763 Branches 45761 45765 +4 ==========================================
+ Hits 218848 218901 +53 + Misses 15402 15346 -56 - Partials 8513 8516 +3

Files with missing lines	Coverage Δ
src/node_task_runner.cc	`89.32% <83.33%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig

Please add a test case

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

StefanStojanovic

Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.

nodejs-github-bot · 2026-08-03T09:12:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75420/

nodejs-github-bot · 2026-08-04T12:33:15Z

Landed in 793a6ec

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

Archkon · 2026-07-31T11:36:21Z

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.

codecov · 2026-07-31T13:12:33Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (bec3d0b) to head (a91aeff).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	83.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02% 
==========================================
Files 746 746 Lines 242763 242763 Branches 45761 45765 +4 ==========================================
+ Hits 218848 218901 +53 + Misses 15402 15346 -56 - Partials 8513 8516 +3

Files with missing lines	Coverage Δ
src/node_task_runner.cc	`89.32% <83.33%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig

Please add a test case

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

StefanStojanovic

Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.

nodejs-github-bot · 2026-08-03T09:12:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75420/

nodejs-github-bot · 2026-08-04T12:33:15Z

Landed in 793a6ec

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

Archkon · 2026-07-31T11:36:21Z

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.

codecov · 2026-07-31T13:12:33Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (bec3d0b) to head (a91aeff).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	83.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02% 
==========================================
Files 746 746 Lines 242763 242763 Branches 45761 45765 +4 ==========================================
+ Hits 218848 218901 +53 + Misses 15402 15346 -56 - Partials 8513 8516 +3

Files with missing lines	Coverage Δ
src/node_task_runner.cc	`89.32% <83.33%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig

Please add a test case

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

StefanStojanovic

Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.

nodejs-github-bot · 2026-08-03T09:12:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75420/

nodejs-github-bot · 2026-08-04T12:33:15Z

Landed in 793a6ec

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

Archkon · 2026-07-31T11:36:21Z

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.

codecov · 2026-07-31T13:12:33Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (bec3d0b) to head (a91aeff).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	83.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02% 
==========================================
Files 746 746 Lines 242763 242763 Branches 45761 45765 +4 ==========================================
+ Hits 218848 218901 +53 + Misses 15402 15346 -56 - Partials 8513 8516 +3

Files with missing lines	Coverage Δ
src/node_task_runner.cc	`89.32% <83.33%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig

Please add a test case

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

StefanStojanovic

Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.

nodejs-github-bot · 2026-08-03T09:12:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75420/

nodejs-github-bot · 2026-08-04T12:33:15Z

Landed in 793a6ec

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

Archkon · 2026-07-31T11:36:21Z

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.

codecov · 2026-07-31T13:12:33Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (bec3d0b) to head (a91aeff).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	83.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02% 
==========================================
Files 746 746 Lines 242763 242763 Branches 45761 45765 +4 ==========================================
+ Hits 218848 218901 +53 + Misses 15402 15346 -56 - Partials 8513 8516 +3

Files with missing lines	Coverage Δ
src/node_task_runner.cc	`89.32% <83.33%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig

Please add a test case

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

StefanStojanovic

Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.

nodejs-github-bot · 2026-08-03T09:12:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75420/

nodejs-github-bot · 2026-08-04T12:33:15Z

Landed in 793a6ec

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

Archkon · 2026-07-31T11:36:21Z

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.

codecov · 2026-07-31T13:12:33Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (bec3d0b) to head (a91aeff).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	83.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02% 
==========================================
Files 746 746 Lines 242763 242763 Branches 45761 45765 +4 ==========================================
+ Hits 218848 218901 +53 + Misses 15402 15346 -56 - Partials 8513 8516 +3

Files with missing lines	Coverage Δ
src/node_task_runner.cc	`89.32% <83.33%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig

Please add a test case

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

StefanStojanovic

Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.

nodejs-github-bot · 2026-08-03T09:12:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75420/

nodejs-github-bot · 2026-08-04T12:33:15Z

Landed in 793a6ec

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

Archkon · 2026-07-31T11:36:21Z

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected.

codecov · 2026-07-31T13:12:33Z

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (bec3d0b) to head (a91aeff).
⚠️ Report is 83 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_task_runner.cc	83.33%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64868 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02% 
==========================================
Files 746 746 Lines 242763 242763 Branches 45761 45765 +4 ==========================================
+ Hits 218848 218901 +53 + Misses 15402 15346 -56 - Partials 8513 8516 +3

Files with missing lines	Coverage Δ
src/node_task_runner.cc	`89.32% <83.33%> (ø)`

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig

Please add a test case

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

StefanStojanovic

Thanks for the ping. LGTM. I've triggered the CI, to verify the changes and the test you added.

nodejs-github-bot · 2026-08-03T09:12:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75420/

nodejs-github-bot · 2026-08-04T12:33:15Z

Landed in 793a6ec

Use ConvertPathToUTF8() instead of path::string() when passing filesystem paths to Node and libuv interfaces. This prevents paths containing characters outside the active Windows code page from being corrupted or rejected. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com> PR-URL: #64868 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026

This comment was marked as spam.
Sign in to view

anonrig requested changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from 18e3a80 to fc5c15eCompare July 31, 2026 17:27

anonrig approved these changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from fc5c15e to a91aeffCompare July 31, 2026 17:36

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

StefanStojanovic approved these changes Aug 3, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

This comment was marked as spam.
Sign in to view

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 793a6ec into nodejs:mainAug 4, 2026
70 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026

This comment was marked as spam.
Sign in to view

anonrig requested changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from 18e3a80 to fc5c15eCompare July 31, 2026 17:27

anonrig approved these changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from fc5c15e to a91aeffCompare July 31, 2026 17:36

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

StefanStojanovic approved these changes Aug 3, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

This comment was marked as spam.
Sign in to view

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 793a6ec into nodejs:mainAug 4, 2026
70 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026

This comment was marked as spam.
Sign in to view

anonrig requested changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from 18e3a80 to fc5c15eCompare July 31, 2026 17:27

anonrig approved these changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from fc5c15e to a91aeffCompare July 31, 2026 17:36

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

StefanStojanovic approved these changes Aug 3, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

This comment was marked as spam.
Sign in to view

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 793a6ec into nodejs:mainAug 4, 2026
70 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026

This comment was marked as spam.
Sign in to view

anonrig requested changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from 18e3a80 to fc5c15eCompare July 31, 2026 17:27

anonrig approved these changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from fc5c15e to a91aeffCompare July 31, 2026 17:36

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

StefanStojanovic approved these changes Aug 3, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

This comment was marked as spam.
Sign in to view

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 793a6ec into nodejs:mainAug 4, 2026
70 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026

This comment was marked as spam.
Sign in to view

anonrig requested changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from 18e3a80 to fc5c15eCompare July 31, 2026 17:27

anonrig approved these changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from fc5c15e to a91aeffCompare July 31, 2026 17:36

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

StefanStojanovic approved these changes Aug 3, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

This comment was marked as spam.
Sign in to view

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 793a6ec into nodejs:mainAug 4, 2026
70 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026

This comment was marked as spam.
Sign in to view

anonrig requested changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from 18e3a80 to fc5c15eCompare July 31, 2026 17:27

anonrig approved these changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from fc5c15e to a91aeffCompare July 31, 2026 17:36

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

StefanStojanovic approved these changes Aug 3, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

This comment was marked as spam.
Sign in to view

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 793a6ec into nodejs:mainAug 4, 2026
70 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026

This comment was marked as spam.
Sign in to view

anonrig requested changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from 18e3a80 to fc5c15eCompare July 31, 2026 17:27

anonrig approved these changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from fc5c15e to a91aeffCompare July 31, 2026 17:36

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

StefanStojanovic approved these changes Aug 3, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

This comment was marked as spam.
Sign in to view

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 793a6ec into nodejs:mainAug 4, 2026
70 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 31, 2026

This comment was marked as spam.
Sign in to view

anonrig requested changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from 18e3a80 to fc5c15eCompare July 31, 2026 17:27

anonrig approved these changes Jul 31, 2026
View reviewed changes

Archkon force-pushed the testrunner branch from fc5c15e to a91aeffCompare July 31, 2026 17:36

StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

StefanStojanovic approved these changes Aug 3, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026

This comment was marked as spam.
Sign in to view

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2026

nodejs-github-bot merged commit 793a6ec into nodejs:mainAug 4, 2026
70 checks passed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

Uh oh!

Uh oh!

Conversation

Archkon commented Jul 31, 2026

Uh oh!

This comment was marked as spam.

codecovBot commented Jul 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

StefanStojanovic left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 3, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

nodejs-github-bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Archkon commented Jul 31, 2026

Uh oh!

This comment was marked as spam.

codecovBot commented Jul 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

StefanStojanovic left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 3, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

nodejs-github-bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Archkon commented Jul 31, 2026

Uh oh!

This comment was marked as spam.

codecovBot commented Jul 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

StefanStojanovic left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 3, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

codecovBot commented Jul 31, 2026•
edited
Loading

codecovBot commented Jul 31, 2026•
edited
Loading

codecovBot commented Jul 31, 2026•
edited
Loading

codecovBot commented Jul 31, 2026•
edited
Loading

codecovBot commented Jul 31, 2026•
edited
Loading