Uh oh!
There was an error while loading. Please reload this page.
doc: add missing float32/float64 FFI type names - #64874
Merged
nodejs-github-bot merged 1 commit intoAug 2, 2026
Merged
Conversation
nodejs-github-bot
commented
Jul 31, 2026
Collaborator
Review requested:
|
Renegade334
approved these changes
Jul 31, 2026
Uh oh!
There was an error while loading. Please reload this page.
`ToFFIType()` accepts `float32` and `float64` as aliases for `float` and `double`, and both names already appear in the `ffi.types` constants list further down the same page, but they were missing from the list of supported type names. Also split `char` onto its own line. Unlike `u8`, `uint8` and `bool`, which always map to `ffi_type_uint8`, `char` maps to either `ffi_type_sint8` or `ffi_type_uint8` depending on the platform C ABI, as the paragraph below the list already explains. Signed-off-by: Soul Lee <alus20x@gmail.com>
soulee-devforce-pushed
the
doc-ffi-float-type-names
branch
from
July 31, 2026 22:23
5773cd1 to
eb5dd9aCompareRenegade334
approved these changes
Aug 1, 2026
ShogunPanda
approved these changes
Aug 1, 2026
UlisesGascon
approved these changes
Aug 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Aug 2, 2026
Collaborator
Landed in 7c6bce0 |
aduh95 pushed a commit
that referenced
this pull request
Aug 3, 2026
`ToFFIType()` accepts `float32` and `float64` as aliases for `float` and `double`, and both names already appear in the `ffi.types` constants list further down the same page, but they were missing from the list of supported type names. Also split `char` onto its own line. Unlike `u8`, `uint8` and `bool`, which always map to `ffi_type_uint8`, `char` maps to either `ffi_type_sint8` or `ffi_type_uint8` depending on the platform C ABI, as the paragraph below the list already explains. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #64874 Refs: #62892 Refs: #64848 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 4, 2026
`ToFFIType()` accepts `float32` and `float64` as aliases for `float` and `double`, and both names already appear in the `ffi.types` constants list further down the same page, but they were missing from the list of supported type names. Also split `char` onto its own line. Unlike `u8`, `uint8` and `bool`, which always map to `ffi_type_uint8`, `char` maps to either `ffi_type_sint8` or `ffi_type_uint8` depending on the platform C ABI, as the paragraph below the list already explains. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #64874 Refs: #62892 Refs: #64848 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 4, 2026
`ToFFIType()` accepts `float32` and `float64` as aliases for `float` and `double`, and both names already appear in the `ffi.types` constants list further down the same page, but they were missing from the list of supported type names. Also split `char` onto its own line. Unlike `u8`, `uint8` and `bool`, which always map to `ffi_type_uint8`, `char` maps to either `ffi_type_sint8` or `ffi_type_uint8` depending on the platform C ABI, as the paragraph below the list already explains. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #64874 Refs: #62892 Refs: #64848 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 5, 2026
`ToFFIType()` accepts `float32` and `float64` as aliases for `float` and `double`, and both names already appear in the `ffi.types` constants list further down the same page, but they were missing from the list of supported type names. Also split `char` onto its own line. Unlike `u8`, `uint8` and `bool`, which always map to `ffi_type_uint8`, `char` maps to either `ffi_type_sint8` or `ffi_type_uint8` depending on the platform C ABI, as the paragraph below the list already explains. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #64874 Refs: #62892 Refs: #64848 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToFFIType()acceptsfloat32andfloat64as aliases forfloatanddouble, but the supported type names list never included them. They were added to the parser in #62892, which only touchedsrc/ffi/types.cc, so the same section lists both asffi.typesconstant values a few lines below a list that omits them.Also splits
charonto its own line.u8,uint8andboolalways map toffi_type_uint8, whereascharmaps toffi_type_sint8orffi_type_uint8depending on the platform, as the paragraph below the list already documents.#64848 proposes removing these aliases entirely; this only makes the list match what
ToFFIType()accepts today, and those lines can go away with the aliases if that lands.Refs: #62892
Refs: #64848