Uh oh!
There was an error while loading. Please reload this page.
test: fix lint in dtls tests - #64902
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
a7d16a8 introduced destructured uses of assert and fixtures, which the test lint rules forbid, plus bare strictEqual/throws calls that were never imported and threw ReferenceError at runtime. Use the assert and fixtures namespaces directly. Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
commented
Aug 1, 2026
MemberAuthor
Fast-track has been requested by @mcollina. Please 👍 to approve. This fixes |
Contributor
Fast-track has been requested by @mcollina. Please 👍 to approve. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #64902 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.02%
==========================================
Files 746 746 Lines 242893 242893 Branches 45769 45766 -3 ==========================================
+ Hits 218935 218985 +50 + Misses 15444 15390 -54 - Partials 8514 8518 +4 🚀 New features to boost your workflow:
|
MikeMcC399
approved these changes
Aug 1, 2026
nodejs-github-bot
commented
Aug 1, 2026
Collaborator
panva
approved these changes
Aug 1, 2026
jasnell
approved these changes
Aug 1, 2026
jasnell
left a comment
Member
There was a problem hiding this comment.
Weird, these didn't show up for me locally when I linted. Wonder if I have something out of sync. Thanks for catching!
MikeMcC399
commented
Aug 1, 2026
Contributor
It seems to have been clobbered by #64716 |
panva pushed a commit
that referenced
this pull request
Aug 1, 2026
a7d16a8 introduced destructured uses of assert and fixtures, which the test lint rules forbid, plus bare strictEqual/throws calls that were never imported and threw ReferenceError at runtime. Use the assert and fixtures namespaces directly. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64902 Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
panva
commented
Aug 1, 2026
Member
Landed in a46087d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a7d16a8 introduced destructured uses of
assertandfixturesin the dtls tests, which the test lint rules forbid (no-restricted-syntax), solint-js-and-mdis currently failing on main and on every open PR.Two of the files (
test-dtls-alpn.mjs,test-dtls-options.mjs) also called barestrictEqual/throwsthat were never imported at all — those threwReferenceErrorat runtime when the assertions ran.This uses the
assertandfixturesnamespaces directly throughout, matching the rest of the test suite.All 25
test-dtls-*tests pass locally on this branch andmake lint-jsis clean.cc @jasnell