test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960

Closed
panva wants to merge 2 commits into
nodejs:mainfrom
panva:actions-fips
Closed

test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom
panva:actions-fips

Conversation

@panva

@panvapanva commented Aug 2, 2026•
edited
Loading

Copy link
Copy Markdown
Member

This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).

Closes: #48379

@panvapanva added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Aug 2, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@panva
panva requested a review from aduh95August 2, 2026 14:31
@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 2, 2026
@panvapanva added test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory. labels Aug 2, 2026
aduh95
aduh95 reviewed Aug 2, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh Outdated
@github-actions

This comment was marked as outdated.

Sign in to view
2 similar comments
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov

codecovBot commented Aug 2, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247634 247635 +1 Branches 46687 46680 -7 =======================================
+ Hits 223623 223635 +12 - Misses 15462 15465 +3 + Partials 8549 8535 -14
Files with missing linesCoverage Δ
lib/internal/crypto/webcrypto.js97.81% <100.00%> (+<0.01%)⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva
panvaforce-pushed the actions-fips branch 2 times, most recently from 68ba143 to 5699e8dCompareAugust 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed Aug 4, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh Outdated
@panvapanva mentioned this pull request Aug 4, 2026
Merged
aduh95
aduh95 reviewed Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix Outdated
aduh95
aduh95 reviewed Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix Outdated
panva added 2 commits August 4, 2026 20:11
@panva
test: update tests to run with OpenSSL >= 3.0 FIPS mode
d199954
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
tools: add an OpenSSL FIPS build to test-shared.yml
00f6176
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
aduh95
aduh95 approved these changes Aug 4, 2026
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@panva

panva commented Aug 4, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM if CI is green

Thank you for your help

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux455 -> 459 => +44 / 459 = 0.8%
aarch64-linux456 -> 460 => +44 / 460 = 0.8%
x86_64-darwin393 -> 396 => +33 / 396 = 0.7%
aarch64-darwin398 -> 401 => +33 / 401 = 0.7%
Total1702 -> 1716 => +1414 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)

@panvapanva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 4, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75520/

@panvapanva added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 5, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 5, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Landed in b79dcdf...dc7838c

nodejs-github-bot pushed a commit that referenced this pull request Aug 5, 2026
@panva@nodejs-github-bot
test: update tests to run with OpenSSL >= 3.0 FIPS mode
45550ee
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit that referenced this pull request Aug 5, 2026
@panva@nodejs-github-bot
tools: add an OpenSSL FIPS build to test-shared.yml
dc7838c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@panva
panva deleted the actions-fips branch August 5, 2026 16:19
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
5bc6133
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
732c48b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
christama
christama reviewed Aug 21, 2026
View reviewed changes

@christamachristama left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
0e1a99a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
fd7e904
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
@aduh95aduh95 added the backported-to-v24.x PRs backported to the v24.x-staging branch. label Aug 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@avivkelleravivkelleravivkeller approved these changes
+1 more reviewer
@christamachristamachristama left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.backported-to-v24.xPRs backported to the v24.x-staging branch.commit-queue-rebasePRs the Commit Queue should land as multiple self-contained commits.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled

5 participants

@panva@nodejs-github-bot@aduh95@avivkeller@christama
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960
Closed
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Closed
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Conversation
@panva
@panvapanva
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).
Closes: #48379
@panvapanva
added
the 
commit-queue-rebase
PRs the Commit Queue should land as multiple self-contained commits.
label
Aug 2, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 2, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
@panva
panva
requested a review
from aduh95August 2, 2026 14:31
@nodejs-github-botnodejs-github-bot
added

crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Aug 2, 2026
@panvapanva
added

test
Issues and PRs related to Node.js core tests and test infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 2, 2026
aduh95
aduh95
reviewed
Aug 2, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@github-actions

This comment was marked as outdated.

Sign in to view

2 similar comments

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247634 247635 +1 Branches 46687 46680 -7 =======================================
+ Hits 223623 223635 +12 - Misses 15462 15465 +3 + Partials 8549 8535 -14 
Files with missing linesCoverage Δ
lib/internal/crypto/webcrypto.js97.81% <100.00%> (+<0.01%)⬆️
... and 28 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
panvaforce-pushed
the
actions-fips
branch
2 times, most recently
from
68ba143 to
5699e8dCompareAugust 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Sign in to view
aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@panvapanva
mentioned this pull request
Aug 4, 2026
 Merged

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

panva
added 2 commits
August 4, 2026 20:11
@panva
test: update tests to run with OpenSSL >= 3.0 FIPS mode
d199954
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
tools: add an OpenSSL FIPS build to test-shared.yml
00f6176
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
aduh95
aduh95
approved these changes
Aug 4, 2026
View reviewed changes
@aduh95aduh95
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green
@panva
panva
commented
Aug 4, 2026

Copy link


Copy Markdown

MemberAuthor
LGTM if CI is green
Thank you for your help
@github-actions
github-actionsBot
commented
Aug 4, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux455 -> 459 => +44 / 459 = 0.8%
aarch64-linux456 -> 460 => +44 / 460 = 0.8%
x86_64-darwin393 -> 396 => +33 / 396 = 0.7%
aarch64-darwin398 -> 401 => +33 / 401 = 0.7%
Total1702 -> 1716 => +1414 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)
@panvapanva
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75520/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Landed in b79dcdf...dc7838c
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
test: update tests to run with OpenSSL >= 3.0 FIPS mode
45550ee
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
tools: add an OpenSSL FIPS build to test-shared.yml
dc7838c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@panva
panva
deleted the

actions-fips

branch
August 5, 2026 16:19
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
5bc6133
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
732c48b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
christama
christama
reviewed
Aug 21, 2026
View reviewed changes
@christamachristama
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
0e1a99a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
fd7e904
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@aduh95aduh95
added
the 
backported-to-v24.x
PRs backported to the v24.x-staging branch.
label
Aug 27, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@avivkelleravivkelleravivkeller approved these changes

+1 more reviewer

@christamachristamachristama left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.backported-to-v24.xPRs backported to the v24.x-staging branch.commit-queue-rebasePRs the Commit Queue should land as multiple self-contained commits.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled


5 participants

@panva@nodejs-github-bot@aduh95@avivkeller@christama

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960
Closed
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Closed
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Conversation
@panva
@panvapanva
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).
Closes: #48379
@panvapanva
added
the 
commit-queue-rebase
PRs the Commit Queue should land as multiple self-contained commits.
label
Aug 2, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 2, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
@panva
panva
requested a review
from aduh95August 2, 2026 14:31
@nodejs-github-botnodejs-github-bot
added

crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Aug 2, 2026
@panvapanva
added

test
Issues and PRs related to Node.js core tests and test infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 2, 2026
aduh95
aduh95
reviewed
Aug 2, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@github-actions

This comment was marked as outdated.

Sign in to view

2 similar comments

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247634 247635 +1 Branches 46687 46680 -7 =======================================
+ Hits 223623 223635 +12 - Misses 15462 15465 +3 + Partials 8549 8535 -14 
Files with missing linesCoverage Δ
lib/internal/crypto/webcrypto.js97.81% <100.00%> (+<0.01%)⬆️
... and 28 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
panvaforce-pushed
the
actions-fips
branch
2 times, most recently
from
68ba143 to
5699e8dCompareAugust 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Sign in to view
aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@panvapanva
mentioned this pull request
Aug 4, 2026
 Merged

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

panva
added 2 commits
August 4, 2026 20:11
@panva
test: update tests to run with OpenSSL >= 3.0 FIPS mode
d199954
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
tools: add an OpenSSL FIPS build to test-shared.yml
00f6176
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
aduh95
aduh95
approved these changes
Aug 4, 2026
View reviewed changes
@aduh95aduh95
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green
@panva
panva
commented
Aug 4, 2026

Copy link


Copy Markdown

MemberAuthor
LGTM if CI is green
Thank you for your help
@github-actions
github-actionsBot
commented
Aug 4, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux455 -> 459 => +44 / 459 = 0.8%
aarch64-linux456 -> 460 => +44 / 460 = 0.8%
x86_64-darwin393 -> 396 => +33 / 396 = 0.7%
aarch64-darwin398 -> 401 => +33 / 401 = 0.7%
Total1702 -> 1716 => +1414 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)
@panvapanva
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75520/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Landed in b79dcdf...dc7838c
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
test: update tests to run with OpenSSL >= 3.0 FIPS mode
45550ee
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
tools: add an OpenSSL FIPS build to test-shared.yml
dc7838c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@panva
panva
deleted the

actions-fips

branch
August 5, 2026 16:19
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
5bc6133
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
732c48b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
christama
christama
reviewed
Aug 21, 2026
View reviewed changes
@christamachristama
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
0e1a99a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
fd7e904
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@aduh95aduh95
added
the 
backported-to-v24.x
PRs backported to the v24.x-staging branch.
label
Aug 27, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@avivkelleravivkelleravivkeller approved these changes

+1 more reviewer

@christamachristamachristama left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.backported-to-v24.xPRs backported to the v24.x-staging branch.commit-queue-rebasePRs the Commit Queue should land as multiple self-contained commits.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled


5 participants

@panva@nodejs-github-bot@aduh95@avivkeller@christama

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960
Closed
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Closed
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Conversation
@panva
@panvapanva
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).
Closes: #48379
@panvapanva
added
the 
commit-queue-rebase
PRs the Commit Queue should land as multiple self-contained commits.
label
Aug 2, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 2, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
@panva
panva
requested a review
from aduh95August 2, 2026 14:31
@nodejs-github-botnodejs-github-bot
added

crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Aug 2, 2026
@panvapanva
added

test
Issues and PRs related to Node.js core tests and test infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 2, 2026
aduh95
aduh95
reviewed
Aug 2, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@github-actions

This comment was marked as outdated.

Sign in to view

2 similar comments

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247634 247635 +1 Branches 46687 46680 -7 =======================================
+ Hits 223623 223635 +12 - Misses 15462 15465 +3 + Partials 8549 8535 -14 
Files with missing linesCoverage Δ
lib/internal/crypto/webcrypto.js97.81% <100.00%> (+<0.01%)⬆️
... and 28 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
panvaforce-pushed
the
actions-fips
branch
2 times, most recently
from
68ba143 to
5699e8dCompareAugust 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Sign in to view
aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@panvapanva
mentioned this pull request
Aug 4, 2026
 Merged

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

panva
added 2 commits
August 4, 2026 20:11
@panva
test: update tests to run with OpenSSL >= 3.0 FIPS mode
d199954
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
tools: add an OpenSSL FIPS build to test-shared.yml
00f6176
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
aduh95
aduh95
approved these changes
Aug 4, 2026
View reviewed changes
@aduh95aduh95
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green
@panva
panva
commented
Aug 4, 2026

Copy link


Copy Markdown

MemberAuthor
LGTM if CI is green
Thank you for your help
@github-actions
github-actionsBot
commented
Aug 4, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux455 -> 459 => +44 / 459 = 0.8%
aarch64-linux456 -> 460 => +44 / 460 = 0.8%
x86_64-darwin393 -> 396 => +33 / 396 = 0.7%
aarch64-darwin398 -> 401 => +33 / 401 = 0.7%
Total1702 -> 1716 => +1414 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)
@panvapanva
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75520/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Landed in b79dcdf...dc7838c
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
test: update tests to run with OpenSSL >= 3.0 FIPS mode
45550ee
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
tools: add an OpenSSL FIPS build to test-shared.yml
dc7838c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@panva
panva
deleted the

actions-fips

branch
August 5, 2026 16:19
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
5bc6133
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
732c48b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
christama
christama
reviewed
Aug 21, 2026
View reviewed changes
@christamachristama
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
0e1a99a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
fd7e904
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@aduh95aduh95
added
the 
backported-to-v24.x
PRs backported to the v24.x-staging branch.
label
Aug 27, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@avivkelleravivkelleravivkeller approved these changes

+1 more reviewer

@christamachristamachristama left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.backported-to-v24.xPRs backported to the v24.x-staging branch.commit-queue-rebasePRs the Commit Queue should land as multiple self-contained commits.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled


5 participants

@panva@nodejs-github-bot@aduh95@avivkeller@christama

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960
Closed
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Closed
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Conversation
@panva
@panvapanva
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).
Closes: #48379
@panvapanva
added
the 
commit-queue-rebase
PRs the Commit Queue should land as multiple self-contained commits.
label
Aug 2, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 2, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
@panva
panva
requested a review
from aduh95August 2, 2026 14:31
@nodejs-github-botnodejs-github-bot
added

crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Aug 2, 2026
@panvapanva
added

test
Issues and PRs related to Node.js core tests and test infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 2, 2026
aduh95
aduh95
reviewed
Aug 2, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@github-actions

This comment was marked as outdated.

Sign in to view

2 similar comments

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247634 247635 +1 Branches 46687 46680 -7 =======================================
+ Hits 223623 223635 +12 - Misses 15462 15465 +3 + Partials 8549 8535 -14 
Files with missing linesCoverage Δ
lib/internal/crypto/webcrypto.js97.81% <100.00%> (+<0.01%)⬆️
... and 28 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
panvaforce-pushed
the
actions-fips
branch
2 times, most recently
from
68ba143 to
5699e8dCompareAugust 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Sign in to view
aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@panvapanva
mentioned this pull request
Aug 4, 2026
 Merged

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

panva
added 2 commits
August 4, 2026 20:11
@panva
test: update tests to run with OpenSSL >= 3.0 FIPS mode
d199954
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
tools: add an OpenSSL FIPS build to test-shared.yml
00f6176
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
aduh95
aduh95
approved these changes
Aug 4, 2026
View reviewed changes
@aduh95aduh95
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green
@panva
panva
commented
Aug 4, 2026

Copy link


Copy Markdown

MemberAuthor
LGTM if CI is green
Thank you for your help
@github-actions
github-actionsBot
commented
Aug 4, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux455 -> 459 => +44 / 459 = 0.8%
aarch64-linux456 -> 460 => +44 / 460 = 0.8%
x86_64-darwin393 -> 396 => +33 / 396 = 0.7%
aarch64-darwin398 -> 401 => +33 / 401 = 0.7%
Total1702 -> 1716 => +1414 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)
@panvapanva
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75520/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Landed in b79dcdf...dc7838c
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
test: update tests to run with OpenSSL >= 3.0 FIPS mode
45550ee
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
tools: add an OpenSSL FIPS build to test-shared.yml
dc7838c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@panva
panva
deleted the

actions-fips

branch
August 5, 2026 16:19
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
5bc6133
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
732c48b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
christama
christama
reviewed
Aug 21, 2026
View reviewed changes
@christamachristama
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
0e1a99a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
fd7e904
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@aduh95aduh95
added
the 
backported-to-v24.x
PRs backported to the v24.x-staging branch.
label
Aug 27, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@avivkelleravivkelleravivkeller approved these changes

+1 more reviewer

@christamachristamachristama left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.backported-to-v24.xPRs backported to the v24.x-staging branch.commit-queue-rebasePRs the Commit Queue should land as multiple self-contained commits.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled


5 participants

@panva@nodejs-github-bot@aduh95@avivkeller@christama

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960
Closed
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Closed
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Conversation
@panva
@panvapanva
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).
Closes: #48379
@panvapanva
added
the 
commit-queue-rebase
PRs the Commit Queue should land as multiple self-contained commits.
label
Aug 2, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 2, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
@panva
panva
requested a review
from aduh95August 2, 2026 14:31
@nodejs-github-botnodejs-github-bot
added

crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Aug 2, 2026
@panvapanva
added

test
Issues and PRs related to Node.js core tests and test infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 2, 2026
aduh95
aduh95
reviewed
Aug 2, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@github-actions

This comment was marked as outdated.

Sign in to view

2 similar comments

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247634 247635 +1 Branches 46687 46680 -7 =======================================
+ Hits 223623 223635 +12 - Misses 15462 15465 +3 + Partials 8549 8535 -14 
Files with missing linesCoverage Δ
lib/internal/crypto/webcrypto.js97.81% <100.00%> (+<0.01%)⬆️
... and 28 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
panvaforce-pushed
the
actions-fips
branch
2 times, most recently
from
68ba143 to
5699e8dCompareAugust 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Sign in to view
aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@panvapanva
mentioned this pull request
Aug 4, 2026
 Merged

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

panva
added 2 commits
August 4, 2026 20:11
@panva
test: update tests to run with OpenSSL >= 3.0 FIPS mode
d199954
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
tools: add an OpenSSL FIPS build to test-shared.yml
00f6176
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
aduh95
aduh95
approved these changes
Aug 4, 2026
View reviewed changes
@aduh95aduh95
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green
@panva
panva
commented
Aug 4, 2026

Copy link


Copy Markdown

MemberAuthor
LGTM if CI is green
Thank you for your help
@github-actions
github-actionsBot
commented
Aug 4, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux455 -> 459 => +44 / 459 = 0.8%
aarch64-linux456 -> 460 => +44 / 460 = 0.8%
x86_64-darwin393 -> 396 => +33 / 396 = 0.7%
aarch64-darwin398 -> 401 => +33 / 401 = 0.7%
Total1702 -> 1716 => +1414 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)
@panvapanva
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75520/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Landed in b79dcdf...dc7838c
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
test: update tests to run with OpenSSL >= 3.0 FIPS mode
45550ee
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
tools: add an OpenSSL FIPS build to test-shared.yml
dc7838c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@panva
panva
deleted the

actions-fips

branch
August 5, 2026 16:19
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
5bc6133
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
732c48b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
christama
christama
reviewed
Aug 21, 2026
View reviewed changes
@christamachristama
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
0e1a99a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
fd7e904
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@aduh95aduh95
added
the 
backported-to-v24.x
PRs backported to the v24.x-staging branch.
label
Aug 27, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@avivkelleravivkelleravivkeller approved these changes

+1 more reviewer

@christamachristamachristama left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.backported-to-v24.xPRs backported to the v24.x-staging branch.commit-queue-rebasePRs the Commit Queue should land as multiple self-contained commits.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled


5 participants

@panva@nodejs-github-bot@aduh95@avivkeller@christama

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960
Closed
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Closed
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Conversation
@panva
@panvapanva
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).
Closes: #48379
@panvapanva
added
the 
commit-queue-rebase
PRs the Commit Queue should land as multiple self-contained commits.
label
Aug 2, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 2, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
@panva
panva
requested a review
from aduh95August 2, 2026 14:31
@nodejs-github-botnodejs-github-bot
added

crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Aug 2, 2026
@panvapanva
added

test
Issues and PRs related to Node.js core tests and test infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 2, 2026
aduh95
aduh95
reviewed
Aug 2, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@github-actions

This comment was marked as outdated.

Sign in to view

2 similar comments

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247634 247635 +1 Branches 46687 46680 -7 =======================================
+ Hits 223623 223635 +12 - Misses 15462 15465 +3 + Partials 8549 8535 -14 
Files with missing linesCoverage Δ
lib/internal/crypto/webcrypto.js97.81% <100.00%> (+<0.01%)⬆️
... and 28 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
panvaforce-pushed
the
actions-fips
branch
2 times, most recently
from
68ba143 to
5699e8dCompareAugust 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Sign in to view
aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@panvapanva
mentioned this pull request
Aug 4, 2026
 Merged

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

panva
added 2 commits
August 4, 2026 20:11
@panva
test: update tests to run with OpenSSL >= 3.0 FIPS mode
d199954
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
tools: add an OpenSSL FIPS build to test-shared.yml
00f6176
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
aduh95
aduh95
approved these changes
Aug 4, 2026
View reviewed changes
@aduh95aduh95
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green
@panva
panva
commented
Aug 4, 2026

Copy link


Copy Markdown

MemberAuthor
LGTM if CI is green
Thank you for your help
@github-actions
github-actionsBot
commented
Aug 4, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux455 -> 459 => +44 / 459 = 0.8%
aarch64-linux456 -> 460 => +44 / 460 = 0.8%
x86_64-darwin393 -> 396 => +33 / 396 = 0.7%
aarch64-darwin398 -> 401 => +33 / 401 = 0.7%
Total1702 -> 1716 => +1414 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)
@panvapanva
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75520/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Landed in b79dcdf...dc7838c
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
test: update tests to run with OpenSSL >= 3.0 FIPS mode
45550ee
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
tools: add an OpenSSL FIPS build to test-shared.yml
dc7838c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@panva
panva
deleted the

actions-fips

branch
August 5, 2026 16:19
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
5bc6133
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
732c48b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
christama
christama
reviewed
Aug 21, 2026
View reviewed changes
@christamachristama
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
0e1a99a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
fd7e904
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@aduh95aduh95
added
the 
backported-to-v24.x
PRs backported to the v24.x-staging branch.
label
Aug 27, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@avivkelleravivkelleravivkeller approved these changes

+1 more reviewer

@christamachristamachristama left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.backported-to-v24.xPRs backported to the v24.x-staging branch.commit-queue-rebasePRs the Commit Queue should land as multiple self-contained commits.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled


5 participants

@panva@nodejs-github-bot@aduh95@avivkeller@christama

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960
Closed
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Closed
test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 2 commits into
nodejs:mainfrom 
panva:actions-fips
Conversation
@panva
@panvapanva
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).
Closes: #48379
@panvapanva
added
the 
commit-queue-rebase
PRs the Commit Queue should land as multiple self-contained commits.
label
Aug 2, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 2, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/crypto
@panva
panva
requested a review
from aduh95August 2, 2026 14:31
@nodejs-github-botnodejs-github-bot
added

crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Aug 2, 2026
@panvapanva
added

test
Issues and PRs related to Node.js core tests and test infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 2, 2026
aduh95
aduh95
reviewed
Aug 2, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@github-actions

This comment was marked as outdated.

Sign in to view

2 similar comments

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov
codecovBot
commented
Aug 2, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.30%. Comparing base (2b350bb) to head (00f6176).
⚠️ Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64960 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247634 247635 +1 Branches 46687 46680 -7 =======================================
+ Hits 223623 223635 +12 - Misses 15462 15465 +3 + Partials 8549 8535 -14 
Files with missing linesCoverage Δ
lib/internal/crypto/webcrypto.js97.81% <100.00%> (+<0.01%)⬆️
... and 28 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@panva
panvaforce-pushed
the
actions-fips
branch
2 times, most recently
from
68ba143 to
5699e8dCompareAugust 3, 2026 12:39
@github-actions

This comment was marked as outdated.

Sign in to view
aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/dep_updaters/update-nixpkgs-pin.sh
Outdated

@panvapanva
mentioned this pull request
Aug 4, 2026
 Merged

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

aduh95
aduh95
reviewed
Aug 4, 2026
View reviewed changes
Comment threadtools/nix/openssl-fips.nix
Outdated

panva
added 2 commits
August 4, 2026 20:11
@panva
test: update tests to run with OpenSSL >= 3.0 FIPS mode
d199954
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
tools: add an OpenSSL FIPS build to test-shared.yml
00f6176
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
aduh95
aduh95
approved these changes
Aug 4, 2026
View reviewed changes
@aduh95aduh95
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green
@panva
panva
commented
Aug 4, 2026

Copy link


Copy Markdown

MemberAuthor
LGTM if CI is green
Thank you for your help
@github-actions
github-actionsBot
commented
Aug 4, 2026

Copy link


Copy Markdown

Contributor
PlatformNumber of requisitesProportion of new derivations
x86_64-linux455 -> 459 => +44 / 459 = 0.8%
aarch64-linux456 -> 460 => +44 / 460 = 0.8%
x86_64-darwin393 -> 396 => +33 / 396 = 0.7%
aarch64-darwin398 -> 401 => +33 / 401 = 0.7%
Total1702 -> 1716 => +1414 / 1716 = 0.8%
Changelog
@@ -1162,0 +1163,14 @@+/nix/store/6b1bwbb3mgkvg9kjwlmy93xcd87nvkf6-openssl-fips-3.5.7 (aarch64-darwin)+/nix/store/nfrpcvi082z2kk43iaszmd92gnwbp5f0-openssl-fips-3.5.7 (aarch64-linux)+/nix/store/2i2z4r6fqb7c3z5zcy0v1yd78jbsqnh1-openssl-fips-3.5.7 (x86_64-darwin)+/nix/store/s96qsmab0chq2jzkzkpgymcgja5vs5p1-openssl-fips-3.5.7 (x86_64-linux)+/nix/store/0p81kgh1639z8zr39m0zqs6zccqcsvh1-openssl-fips-3.5.7-bin (aarch64-darwin)+/nix/store/ynakvlsv8sr5lpv51m77vkn38kx3ppiw-openssl-fips-3.5.7-bin (aarch64-linux)+/nix/store/93kh06km5crk5m8z0kxl4r0ndrkrnfyd-openssl-fips-3.5.7-bin (x86_64-darwin)+/nix/store/aasmhsircg72s5d2y92cbd4qp1jvgj9q-openssl-fips-3.5.7-bin (x86_64-linux)+/nix/store/h28vwffb18m1l3fpdbr35qxhfpdn3nqh-openssl-fips-3.5.7-debug (aarch64-linux)+/nix/store/d40w9sl2fvmhlzlshizx0mhpp9s3hw67-openssl-fips-3.5.7-debug (x86_64-linux)+/nix/store/pifad21yfabgxw8pvs72yki3bgx2qdj2-openssl-fips-3.5.7-dev (aarch64-darwin)+/nix/store/kx2ba6zq4xwrpmnv1y2q6vn796m7fr50-openssl-fips-3.5.7-dev (aarch64-linux)+/nix/store/asqr3alb9nx3an2y3fafldlyzdsjlgld-openssl-fips-3.5.7-dev (x86_64-darwin)+/nix/store/3z0fq49q0lbx0gs8dnv80y3nnraa3r3l-openssl-fips-3.5.7-dev (x86_64-linux)
@panvapanva
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75520/
@panvapanva
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 5, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 5, 2026

Copy link


Copy Markdown

Collaborator
Landed in b79dcdf...dc7838c
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
test: update tests to run with OpenSSL >= 3.0 FIPS mode
45550ee
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 5, 2026
@panva@nodejs-github-bot
tools: add an OpenSSL FIPS build to test-shared.yml
dc7838c
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@panva
panva
deleted the

actions-fips

branch
August 5, 2026 16:19
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
5bc6133
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
732c48b
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
christama
christama
reviewed
Aug 21, 2026
View reviewed changes
@christamachristama
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crypto
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
tools: add an OpenSSL FIPS build to test-shared.yml
0e1a99a
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@panva@aduh95
test: update tests to run with OpenSSL >= 3.0 FIPS mode
fd7e904
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64960Fixes: #48379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

@aduh95aduh95
added
the 
backported-to-v24.x
PRs backported to the v24.x-staging branch.
label
Aug 27, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@avivkelleravivkelleravivkeller approved these changes

+1 more reviewer

@christamachristamachristama left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.backported-to-v24.xPRs backported to the v24.x-staging branch.commit-queue-rebasePRs the Commit Queue should land as multiple self-contained commits.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to Node.js core tests and test infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Test failures with FIPS enabled


5 participants

@panva@nodejs-github-bot@aduh95@avivkeller@christama