Uh oh!
There was an error while loading. Please reload this page.
http: cache maxHeaderPairs per header section - #64988
Open
GetThatCookie wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
commented
Aug 3, 2026
Collaborator
Review requested:
|
ronag
approved these changes
Aug 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #64988 +/- ##
==========================================
+ Coverage 90.27% 90.30% +0.02%
==========================================
Files 762 759 -3 Lines 247534 247635 +101 Branches 46694 46687 -7 ==========================================
+ Hits 223457 223617 +160 + Misses 15529 15469 -60 - Partials 8548 8549 +1
🚀 New features to boost your workflow:
|
pimterry
approved these changes
Aug 4, 2026
nodejs-github-bot
commented
Aug 4, 2026
Collaborator
GetThatCookieforce-pushed
the
pr64980_parser
branch
from
August 4, 2026 21:16
5c61338 to
ef24255Compare
This was referenced Aug 4, 2026
pimterry
commented
Aug 5, 2026
Member
@GetThatCookie why the force push? Can you explain why the implementation has changed and that test code was dropped? It's helpful to provide context for reviewers when substantially changing a PR like this. At a glance, it looks like this new code is just doing the same thing but in a more fragile less clear way, and with less testing? Presumably I'm missing something. |
GetThatCookieforce-pushed
the
pr64980_parser
branch
from
August 5, 2026 17:51
ef24255 to
818cae4CompareGetThatCookie
commented
Aug 5, 2026
Author
Sorry, I accidentally overwrote it with an older version. |
Signed-off-by: GetThatCookie <NimmenKeks@gmx.de>
GetThatCookieforce-pushed
the
pr64980_parser
branch
from
August 5, 2026 20:31
818cae4 to
246ebc2CompareGetThatCookie
commented
Aug 5, 2026
Author
Missing Signed-off-by trailer... |
pimterry
approved these changes
Aug 5, 2026
nodejs-github-bot
commented
Aug 6, 2026
Collaborator
nodejs-github-bot
commented
Aug 6, 2026
Collaborator
ronag
approved these changes
Aug 6, 2026
nodejs-github-bot
commented
Aug 6, 2026
Collaborator
nodejs-github-bot
commented
Aug 6, 2026
Collaborator
nodejs-github-bot
commented
Aug 6, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is one of four focused changes split out of #64980 following review
feedback.
The full context, rationale, related work, benchmarks, and validation details
are documented there.
The AI-assistance disclosure in #64980 applies to this split PR as well.