Skip to content

http: cache maxHeaderPairs per header section - #64988

Open
GetThatCookie wants to merge 1 commit into
nodejs:mainfrom
GetThatCookie:pr64980_parser
Open

http: cache maxHeaderPairs per header section#64988
GetThatCookie wants to merge 1 commit into
nodejs:mainfrom
GetThatCookie:pr64980_parser

Conversation

@GetThatCookie

Copy link
Copy Markdown

This PR is one of four focused changes split out of #64980 following review
feedback.

The full context, rationale, related work, benchmarks, and validation details
are documented there.

The AI-assistance disclosure in #64980 applies to this split PR as well.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
  • @nodejs/performance

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run. labels Aug 3, 2026
@codecov

codecovBot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (f00fb75) to head (246ebc2).
⚠️ Report is 68 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64988 +/- ##
==========================================
+ Coverage 90.27% 90.30% +0.02% 
==========================================
Files 762 759 -3 Lines 247534 247635 +101 Branches 46694 46687 -7 ==========================================
+ Hits 223457 223617 +160 + Misses 15529 15469 -60 - Partials 8548 8549 +1 
Files with missing linesCoverage Δ
src/node_http_parser.cc85.45% <100.00%> (+0.47%)⬆️

... and 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterrypimterry added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 4, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@pimterry

Copy link
Copy Markdown
Member

@GetThatCookie why the force push? Can you explain why the implementation has changed and that test code was dropped? It's helpful to provide context for reviewers when substantially changing a PR like this.

At a glance, it looks like this new code is just doing the same thing but in a more fragile less clear way, and with less testing? Presumably I'm missing something.

@GetThatCookie

Copy link
Copy Markdown
Author

Sorry, I accidentally overwrote it with an older version.

@gurgundaygurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: GetThatCookie <NimmenKeks@gmx.de>
@GetThatCookie

Copy link
Copy Markdown
Author

Missing Signed-off-by trailer...

@H4adH4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@ronag
ronag requested a review from mcollinaAugust 6, 2026 15:47
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.http_parserIssues and PRs related to the HTTP Parser dependency or the http_parser binding.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@GetThatCookie@nodejs-github-bot@pimterry@ronag@gurgunday@H4ad