sqlite: clear SQLTagStore bindings by mcollina · Pull Request #65041 · nodejs/node

mcollina · 2026-08-05T08:48:57Z

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.

nodejs-github-bot · 2026-08-05T08:49:02Z

Review requested:

@nodejs/sqlite

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>

codecov · 2026-08-05T11:23:46Z

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (41afbd3) to head (78f82ca).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247597 247586 -11 Branches 46679 46673 -6 =======================================
+ Hits 223591 223592 +1 + Misses 15469 15459 -10 + Partials 8537 8535 -2

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <ø> (ø)`
src/node_sqlite.cc	`80.74% <85.18%> (+0.21%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2026-08-05T22:59:03Z

+ uint32_t n_params = args.Length() - 1;
+ int param_count = sqlite3_bind_parameter_count(stmt->statement_);
+ if (param_count != static_cast<int>(n_params)) {
+ THROW_ERR_INVALID_ARG_VALUE(
+ env,
+ "SQLite parameters must be bound using template literal placeholders.");
+ return false;
+ }


nodejs-github-bot · 2026-08-06T01:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75547/

nodejs-github-bot · 2026-08-07T09:16:52Z

Landed in 8fc7341

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

mcollina · 2026-08-05T08:48:57Z

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.

nodejs-github-bot · 2026-08-05T08:49:02Z

Review requested:

@nodejs/sqlite

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>

codecov · 2026-08-05T11:23:46Z

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (41afbd3) to head (78f82ca).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247597 247586 -11 Branches 46679 46673 -6 =======================================
+ Hits 223591 223592 +1 + Misses 15469 15459 -10 + Partials 8537 8535 -2

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <ø> (ø)`
src/node_sqlite.cc	`80.74% <85.18%> (+0.21%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2026-08-05T22:59:03Z

+ uint32_t n_params = args.Length() - 1;
+ int param_count = sqlite3_bind_parameter_count(stmt->statement_);
+ if (param_count != static_cast<int>(n_params)) {
+ THROW_ERR_INVALID_ARG_VALUE(
+ env,
+ "SQLite parameters must be bound using template literal placeholders.");
+ return false;
+ }


nodejs-github-bot · 2026-08-06T01:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75547/

nodejs-github-bot · 2026-08-07T09:16:52Z

Landed in 8fc7341

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

mcollina · 2026-08-05T08:48:57Z

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.

nodejs-github-bot · 2026-08-05T08:49:02Z

Review requested:

@nodejs/sqlite

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>

codecov · 2026-08-05T11:23:46Z

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (41afbd3) to head (78f82ca).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247597 247586 -11 Branches 46679 46673 -6 =======================================
+ Hits 223591 223592 +1 + Misses 15469 15459 -10 + Partials 8537 8535 -2

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <ø> (ø)`
src/node_sqlite.cc	`80.74% <85.18%> (+0.21%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2026-08-05T22:59:03Z

+ uint32_t n_params = args.Length() - 1;
+ int param_count = sqlite3_bind_parameter_count(stmt->statement_);
+ if (param_count != static_cast<int>(n_params)) {
+ THROW_ERR_INVALID_ARG_VALUE(
+ env,
+ "SQLite parameters must be bound using template literal placeholders.");
+ return false;
+ }


nodejs-github-bot · 2026-08-06T01:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75547/

nodejs-github-bot · 2026-08-07T09:16:52Z

Landed in 8fc7341

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

mcollina · 2026-08-05T08:48:57Z

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.

nodejs-github-bot · 2026-08-05T08:49:02Z

Review requested:

@nodejs/sqlite

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>

codecov · 2026-08-05T11:23:46Z

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (41afbd3) to head (78f82ca).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247597 247586 -11 Branches 46679 46673 -6 =======================================
+ Hits 223591 223592 +1 + Misses 15469 15459 -10 + Partials 8537 8535 -2

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <ø> (ø)`
src/node_sqlite.cc	`80.74% <85.18%> (+0.21%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2026-08-05T22:59:03Z

+ uint32_t n_params = args.Length() - 1;
+ int param_count = sqlite3_bind_parameter_count(stmt->statement_);
+ if (param_count != static_cast<int>(n_params)) {
+ THROW_ERR_INVALID_ARG_VALUE(
+ env,
+ "SQLite parameters must be bound using template literal placeholders.");
+ return false;
+ }


nodejs-github-bot · 2026-08-06T01:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75547/

nodejs-github-bot · 2026-08-07T09:16:52Z

Landed in 8fc7341

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

mcollina · 2026-08-05T08:48:57Z

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.

nodejs-github-bot · 2026-08-05T08:49:02Z

Review requested:

@nodejs/sqlite

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>

codecov · 2026-08-05T11:23:46Z

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (41afbd3) to head (78f82ca).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247597 247586 -11 Branches 46679 46673 -6 =======================================
+ Hits 223591 223592 +1 + Misses 15469 15459 -10 + Partials 8537 8535 -2

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <ø> (ø)`
src/node_sqlite.cc	`80.74% <85.18%> (+0.21%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2026-08-05T22:59:03Z

+ uint32_t n_params = args.Length() - 1;
+ int param_count = sqlite3_bind_parameter_count(stmt->statement_);
+ if (param_count != static_cast<int>(n_params)) {
+ THROW_ERR_INVALID_ARG_VALUE(
+ env,
+ "SQLite parameters must be bound using template literal placeholders.");
+ return false;
+ }


nodejs-github-bot · 2026-08-06T01:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75547/

nodejs-github-bot · 2026-08-07T09:16:52Z

Landed in 8fc7341

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

mcollina · 2026-08-05T08:48:57Z

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.

nodejs-github-bot · 2026-08-05T08:49:02Z

Review requested:

@nodejs/sqlite

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>

codecov · 2026-08-05T11:23:46Z

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (41afbd3) to head (78f82ca).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247597 247586 -11 Branches 46679 46673 -6 =======================================
+ Hits 223591 223592 +1 + Misses 15469 15459 -10 + Partials 8537 8535 -2

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <ø> (ø)`
src/node_sqlite.cc	`80.74% <85.18%> (+0.21%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2026-08-05T22:59:03Z

+ uint32_t n_params = args.Length() - 1;
+ int param_count = sqlite3_bind_parameter_count(stmt->statement_);
+ if (param_count != static_cast<int>(n_params)) {
+ THROW_ERR_INVALID_ARG_VALUE(
+ env,
+ "SQLite parameters must be bound using template literal placeholders.");
+ return false;
+ }


nodejs-github-bot · 2026-08-06T01:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75547/

nodejs-github-bot · 2026-08-07T09:16:52Z

Landed in 8fc7341

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

mcollina · 2026-08-05T08:48:57Z

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.

nodejs-github-bot · 2026-08-05T08:49:02Z

Review requested:

@nodejs/sqlite

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>

codecov · 2026-08-05T11:23:46Z

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (41afbd3) to head (78f82ca).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247597 247586 -11 Branches 46679 46673 -6 =======================================
+ Hits 223591 223592 +1 + Misses 15469 15459 -10 + Partials 8537 8535 -2

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <ø> (ø)`
src/node_sqlite.cc	`80.74% <85.18%> (+0.21%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2026-08-05T22:59:03Z

+ uint32_t n_params = args.Length() - 1;
+ int param_count = sqlite3_bind_parameter_count(stmt->statement_);
+ if (param_count != static_cast<int>(n_params)) {
+ THROW_ERR_INVALID_ARG_VALUE(
+ env,
+ "SQLite parameters must be bound using template literal placeholders.");
+ return false;
+ }


nodejs-github-bot · 2026-08-06T01:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75547/

nodejs-github-bot · 2026-08-07T09:16:52Z

Landed in 8fc7341

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

mcollina · 2026-08-05T08:48:57Z

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions.

nodejs-github-bot · 2026-08-05T08:49:02Z

Review requested:

@nodejs/sqlite

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com>

codecov · 2026-08-05T11:23:46Z

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (41afbd3) to head (78f82ca).
⚠️ Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.18%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65041 +/- ##
=======================================
Coverage 90.30% 90.30% =======================================
Files 759 759 Lines 247597 247586 -11 Branches 46679 46673 -6 =======================================
+ Hits 223591 223592 +1 + Misses 15469 15459 -10 + Partials 8537 8535 -2

Files with missing lines	Coverage Δ
src/node_sqlite.h	`82.60% <ø> (ø)`
src/node_sqlite.cc	`80.74% <85.18%> (+0.21%)`	⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334 · 2026-08-05T22:59:03Z

+ uint32_t n_params = args.Length() - 1;
+ int param_count = sqlite3_bind_parameter_count(stmt->statement_);
+ if (param_count != static_cast<int>(n_params)) {
+ THROW_ERR_INVALID_ARG_VALUE(
+ env,
+ "SQLite parameters must be bound using template literal placeholders.");
+ return false;
+ }


nodejs-github-bot · 2026-08-06T01:22:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75547/

nodejs-github-bot · 2026-08-07T09:16:52Z

Landed in 8fc7341

SQLTagStore reused cached statements without clearing values bound by a previous execution. Clear bindings before binding new values and reject parameters that do not correspond to template substitutions. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65041 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Aug 5, 2026

mcollina force-pushed the fix-sqlite-tagstore-bindings branch from 35ab44c to 78f82caCompare August 5, 2026 09:41

mcollina requested review from Qard, Renegade334, aduh95 and trivikr August 5, 2026 15:55

Renegade334 approved these changes Aug 5, 2026
View reviewed changes

trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026

trivikr approved these changes Aug 6, 2026
View reviewed changes

trivikr added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 6, 2026

mcollina added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 6, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 7, 2026

nodejs-github-bot merged commit 8fc7341 into nodejs:mainAug 7, 2026
78 checks passed

TrevorBurnham mentioned this pull request Aug 8, 2026
sqlite: segfault when a SQLTagStore query contains only a comment #65149
Closed

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged