util: keep function name for mapped call sites

[lazerg]

When getCallSites({ sourceMap: true }) remaps a frame, reconstructCallSite() uses entry.name ?? ''. The names array is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us and functionName comes back empty.

Fall back to the generated call site's functionName instead, which is what the source-mapped stack trace formatter in lib/internal/source_map/prepare_stack_trace.js already does.

Fixes: #65104

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (e2d7b34) to head (60488c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31% =======================================
Files 759 759 Lines 248290 248290 Branches 46859 46853 -6 =======================================
Hits 224241 224241 + Misses 15472 15470 -2 - Partials 8577 8579 +2 

Files with missing lines	Coverage Δ
lib/util.js	100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lazerg]

The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR.

[lazerg]

Closing this since #65104 was fixed by #65108, which was merged. This PR is no longer needed.

[lazerg]

When getCallSites({ sourceMap: true }) remaps a frame, reconstructCallSite() uses entry.name ?? ''. The names array is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us and functionName comes back empty.

Fall back to the generated call site's functionName instead, which is what the source-mapped stack trace formatter in lib/internal/source_map/prepare_stack_trace.js already does.

Fixes: #65104

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (e2d7b34) to head (60488c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31% =======================================
Files 759 759 Lines 248290 248290 Branches 46859 46853 -6 =======================================
Hits 224241 224241 + Misses 15472 15470 -2 - Partials 8577 8579 +2 

Files with missing lines	Coverage Δ
lib/util.js	100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lazerg]

The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR.

[lazerg]

Closing this since #65104 was fixed by #65108, which was merged. This PR is no longer needed.

[lazerg]

When getCallSites({ sourceMap: true }) remaps a frame, reconstructCallSite() uses entry.name ?? ''. The names array is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us and functionName comes back empty.

Fall back to the generated call site's functionName instead, which is what the source-mapped stack trace formatter in lib/internal/source_map/prepare_stack_trace.js already does.

Fixes: #65104

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (e2d7b34) to head (60488c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31% =======================================
Files 759 759 Lines 248290 248290 Branches 46859 46853 -6 =======================================
Hits 224241 224241 + Misses 15472 15470 -2 - Partials 8577 8579 +2 

Files with missing lines	Coverage Δ
lib/util.js	100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lazerg]

The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR.

[lazerg]

Closing this since #65104 was fixed by #65108, which was merged. This PR is no longer needed.

[lazerg]

When getCallSites({ sourceMap: true }) remaps a frame, reconstructCallSite() uses entry.name ?? ''. The names array is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us and functionName comes back empty.

Fall back to the generated call site's functionName instead, which is what the source-mapped stack trace formatter in lib/internal/source_map/prepare_stack_trace.js already does.

Fixes: #65104

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (e2d7b34) to head (60488c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31% =======================================
Files 759 759 Lines 248290 248290 Branches 46859 46853 -6 =======================================
Hits 224241 224241 + Misses 15472 15470 -2 - Partials 8577 8579 +2 

Files with missing lines	Coverage Δ
lib/util.js	100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lazerg]

The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR.

[lazerg]

Closing this since #65104 was fixed by #65108, which was merged. This PR is no longer needed.

[lazerg]

When getCallSites({ sourceMap: true }) remaps a frame, reconstructCallSite() uses entry.name ?? ''. The names array is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us and functionName comes back empty.

Fall back to the generated call site's functionName instead, which is what the source-mapped stack trace formatter in lib/internal/source_map/prepare_stack_trace.js already does.

Fixes: #65104

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (e2d7b34) to head (60488c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31% =======================================
Files 759 759 Lines 248290 248290 Branches 46859 46853 -6 =======================================
Hits 224241 224241 + Misses 15472 15470 -2 - Partials 8577 8579 +2 

Files with missing lines	Coverage Δ
lib/util.js	100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lazerg]

The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR.

[lazerg]

Closing this since #65104 was fixed by #65108, which was merged. This PR is no longer needed.

[lazerg]

When getCallSites({ sourceMap: true }) remaps a frame, reconstructCallSite() uses entry.name ?? ''. The names array is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us and functionName comes back empty.

Fall back to the generated call site's functionName instead, which is what the source-mapped stack trace formatter in lib/internal/source_map/prepare_stack_trace.js already does.

Fixes: #65104

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (e2d7b34) to head (60488c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31% =======================================
Files 759 759 Lines 248290 248290 Branches 46859 46853 -6 =======================================
Hits 224241 224241 + Misses 15472 15470 -2 - Partials 8577 8579 +2 

Files with missing lines	Coverage Δ
lib/util.js	100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lazerg]

The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR.

[lazerg]

Closing this since #65104 was fixed by #65108, which was merged. This PR is no longer needed.

[lazerg]

When getCallSites({ sourceMap: true }) remaps a frame, reconstructCallSite() uses entry.name ?? ''. The names array is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us and functionName comes back empty.

Fall back to the generated call site's functionName instead, which is what the source-mapped stack trace formatter in lib/internal/source_map/prepare_stack_trace.js already does.

Fixes: #65104

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (e2d7b34) to head (60488c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31% =======================================
Files 759 759 Lines 248290 248290 Branches 46859 46853 -6 =======================================
Hits 224241 224241 + Misses 15472 15470 -2 - Partials 8577 8579 +2 

Files with missing lines	Coverage Δ
lib/util.js	100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lazerg]

The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR.

[lazerg]

Closing this since #65104 was fixed by #65108, which was merged. This PR is no longer needed.

[lazerg]

When getCallSites({ sourceMap: true }) remaps a frame, reconstructCallSite() uses entry.name ?? ''. The names array is optional in Source Map v3, so a map without a name for that position wipes out the function name V8 already gave us and functionName comes back empty.

Fall back to the generated call site's functionName instead, which is what the source-mapped stack trace formatter in lib/internal/source_map/prepare_stack_trace.js already does.

Fixes: #65104

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (e2d7b34) to head (60488c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65107 +/- ##
=======================================
Coverage 90.31% 90.31% =======================================
Files 759 759 Lines 248290 248290 Branches 46859 46853 -6 =======================================
Hits 224241 224241 + Misses 15472 15470 -2 - Partials 8577 8579 +2 

Files with missing lines	Coverage Δ
lib/util.js	100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lazerg]

The test-macOS failure is in test-stream-pipeline-http2 and test-debugger-exceptions. Both time out, both pass locally, and neither touches the code in this PR.

[lazerg]

Closing this since #65104 was fixed by #65108, which was merged. This PR is no longer needed.