Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions deps/uv/src/win/fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,13 +63,17 @@ static void uv__fs_event_queue_readdirchanges(uv_loop_t* loop,
handle->req_pending = 1;
}

static void uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
/* Compute the path of `filename` relative to the watched directory `dir`.
* Returns 0 on success, -1 if `filename` is not actually prefixed by `dir`,
* which can happen if the directory is a short path. */
static int uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
size_t relpathlen;
size_t filenamelen = wcslen(filename);
size_t dirlen = wcslen(dir);
assert(!_wcsnicmp(filename, dir, dirlen));
if (filenamelen <= dirlen || _wcsnicmp(filename, dir, dirlen) != 0)
return -1;
if (dirlen > 0 && dir[dirlen - 1] == '\\')
dirlen--;
relpathlen = filenamelen - dirlen - 1;
Expand All@@ -78,6 +82,7 @@ static void uv__relative_path(const WCHAR* filename,
uv_fatal_error(ERROR_OUTOFMEMORY, "uv__malloc");
wcsncpy(*relpath, filename + dirlen + 1, relpathlen);
(*relpath)[relpathlen] = L'\0';
return 0;
}

static int uv__split_path(const WCHAR* filename, WCHAR** dir,
Expand DownExpand Up@@ -517,12 +522,21 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,

if (long_filenamew) {
/* Get the file name out of the long path. */
uv__relative_path(long_filenamew,
handle->dirw,
&filenamew);
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
if (uv__relative_path(long_filenamew,
handle->dirw,
&filenamew) == 0) {
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
} else {
/* The resolved long path was not prefixed by the watched
* directory (e.g. short name vs long name mismatch),
* fall back to the name given by ReadDirectoryChangesW. */
uv__free(long_filenamew);
long_filenamew = NULL;
filenamew = file_info->FileName;
sizew = file_info->FileNameLength / sizeof(WCHAR);
}
} else {
/* We couldn't get the long filename, use the one reported. */
filenamew = file_info->FileName;
Expand Down
108 changes: 91 additions & 17 deletions deps/uv/test/test-fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -587,45 +587,119 @@ TEST_IMPL(fs_event_watch_dir_recursive) {
}

#ifdef _WIN32
static char short_path_file[MAX_PATH];

static void short_path_timer_cb(uv_timer_t* handle) {
++timer_cb_called;
touch_file(short_path_file);
}

/* Try to create a unique watch directory that has a 8.3 short component
under `parent` ("" means the cwd). If it's successful, fills `watch_dir`
and `short_dir` with the long and short forms of the created directory
respectively, and returns 1. Otherwise removes the directory created
and returns 0. */
static int short_path_make(const char* parent,
char* watch_dir, size_t watch_n,
char* short_dir, size_t short_n) {
uv_fs_t req;
char tmpl[MAX_PATH];
WCHAR watch_dirw[MAX_PATH];
WCHAR short_dirw[MAX_PATH];
WCHAR long_dirw[MAX_PATH];
size_t pathlen;
int r;

if (parent[0] != '\0')
r = snprintf(tmpl, sizeof(tmpl), "%s\\watch_dirXXXXXX", parent);
else
r = snprintf(tmpl, sizeof(tmpl), "watch_dirXXXXXX");
if (r < 0 || (size_t) r >= sizeof(tmpl))
return 0;

r = uv_fs_mkdtemp(NULL, &req, tmpl, NULL);
if (r != 0) {
uv_fs_req_cleanup(&req);
return 0;
}

/* Copy the created path out before cleaning up the request that owns it. */
pathlen = strlen(req.path);
memcpy(watch_dir, req.path, pathlen + 1);
uv_fs_req_cleanup(&req);

/* The caller appends "\\file1" to both watch_dir and short_dir. If there is
no room for that suffix, skip this location. */
if (pathlen + sizeof("\\file1") <= watch_n &&
MultiByteToWideChar(CP_UTF8, 0, watch_dir, -1,
watch_dirw, ARRAY_SIZE(watch_dirw)) != 0 &&
GetShortPathNameW(watch_dirw, short_dirw, ARRAY_SIZE(short_dirw)) != 0 &&
GetLongPathNameW(watch_dirw, long_dirw, ARRAY_SIZE(long_dirw)) != 0 &&
_wcsicmp(short_dirw, long_dirw) != 0 &&
WideCharToMultiByte(CP_UTF8, 0, short_dirw, -1,
short_dir, (int) short_n, NULL, NULL) != 0)
return 1;

uv_fs_rmdir(NULL, &req, watch_dir, NULL);
uv_fs_req_cleanup(&req);
return 0;
}

TEST_IMPL(fs_event_watch_dir_short_path) {
uv_loop_t* loop;
uv_fs_t req;
char temp_path[MAX_PATH];
char watch_dir[MAX_PATH];
char watch_file[MAX_PATH];
char short_dir[MAX_PATH];
size_t temp_len;
int has_shortnames;
int r;

/* Setup */
loop = uv_default_loop();
delete_file("watch_dir/file1");
delete_dir("watch_dir/");
create_dir("watch_dir");
create_file("watch_dir/file1");

/* Newer version of Windows ship with
HKLM\SYSTEM\CurrentControlSet\Control\FileSystem\NtfsDisable8dot3NameCreation
not equal to 0. So we verify the files we created are addressable by a 8.3
short name */
has_shortnames = uv_fs_stat(NULL, &req, "watch_~1", NULL) != UV_ENOENT;
/* This test needs the watched directory to have an 8.3 short component. The
generated "watch_dirXXXXXX" name is > 8 chars, so it gets a short alias on
volumes where 8.3 name creation is enabled. For non-system volumes on
newer Windows it's disabled by default (NtfsDisable8dot3NameCreation=3).
The temp dir and the cwd may be on different volumes, so try each and use
whichever has a short alias, and skip if neither does. */
has_shortnames = 0;
temp_len = sizeof(temp_path);
if (uv_os_tmpdir(temp_path, &temp_len) == 0)
has_shortnames = short_path_make(temp_path,
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));
if (!has_shortnames)
has_shortnames = short_path_make("",
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));

if (has_shortnames) {
snprintf(watch_file, sizeof(watch_file), "%s\\file1", watch_dir);
/* short_path_file is used in the timer callback to touch the file. */
snprintf(short_path_file, sizeof(short_path_file), "%s\\file1", short_dir);
/* The directory was just created, so file1 cannot exist yet. */
create_file(watch_file);

r = uv_fs_event_init(loop, &fs_event);
ASSERT_OK(r);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, "watch_~1", 0);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, short_dir, 0);
ASSERT_OK(r);
r = uv_timer_init(loop, &timer);
ASSERT_OK(r);
r = uv_timer_start(&timer, timer_cb_file, 100, 0);
r = uv_timer_start(&timer, short_path_timer_cb, 100, 0);
ASSERT_OK(r);

uv_run(loop, UV_RUN_DEFAULT);

ASSERT_EQ(1, fs_event_cb_called);
ASSERT_EQ(1, timer_cb_called);
ASSERT_EQ(1, close_cb_called);
/* Cleanup */
delete_file(watch_file);
delete_dir(watch_dir);
}

/* Cleanup */
delete_file("watch_dir/file1");
delete_dir("watch_dir/");

MAKE_VALGRIND_HAPPY(loop);

if (!has_shortnames)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions deps/uv/src/win/fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,13 +63,17 @@ static void uv__fs_event_queue_readdirchanges(uv_loop_t* loop,
handle->req_pending = 1;
}

static void uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
/* Compute the path of `filename` relative to the watched directory `dir`.
* Returns 0 on success, -1 if `filename` is not actually prefixed by `dir`,
* which can happen if the directory is a short path. */
static int uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
size_t relpathlen;
size_t filenamelen = wcslen(filename);
size_t dirlen = wcslen(dir);
assert(!_wcsnicmp(filename, dir, dirlen));
if (filenamelen <= dirlen || _wcsnicmp(filename, dir, dirlen) != 0)
return -1;
if (dirlen > 0 && dir[dirlen - 1] == '\\')
dirlen--;
relpathlen = filenamelen - dirlen - 1;
Expand All@@ -78,6 +82,7 @@ static void uv__relative_path(const WCHAR* filename,
uv_fatal_error(ERROR_OUTOFMEMORY, "uv__malloc");
wcsncpy(*relpath, filename + dirlen + 1, relpathlen);
(*relpath)[relpathlen] = L'\0';
return 0;
}

static int uv__split_path(const WCHAR* filename, WCHAR** dir,
Expand DownExpand Up@@ -517,12 +522,21 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,

if (long_filenamew) {
/* Get the file name out of the long path. */
uv__relative_path(long_filenamew,
handle->dirw,
&filenamew);
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
if (uv__relative_path(long_filenamew,
handle->dirw,
&filenamew) == 0) {
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
} else {
/* The resolved long path was not prefixed by the watched
* directory (e.g. short name vs long name mismatch),
* fall back to the name given by ReadDirectoryChangesW. */
uv__free(long_filenamew);
long_filenamew = NULL;
filenamew = file_info->FileName;
sizew = file_info->FileNameLength / sizeof(WCHAR);
}
} else {
/* We couldn't get the long filename, use the one reported. */
filenamew = file_info->FileName;
Expand Down
108 changes: 91 additions & 17 deletions deps/uv/test/test-fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -587,45 +587,119 @@ TEST_IMPL(fs_event_watch_dir_recursive) {
}

#ifdef _WIN32
static char short_path_file[MAX_PATH];

static void short_path_timer_cb(uv_timer_t* handle) {
++timer_cb_called;
touch_file(short_path_file);
}

/* Try to create a unique watch directory that has a 8.3 short component
under `parent` ("" means the cwd). If it's successful, fills `watch_dir`
and `short_dir` with the long and short forms of the created directory
respectively, and returns 1. Otherwise removes the directory created
and returns 0. */
static int short_path_make(const char* parent,
char* watch_dir, size_t watch_n,
char* short_dir, size_t short_n) {
uv_fs_t req;
char tmpl[MAX_PATH];
WCHAR watch_dirw[MAX_PATH];
WCHAR short_dirw[MAX_PATH];
WCHAR long_dirw[MAX_PATH];
size_t pathlen;
int r;

if (parent[0] != '\0')
r = snprintf(tmpl, sizeof(tmpl), "%s\\watch_dirXXXXXX", parent);
else
r = snprintf(tmpl, sizeof(tmpl), "watch_dirXXXXXX");
if (r < 0 || (size_t) r >= sizeof(tmpl))
return 0;

r = uv_fs_mkdtemp(NULL, &req, tmpl, NULL);
if (r != 0) {
uv_fs_req_cleanup(&req);
return 0;
}

/* Copy the created path out before cleaning up the request that owns it. */
pathlen = strlen(req.path);
memcpy(watch_dir, req.path, pathlen + 1);
uv_fs_req_cleanup(&req);

/* The caller appends "\\file1" to both watch_dir and short_dir. If there is
no room for that suffix, skip this location. */
if (pathlen + sizeof("\\file1") <= watch_n &&
MultiByteToWideChar(CP_UTF8, 0, watch_dir, -1,
watch_dirw, ARRAY_SIZE(watch_dirw)) != 0 &&
GetShortPathNameW(watch_dirw, short_dirw, ARRAY_SIZE(short_dirw)) != 0 &&
GetLongPathNameW(watch_dirw, long_dirw, ARRAY_SIZE(long_dirw)) != 0 &&
_wcsicmp(short_dirw, long_dirw) != 0 &&
WideCharToMultiByte(CP_UTF8, 0, short_dirw, -1,
short_dir, (int) short_n, NULL, NULL) != 0)
return 1;

uv_fs_rmdir(NULL, &req, watch_dir, NULL);
uv_fs_req_cleanup(&req);
return 0;
}

TEST_IMPL(fs_event_watch_dir_short_path) {
uv_loop_t* loop;
uv_fs_t req;
char temp_path[MAX_PATH];
char watch_dir[MAX_PATH];
char watch_file[MAX_PATH];
char short_dir[MAX_PATH];
size_t temp_len;
int has_shortnames;
int r;

/* Setup */
loop = uv_default_loop();
delete_file("watch_dir/file1");
delete_dir("watch_dir/");
create_dir("watch_dir");
create_file("watch_dir/file1");

/* Newer version of Windows ship with
HKLM\SYSTEM\CurrentControlSet\Control\FileSystem\NtfsDisable8dot3NameCreation
not equal to 0. So we verify the files we created are addressable by a 8.3
short name */
has_shortnames = uv_fs_stat(NULL, &req, "watch_~1", NULL) != UV_ENOENT;
/* This test needs the watched directory to have an 8.3 short component. The
generated "watch_dirXXXXXX" name is > 8 chars, so it gets a short alias on
volumes where 8.3 name creation is enabled. For non-system volumes on
newer Windows it's disabled by default (NtfsDisable8dot3NameCreation=3).
The temp dir and the cwd may be on different volumes, so try each and use
whichever has a short alias, and skip if neither does. */
has_shortnames = 0;
temp_len = sizeof(temp_path);
if (uv_os_tmpdir(temp_path, &temp_len) == 0)
has_shortnames = short_path_make(temp_path,
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));
if (!has_shortnames)
has_shortnames = short_path_make("",
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));

if (has_shortnames) {
snprintf(watch_file, sizeof(watch_file), "%s\\file1", watch_dir);
/* short_path_file is used in the timer callback to touch the file. */
snprintf(short_path_file, sizeof(short_path_file), "%s\\file1", short_dir);
/* The directory was just created, so file1 cannot exist yet. */
create_file(watch_file);

r = uv_fs_event_init(loop, &fs_event);
ASSERT_OK(r);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, "watch_~1", 0);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, short_dir, 0);
ASSERT_OK(r);
r = uv_timer_init(loop, &timer);
ASSERT_OK(r);
r = uv_timer_start(&timer, timer_cb_file, 100, 0);
r = uv_timer_start(&timer, short_path_timer_cb, 100, 0);
ASSERT_OK(r);

uv_run(loop, UV_RUN_DEFAULT);

ASSERT_EQ(1, fs_event_cb_called);
ASSERT_EQ(1, timer_cb_called);
ASSERT_EQ(1, close_cb_called);
/* Cleanup */
delete_file(watch_file);
delete_dir(watch_dir);
}

/* Cleanup */
delete_file("watch_dir/file1");
delete_dir("watch_dir/");

MAKE_VALGRIND_HAPPY(loop);

if (!has_shortnames)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions deps/uv/src/win/fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,13 +63,17 @@ static void uv__fs_event_queue_readdirchanges(uv_loop_t* loop,
handle->req_pending = 1;
}

static void uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
/* Compute the path of `filename` relative to the watched directory `dir`.
* Returns 0 on success, -1 if `filename` is not actually prefixed by `dir`,
* which can happen if the directory is a short path. */
static int uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
size_t relpathlen;
size_t filenamelen = wcslen(filename);
size_t dirlen = wcslen(dir);
assert(!_wcsnicmp(filename, dir, dirlen));
if (filenamelen <= dirlen || _wcsnicmp(filename, dir, dirlen) != 0)
return -1;
if (dirlen > 0 && dir[dirlen - 1] == '\\')
dirlen--;
relpathlen = filenamelen - dirlen - 1;
Expand All@@ -78,6 +82,7 @@ static void uv__relative_path(const WCHAR* filename,
uv_fatal_error(ERROR_OUTOFMEMORY, "uv__malloc");
wcsncpy(*relpath, filename + dirlen + 1, relpathlen);
(*relpath)[relpathlen] = L'\0';
return 0;
}

static int uv__split_path(const WCHAR* filename, WCHAR** dir,
Expand DownExpand Up@@ -517,12 +522,21 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,

if (long_filenamew) {
/* Get the file name out of the long path. */
uv__relative_path(long_filenamew,
handle->dirw,
&filenamew);
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
if (uv__relative_path(long_filenamew,
handle->dirw,
&filenamew) == 0) {
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
} else {
/* The resolved long path was not prefixed by the watched
* directory (e.g. short name vs long name mismatch),
* fall back to the name given by ReadDirectoryChangesW. */
uv__free(long_filenamew);
long_filenamew = NULL;
filenamew = file_info->FileName;
sizew = file_info->FileNameLength / sizeof(WCHAR);
}
} else {
/* We couldn't get the long filename, use the one reported. */
filenamew = file_info->FileName;
Expand Down
108 changes: 91 additions & 17 deletions deps/uv/test/test-fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -587,45 +587,119 @@ TEST_IMPL(fs_event_watch_dir_recursive) {
}

#ifdef _WIN32
static char short_path_file[MAX_PATH];

static void short_path_timer_cb(uv_timer_t* handle) {
++timer_cb_called;
touch_file(short_path_file);
}

/* Try to create a unique watch directory that has a 8.3 short component
under `parent` ("" means the cwd). If it's successful, fills `watch_dir`
and `short_dir` with the long and short forms of the created directory
respectively, and returns 1. Otherwise removes the directory created
and returns 0. */
static int short_path_make(const char* parent,
char* watch_dir, size_t watch_n,
char* short_dir, size_t short_n) {
uv_fs_t req;
char tmpl[MAX_PATH];
WCHAR watch_dirw[MAX_PATH];
WCHAR short_dirw[MAX_PATH];
WCHAR long_dirw[MAX_PATH];
size_t pathlen;
int r;

if (parent[0] != '\0')
r = snprintf(tmpl, sizeof(tmpl), "%s\\watch_dirXXXXXX", parent);
else
r = snprintf(tmpl, sizeof(tmpl), "watch_dirXXXXXX");
if (r < 0 || (size_t) r >= sizeof(tmpl))
return 0;

r = uv_fs_mkdtemp(NULL, &req, tmpl, NULL);
if (r != 0) {
uv_fs_req_cleanup(&req);
return 0;
}

/* Copy the created path out before cleaning up the request that owns it. */
pathlen = strlen(req.path);
memcpy(watch_dir, req.path, pathlen + 1);
uv_fs_req_cleanup(&req);

/* The caller appends "\\file1" to both watch_dir and short_dir. If there is
no room for that suffix, skip this location. */
if (pathlen + sizeof("\\file1") <= watch_n &&
MultiByteToWideChar(CP_UTF8, 0, watch_dir, -1,
watch_dirw, ARRAY_SIZE(watch_dirw)) != 0 &&
GetShortPathNameW(watch_dirw, short_dirw, ARRAY_SIZE(short_dirw)) != 0 &&
GetLongPathNameW(watch_dirw, long_dirw, ARRAY_SIZE(long_dirw)) != 0 &&
_wcsicmp(short_dirw, long_dirw) != 0 &&
WideCharToMultiByte(CP_UTF8, 0, short_dirw, -1,
short_dir, (int) short_n, NULL, NULL) != 0)
return 1;

uv_fs_rmdir(NULL, &req, watch_dir, NULL);
uv_fs_req_cleanup(&req);
return 0;
}

TEST_IMPL(fs_event_watch_dir_short_path) {
uv_loop_t* loop;
uv_fs_t req;
char temp_path[MAX_PATH];
char watch_dir[MAX_PATH];
char watch_file[MAX_PATH];
char short_dir[MAX_PATH];
size_t temp_len;
int has_shortnames;
int r;

/* Setup */
loop = uv_default_loop();
delete_file("watch_dir/file1");
delete_dir("watch_dir/");
create_dir("watch_dir");
create_file("watch_dir/file1");

/* Newer version of Windows ship with
HKLM\SYSTEM\CurrentControlSet\Control\FileSystem\NtfsDisable8dot3NameCreation
not equal to 0. So we verify the files we created are addressable by a 8.3
short name */
has_shortnames = uv_fs_stat(NULL, &req, "watch_~1", NULL) != UV_ENOENT;
/* This test needs the watched directory to have an 8.3 short component. The
generated "watch_dirXXXXXX" name is > 8 chars, so it gets a short alias on
volumes where 8.3 name creation is enabled. For non-system volumes on
newer Windows it's disabled by default (NtfsDisable8dot3NameCreation=3).
The temp dir and the cwd may be on different volumes, so try each and use
whichever has a short alias, and skip if neither does. */
has_shortnames = 0;
temp_len = sizeof(temp_path);
if (uv_os_tmpdir(temp_path, &temp_len) == 0)
has_shortnames = short_path_make(temp_path,
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));
if (!has_shortnames)
has_shortnames = short_path_make("",
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));

if (has_shortnames) {
snprintf(watch_file, sizeof(watch_file), "%s\\file1", watch_dir);
/* short_path_file is used in the timer callback to touch the file. */
snprintf(short_path_file, sizeof(short_path_file), "%s\\file1", short_dir);
/* The directory was just created, so file1 cannot exist yet. */
create_file(watch_file);

r = uv_fs_event_init(loop, &fs_event);
ASSERT_OK(r);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, "watch_~1", 0);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, short_dir, 0);
ASSERT_OK(r);
r = uv_timer_init(loop, &timer);
ASSERT_OK(r);
r = uv_timer_start(&timer, timer_cb_file, 100, 0);
r = uv_timer_start(&timer, short_path_timer_cb, 100, 0);
ASSERT_OK(r);

uv_run(loop, UV_RUN_DEFAULT);

ASSERT_EQ(1, fs_event_cb_called);
ASSERT_EQ(1, timer_cb_called);
ASSERT_EQ(1, close_cb_called);
/* Cleanup */
delete_file(watch_file);
delete_dir(watch_dir);
}

/* Cleanup */
delete_file("watch_dir/file1");
delete_dir("watch_dir/");

MAKE_VALGRIND_HAPPY(loop);

if (!has_shortnames)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions deps/uv/src/win/fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,13 +63,17 @@ static void uv__fs_event_queue_readdirchanges(uv_loop_t* loop,
handle->req_pending = 1;
}

static void uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
/* Compute the path of `filename` relative to the watched directory `dir`.
* Returns 0 on success, -1 if `filename` is not actually prefixed by `dir`,
* which can happen if the directory is a short path. */
static int uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
size_t relpathlen;
size_t filenamelen = wcslen(filename);
size_t dirlen = wcslen(dir);
assert(!_wcsnicmp(filename, dir, dirlen));
if (filenamelen <= dirlen || _wcsnicmp(filename, dir, dirlen) != 0)
return -1;
if (dirlen > 0 && dir[dirlen - 1] == '\\')
dirlen--;
relpathlen = filenamelen - dirlen - 1;
Expand All@@ -78,6 +82,7 @@ static void uv__relative_path(const WCHAR* filename,
uv_fatal_error(ERROR_OUTOFMEMORY, "uv__malloc");
wcsncpy(*relpath, filename + dirlen + 1, relpathlen);
(*relpath)[relpathlen] = L'\0';
return 0;
}

static int uv__split_path(const WCHAR* filename, WCHAR** dir,
Expand DownExpand Up@@ -517,12 +522,21 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,

if (long_filenamew) {
/* Get the file name out of the long path. */
uv__relative_path(long_filenamew,
handle->dirw,
&filenamew);
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
if (uv__relative_path(long_filenamew,
handle->dirw,
&filenamew) == 0) {
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
} else {
/* The resolved long path was not prefixed by the watched
* directory (e.g. short name vs long name mismatch),
* fall back to the name given by ReadDirectoryChangesW. */
uv__free(long_filenamew);
long_filenamew = NULL;
filenamew = file_info->FileName;
sizew = file_info->FileNameLength / sizeof(WCHAR);
}
} else {
/* We couldn't get the long filename, use the one reported. */
filenamew = file_info->FileName;
Expand Down
108 changes: 91 additions & 17 deletions deps/uv/test/test-fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -587,45 +587,119 @@ TEST_IMPL(fs_event_watch_dir_recursive) {
}

#ifdef _WIN32
static char short_path_file[MAX_PATH];

static void short_path_timer_cb(uv_timer_t* handle) {
++timer_cb_called;
touch_file(short_path_file);
}

/* Try to create a unique watch directory that has a 8.3 short component
under `parent` ("" means the cwd). If it's successful, fills `watch_dir`
and `short_dir` with the long and short forms of the created directory
respectively, and returns 1. Otherwise removes the directory created
and returns 0. */
static int short_path_make(const char* parent,
char* watch_dir, size_t watch_n,
char* short_dir, size_t short_n) {
uv_fs_t req;
char tmpl[MAX_PATH];
WCHAR watch_dirw[MAX_PATH];
WCHAR short_dirw[MAX_PATH];
WCHAR long_dirw[MAX_PATH];
size_t pathlen;
int r;

if (parent[0] != '\0')
r = snprintf(tmpl, sizeof(tmpl), "%s\\watch_dirXXXXXX", parent);
else
r = snprintf(tmpl, sizeof(tmpl), "watch_dirXXXXXX");
if (r < 0 || (size_t) r >= sizeof(tmpl))
return 0;

r = uv_fs_mkdtemp(NULL, &req, tmpl, NULL);
if (r != 0) {
uv_fs_req_cleanup(&req);
return 0;
}

/* Copy the created path out before cleaning up the request that owns it. */
pathlen = strlen(req.path);
memcpy(watch_dir, req.path, pathlen + 1);
uv_fs_req_cleanup(&req);

/* The caller appends "\\file1" to both watch_dir and short_dir. If there is
no room for that suffix, skip this location. */
if (pathlen + sizeof("\\file1") <= watch_n &&
MultiByteToWideChar(CP_UTF8, 0, watch_dir, -1,
watch_dirw, ARRAY_SIZE(watch_dirw)) != 0 &&
GetShortPathNameW(watch_dirw, short_dirw, ARRAY_SIZE(short_dirw)) != 0 &&
GetLongPathNameW(watch_dirw, long_dirw, ARRAY_SIZE(long_dirw)) != 0 &&
_wcsicmp(short_dirw, long_dirw) != 0 &&
WideCharToMultiByte(CP_UTF8, 0, short_dirw, -1,
short_dir, (int) short_n, NULL, NULL) != 0)
return 1;

uv_fs_rmdir(NULL, &req, watch_dir, NULL);
uv_fs_req_cleanup(&req);
return 0;
}

TEST_IMPL(fs_event_watch_dir_short_path) {
uv_loop_t* loop;
uv_fs_t req;
char temp_path[MAX_PATH];
char watch_dir[MAX_PATH];
char watch_file[MAX_PATH];
char short_dir[MAX_PATH];
size_t temp_len;
int has_shortnames;
int r;

/* Setup */
loop = uv_default_loop();
delete_file("watch_dir/file1");
delete_dir("watch_dir/");
create_dir("watch_dir");
create_file("watch_dir/file1");

/* Newer version of Windows ship with
HKLM\SYSTEM\CurrentControlSet\Control\FileSystem\NtfsDisable8dot3NameCreation
not equal to 0. So we verify the files we created are addressable by a 8.3
short name */
has_shortnames = uv_fs_stat(NULL, &req, "watch_~1", NULL) != UV_ENOENT;
/* This test needs the watched directory to have an 8.3 short component. The
generated "watch_dirXXXXXX" name is > 8 chars, so it gets a short alias on
volumes where 8.3 name creation is enabled. For non-system volumes on
newer Windows it's disabled by default (NtfsDisable8dot3NameCreation=3).
The temp dir and the cwd may be on different volumes, so try each and use
whichever has a short alias, and skip if neither does. */
has_shortnames = 0;
temp_len = sizeof(temp_path);
if (uv_os_tmpdir(temp_path, &temp_len) == 0)
has_shortnames = short_path_make(temp_path,
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));
if (!has_shortnames)
has_shortnames = short_path_make("",
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));

if (has_shortnames) {
snprintf(watch_file, sizeof(watch_file), "%s\\file1", watch_dir);
/* short_path_file is used in the timer callback to touch the file. */
snprintf(short_path_file, sizeof(short_path_file), "%s\\file1", short_dir);
/* The directory was just created, so file1 cannot exist yet. */
create_file(watch_file);

r = uv_fs_event_init(loop, &fs_event);
ASSERT_OK(r);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, "watch_~1", 0);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, short_dir, 0);
ASSERT_OK(r);
r = uv_timer_init(loop, &timer);
ASSERT_OK(r);
r = uv_timer_start(&timer, timer_cb_file, 100, 0);
r = uv_timer_start(&timer, short_path_timer_cb, 100, 0);
ASSERT_OK(r);

uv_run(loop, UV_RUN_DEFAULT);

ASSERT_EQ(1, fs_event_cb_called);
ASSERT_EQ(1, timer_cb_called);
ASSERT_EQ(1, close_cb_called);
/* Cleanup */
delete_file(watch_file);
delete_dir(watch_dir);
}

/* Cleanup */
delete_file("watch_dir/file1");
delete_dir("watch_dir/");

MAKE_VALGRIND_HAPPY(loop);

if (!has_shortnames)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions deps/uv/src/win/fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,13 +63,17 @@ static void uv__fs_event_queue_readdirchanges(uv_loop_t* loop,
handle->req_pending = 1;
}

static void uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
/* Compute the path of `filename` relative to the watched directory `dir`.
* Returns 0 on success, -1 if `filename` is not actually prefixed by `dir`,
* which can happen if the directory is a short path. */
static int uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
size_t relpathlen;
size_t filenamelen = wcslen(filename);
size_t dirlen = wcslen(dir);
assert(!_wcsnicmp(filename, dir, dirlen));
if (filenamelen <= dirlen || _wcsnicmp(filename, dir, dirlen) != 0)
return -1;
if (dirlen > 0 && dir[dirlen - 1] == '\\')
dirlen--;
relpathlen = filenamelen - dirlen - 1;
Expand All@@ -78,6 +82,7 @@ static void uv__relative_path(const WCHAR* filename,
uv_fatal_error(ERROR_OUTOFMEMORY, "uv__malloc");
wcsncpy(*relpath, filename + dirlen + 1, relpathlen);
(*relpath)[relpathlen] = L'\0';
return 0;
}

static int uv__split_path(const WCHAR* filename, WCHAR** dir,
Expand DownExpand Up@@ -517,12 +522,21 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,

if (long_filenamew) {
/* Get the file name out of the long path. */
uv__relative_path(long_filenamew,
handle->dirw,
&filenamew);
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
if (uv__relative_path(long_filenamew,
handle->dirw,
&filenamew) == 0) {
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
} else {
/* The resolved long path was not prefixed by the watched
* directory (e.g. short name vs long name mismatch),
* fall back to the name given by ReadDirectoryChangesW. */
uv__free(long_filenamew);
long_filenamew = NULL;
filenamew = file_info->FileName;
sizew = file_info->FileNameLength / sizeof(WCHAR);
}
} else {
/* We couldn't get the long filename, use the one reported. */
filenamew = file_info->FileName;
Expand Down
108 changes: 91 additions & 17 deletions deps/uv/test/test-fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -587,45 +587,119 @@ TEST_IMPL(fs_event_watch_dir_recursive) {
}

#ifdef _WIN32
static char short_path_file[MAX_PATH];

static void short_path_timer_cb(uv_timer_t* handle) {
++timer_cb_called;
touch_file(short_path_file);
}

/* Try to create a unique watch directory that has a 8.3 short component
under `parent` ("" means the cwd). If it's successful, fills `watch_dir`
and `short_dir` with the long and short forms of the created directory
respectively, and returns 1. Otherwise removes the directory created
and returns 0. */
static int short_path_make(const char* parent,
char* watch_dir, size_t watch_n,
char* short_dir, size_t short_n) {
uv_fs_t req;
char tmpl[MAX_PATH];
WCHAR watch_dirw[MAX_PATH];
WCHAR short_dirw[MAX_PATH];
WCHAR long_dirw[MAX_PATH];
size_t pathlen;
int r;

if (parent[0] != '\0')
r = snprintf(tmpl, sizeof(tmpl), "%s\\watch_dirXXXXXX", parent);
else
r = snprintf(tmpl, sizeof(tmpl), "watch_dirXXXXXX");
if (r < 0 || (size_t) r >= sizeof(tmpl))
return 0;

r = uv_fs_mkdtemp(NULL, &req, tmpl, NULL);
if (r != 0) {
uv_fs_req_cleanup(&req);
return 0;
}

/* Copy the created path out before cleaning up the request that owns it. */
pathlen = strlen(req.path);
memcpy(watch_dir, req.path, pathlen + 1);
uv_fs_req_cleanup(&req);

/* The caller appends "\\file1" to both watch_dir and short_dir. If there is
no room for that suffix, skip this location. */
if (pathlen + sizeof("\\file1") <= watch_n &&
MultiByteToWideChar(CP_UTF8, 0, watch_dir, -1,
watch_dirw, ARRAY_SIZE(watch_dirw)) != 0 &&
GetShortPathNameW(watch_dirw, short_dirw, ARRAY_SIZE(short_dirw)) != 0 &&
GetLongPathNameW(watch_dirw, long_dirw, ARRAY_SIZE(long_dirw)) != 0 &&
_wcsicmp(short_dirw, long_dirw) != 0 &&
WideCharToMultiByte(CP_UTF8, 0, short_dirw, -1,
short_dir, (int) short_n, NULL, NULL) != 0)
return 1;

uv_fs_rmdir(NULL, &req, watch_dir, NULL);
uv_fs_req_cleanup(&req);
return 0;
}

TEST_IMPL(fs_event_watch_dir_short_path) {
uv_loop_t* loop;
uv_fs_t req;
char temp_path[MAX_PATH];
char watch_dir[MAX_PATH];
char watch_file[MAX_PATH];
char short_dir[MAX_PATH];
size_t temp_len;
int has_shortnames;
int r;

/* Setup */
loop = uv_default_loop();
delete_file("watch_dir/file1");
delete_dir("watch_dir/");
create_dir("watch_dir");
create_file("watch_dir/file1");

/* Newer version of Windows ship with
HKLM\SYSTEM\CurrentControlSet\Control\FileSystem\NtfsDisable8dot3NameCreation
not equal to 0. So we verify the files we created are addressable by a 8.3
short name */
has_shortnames = uv_fs_stat(NULL, &req, "watch_~1", NULL) != UV_ENOENT;
/* This test needs the watched directory to have an 8.3 short component. The
generated "watch_dirXXXXXX" name is > 8 chars, so it gets a short alias on
volumes where 8.3 name creation is enabled. For non-system volumes on
newer Windows it's disabled by default (NtfsDisable8dot3NameCreation=3).
The temp dir and the cwd may be on different volumes, so try each and use
whichever has a short alias, and skip if neither does. */
has_shortnames = 0;
temp_len = sizeof(temp_path);
if (uv_os_tmpdir(temp_path, &temp_len) == 0)
has_shortnames = short_path_make(temp_path,
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));
if (!has_shortnames)
has_shortnames = short_path_make("",
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));

if (has_shortnames) {
snprintf(watch_file, sizeof(watch_file), "%s\\file1", watch_dir);
/* short_path_file is used in the timer callback to touch the file. */
snprintf(short_path_file, sizeof(short_path_file), "%s\\file1", short_dir);
/* The directory was just created, so file1 cannot exist yet. */
create_file(watch_file);

r = uv_fs_event_init(loop, &fs_event);
ASSERT_OK(r);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, "watch_~1", 0);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, short_dir, 0);
ASSERT_OK(r);
r = uv_timer_init(loop, &timer);
ASSERT_OK(r);
r = uv_timer_start(&timer, timer_cb_file, 100, 0);
r = uv_timer_start(&timer, short_path_timer_cb, 100, 0);
ASSERT_OK(r);

uv_run(loop, UV_RUN_DEFAULT);

ASSERT_EQ(1, fs_event_cb_called);
ASSERT_EQ(1, timer_cb_called);
ASSERT_EQ(1, close_cb_called);
/* Cleanup */
delete_file(watch_file);
delete_dir(watch_dir);
}

/* Cleanup */
delete_file("watch_dir/file1");
delete_dir("watch_dir/");

MAKE_VALGRIND_HAPPY(loop);

if (!has_shortnames)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions deps/uv/src/win/fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,13 +63,17 @@ static void uv__fs_event_queue_readdirchanges(uv_loop_t* loop,
handle->req_pending = 1;
}

static void uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
/* Compute the path of `filename` relative to the watched directory `dir`.
* Returns 0 on success, -1 if `filename` is not actually prefixed by `dir`,
* which can happen if the directory is a short path. */
static int uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
size_t relpathlen;
size_t filenamelen = wcslen(filename);
size_t dirlen = wcslen(dir);
assert(!_wcsnicmp(filename, dir, dirlen));
if (filenamelen <= dirlen || _wcsnicmp(filename, dir, dirlen) != 0)
return -1;
if (dirlen > 0 && dir[dirlen - 1] == '\\')
dirlen--;
relpathlen = filenamelen - dirlen - 1;
Expand All@@ -78,6 +82,7 @@ static void uv__relative_path(const WCHAR* filename,
uv_fatal_error(ERROR_OUTOFMEMORY, "uv__malloc");
wcsncpy(*relpath, filename + dirlen + 1, relpathlen);
(*relpath)[relpathlen] = L'\0';
return 0;
}

static int uv__split_path(const WCHAR* filename, WCHAR** dir,
Expand DownExpand Up@@ -517,12 +522,21 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,

if (long_filenamew) {
/* Get the file name out of the long path. */
uv__relative_path(long_filenamew,
handle->dirw,
&filenamew);
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
if (uv__relative_path(long_filenamew,
handle->dirw,
&filenamew) == 0) {
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
} else {
/* The resolved long path was not prefixed by the watched
* directory (e.g. short name vs long name mismatch),
* fall back to the name given by ReadDirectoryChangesW. */
uv__free(long_filenamew);
long_filenamew = NULL;
filenamew = file_info->FileName;
sizew = file_info->FileNameLength / sizeof(WCHAR);
}
} else {
/* We couldn't get the long filename, use the one reported. */
filenamew = file_info->FileName;
Expand Down
108 changes: 91 additions & 17 deletions deps/uv/test/test-fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -587,45 +587,119 @@ TEST_IMPL(fs_event_watch_dir_recursive) {
}

#ifdef _WIN32
static char short_path_file[MAX_PATH];

static void short_path_timer_cb(uv_timer_t* handle) {
++timer_cb_called;
touch_file(short_path_file);
}

/* Try to create a unique watch directory that has a 8.3 short component
under `parent` ("" means the cwd). If it's successful, fills `watch_dir`
and `short_dir` with the long and short forms of the created directory
respectively, and returns 1. Otherwise removes the directory created
and returns 0. */
static int short_path_make(const char* parent,
char* watch_dir, size_t watch_n,
char* short_dir, size_t short_n) {
uv_fs_t req;
char tmpl[MAX_PATH];
WCHAR watch_dirw[MAX_PATH];
WCHAR short_dirw[MAX_PATH];
WCHAR long_dirw[MAX_PATH];
size_t pathlen;
int r;

if (parent[0] != '\0')
r = snprintf(tmpl, sizeof(tmpl), "%s\\watch_dirXXXXXX", parent);
else
r = snprintf(tmpl, sizeof(tmpl), "watch_dirXXXXXX");
if (r < 0 || (size_t) r >= sizeof(tmpl))
return 0;

r = uv_fs_mkdtemp(NULL, &req, tmpl, NULL);
if (r != 0) {
uv_fs_req_cleanup(&req);
return 0;
}

/* Copy the created path out before cleaning up the request that owns it. */
pathlen = strlen(req.path);
memcpy(watch_dir, req.path, pathlen + 1);
uv_fs_req_cleanup(&req);

/* The caller appends "\\file1" to both watch_dir and short_dir. If there is
no room for that suffix, skip this location. */
if (pathlen + sizeof("\\file1") <= watch_n &&
MultiByteToWideChar(CP_UTF8, 0, watch_dir, -1,
watch_dirw, ARRAY_SIZE(watch_dirw)) != 0 &&
GetShortPathNameW(watch_dirw, short_dirw, ARRAY_SIZE(short_dirw)) != 0 &&
GetLongPathNameW(watch_dirw, long_dirw, ARRAY_SIZE(long_dirw)) != 0 &&
_wcsicmp(short_dirw, long_dirw) != 0 &&
WideCharToMultiByte(CP_UTF8, 0, short_dirw, -1,
short_dir, (int) short_n, NULL, NULL) != 0)
return 1;

uv_fs_rmdir(NULL, &req, watch_dir, NULL);
uv_fs_req_cleanup(&req);
return 0;
}

TEST_IMPL(fs_event_watch_dir_short_path) {
uv_loop_t* loop;
uv_fs_t req;
char temp_path[MAX_PATH];
char watch_dir[MAX_PATH];
char watch_file[MAX_PATH];
char short_dir[MAX_PATH];
size_t temp_len;
int has_shortnames;
int r;

/* Setup */
loop = uv_default_loop();
delete_file("watch_dir/file1");
delete_dir("watch_dir/");
create_dir("watch_dir");
create_file("watch_dir/file1");

/* Newer version of Windows ship with
HKLM\SYSTEM\CurrentControlSet\Control\FileSystem\NtfsDisable8dot3NameCreation
not equal to 0. So we verify the files we created are addressable by a 8.3
short name */
has_shortnames = uv_fs_stat(NULL, &req, "watch_~1", NULL) != UV_ENOENT;
/* This test needs the watched directory to have an 8.3 short component. The
generated "watch_dirXXXXXX" name is > 8 chars, so it gets a short alias on
volumes where 8.3 name creation is enabled. For non-system volumes on
newer Windows it's disabled by default (NtfsDisable8dot3NameCreation=3).
The temp dir and the cwd may be on different volumes, so try each and use
whichever has a short alias, and skip if neither does. */
has_shortnames = 0;
temp_len = sizeof(temp_path);
if (uv_os_tmpdir(temp_path, &temp_len) == 0)
has_shortnames = short_path_make(temp_path,
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));
if (!has_shortnames)
has_shortnames = short_path_make("",
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));

if (has_shortnames) {
snprintf(watch_file, sizeof(watch_file), "%s\\file1", watch_dir);
/* short_path_file is used in the timer callback to touch the file. */
snprintf(short_path_file, sizeof(short_path_file), "%s\\file1", short_dir);
/* The directory was just created, so file1 cannot exist yet. */
create_file(watch_file);

r = uv_fs_event_init(loop, &fs_event);
ASSERT_OK(r);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, "watch_~1", 0);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, short_dir, 0);
ASSERT_OK(r);
r = uv_timer_init(loop, &timer);
ASSERT_OK(r);
r = uv_timer_start(&timer, timer_cb_file, 100, 0);
r = uv_timer_start(&timer, short_path_timer_cb, 100, 0);
ASSERT_OK(r);

uv_run(loop, UV_RUN_DEFAULT);

ASSERT_EQ(1, fs_event_cb_called);
ASSERT_EQ(1, timer_cb_called);
ASSERT_EQ(1, close_cb_called);
/* Cleanup */
delete_file(watch_file);
delete_dir(watch_dir);
}

/* Cleanup */
delete_file("watch_dir/file1");
delete_dir("watch_dir/");

MAKE_VALGRIND_HAPPY(loop);

if (!has_shortnames)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions deps/uv/src/win/fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,13 +63,17 @@ static void uv__fs_event_queue_readdirchanges(uv_loop_t* loop,
handle->req_pending = 1;
}

static void uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
/* Compute the path of `filename` relative to the watched directory `dir`.
* Returns 0 on success, -1 if `filename` is not actually prefixed by `dir`,
* which can happen if the directory is a short path. */
static int uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
size_t relpathlen;
size_t filenamelen = wcslen(filename);
size_t dirlen = wcslen(dir);
assert(!_wcsnicmp(filename, dir, dirlen));
if (filenamelen <= dirlen || _wcsnicmp(filename, dir, dirlen) != 0)
return -1;
if (dirlen > 0 && dir[dirlen - 1] == '\\')
dirlen--;
relpathlen = filenamelen - dirlen - 1;
Expand All@@ -78,6 +82,7 @@ static void uv__relative_path(const WCHAR* filename,
uv_fatal_error(ERROR_OUTOFMEMORY, "uv__malloc");
wcsncpy(*relpath, filename + dirlen + 1, relpathlen);
(*relpath)[relpathlen] = L'\0';
return 0;
}

static int uv__split_path(const WCHAR* filename, WCHAR** dir,
Expand DownExpand Up@@ -517,12 +522,21 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,

if (long_filenamew) {
/* Get the file name out of the long path. */
uv__relative_path(long_filenamew,
handle->dirw,
&filenamew);
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
if (uv__relative_path(long_filenamew,
handle->dirw,
&filenamew) == 0) {
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
} else {
/* The resolved long path was not prefixed by the watched
* directory (e.g. short name vs long name mismatch),
* fall back to the name given by ReadDirectoryChangesW. */
uv__free(long_filenamew);
long_filenamew = NULL;
filenamew = file_info->FileName;
sizew = file_info->FileNameLength / sizeof(WCHAR);
}
} else {
/* We couldn't get the long filename, use the one reported. */
filenamew = file_info->FileName;
Expand Down
108 changes: 91 additions & 17 deletions deps/uv/test/test-fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -587,45 +587,119 @@ TEST_IMPL(fs_event_watch_dir_recursive) {
}

#ifdef _WIN32
static char short_path_file[MAX_PATH];

static void short_path_timer_cb(uv_timer_t* handle) {
++timer_cb_called;
touch_file(short_path_file);
}

/* Try to create a unique watch directory that has a 8.3 short component
under `parent` ("" means the cwd). If it's successful, fills `watch_dir`
and `short_dir` with the long and short forms of the created directory
respectively, and returns 1. Otherwise removes the directory created
and returns 0. */
static int short_path_make(const char* parent,
char* watch_dir, size_t watch_n,
char* short_dir, size_t short_n) {
uv_fs_t req;
char tmpl[MAX_PATH];
WCHAR watch_dirw[MAX_PATH];
WCHAR short_dirw[MAX_PATH];
WCHAR long_dirw[MAX_PATH];
size_t pathlen;
int r;

if (parent[0] != '\0')
r = snprintf(tmpl, sizeof(tmpl), "%s\\watch_dirXXXXXX", parent);
else
r = snprintf(tmpl, sizeof(tmpl), "watch_dirXXXXXX");
if (r < 0 || (size_t) r >= sizeof(tmpl))
return 0;

r = uv_fs_mkdtemp(NULL, &req, tmpl, NULL);
if (r != 0) {
uv_fs_req_cleanup(&req);
return 0;
}

/* Copy the created path out before cleaning up the request that owns it. */
pathlen = strlen(req.path);
memcpy(watch_dir, req.path, pathlen + 1);
uv_fs_req_cleanup(&req);

/* The caller appends "\\file1" to both watch_dir and short_dir. If there is
no room for that suffix, skip this location. */
if (pathlen + sizeof("\\file1") <= watch_n &&
MultiByteToWideChar(CP_UTF8, 0, watch_dir, -1,
watch_dirw, ARRAY_SIZE(watch_dirw)) != 0 &&
GetShortPathNameW(watch_dirw, short_dirw, ARRAY_SIZE(short_dirw)) != 0 &&
GetLongPathNameW(watch_dirw, long_dirw, ARRAY_SIZE(long_dirw)) != 0 &&
_wcsicmp(short_dirw, long_dirw) != 0 &&
WideCharToMultiByte(CP_UTF8, 0, short_dirw, -1,
short_dir, (int) short_n, NULL, NULL) != 0)
return 1;

uv_fs_rmdir(NULL, &req, watch_dir, NULL);
uv_fs_req_cleanup(&req);
return 0;
}

TEST_IMPL(fs_event_watch_dir_short_path) {
uv_loop_t* loop;
uv_fs_t req;
char temp_path[MAX_PATH];
char watch_dir[MAX_PATH];
char watch_file[MAX_PATH];
char short_dir[MAX_PATH];
size_t temp_len;
int has_shortnames;
int r;

/* Setup */
loop = uv_default_loop();
delete_file("watch_dir/file1");
delete_dir("watch_dir/");
create_dir("watch_dir");
create_file("watch_dir/file1");

/* Newer version of Windows ship with
HKLM\SYSTEM\CurrentControlSet\Control\FileSystem\NtfsDisable8dot3NameCreation
not equal to 0. So we verify the files we created are addressable by a 8.3
short name */
has_shortnames = uv_fs_stat(NULL, &req, "watch_~1", NULL) != UV_ENOENT;
/* This test needs the watched directory to have an 8.3 short component. The
generated "watch_dirXXXXXX" name is > 8 chars, so it gets a short alias on
volumes where 8.3 name creation is enabled. For non-system volumes on
newer Windows it's disabled by default (NtfsDisable8dot3NameCreation=3).
The temp dir and the cwd may be on different volumes, so try each and use
whichever has a short alias, and skip if neither does. */
has_shortnames = 0;
temp_len = sizeof(temp_path);
if (uv_os_tmpdir(temp_path, &temp_len) == 0)
has_shortnames = short_path_make(temp_path,
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));
if (!has_shortnames)
has_shortnames = short_path_make("",
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));

if (has_shortnames) {
snprintf(watch_file, sizeof(watch_file), "%s\\file1", watch_dir);
/* short_path_file is used in the timer callback to touch the file. */
snprintf(short_path_file, sizeof(short_path_file), "%s\\file1", short_dir);
/* The directory was just created, so file1 cannot exist yet. */
create_file(watch_file);

r = uv_fs_event_init(loop, &fs_event);
ASSERT_OK(r);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, "watch_~1", 0);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, short_dir, 0);
ASSERT_OK(r);
r = uv_timer_init(loop, &timer);
ASSERT_OK(r);
r = uv_timer_start(&timer, timer_cb_file, 100, 0);
r = uv_timer_start(&timer, short_path_timer_cb, 100, 0);
ASSERT_OK(r);

uv_run(loop, UV_RUN_DEFAULT);

ASSERT_EQ(1, fs_event_cb_called);
ASSERT_EQ(1, timer_cb_called);
ASSERT_EQ(1, close_cb_called);
/* Cleanup */
delete_file(watch_file);
delete_dir(watch_dir);
}

/* Cleanup */
delete_file("watch_dir/file1");
delete_dir("watch_dir/");

MAKE_VALGRIND_HAPPY(loop);

if (!has_shortnames)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions deps/uv/src/win/fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,13 +63,17 @@ static void uv__fs_event_queue_readdirchanges(uv_loop_t* loop,
handle->req_pending = 1;
}

static void uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
/* Compute the path of `filename` relative to the watched directory `dir`.
* Returns 0 on success, -1 if `filename` is not actually prefixed by `dir`,
* which can happen if the directory is a short path. */
static int uv__relative_path(const WCHAR* filename,
const WCHAR* dir,
WCHAR** relpath) {
size_t relpathlen;
size_t filenamelen = wcslen(filename);
size_t dirlen = wcslen(dir);
assert(!_wcsnicmp(filename, dir, dirlen));
if (filenamelen <= dirlen || _wcsnicmp(filename, dir, dirlen) != 0)
return -1;
if (dirlen > 0 && dir[dirlen - 1] == '\\')
dirlen--;
relpathlen = filenamelen - dirlen - 1;
Expand All@@ -78,6 +82,7 @@ static void uv__relative_path(const WCHAR* filename,
uv_fatal_error(ERROR_OUTOFMEMORY, "uv__malloc");
wcsncpy(*relpath, filename + dirlen + 1, relpathlen);
(*relpath)[relpathlen] = L'\0';
return 0;
}

static int uv__split_path(const WCHAR* filename, WCHAR** dir,
Expand DownExpand Up@@ -517,12 +522,21 @@ void uv__process_fs_event_req(uv_loop_t* loop, uv_req_t* req,

if (long_filenamew) {
/* Get the file name out of the long path. */
uv__relative_path(long_filenamew,
handle->dirw,
&filenamew);
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
if (uv__relative_path(long_filenamew,
handle->dirw,
&filenamew) == 0) {
uv__free(long_filenamew);
long_filenamew = filenamew;
sizew = -1;
} else {
/* The resolved long path was not prefixed by the watched
* directory (e.g. short name vs long name mismatch),
* fall back to the name given by ReadDirectoryChangesW. */
uv__free(long_filenamew);
long_filenamew = NULL;
filenamew = file_info->FileName;
sizew = file_info->FileNameLength / sizeof(WCHAR);
}
} else {
/* We couldn't get the long filename, use the one reported. */
filenamew = file_info->FileName;
Expand Down
108 changes: 91 additions & 17 deletions deps/uv/test/test-fs-event.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -587,45 +587,119 @@ TEST_IMPL(fs_event_watch_dir_recursive) {
}

#ifdef _WIN32
static char short_path_file[MAX_PATH];

static void short_path_timer_cb(uv_timer_t* handle) {
++timer_cb_called;
touch_file(short_path_file);
}

/* Try to create a unique watch directory that has a 8.3 short component
under `parent` ("" means the cwd). If it's successful, fills `watch_dir`
and `short_dir` with the long and short forms of the created directory
respectively, and returns 1. Otherwise removes the directory created
and returns 0. */
static int short_path_make(const char* parent,
char* watch_dir, size_t watch_n,
char* short_dir, size_t short_n) {
uv_fs_t req;
char tmpl[MAX_PATH];
WCHAR watch_dirw[MAX_PATH];
WCHAR short_dirw[MAX_PATH];
WCHAR long_dirw[MAX_PATH];
size_t pathlen;
int r;

if (parent[0] != '\0')
r = snprintf(tmpl, sizeof(tmpl), "%s\\watch_dirXXXXXX", parent);
else
r = snprintf(tmpl, sizeof(tmpl), "watch_dirXXXXXX");
if (r < 0 || (size_t) r >= sizeof(tmpl))
return 0;

r = uv_fs_mkdtemp(NULL, &req, tmpl, NULL);
if (r != 0) {
uv_fs_req_cleanup(&req);
return 0;
}

/* Copy the created path out before cleaning up the request that owns it. */
pathlen = strlen(req.path);
memcpy(watch_dir, req.path, pathlen + 1);
uv_fs_req_cleanup(&req);

/* The caller appends "\\file1" to both watch_dir and short_dir. If there is
no room for that suffix, skip this location. */
if (pathlen + sizeof("\\file1") <= watch_n &&
MultiByteToWideChar(CP_UTF8, 0, watch_dir, -1,
watch_dirw, ARRAY_SIZE(watch_dirw)) != 0 &&
GetShortPathNameW(watch_dirw, short_dirw, ARRAY_SIZE(short_dirw)) != 0 &&
GetLongPathNameW(watch_dirw, long_dirw, ARRAY_SIZE(long_dirw)) != 0 &&
_wcsicmp(short_dirw, long_dirw) != 0 &&
WideCharToMultiByte(CP_UTF8, 0, short_dirw, -1,
short_dir, (int) short_n, NULL, NULL) != 0)
return 1;

uv_fs_rmdir(NULL, &req, watch_dir, NULL);
uv_fs_req_cleanup(&req);
return 0;
}

TEST_IMPL(fs_event_watch_dir_short_path) {
uv_loop_t* loop;
uv_fs_t req;
char temp_path[MAX_PATH];
char watch_dir[MAX_PATH];
char watch_file[MAX_PATH];
char short_dir[MAX_PATH];
size_t temp_len;
int has_shortnames;
int r;

/* Setup */
loop = uv_default_loop();
delete_file("watch_dir/file1");
delete_dir("watch_dir/");
create_dir("watch_dir");
create_file("watch_dir/file1");

/* Newer version of Windows ship with
HKLM\SYSTEM\CurrentControlSet\Control\FileSystem\NtfsDisable8dot3NameCreation
not equal to 0. So we verify the files we created are addressable by a 8.3
short name */
has_shortnames = uv_fs_stat(NULL, &req, "watch_~1", NULL) != UV_ENOENT;
/* This test needs the watched directory to have an 8.3 short component. The
generated "watch_dirXXXXXX" name is > 8 chars, so it gets a short alias on
volumes where 8.3 name creation is enabled. For non-system volumes on
newer Windows it's disabled by default (NtfsDisable8dot3NameCreation=3).
The temp dir and the cwd may be on different volumes, so try each and use
whichever has a short alias, and skip if neither does. */
has_shortnames = 0;
temp_len = sizeof(temp_path);
if (uv_os_tmpdir(temp_path, &temp_len) == 0)
has_shortnames = short_path_make(temp_path,
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));
if (!has_shortnames)
has_shortnames = short_path_make("",
watch_dir, sizeof(watch_dir),
short_dir, sizeof(short_dir));

if (has_shortnames) {
snprintf(watch_file, sizeof(watch_file), "%s\\file1", watch_dir);
/* short_path_file is used in the timer callback to touch the file. */
snprintf(short_path_file, sizeof(short_path_file), "%s\\file1", short_dir);
/* The directory was just created, so file1 cannot exist yet. */
create_file(watch_file);

r = uv_fs_event_init(loop, &fs_event);
ASSERT_OK(r);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, "watch_~1", 0);
r = uv_fs_event_start(&fs_event, fs_event_cb_dir, short_dir, 0);
ASSERT_OK(r);
r = uv_timer_init(loop, &timer);
ASSERT_OK(r);
r = uv_timer_start(&timer, timer_cb_file, 100, 0);
r = uv_timer_start(&timer, short_path_timer_cb, 100, 0);
ASSERT_OK(r);

uv_run(loop, UV_RUN_DEFAULT);

ASSERT_EQ(1, fs_event_cb_called);
ASSERT_EQ(1, timer_cb_called);
ASSERT_EQ(1, close_cb_called);
/* Cleanup */
delete_file(watch_file);
delete_dir(watch_dir);
}

/* Cleanup */
delete_file("watch_dir/file1");
delete_dir("watch_dir/");

MAKE_VALGRIND_HAPPY(loop);

if (!has_shortnames)
Expand Down
Loading