test: update WPT for WebCryptoAPI to 4c2fd05ed5#65150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Aug 11, 2026
+98 −70
Merged

test: update WPT for WebCryptoAPI to 4c2fd05ed5 #65150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 71 additions & 69 deletions test/fixtures/wpt/WebCryptoAPI/generateKey/failures.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
function run_test(algorithmNames) {
var subtle = crypto.subtle; // Change to test prefixed implementations

// These tests check that generateKey throws an error, and that
// the error is of the right type, for a wide set of incorrect parameters.
//
Expand All@@ -19,42 +16,83 @@ function run_test(algorithmNames) {
// helper functions that generate all possible test parameters for
// different situations.

var testVectors = getGenerateKeyTestVectors(algorithmNames);
function parameterString(algorithm, extractable, usages) {
if (typeof algorithm !== "object" && typeof algorithm !== "string") {
alert(algorithm);
}

var result = "(" +
objectToString(algorithm) + ", " +
objectToString(extractable) + ", " +
objectToString(usages) +
")";

function parameterString(algorithm, extractable, usages) {
if (typeof algorithm !== "object" && typeof algorithm !== "string") {
alert(algorithm);
}
return result;
}

var result = "(" +
objectToString(algorithm) + ", " +
objectToString(extractable) + ", " +
objectToString(usages) +
")";
// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
promise_test(function(test) {
return crypto.subtle.generateKey(algorithm, extractable, usages)
.then(function(result) {
assert_unreached("Operation succeeded, but should not have");
}, function(err) {
if (typeof expectedError === "number") {
assert_equals(err.code, expectedError, testTag + " not supported");
} else {
assert_equals(err.name, expectedError, testTag + " not supported");
}
});
}, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}

return result;
}

// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
promise_test(function(test) {
return crypto.subtle.generateKey(algorithm, extractable, usages)
.then(function(result) {
assert_unreached("Operation succeeded, but should not have");
}, function(err) {
if (typeof expectedError === "number") {
assert_equals(err.code, expectedError, testTag + " not supported");
} else {
assert_equals(err.name, expectedError, testTag + " not supported");
}
// Algorithm normalization happens before generateKey looks at any other
// argument, so these cases are independent of the algorithm under test and
// only need to run once for the whole suite.
function run_bad_algorithm_test() {
// Algorithm normalization should fail with "Not supported"
var badAlgorithmNames = [
"AES",
{name: "AES"},
{name: "AES", length: 128},
{name: "AES-CMAC", length: 128}, // Removed after CR
{name: "AES-CFB", length: 128}, // Removed after CR
{name: "HMAC", hash: "MD5"},
{name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
{name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
{name: "EC", namedCurve: "P521"}
];


// Algorithm normalization failures should be found first
// - all other parameters can be good or bad, should fail
// due to NotSupportedError.
badAlgorithmNames.forEach(function(algorithm) {
allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
.forEach(function(usages) {
[false, true, "RED", 7].forEach(function(extractable){
testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
});
}, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}
});
});

// Empty algorithm should fail with TypeError
allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
.forEach(function(usages) {
[false, true, "RED", 7].forEach(function(extractable){
testError({}, extractable, usages, "TypeError", "Empty algorithm");
});
});
}


function run_test(algorithmNames) {
var testVectors = getGenerateKeyTestVectors(algorithmNames);


// Given an algorithm name, create several invalid parameters.
Expand DownExpand Up@@ -108,45 +146,9 @@ function run_test(algorithmNames) {


// Now test for properly handling errors
// - Unsupported algorithm
// - Bad usages for algorithm
// - Bad key lengths

// Algorithm normalization should fail with "Not supported"
var badAlgorithmNames = [
"AES",
{name: "AES"},
{name: "AES", length: 128},
{name: "AES-CMAC", length: 128}, // Removed after CR
{name: "AES-CFB", length: 128}, // Removed after CR
{name: "HMAC", hash: "MD5"},
{name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
{name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
{name: "EC", namedCurve: "P521"}
];


// Algorithm normalization failures should be found first
// - all other parameters can be good or bad, should fail
// due to NotSupportedError.
badAlgorithmNames.forEach(function(algorithm) {
allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
.forEach(function(usages) {
[false, true, "RED", 7].forEach(function(extractable){
testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
});
});
});

// Empty algorithm should fail with TypeError
allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
.forEach(function(usages) {
[false, true, "RED", 7].forEach(function(extractable){
testError({}, extractable, usages, "TypeError", "Empty algorithm");
});
});


// Algorithms normalize okay, but usages bad (though not empty).
// It shouldn't matter what other extractable is. Should fail
// due to SyntaxError
Expand Down
5 changes: 5 additions & 0 deletions test/fixtures/wpt/WebCryptoAPI/generateKey/failures_bad_algorithm.https.any.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
// META: title=WebCryptoAPI: generateKey() for Failures
// META: timeout=long
// META: script=../util/helpers.js
// META: script=failures.js
run_bad_algorithm_test();
21 changes: 21 additions & 0 deletions test/fixtures/wpt/WebCryptoAPI/generateKey/successes.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,27 @@ function run_test(algorithmNames, slowTest) {
assert_unreached("exportKey threw an unexpected error: " + err.toString());
})
}, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));

// Special case for ECDH and ECDSA: check that the generated key length is consistent.
// Particularly for P-521, there is a high risk of the generated key being one byte short
// if the implementation isn't careful.
if (algorithm.namedCurve && extractable) {
promise_test(async function(test) {
// We run about 20 variants of this test, times 10 key generations below,
// so this should have a decent chance of catching issues.
await Promise.all(Array.from({ length: 10 }).map(async () => {
const { privateKey, publicKey } = await subtle.generateKey(algorithm, extractable, usages);
const [jwkPub, jwkPriv] = await Promise.all([
subtle.exportKey('jwk', publicKey),
subtle.exportKey('jwk', privateKey),
]);
const expectedLength = Math.ceil(Math.ceil(parseInt(algorithm.namedCurve.substring(2)) / 8) * 4/3);
assert_equals(jwkPub.x.length, expectedLength, "Public key value x has correct length");
assert_equals(jwkPub.y.length, expectedLength, "Public key value y has correct length");
assert_equals(jwkPriv.d.length, expectedLength, "Private key value d has correct length");
}));
}, testTag + ": generateKey" + parameterString(algorithm, extractable, usages) + " produces consistent length key");
}
}

// Test all valid sets of parameters for successful
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/wpt/versions.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,7 @@
"path": "web-locks"
},
"WebCryptoAPI": {
"commit": "82c3d9069cf2e93e5528a1f428fa122bd9af651d",
"commit": "4c2fd05ed5d0b90a9e1fcdcb35f6671bd461de0d",
"path": "WebCryptoAPI"
},
"webidl": {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test: update WPT for WebCryptoAPI to 4c2fd05ed5#65150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nodejs-github-bot
merged 1 commit into

from

Aug 11, 2026

+98

−70

 Merged


test: update WPT for WebCryptoAPI to 4c2fd05ed5
#65150
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


140 changes: 71 additions & 69 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
function run_test(algorithmNames) {
 var subtle = crypto.subtle; // Change to test prefixed implementations

// These tests check that generateKey throws an error, and that
// the error is of the right type, for a wide set of incorrect parameters.
//
Expand All@@ -19,42 +16,83 @@ function run_test(algorithmNames) {
// helper functions that generate all possible test parameters for
// different situations.

 var testVectors = getGenerateKeyTestVectors(algorithmNames);
function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";

 function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }
 return result;
}

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";
// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}

 return result;
 }

 // Test that a given combination of parameters results in an error,
 // AND that it is the correct kind of error.
 //
 // Expected error is either a number, tested against the error code,
 // or a string, tested against the error name.
 function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
// Algorithm normalization happens before generateKey looks at any other
// argument, so these cases are independent of the algorithm under test and
// only need to run once for the whole suite.
function run_bad_algorithm_test() {
 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
 }
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });
}


function run_test(algorithmNames) {
 var testVectors = getGenerateKeyTestVectors(algorithmNames);


 // Given an algorithm name, create several invalid parameters.
Expand DownExpand Up@@ -108,45 +146,9 @@ function run_test(algorithmNames) {


// Now test for properly handling errors
// - Unsupported algorithm
// - Bad usages for algorithm
// - Bad key lengths

 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });


 // Algorithms normalize okay, but usages bad (though not empty).
 // It shouldn't matter what other extractable is. Should fail
 // due to SyntaxError
Expand Down

5 changes: 5 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures_bad_algorithm.https.any.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
// META: title=WebCryptoAPI: generateKey() for Failures
// META: timeout=long
// META: script=../util/helpers.js
// META: script=failures.js
run_bad_algorithm_test();

21 changes: 21 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/successes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,27 @@ function run_test(algorithmNames, slowTest) {
 assert_unreached("exportKey threw an unexpected error: " + err.toString());
 })
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));

 // Special case for ECDH and ECDSA: check that the generated key length is consistent.
 // Particularly for P-521, there is a high risk of the generated key being one byte short
 // if the implementation isn't careful.
 if (algorithm.namedCurve && extractable) {
 promise_test(async function(test) {
 // We run about 20 variants of this test, times 10 key generations below,
 // so this should have a decent chance of catching issues.
 await Promise.all(Array.from({ length: 10 }).map(async () => {
 const { privateKey, publicKey } = await subtle.generateKey(algorithm, extractable, usages);
 const [jwkPub, jwkPriv] = await Promise.all([
 subtle.exportKey('jwk', publicKey),
 subtle.exportKey('jwk', privateKey),
 ]);
 const expectedLength = Math.ceil(Math.ceil(parseInt(algorithm.namedCurve.substring(2)) / 8) * 4/3);
 assert_equals(jwkPub.x.length, expectedLength, "Public key value x has correct length");
 assert_equals(jwkPub.y.length, expectedLength, "Public key value y has correct length");
 assert_equals(jwkPriv.d.length, expectedLength, "Private key value d has correct length");
 }));
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages) + " produces consistent length key");
 }
 }

 // Test all valid sets of parameters for successful
Expand Down

2 changes: 1 addition & 1 deletion
test/fixtures/wpt/versions.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,7 @@
 "path": "web-locks"
 },
 "WebCryptoAPI": {
 "commit": "82c3d9069cf2e93e5528a1f428fa122bd9af651d",
 "commit": "4c2fd05ed5d0b90a9e1fcdcb35f6671bd461de0d",
 "path": "WebCryptoAPI"
 },
 "webidl": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: update WPT for WebCryptoAPI to 4c2fd05ed5#65150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nodejs-github-bot
merged 1 commit into

from

Aug 11, 2026

+98

−70

 Merged


test: update WPT for WebCryptoAPI to 4c2fd05ed5
#65150
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


140 changes: 71 additions & 69 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
function run_test(algorithmNames) {
 var subtle = crypto.subtle; // Change to test prefixed implementations

// These tests check that generateKey throws an error, and that
// the error is of the right type, for a wide set of incorrect parameters.
//
Expand All@@ -19,42 +16,83 @@ function run_test(algorithmNames) {
// helper functions that generate all possible test parameters for
// different situations.

 var testVectors = getGenerateKeyTestVectors(algorithmNames);
function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";

 function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }
 return result;
}

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";
// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}

 return result;
 }

 // Test that a given combination of parameters results in an error,
 // AND that it is the correct kind of error.
 //
 // Expected error is either a number, tested against the error code,
 // or a string, tested against the error name.
 function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
// Algorithm normalization happens before generateKey looks at any other
// argument, so these cases are independent of the algorithm under test and
// only need to run once for the whole suite.
function run_bad_algorithm_test() {
 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
 }
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });
}


function run_test(algorithmNames) {
 var testVectors = getGenerateKeyTestVectors(algorithmNames);


 // Given an algorithm name, create several invalid parameters.
Expand DownExpand Up@@ -108,45 +146,9 @@ function run_test(algorithmNames) {


// Now test for properly handling errors
// - Unsupported algorithm
// - Bad usages for algorithm
// - Bad key lengths

 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });


 // Algorithms normalize okay, but usages bad (though not empty).
 // It shouldn't matter what other extractable is. Should fail
 // due to SyntaxError
Expand Down

5 changes: 5 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures_bad_algorithm.https.any.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
// META: title=WebCryptoAPI: generateKey() for Failures
// META: timeout=long
// META: script=../util/helpers.js
// META: script=failures.js
run_bad_algorithm_test();

21 changes: 21 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/successes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,27 @@ function run_test(algorithmNames, slowTest) {
 assert_unreached("exportKey threw an unexpected error: " + err.toString());
 })
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));

 // Special case for ECDH and ECDSA: check that the generated key length is consistent.
 // Particularly for P-521, there is a high risk of the generated key being one byte short
 // if the implementation isn't careful.
 if (algorithm.namedCurve && extractable) {
 promise_test(async function(test) {
 // We run about 20 variants of this test, times 10 key generations below,
 // so this should have a decent chance of catching issues.
 await Promise.all(Array.from({ length: 10 }).map(async () => {
 const { privateKey, publicKey } = await subtle.generateKey(algorithm, extractable, usages);
 const [jwkPub, jwkPriv] = await Promise.all([
 subtle.exportKey('jwk', publicKey),
 subtle.exportKey('jwk', privateKey),
 ]);
 const expectedLength = Math.ceil(Math.ceil(parseInt(algorithm.namedCurve.substring(2)) / 8) * 4/3);
 assert_equals(jwkPub.x.length, expectedLength, "Public key value x has correct length");
 assert_equals(jwkPub.y.length, expectedLength, "Public key value y has correct length");
 assert_equals(jwkPriv.d.length, expectedLength, "Private key value d has correct length");
 }));
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages) + " produces consistent length key");
 }
 }

 // Test all valid sets of parameters for successful
Expand Down

2 changes: 1 addition & 1 deletion
test/fixtures/wpt/versions.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,7 @@
 "path": "web-locks"
 },
 "WebCryptoAPI": {
 "commit": "82c3d9069cf2e93e5528a1f428fa122bd9af651d",
 "commit": "4c2fd05ed5d0b90a9e1fcdcb35f6671bd461de0d",
 "path": "WebCryptoAPI"
 },
 "webidl": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: update WPT for WebCryptoAPI to 4c2fd05ed5#65150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nodejs-github-bot
merged 1 commit into

from

Aug 11, 2026

+98

−70

 Merged


test: update WPT for WebCryptoAPI to 4c2fd05ed5
#65150
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


140 changes: 71 additions & 69 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
function run_test(algorithmNames) {
 var subtle = crypto.subtle; // Change to test prefixed implementations

// These tests check that generateKey throws an error, and that
// the error is of the right type, for a wide set of incorrect parameters.
//
Expand All@@ -19,42 +16,83 @@ function run_test(algorithmNames) {
// helper functions that generate all possible test parameters for
// different situations.

 var testVectors = getGenerateKeyTestVectors(algorithmNames);
function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";

 function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }
 return result;
}

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";
// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}

 return result;
 }

 // Test that a given combination of parameters results in an error,
 // AND that it is the correct kind of error.
 //
 // Expected error is either a number, tested against the error code,
 // or a string, tested against the error name.
 function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
// Algorithm normalization happens before generateKey looks at any other
// argument, so these cases are independent of the algorithm under test and
// only need to run once for the whole suite.
function run_bad_algorithm_test() {
 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
 }
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });
}


function run_test(algorithmNames) {
 var testVectors = getGenerateKeyTestVectors(algorithmNames);


 // Given an algorithm name, create several invalid parameters.
Expand DownExpand Up@@ -108,45 +146,9 @@ function run_test(algorithmNames) {


// Now test for properly handling errors
// - Unsupported algorithm
// - Bad usages for algorithm
// - Bad key lengths

 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });


 // Algorithms normalize okay, but usages bad (though not empty).
 // It shouldn't matter what other extractable is. Should fail
 // due to SyntaxError
Expand Down

5 changes: 5 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures_bad_algorithm.https.any.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
// META: title=WebCryptoAPI: generateKey() for Failures
// META: timeout=long
// META: script=../util/helpers.js
// META: script=failures.js
run_bad_algorithm_test();

21 changes: 21 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/successes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,27 @@ function run_test(algorithmNames, slowTest) {
 assert_unreached("exportKey threw an unexpected error: " + err.toString());
 })
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));

 // Special case for ECDH and ECDSA: check that the generated key length is consistent.
 // Particularly for P-521, there is a high risk of the generated key being one byte short
 // if the implementation isn't careful.
 if (algorithm.namedCurve && extractable) {
 promise_test(async function(test) {
 // We run about 20 variants of this test, times 10 key generations below,
 // so this should have a decent chance of catching issues.
 await Promise.all(Array.from({ length: 10 }).map(async () => {
 const { privateKey, publicKey } = await subtle.generateKey(algorithm, extractable, usages);
 const [jwkPub, jwkPriv] = await Promise.all([
 subtle.exportKey('jwk', publicKey),
 subtle.exportKey('jwk', privateKey),
 ]);
 const expectedLength = Math.ceil(Math.ceil(parseInt(algorithm.namedCurve.substring(2)) / 8) * 4/3);
 assert_equals(jwkPub.x.length, expectedLength, "Public key value x has correct length");
 assert_equals(jwkPub.y.length, expectedLength, "Public key value y has correct length");
 assert_equals(jwkPriv.d.length, expectedLength, "Private key value d has correct length");
 }));
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages) + " produces consistent length key");
 }
 }

 // Test all valid sets of parameters for successful
Expand Down

2 changes: 1 addition & 1 deletion
test/fixtures/wpt/versions.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,7 @@
 "path": "web-locks"
 },
 "WebCryptoAPI": {
 "commit": "82c3d9069cf2e93e5528a1f428fa122bd9af651d",
 "commit": "4c2fd05ed5d0b90a9e1fcdcb35f6671bd461de0d",
 "path": "WebCryptoAPI"
 },
 "webidl": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test: update WPT for WebCryptoAPI to 4c2fd05ed5#65150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nodejs-github-bot
merged 1 commit into

from

Aug 11, 2026

+98

−70

 Merged


test: update WPT for WebCryptoAPI to 4c2fd05ed5
#65150
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


140 changes: 71 additions & 69 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
function run_test(algorithmNames) {
 var subtle = crypto.subtle; // Change to test prefixed implementations

// These tests check that generateKey throws an error, and that
// the error is of the right type, for a wide set of incorrect parameters.
//
Expand All@@ -19,42 +16,83 @@ function run_test(algorithmNames) {
// helper functions that generate all possible test parameters for
// different situations.

 var testVectors = getGenerateKeyTestVectors(algorithmNames);
function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";

 function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }
 return result;
}

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";
// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}

 return result;
 }

 // Test that a given combination of parameters results in an error,
 // AND that it is the correct kind of error.
 //
 // Expected error is either a number, tested against the error code,
 // or a string, tested against the error name.
 function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
// Algorithm normalization happens before generateKey looks at any other
// argument, so these cases are independent of the algorithm under test and
// only need to run once for the whole suite.
function run_bad_algorithm_test() {
 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
 }
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });
}


function run_test(algorithmNames) {
 var testVectors = getGenerateKeyTestVectors(algorithmNames);


 // Given an algorithm name, create several invalid parameters.
Expand DownExpand Up@@ -108,45 +146,9 @@ function run_test(algorithmNames) {


// Now test for properly handling errors
// - Unsupported algorithm
// - Bad usages for algorithm
// - Bad key lengths

 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });


 // Algorithms normalize okay, but usages bad (though not empty).
 // It shouldn't matter what other extractable is. Should fail
 // due to SyntaxError
Expand Down

5 changes: 5 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures_bad_algorithm.https.any.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
// META: title=WebCryptoAPI: generateKey() for Failures
// META: timeout=long
// META: script=../util/helpers.js
// META: script=failures.js
run_bad_algorithm_test();

21 changes: 21 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/successes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,27 @@ function run_test(algorithmNames, slowTest) {
 assert_unreached("exportKey threw an unexpected error: " + err.toString());
 })
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));

 // Special case for ECDH and ECDSA: check that the generated key length is consistent.
 // Particularly for P-521, there is a high risk of the generated key being one byte short
 // if the implementation isn't careful.
 if (algorithm.namedCurve && extractable) {
 promise_test(async function(test) {
 // We run about 20 variants of this test, times 10 key generations below,
 // so this should have a decent chance of catching issues.
 await Promise.all(Array.from({ length: 10 }).map(async () => {
 const { privateKey, publicKey } = await subtle.generateKey(algorithm, extractable, usages);
 const [jwkPub, jwkPriv] = await Promise.all([
 subtle.exportKey('jwk', publicKey),
 subtle.exportKey('jwk', privateKey),
 ]);
 const expectedLength = Math.ceil(Math.ceil(parseInt(algorithm.namedCurve.substring(2)) / 8) * 4/3);
 assert_equals(jwkPub.x.length, expectedLength, "Public key value x has correct length");
 assert_equals(jwkPub.y.length, expectedLength, "Public key value y has correct length");
 assert_equals(jwkPriv.d.length, expectedLength, "Private key value d has correct length");
 }));
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages) + " produces consistent length key");
 }
 }

 // Test all valid sets of parameters for successful
Expand Down

2 changes: 1 addition & 1 deletion
test/fixtures/wpt/versions.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,7 @@
 "path": "web-locks"
 },
 "WebCryptoAPI": {
 "commit": "82c3d9069cf2e93e5528a1f428fa122bd9af651d",
 "commit": "4c2fd05ed5d0b90a9e1fcdcb35f6671bd461de0d",
 "path": "WebCryptoAPI"
 },
 "webidl": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: update WPT for WebCryptoAPI to 4c2fd05ed5#65150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nodejs-github-bot
merged 1 commit into

from

Aug 11, 2026

+98

−70

 Merged


test: update WPT for WebCryptoAPI to 4c2fd05ed5
#65150
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


140 changes: 71 additions & 69 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
function run_test(algorithmNames) {
 var subtle = crypto.subtle; // Change to test prefixed implementations

// These tests check that generateKey throws an error, and that
// the error is of the right type, for a wide set of incorrect parameters.
//
Expand All@@ -19,42 +16,83 @@ function run_test(algorithmNames) {
// helper functions that generate all possible test parameters for
// different situations.

 var testVectors = getGenerateKeyTestVectors(algorithmNames);
function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";

 function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }
 return result;
}

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";
// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}

 return result;
 }

 // Test that a given combination of parameters results in an error,
 // AND that it is the correct kind of error.
 //
 // Expected error is either a number, tested against the error code,
 // or a string, tested against the error name.
 function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
// Algorithm normalization happens before generateKey looks at any other
// argument, so these cases are independent of the algorithm under test and
// only need to run once for the whole suite.
function run_bad_algorithm_test() {
 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
 }
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });
}


function run_test(algorithmNames) {
 var testVectors = getGenerateKeyTestVectors(algorithmNames);


 // Given an algorithm name, create several invalid parameters.
Expand DownExpand Up@@ -108,45 +146,9 @@ function run_test(algorithmNames) {


// Now test for properly handling errors
// - Unsupported algorithm
// - Bad usages for algorithm
// - Bad key lengths

 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });


 // Algorithms normalize okay, but usages bad (though not empty).
 // It shouldn't matter what other extractable is. Should fail
 // due to SyntaxError
Expand Down

5 changes: 5 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures_bad_algorithm.https.any.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
// META: title=WebCryptoAPI: generateKey() for Failures
// META: timeout=long
// META: script=../util/helpers.js
// META: script=failures.js
run_bad_algorithm_test();

21 changes: 21 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/successes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,27 @@ function run_test(algorithmNames, slowTest) {
 assert_unreached("exportKey threw an unexpected error: " + err.toString());
 })
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));

 // Special case for ECDH and ECDSA: check that the generated key length is consistent.
 // Particularly for P-521, there is a high risk of the generated key being one byte short
 // if the implementation isn't careful.
 if (algorithm.namedCurve && extractable) {
 promise_test(async function(test) {
 // We run about 20 variants of this test, times 10 key generations below,
 // so this should have a decent chance of catching issues.
 await Promise.all(Array.from({ length: 10 }).map(async () => {
 const { privateKey, publicKey } = await subtle.generateKey(algorithm, extractable, usages);
 const [jwkPub, jwkPriv] = await Promise.all([
 subtle.exportKey('jwk', publicKey),
 subtle.exportKey('jwk', privateKey),
 ]);
 const expectedLength = Math.ceil(Math.ceil(parseInt(algorithm.namedCurve.substring(2)) / 8) * 4/3);
 assert_equals(jwkPub.x.length, expectedLength, "Public key value x has correct length");
 assert_equals(jwkPub.y.length, expectedLength, "Public key value y has correct length");
 assert_equals(jwkPriv.d.length, expectedLength, "Private key value d has correct length");
 }));
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages) + " produces consistent length key");
 }
 }

 // Test all valid sets of parameters for successful
Expand Down

2 changes: 1 addition & 1 deletion
test/fixtures/wpt/versions.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,7 @@
 "path": "web-locks"
 },
 "WebCryptoAPI": {
 "commit": "82c3d9069cf2e93e5528a1f428fa122bd9af651d",
 "commit": "4c2fd05ed5d0b90a9e1fcdcb35f6671bd461de0d",
 "path": "WebCryptoAPI"
 },
 "webidl": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: update WPT for WebCryptoAPI to 4c2fd05ed5#65150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nodejs-github-bot
merged 1 commit into

from

Aug 11, 2026

+98

−70

 Merged


test: update WPT for WebCryptoAPI to 4c2fd05ed5
#65150
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


140 changes: 71 additions & 69 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
function run_test(algorithmNames) {
 var subtle = crypto.subtle; // Change to test prefixed implementations

// These tests check that generateKey throws an error, and that
// the error is of the right type, for a wide set of incorrect parameters.
//
Expand All@@ -19,42 +16,83 @@ function run_test(algorithmNames) {
// helper functions that generate all possible test parameters for
// different situations.

 var testVectors = getGenerateKeyTestVectors(algorithmNames);
function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";

 function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }
 return result;
}

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";
// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}

 return result;
 }

 // Test that a given combination of parameters results in an error,
 // AND that it is the correct kind of error.
 //
 // Expected error is either a number, tested against the error code,
 // or a string, tested against the error name.
 function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
// Algorithm normalization happens before generateKey looks at any other
// argument, so these cases are independent of the algorithm under test and
// only need to run once for the whole suite.
function run_bad_algorithm_test() {
 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
 }
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });
}


function run_test(algorithmNames) {
 var testVectors = getGenerateKeyTestVectors(algorithmNames);


 // Given an algorithm name, create several invalid parameters.
Expand DownExpand Up@@ -108,45 +146,9 @@ function run_test(algorithmNames) {


// Now test for properly handling errors
// - Unsupported algorithm
// - Bad usages for algorithm
// - Bad key lengths

 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });


 // Algorithms normalize okay, but usages bad (though not empty).
 // It shouldn't matter what other extractable is. Should fail
 // due to SyntaxError
Expand Down

5 changes: 5 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures_bad_algorithm.https.any.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
// META: title=WebCryptoAPI: generateKey() for Failures
// META: timeout=long
// META: script=../util/helpers.js
// META: script=failures.js
run_bad_algorithm_test();

21 changes: 21 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/successes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,27 @@ function run_test(algorithmNames, slowTest) {
 assert_unreached("exportKey threw an unexpected error: " + err.toString());
 })
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));

 // Special case for ECDH and ECDSA: check that the generated key length is consistent.
 // Particularly for P-521, there is a high risk of the generated key being one byte short
 // if the implementation isn't careful.
 if (algorithm.namedCurve && extractable) {
 promise_test(async function(test) {
 // We run about 20 variants of this test, times 10 key generations below,
 // so this should have a decent chance of catching issues.
 await Promise.all(Array.from({ length: 10 }).map(async () => {
 const { privateKey, publicKey } = await subtle.generateKey(algorithm, extractable, usages);
 const [jwkPub, jwkPriv] = await Promise.all([
 subtle.exportKey('jwk', publicKey),
 subtle.exportKey('jwk', privateKey),
 ]);
 const expectedLength = Math.ceil(Math.ceil(parseInt(algorithm.namedCurve.substring(2)) / 8) * 4/3);
 assert_equals(jwkPub.x.length, expectedLength, "Public key value x has correct length");
 assert_equals(jwkPub.y.length, expectedLength, "Public key value y has correct length");
 assert_equals(jwkPriv.d.length, expectedLength, "Private key value d has correct length");
 }));
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages) + " produces consistent length key");
 }
 }

 // Test all valid sets of parameters for successful
Expand Down

2 changes: 1 addition & 1 deletion
test/fixtures/wpt/versions.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,7 @@
 "path": "web-locks"
 },
 "WebCryptoAPI": {
 "commit": "82c3d9069cf2e93e5528a1f428fa122bd9af651d",
 "commit": "4c2fd05ed5d0b90a9e1fcdcb35f6671bd461de0d",
 "path": "WebCryptoAPI"
 },
 "webidl": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test: update WPT for WebCryptoAPI to 4c2fd05ed5#65150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

nodejs-github-bot
merged 1 commit into

from

Aug 11, 2026

+98

−70

 Merged


test: update WPT for WebCryptoAPI to 4c2fd05ed5
#65150
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


140 changes: 71 additions & 69 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
function run_test(algorithmNames) {
 var subtle = crypto.subtle; // Change to test prefixed implementations

// These tests check that generateKey throws an error, and that
// the error is of the right type, for a wide set of incorrect parameters.
//
Expand All@@ -19,42 +16,83 @@ function run_test(algorithmNames) {
// helper functions that generate all possible test parameters for
// different situations.

 var testVectors = getGenerateKeyTestVectors(algorithmNames);
function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";

 function parameterString(algorithm, extractable, usages) {
 if (typeof algorithm !== "object" && typeof algorithm !== "string") {
 alert(algorithm);
 }
 return result;
}

 var result = "(" +
 objectToString(algorithm) + ", " +
 objectToString(extractable) + ", " +
 objectToString(usages) +
 ")";
// Test that a given combination of parameters results in an error,
// AND that it is the correct kind of error.
//
// Expected error is either a number, tested against the error code,
// or a string, tested against the error name.
function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
}

 return result;
 }

 // Test that a given combination of parameters results in an error,
 // AND that it is the correct kind of error.
 //
 // Expected error is either a number, tested against the error code,
 // or a string, tested against the error name.
 function testError(algorithm, extractable, usages, expectedError, testTag) {
 promise_test(function(test) {
 return crypto.subtle.generateKey(algorithm, extractable, usages)
 .then(function(result) {
 assert_unreached("Operation succeeded, but should not have");
 }, function(err) {
 if (typeof expectedError === "number") {
 assert_equals(err.code, expectedError, testTag + " not supported");
 } else {
 assert_equals(err.name, expectedError, testTag + " not supported");
 }
// Algorithm normalization happens before generateKey looks at any other
// argument, so these cases are independent of the algorithm under test and
// only need to run once for the whole suite.
function run_bad_algorithm_test() {
 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));
 }
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });
}


function run_test(algorithmNames) {
 var testVectors = getGenerateKeyTestVectors(algorithmNames);


 // Given an algorithm name, create several invalid parameters.
Expand DownExpand Up@@ -108,45 +146,9 @@ function run_test(algorithmNames) {


// Now test for properly handling errors
// - Unsupported algorithm
// - Bad usages for algorithm
// - Bad key lengths

 // Algorithm normalization should fail with "Not supported"
 var badAlgorithmNames = [
 "AES",
 {name: "AES"},
 {name: "AES", length: 128},
 {name: "AES-CMAC", length: 128}, // Removed after CR
 {name: "AES-CFB", length: 128}, // Removed after CR
 {name: "HMAC", hash: "MD5"},
 {name: "RSA", hash: "SHA-256", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "RSA-PSS", hash: "SHA", modulusLength: 2048, publicExponent: new Uint8Array([1,0,1])},
 {name: "EC", namedCurve: "P521"}
 ];


 // Algorithm normalization failures should be found first
 // - all other parameters can be good or bad, should fail
 // due to NotSupportedError.
 badAlgorithmNames.forEach(function(algorithm) {
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError(algorithm, extractable, usages, "NotSupportedError", "Bad algorithm");
 });
 });
 });

 // Empty algorithm should fail with TypeError
 allValidUsages(["decrypt", "sign", "deriveBits"], true, []) // Small search space, shouldn't matter because should fail before used
 .forEach(function(usages) {
 [false, true, "RED", 7].forEach(function(extractable){
 testError({}, extractable, usages, "TypeError", "Empty algorithm");
 });
 });


 // Algorithms normalize okay, but usages bad (though not empty).
 // It shouldn't matter what other extractable is. Should fail
 // due to SyntaxError
Expand Down

5 changes: 5 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/failures_bad_algorithm.https.any.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
// META: title=WebCryptoAPI: generateKey() for Failures
// META: timeout=long
// META: script=../util/helpers.js
// META: script=failures.js
run_bad_algorithm_test();

21 changes: 21 additions & 0 deletions
test/fixtures/wpt/WebCryptoAPI/generateKey/successes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,27 @@ function run_test(algorithmNames, slowTest) {
 assert_unreached("exportKey threw an unexpected error: " + err.toString());
 })
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages));

 // Special case for ECDH and ECDSA: check that the generated key length is consistent.
 // Particularly for P-521, there is a high risk of the generated key being one byte short
 // if the implementation isn't careful.
 if (algorithm.namedCurve && extractable) {
 promise_test(async function(test) {
 // We run about 20 variants of this test, times 10 key generations below,
 // so this should have a decent chance of catching issues.
 await Promise.all(Array.from({ length: 10 }).map(async () => {
 const { privateKey, publicKey } = await subtle.generateKey(algorithm, extractable, usages);
 const [jwkPub, jwkPriv] = await Promise.all([
 subtle.exportKey('jwk', publicKey),
 subtle.exportKey('jwk', privateKey),
 ]);
 const expectedLength = Math.ceil(Math.ceil(parseInt(algorithm.namedCurve.substring(2)) / 8) * 4/3);
 assert_equals(jwkPub.x.length, expectedLength, "Public key value x has correct length");
 assert_equals(jwkPub.y.length, expectedLength, "Public key value y has correct length");
 assert_equals(jwkPriv.d.length, expectedLength, "Private key value d has correct length");
 }));
 }, testTag + ": generateKey" + parameterString(algorithm, extractable, usages) + " produces consistent length key");
 }
 }

 // Test all valid sets of parameters for successful
Expand Down

2 changes: 1 addition & 1 deletion
test/fixtures/wpt/versions.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,7 @@
 "path": "web-locks"
 },
 "WebCryptoAPI": {
 "commit": "82c3d9069cf2e93e5528a1f428fa122bd9af651d",
 "commit": "4c2fd05ed5d0b90a9e1fcdcb35f6671bd461de0d",
 "path": "WebCryptoAPI"
 },
 "webidl": {
Expand Down
Loading