Uh oh!
There was an error while loading. Please reload this page.
doc,cluster: fix the lint of an example - #6516
Closed
yorkie wants to merge 2 commits into
Closed
Conversation
yorkie
commented
May 2, 2016
ContributorAuthor
As for this is only fix to docs, so we don't have a test case for that :-) |
cjihrig
commented
May 2, 2016
Contributor
LGTM |
Fishrock123
commented
May 2, 2016
Contributor
lgtm |
jasnell
commented
May 2, 2016
Member
LGTM |
silverwind
commented
May 2, 2016
Contributor
No need to, we can lint them in place. #5053 is set up to do that, but it's kind of dead right now. |
yorkie
commented
May 3, 2016
ContributorAuthor
Wait for CI? |
jasnell
commented
May 3, 2016
Member
There's really no CI for docs. Will get this landed shortly. Thanks @yorkie ! |
yorkie
commented
May 3, 2016
ContributorAuthor
Ok, just make sure if this one is in your plan, that's my pleasure :-) |
jasnell pushed a commit
that referenced
this pull request
May 3, 2016
PR-URL: #6516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
May 3, 2016
Member
Fishrock123 pushed a commit
that referenced
this pull request
May 4, 2016
PR-URL: #6516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 4, 2016
joelostrowski pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
PR-URL: nodejs#6516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jun 2, 2016
PR-URL: #6516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jun 24, 2016
PR-URL: #6516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jun 24, 2016
PR-URL: #6516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Just fix the example at https://nodejs.org/dist/latest-v6.x/docs/api/cluster.html, which doesn't follow the coding style.
By the way, how about moving example codes outside to separate files so that we can lint them in our build system.