sqlite: improve error for excess bound parameters

[bitpshr]

Fixes#65163. Passing more values than a prepared statement has parameters surfaced SQLite's own column index out of range error, which reads as a problem with the table's columns rather than with the call, and is inconsistent with the adjacent failure (a wrong-type value already throws a Node-authored error from the same function).

This detects the overflow before handing the index to sqlite3_bind_*(). The check sits after the scan for the next anonymous slot, so it also covers excess anonymous values passed alongside named parameters.

before: ERR_SQLITE_ERROR column index out of range
after: ERR_INVALID_ARG_VALUE Too many parameter values were provided. The statement accepts 1 parameter(s), which are already bound.

Three notes for reviewers, since I deviated from the issue's suggestions:

• This needs semver-major treatment.test-sqlite-statement-sync.js had a test asserting the old ERR_SQLITE_ERROR / errcode: 25, so the change is a deliberate behavior change. That test is updated here and renamed, since the error no longer comes from SQLite.
• ERR_INVALID_ARG_COUNT does not exist in node_errors.h or lib/internal/errors.js, so I used ERR_INVALID_ARG_VALUE. It is already a TypeError and is what the sibling binding failure a few lines away uses, which keeps the two consistent.
• The message reports only the parameter count. I first included a "but N were provided" count as suggested, but when named and anonymous parameters are mixed that number counts only the anonymous values, so run({ $k: 1 }, 2) would have read "accepts 1, but 1 were provided". The current wording is accurate in every case.

Verified locally against a build: the full sqlite suite passes (18/18), and correct arity still binds normally. Happy to change the error code, the wording, or drop this entirely if you'd rather leave the behavior alone.

Fixes: #65163

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[bitpshr]

Closing in favor of #65164, which does the same thing and also covers the docs. I had this in flight while building and missed that it was already open, sorry for the noise.

[bitpshr]

Fixes#65163. Passing more values than a prepared statement has parameters surfaced SQLite's own column index out of range error, which reads as a problem with the table's columns rather than with the call, and is inconsistent with the adjacent failure (a wrong-type value already throws a Node-authored error from the same function).

This detects the overflow before handing the index to sqlite3_bind_*(). The check sits after the scan for the next anonymous slot, so it also covers excess anonymous values passed alongside named parameters.

before: ERR_SQLITE_ERROR column index out of range
after: ERR_INVALID_ARG_VALUE Too many parameter values were provided. The statement accepts 1 parameter(s), which are already bound.

Three notes for reviewers, since I deviated from the issue's suggestions:

• This needs semver-major treatment.test-sqlite-statement-sync.js had a test asserting the old ERR_SQLITE_ERROR / errcode: 25, so the change is a deliberate behavior change. That test is updated here and renamed, since the error no longer comes from SQLite.
• ERR_INVALID_ARG_COUNT does not exist in node_errors.h or lib/internal/errors.js, so I used ERR_INVALID_ARG_VALUE. It is already a TypeError and is what the sibling binding failure a few lines away uses, which keeps the two consistent.
• The message reports only the parameter count. I first included a "but N were provided" count as suggested, but when named and anonymous parameters are mixed that number counts only the anonymous values, so run({ $k: 1 }, 2) would have read "accepts 1, but 1 were provided". The current wording is accurate in every case.

Verified locally against a build: the full sqlite suite passes (18/18), and correct arity still binds normally. Happy to change the error code, the wording, or drop this entirely if you'd rather leave the behavior alone.

Fixes: #65163

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[bitpshr]

Closing in favor of #65164, which does the same thing and also covers the docs. I had this in flight while building and missed that it was already open, sorry for the noise.

[bitpshr]

Fixes#65163. Passing more values than a prepared statement has parameters surfaced SQLite's own column index out of range error, which reads as a problem with the table's columns rather than with the call, and is inconsistent with the adjacent failure (a wrong-type value already throws a Node-authored error from the same function).

This detects the overflow before handing the index to sqlite3_bind_*(). The check sits after the scan for the next anonymous slot, so it also covers excess anonymous values passed alongside named parameters.

before: ERR_SQLITE_ERROR column index out of range
after: ERR_INVALID_ARG_VALUE Too many parameter values were provided. The statement accepts 1 parameter(s), which are already bound.

Three notes for reviewers, since I deviated from the issue's suggestions:

• This needs semver-major treatment.test-sqlite-statement-sync.js had a test asserting the old ERR_SQLITE_ERROR / errcode: 25, so the change is a deliberate behavior change. That test is updated here and renamed, since the error no longer comes from SQLite.
• ERR_INVALID_ARG_COUNT does not exist in node_errors.h or lib/internal/errors.js, so I used ERR_INVALID_ARG_VALUE. It is already a TypeError and is what the sibling binding failure a few lines away uses, which keeps the two consistent.
• The message reports only the parameter count. I first included a "but N were provided" count as suggested, but when named and anonymous parameters are mixed that number counts only the anonymous values, so run({ $k: 1 }, 2) would have read "accepts 1, but 1 were provided". The current wording is accurate in every case.

Verified locally against a build: the full sqlite suite passes (18/18), and correct arity still binds normally. Happy to change the error code, the wording, or drop this entirely if you'd rather leave the behavior alone.

Fixes: #65163

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[bitpshr]

Closing in favor of #65164, which does the same thing and also covers the docs. I had this in flight while building and missed that it was already open, sorry for the noise.

[bitpshr]

Fixes#65163. Passing more values than a prepared statement has parameters surfaced SQLite's own column index out of range error, which reads as a problem with the table's columns rather than with the call, and is inconsistent with the adjacent failure (a wrong-type value already throws a Node-authored error from the same function).

This detects the overflow before handing the index to sqlite3_bind_*(). The check sits after the scan for the next anonymous slot, so it also covers excess anonymous values passed alongside named parameters.

before: ERR_SQLITE_ERROR column index out of range
after: ERR_INVALID_ARG_VALUE Too many parameter values were provided. The statement accepts 1 parameter(s), which are already bound.

Three notes for reviewers, since I deviated from the issue's suggestions:

• This needs semver-major treatment.test-sqlite-statement-sync.js had a test asserting the old ERR_SQLITE_ERROR / errcode: 25, so the change is a deliberate behavior change. That test is updated here and renamed, since the error no longer comes from SQLite.
• ERR_INVALID_ARG_COUNT does not exist in node_errors.h or lib/internal/errors.js, so I used ERR_INVALID_ARG_VALUE. It is already a TypeError and is what the sibling binding failure a few lines away uses, which keeps the two consistent.
• The message reports only the parameter count. I first included a "but N were provided" count as suggested, but when named and anonymous parameters are mixed that number counts only the anonymous values, so run({ $k: 1 }, 2) would have read "accepts 1, but 1 were provided". The current wording is accurate in every case.

Verified locally against a build: the full sqlite suite passes (18/18), and correct arity still binds normally. Happy to change the error code, the wording, or drop this entirely if you'd rather leave the behavior alone.

Fixes: #65163

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[bitpshr]

Closing in favor of #65164, which does the same thing and also covers the docs. I had this in flight while building and missed that it was already open, sorry for the noise.

[bitpshr]

Fixes#65163. Passing more values than a prepared statement has parameters surfaced SQLite's own column index out of range error, which reads as a problem with the table's columns rather than with the call, and is inconsistent with the adjacent failure (a wrong-type value already throws a Node-authored error from the same function).

This detects the overflow before handing the index to sqlite3_bind_*(). The check sits after the scan for the next anonymous slot, so it also covers excess anonymous values passed alongside named parameters.

before: ERR_SQLITE_ERROR column index out of range
after: ERR_INVALID_ARG_VALUE Too many parameter values were provided. The statement accepts 1 parameter(s), which are already bound.

Three notes for reviewers, since I deviated from the issue's suggestions:

• This needs semver-major treatment.test-sqlite-statement-sync.js had a test asserting the old ERR_SQLITE_ERROR / errcode: 25, so the change is a deliberate behavior change. That test is updated here and renamed, since the error no longer comes from SQLite.
• ERR_INVALID_ARG_COUNT does not exist in node_errors.h or lib/internal/errors.js, so I used ERR_INVALID_ARG_VALUE. It is already a TypeError and is what the sibling binding failure a few lines away uses, which keeps the two consistent.
• The message reports only the parameter count. I first included a "but N were provided" count as suggested, but when named and anonymous parameters are mixed that number counts only the anonymous values, so run({ $k: 1 }, 2) would have read "accepts 1, but 1 were provided". The current wording is accurate in every case.

Verified locally against a build: the full sqlite suite passes (18/18), and correct arity still binds normally. Happy to change the error code, the wording, or drop this entirely if you'd rather leave the behavior alone.

Fixes: #65163

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[bitpshr]

Closing in favor of #65164, which does the same thing and also covers the docs. I had this in flight while building and missed that it was already open, sorry for the noise.

[bitpshr]

Fixes#65163. Passing more values than a prepared statement has parameters surfaced SQLite's own column index out of range error, which reads as a problem with the table's columns rather than with the call, and is inconsistent with the adjacent failure (a wrong-type value already throws a Node-authored error from the same function).

This detects the overflow before handing the index to sqlite3_bind_*(). The check sits after the scan for the next anonymous slot, so it also covers excess anonymous values passed alongside named parameters.

before: ERR_SQLITE_ERROR column index out of range
after: ERR_INVALID_ARG_VALUE Too many parameter values were provided. The statement accepts 1 parameter(s), which are already bound.

Three notes for reviewers, since I deviated from the issue's suggestions:

• This needs semver-major treatment.test-sqlite-statement-sync.js had a test asserting the old ERR_SQLITE_ERROR / errcode: 25, so the change is a deliberate behavior change. That test is updated here and renamed, since the error no longer comes from SQLite.
• ERR_INVALID_ARG_COUNT does not exist in node_errors.h or lib/internal/errors.js, so I used ERR_INVALID_ARG_VALUE. It is already a TypeError and is what the sibling binding failure a few lines away uses, which keeps the two consistent.
• The message reports only the parameter count. I first included a "but N were provided" count as suggested, but when named and anonymous parameters are mixed that number counts only the anonymous values, so run({ $k: 1 }, 2) would have read "accepts 1, but 1 were provided". The current wording is accurate in every case.

Verified locally against a build: the full sqlite suite passes (18/18), and correct arity still binds normally. Happy to change the error code, the wording, or drop this entirely if you'd rather leave the behavior alone.

Fixes: #65163

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[bitpshr]

Closing in favor of #65164, which does the same thing and also covers the docs. I had this in flight while building and missed that it was already open, sorry for the noise.

[bitpshr]

Fixes#65163. Passing more values than a prepared statement has parameters surfaced SQLite's own column index out of range error, which reads as a problem with the table's columns rather than with the call, and is inconsistent with the adjacent failure (a wrong-type value already throws a Node-authored error from the same function).

This detects the overflow before handing the index to sqlite3_bind_*(). The check sits after the scan for the next anonymous slot, so it also covers excess anonymous values passed alongside named parameters.

before: ERR_SQLITE_ERROR column index out of range
after: ERR_INVALID_ARG_VALUE Too many parameter values were provided. The statement accepts 1 parameter(s), which are already bound.

Three notes for reviewers, since I deviated from the issue's suggestions:

• This needs semver-major treatment.test-sqlite-statement-sync.js had a test asserting the old ERR_SQLITE_ERROR / errcode: 25, so the change is a deliberate behavior change. That test is updated here and renamed, since the error no longer comes from SQLite.
• ERR_INVALID_ARG_COUNT does not exist in node_errors.h or lib/internal/errors.js, so I used ERR_INVALID_ARG_VALUE. It is already a TypeError and is what the sibling binding failure a few lines away uses, which keeps the two consistent.
• The message reports only the parameter count. I first included a "but N were provided" count as suggested, but when named and anonymous parameters are mixed that number counts only the anonymous values, so run({ $k: 1 }, 2) would have read "accepts 1, but 1 were provided". The current wording is accurate in every case.

Verified locally against a build: the full sqlite suite passes (18/18), and correct arity still binds normally. Happy to change the error code, the wording, or drop this entirely if you'd rather leave the behavior alone.

Fixes: #65163

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[bitpshr]

Closing in favor of #65164, which does the same thing and also covers the docs. I had this in flight while building and missed that it was already open, sorry for the noise.

[bitpshr]

Fixes#65163. Passing more values than a prepared statement has parameters surfaced SQLite's own column index out of range error, which reads as a problem with the table's columns rather than with the call, and is inconsistent with the adjacent failure (a wrong-type value already throws a Node-authored error from the same function).

This detects the overflow before handing the index to sqlite3_bind_*(). The check sits after the scan for the next anonymous slot, so it also covers excess anonymous values passed alongside named parameters.

before: ERR_SQLITE_ERROR column index out of range
after: ERR_INVALID_ARG_VALUE Too many parameter values were provided. The statement accepts 1 parameter(s), which are already bound.

Three notes for reviewers, since I deviated from the issue's suggestions:

• This needs semver-major treatment.test-sqlite-statement-sync.js had a test asserting the old ERR_SQLITE_ERROR / errcode: 25, so the change is a deliberate behavior change. That test is updated here and renamed, since the error no longer comes from SQLite.
• ERR_INVALID_ARG_COUNT does not exist in node_errors.h or lib/internal/errors.js, so I used ERR_INVALID_ARG_VALUE. It is already a TypeError and is what the sibling binding failure a few lines away uses, which keeps the two consistent.
• The message reports only the parameter count. I first included a "but N were provided" count as suggested, but when named and anonymous parameters are mixed that number counts only the anonymous values, so run({ $k: 1 }, 2) would have read "accepts 1, but 1 were provided". The current wording is accurate in every case.

Verified locally against a build: the full sqlite suite passes (18/18), and correct arity still binds normally. Happy to change the error code, the wording, or drop this entirely if you'd rather leave the behavior alone.

Fixes: #65163

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[bitpshr]

Closing in favor of #65164, which does the same thing and also covers the docs. I had this in flight while building and missed that it was already open, sorry for the noise.