tools: make env variables consistent in cron jobs by aduh95 · Pull Request #65168 · nodejs/node

aduh95 · 2026-08-09T18:21:21Z

Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot · 2026-08-09T18:21:26Z

Review requested:

@nodejs/actions

panva · 2026-08-10T17:57:57Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 · 2026-08-10T19:04:31Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva · 2026-08-10T19:09:28Z

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva · 2026-08-10T20:10:04Z

Is use of ?: intentional over :??

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-20T15:44:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/65168 ✔ Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD ✔ Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) ✔ Patches applied Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/32387611571

nodejs-github-bot · 2026-08-20T19:15:59Z

Landed in 12eb296

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 · 2026-08-09T18:21:21Z

Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot · 2026-08-09T18:21:26Z

Review requested:

@nodejs/actions

panva · 2026-08-10T17:57:57Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 · 2026-08-10T19:04:31Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva · 2026-08-10T19:09:28Z

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva · 2026-08-10T20:10:04Z

Is use of ?: intentional over :??

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-20T15:44:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/65168 ✔ Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD ✔ Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) ✔ Patches applied Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/32387611571

nodejs-github-bot · 2026-08-20T19:15:59Z

Landed in 12eb296

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 · 2026-08-09T18:21:21Z

Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot · 2026-08-09T18:21:26Z

Review requested:

@nodejs/actions

panva · 2026-08-10T17:57:57Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 · 2026-08-10T19:04:31Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva · 2026-08-10T19:09:28Z

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva · 2026-08-10T20:10:04Z

Is use of ?: intentional over :??

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-20T15:44:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/65168 ✔ Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD ✔ Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) ✔ Patches applied Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/32387611571

nodejs-github-bot · 2026-08-20T19:15:59Z

Landed in 12eb296

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 · 2026-08-09T18:21:21Z

Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot · 2026-08-09T18:21:26Z

Review requested:

@nodejs/actions

panva · 2026-08-10T17:57:57Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 · 2026-08-10T19:04:31Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva · 2026-08-10T19:09:28Z

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva · 2026-08-10T20:10:04Z

Is use of ?: intentional over :??

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-20T15:44:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/65168 ✔ Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD ✔ Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) ✔ Patches applied Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/32387611571

nodejs-github-bot · 2026-08-20T19:15:59Z

Landed in 12eb296

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 · 2026-08-09T18:21:21Z

Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot · 2026-08-09T18:21:26Z

Review requested:

@nodejs/actions

panva · 2026-08-10T17:57:57Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 · 2026-08-10T19:04:31Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva · 2026-08-10T19:09:28Z

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva · 2026-08-10T20:10:04Z

Is use of ?: intentional over :??

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-20T15:44:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/65168 ✔ Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD ✔ Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) ✔ Patches applied Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/32387611571

nodejs-github-bot · 2026-08-20T19:15:59Z

Landed in 12eb296

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 · 2026-08-09T18:21:21Z

Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot · 2026-08-09T18:21:26Z

Review requested:

@nodejs/actions

panva · 2026-08-10T17:57:57Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 · 2026-08-10T19:04:31Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva · 2026-08-10T19:09:28Z

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva · 2026-08-10T20:10:04Z

Is use of ?: intentional over :??

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-20T15:44:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/65168 ✔ Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD ✔ Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) ✔ Patches applied Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/32387611571

nodejs-github-bot · 2026-08-20T19:15:59Z

Landed in 12eb296

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 · 2026-08-09T18:21:21Z

Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot · 2026-08-09T18:21:26Z

Review requested:

@nodejs/actions

panva · 2026-08-10T17:57:57Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 · 2026-08-10T19:04:31Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva · 2026-08-10T19:09:28Z

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva · 2026-08-10T20:10:04Z

Is use of ?: intentional over :??

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-20T15:44:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/65168 ✔ Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD ✔ Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) ✔ Patches applied Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/32387611571

nodejs-github-bot · 2026-08-20T19:15:59Z

Landed in 12eb296

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 · 2026-08-09T18:21:21Z

Pass -R/--repo explicitly instead of an implicit use of GH_REPO or let the tool figure out based on the local repo
Prefer GH_TOKEN, since that's what gh checks first according to https://cli.github.com/manual/gh_help_environment
Prefer github.token over secrets.GITHUB_TOKEN to help avoid confusing it with secrets.GH_USER_TOKEN=
Document secrets used in auto-start-ci.yml, remove references to secrets.GH_USER_TOKEN (add permissions meeting the ones we use for CQ filtering PRs)
Do not pass owner and repository as argv for commit-queue.sh, it already expects to find e.g. GITHUB_SERVER_URL in the env, it's simpler for it to also expect GITHUB_REPOSITORY to be defined.
Move git config call to the workflow so a human running the script locally doesn't accidentally impersonate the bot.

nodejs-github-bot · 2026-08-09T18:21:26Z

Review requested:

@nodejs/actions

panva · 2026-08-10T17:57:57Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

aduh95 · 2026-08-10T19:04:31Z

There's a permissions smoking gun in there somewhere. Sorry I don't have the time to look closely at the moment.

I'm not touching the permissions though

panva · 2026-08-10T19:09:28Z

I'm not touching the permissions though

But there is a user change in auto-start-ci.yml, isn't there?

panva · 2026-08-10T20:10:04Z

Is use of ?: intentional over :??

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Co-authored-by: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot · 2026-08-20T15:44:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/65168 ✔ Done loading data for nodejs/node/pull/65168 ----------------------------------- PR info ------------------------------------ Title tools: make env variables consistent in cron jobs (#65168) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:consistent-cron-envs -> nodejs:main Labels meta, tools, author ready, commit-queue Commits 6 - tools: make env variables consistent in cron jobs - fixup! tools: make env variables consistent in cron jobs - squash! use same permissions as CQ - squash! Apply suggestion from @panva - squash! not early stage anymore - squash! not early stages anymore Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Aug 2026 18:21:21 GMT ✔ Approvals: 1 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65168#pullrequestreview-4983148316 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 65168 From https://github.com/nodejs/node * branch refs/pull/65168/merge -> FETCH_HEAD ✔ Fetched commits as 58d58a47e3f8..1316c0d3ee44 -------------------------------------------------------------------------------- [main 6b25dfdc6b] tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Sun Aug 9 20:13:26 2026 +0200 4 files changed, 26 insertions(+), 37 deletions(-) [main 977da716bc] fixup! tools: make env variables consistent in cron jobs Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:32 2026 +0200 3 files changed, 9 insertions(+), 157 deletions(-) [main 76d31e5981] squash! use same permissions as CQ Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 21:18:11 2026 +0200 1 file changed, 2 insertions(+) [main d766fff13e] squash! Apply suggestion from @panva Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Mon Aug 10 23:15:58 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 162af24468] squash! not early stage anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:14 2026 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main a0b2e90ff1] squash! not early stages anymore Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Thu Aug 20 15:19:49 2026 +0200 1 file changed, 2 deletions(-) ✔ Patches applied Please run the following commands to complete landing

$ git rebase origin/main --no-keep-empty -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/32387611571

nodejs-github-bot · 2026-08-20T19:15:59Z

Landed in 12eb296

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 9, 2026

aduh95 force-pushed the consistent-cron-envs branch 5 times, most recently from 6ef5a74 to 3fcf56fCompare August 10, 2026 13:41

aduh95 requested a review from panva August 10, 2026 16:20

panva reviewed Aug 10, 2026
View reviewed changes

Comment thread.github/workflows/commit-queue.yml

panva reviewed Aug 10, 2026
View reviewed changes

Comment thread.github/workflows/auto-start-ci.yml Outdated

aduh95 force-pushed the consistent-cron-envs branch from 3a4eccd to e775846Compare August 11, 2026 13:47

aduh95and others added 4 commits August 12, 2026 18:01

tools: make env variables consistent in cron jobs
0da0b6c
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

fixup! tools: make env variables consistent in cron jobs
4582084

squash! use same permissions as CQ
4ba9dcd

squash! Apply suggestion from@panva
efed148
Co-authored-by: Filip Skokan <panva.ip@gmail.com>

aduh95 force-pushed the consistent-cron-envs branch from e775846 to efed148Compare August 12, 2026 16:02

panva approved these changes Aug 20, 2026
View reviewed changes

aduh95 commented Aug 20, 2026
View reviewed changes

Comment threaddoc/contributing/commit-queue.md Outdated

squash! not early stage anymore
ef9b85f

aduh95 commented Aug 20, 2026
View reviewed changes

Comment threaddoc/contributing/commit-queue.md Outdated

squash! not early stages anymore
1316c0d

panva approved these changes Aug 20, 2026
View reviewed changes

aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 20, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Aug 20, 2026

aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 20, 2026

nodejs-github-bot merged commit 12eb296 into nodejs:mainAug 20, 2026
34 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026

aduh95 deleted the consistent-cron-envs branch August 20, 2026 19:58

aduh95 added a commit that referenced this pull request Aug 25, 2026
tools: make env variables consistent in cron jobs
3ec5133
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 added a commit that referenced this pull request Aug 25, 2026
tools: make env variables consistent in cron jobs
41edd2f
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

aduh95 added a commit that referenced this pull request Aug 27, 2026
tools: make env variables consistent in cron jobs
a0ed3b5
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65168 Reviewed-By: Filip Skokan <panva.ip@gmail.com>