ffi: keep FFI functions non-constructible - #65184

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:ffi-constructible-native-functions
Aug 17, 2026
Merged

ffi: keep FFI functions non-constructible#65184
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:ffi-constructible-native-functions

Conversation

@trivikr

@trivikrtrivikr commented Aug 10, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #65183

Use concise method functions for Fast API and shared-buffer wrappers, and create native fallback functions with ConstructorBehavior::kThrow, so FFI functions remain non-constructible on all invocation paths.

Assisted-by: codex:gpt-5.6-sol

@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi

@nodejs-github-botnodejs-github-bot added ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run. labels Aug 10, 2026
@trivikrtrivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2026
@codecov

codecovBot commented Aug 10, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/ffi-shared-buffer.js33.33%24 Missing ⚠️
src/node_ffi.cc66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65184 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01% 
==========================================
Files 760 760 Lines 248526 248530 +4 Branches 46886 46895 +9 ==========================================
+ Hits 224439 224478 +39 + Misses 15515 15465 -50 - Partials 8572 8587 +15
Files with missing linesCoverage Δ
lib/internal/ffi/fast-api.js94.80% <100.00%> (+0.02%)⬆️
src/node_ffi.cc70.73% <66.66%> (ø)
lib/internal/ffi-shared-buffer.js55.57% <33.33%> (+0.16%)⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikrtrivikr removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75753/

@trivikr
trivikr marked this pull request as draft August 11, 2026 01:15
@trivikr

trivikr commented Aug 11, 2026

Copy link
Copy Markdown
MemberAuthor

Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/

not ok 3 ffi/test-ffi-dynamic-library --- duration_ms: 800.27300 severity: fail exitcode: 1 stack: |- Test failure: 'FFI functions are not constructible' Location: test/ffi/test-ffi-dynamic-library.js:70:1 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: true !== false at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12) at Test.runInAsyncScope (node:async_hooks:227:14) at Test.run (node:internal/test_runner/test:1397:25) at Test.processPendingSubtests (node:internal/test_runner/test:969:18) at Test.postRun (node:internal/test_runner/test:1537:19) at Test.run (node:internal/test_runner/test:1462:12) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: true, expected: false, operator: 'strictEqual', diff: 'simple' } (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) ...

@trivikr
trivikrforce-pushed the ffi-constructible-native-functions branch from edd2a79 to 317ff65CompareAugust 11, 2026 02:41
@trivikr
trivikr marked this pull request as ready for review August 11, 2026 02:41
@trivikr

trivikr commented Aug 11, 2026

Copy link
Copy Markdown
MemberAuthor

The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.

AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().

Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.

I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.

@trivikrtrivikr changed the title ffi: keep wrapped functions non-constructibleffi: keep FFI functions non-constructibleAug 11, 2026
@trivikr
ffi: keep FFI functions non-constructible
4c9023c
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikrforce-pushed the ffi-constructible-native-functions branch from 317ff65 to 4c9023cCompareAugust 11, 2026 02:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75766/

@trivikrtrivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 8f6c69f into nodejs:mainAug 17, 2026
67 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Landed in 8f6c69f

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 17, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
630a0b3
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
9024ec2
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees

No one assigned

Labels

ffiIssues and PRs related to experimental Foreign Function Interface support.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible

3 participants

@trivikr@nodejs-github-bot@ShogunPanda
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ffi: keep FFI functions non-constructible - #65184
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Aug 17, 2026
Merged
ffi: keep FFI functions non-constructible#65184
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Conversation
@trivikr
@trivikrtrivikr
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes: #65183
Use concise method functions for Fast API and shared-buffer wrappers, and create native fallback functions with ConstructorBehavior::kThrow, so FFI functions remain non-constructible on all invocation paths.
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/ffi
@nodejs-github-botnodejs-github-bot
added

ffi
Issues and PRs related to experimental Foreign Function Interface support.
needs-ci
PRs that need a full CI run.
labels
Aug 10, 2026
@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@codecov
codecovBot
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/ffi-shared-buffer.js33.33%24 Missing ⚠️
src/node_ffi.cc66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65184 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01% 
==========================================
Files 760 760 Lines 248526 248530 +4 Branches 46886 46895 +9 ==========================================
+ Hits 224439 224478 +39 + Misses 15515 15465 -50 - Partials 8572 8587 +15 
Files with missing linesCoverage Δ
lib/internal/ffi/fast-api.js94.80% <100.00%> (+0.02%)⬆️
src/node_ffi.cc70.73% <66.66%> (ø)
lib/internal/ffi-shared-buffer.js55.57% <33.33%> (+0.16%)⬆️
... and 29 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@trivikrtrivikr
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75753/
@trivikr
trivikr
marked this pull request as draft
August 11, 2026 01:15
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/
not ok 3 ffi/test-ffi-dynamic-library --- duration_ms: 800.27300 severity: fail exitcode: 1 stack: |- Test failure: 'FFI functions are not constructible' Location: test/ffi/test-ffi-dynamic-library.js:70:1 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: true !== false at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12) at Test.runInAsyncScope (node:async_hooks:227:14) at Test.run (node:internal/test_runner/test:1397:25) at Test.processPendingSubtests (node:internal/test_runner/test:969:18) at Test.postRun (node:internal/test_runner/test:1537:19) at Test.run (node:internal/test_runner/test:1462:12) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: true, expected: false, operator: 'strictEqual', diff: 'simple' } (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) ...
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
edd2a79 to
317ff65CompareAugust 11, 2026 02:41
@trivikr
trivikr
marked this pull request as ready for review
August 11, 2026 02:41
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.
AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().
Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.
I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.
@trivikrtrivikr
changed the title
ffi: keep wrapped functions non-constructibleffi: keep FFI functions non-constructibleAug 11, 2026
@trivikr
ffi: keep FFI functions non-constructible
4c9023c
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
317ff65 to
4c9023cCompareAugust 11, 2026 02:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75766/
@trivikrtrivikr
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 8f6c69f
into
nodejs:mainAug 17, 2026

67 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
Landed in 8f6c69f
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
630a0b3
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
9024ec2
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees


No one assigned


Labels

ffiIssues and PRs related to experimental Foreign Function Interface support.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible


3 participants

@trivikr@nodejs-github-bot@ShogunPanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ffi: keep FFI functions non-constructible - #65184
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Aug 17, 2026
Merged
ffi: keep FFI functions non-constructible#65184
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Conversation
@trivikr
@trivikrtrivikr
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes: #65183
Use concise method functions for Fast API and shared-buffer wrappers, and create native fallback functions with ConstructorBehavior::kThrow, so FFI functions remain non-constructible on all invocation paths.
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/ffi
@nodejs-github-botnodejs-github-bot
added

ffi
Issues and PRs related to experimental Foreign Function Interface support.
needs-ci
PRs that need a full CI run.
labels
Aug 10, 2026
@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@codecov
codecovBot
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/ffi-shared-buffer.js33.33%24 Missing ⚠️
src/node_ffi.cc66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65184 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01% 
==========================================
Files 760 760 Lines 248526 248530 +4 Branches 46886 46895 +9 ==========================================
+ Hits 224439 224478 +39 + Misses 15515 15465 -50 - Partials 8572 8587 +15 
Files with missing linesCoverage Δ
lib/internal/ffi/fast-api.js94.80% <100.00%> (+0.02%)⬆️
src/node_ffi.cc70.73% <66.66%> (ø)
lib/internal/ffi-shared-buffer.js55.57% <33.33%> (+0.16%)⬆️
... and 29 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@trivikrtrivikr
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75753/
@trivikr
trivikr
marked this pull request as draft
August 11, 2026 01:15
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/
not ok 3 ffi/test-ffi-dynamic-library --- duration_ms: 800.27300 severity: fail exitcode: 1 stack: |- Test failure: 'FFI functions are not constructible' Location: test/ffi/test-ffi-dynamic-library.js:70:1 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: true !== false at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12) at Test.runInAsyncScope (node:async_hooks:227:14) at Test.run (node:internal/test_runner/test:1397:25) at Test.processPendingSubtests (node:internal/test_runner/test:969:18) at Test.postRun (node:internal/test_runner/test:1537:19) at Test.run (node:internal/test_runner/test:1462:12) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: true, expected: false, operator: 'strictEqual', diff: 'simple' } (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) ...
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
edd2a79 to
317ff65CompareAugust 11, 2026 02:41
@trivikr
trivikr
marked this pull request as ready for review
August 11, 2026 02:41
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.
AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().
Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.
I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.
@trivikrtrivikr
changed the title
ffi: keep wrapped functions non-constructibleffi: keep FFI functions non-constructibleAug 11, 2026
@trivikr
ffi: keep FFI functions non-constructible
4c9023c
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
317ff65 to
4c9023cCompareAugust 11, 2026 02:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75766/
@trivikrtrivikr
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 8f6c69f
into
nodejs:mainAug 17, 2026

67 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
Landed in 8f6c69f
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
630a0b3
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
9024ec2
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees


No one assigned


Labels

ffiIssues and PRs related to experimental Foreign Function Interface support.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible


3 participants

@trivikr@nodejs-github-bot@ShogunPanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ffi: keep FFI functions non-constructible - #65184
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Aug 17, 2026
Merged
ffi: keep FFI functions non-constructible#65184
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Conversation
@trivikr
@trivikrtrivikr
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes: #65183
Use concise method functions for Fast API and shared-buffer wrappers, and create native fallback functions with ConstructorBehavior::kThrow, so FFI functions remain non-constructible on all invocation paths.
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/ffi
@nodejs-github-botnodejs-github-bot
added

ffi
Issues and PRs related to experimental Foreign Function Interface support.
needs-ci
PRs that need a full CI run.
labels
Aug 10, 2026
@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@codecov
codecovBot
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/ffi-shared-buffer.js33.33%24 Missing ⚠️
src/node_ffi.cc66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65184 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01% 
==========================================
Files 760 760 Lines 248526 248530 +4 Branches 46886 46895 +9 ==========================================
+ Hits 224439 224478 +39 + Misses 15515 15465 -50 - Partials 8572 8587 +15 
Files with missing linesCoverage Δ
lib/internal/ffi/fast-api.js94.80% <100.00%> (+0.02%)⬆️
src/node_ffi.cc70.73% <66.66%> (ø)
lib/internal/ffi-shared-buffer.js55.57% <33.33%> (+0.16%)⬆️
... and 29 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@trivikrtrivikr
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75753/
@trivikr
trivikr
marked this pull request as draft
August 11, 2026 01:15
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/
not ok 3 ffi/test-ffi-dynamic-library --- duration_ms: 800.27300 severity: fail exitcode: 1 stack: |- Test failure: 'FFI functions are not constructible' Location: test/ffi/test-ffi-dynamic-library.js:70:1 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: true !== false at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12) at Test.runInAsyncScope (node:async_hooks:227:14) at Test.run (node:internal/test_runner/test:1397:25) at Test.processPendingSubtests (node:internal/test_runner/test:969:18) at Test.postRun (node:internal/test_runner/test:1537:19) at Test.run (node:internal/test_runner/test:1462:12) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: true, expected: false, operator: 'strictEqual', diff: 'simple' } (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) ...
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
edd2a79 to
317ff65CompareAugust 11, 2026 02:41
@trivikr
trivikr
marked this pull request as ready for review
August 11, 2026 02:41
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.
AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().
Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.
I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.
@trivikrtrivikr
changed the title
ffi: keep wrapped functions non-constructibleffi: keep FFI functions non-constructibleAug 11, 2026
@trivikr
ffi: keep FFI functions non-constructible
4c9023c
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
317ff65 to
4c9023cCompareAugust 11, 2026 02:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75766/
@trivikrtrivikr
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 8f6c69f
into
nodejs:mainAug 17, 2026

67 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
Landed in 8f6c69f
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
630a0b3
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
9024ec2
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees


No one assigned


Labels

ffiIssues and PRs related to experimental Foreign Function Interface support.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible


3 participants

@trivikr@nodejs-github-bot@ShogunPanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ffi: keep FFI functions non-constructible - #65184
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Aug 17, 2026
Merged
ffi: keep FFI functions non-constructible#65184
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Conversation
@trivikr
@trivikrtrivikr
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes: #65183
Use concise method functions for Fast API and shared-buffer wrappers, and create native fallback functions with ConstructorBehavior::kThrow, so FFI functions remain non-constructible on all invocation paths.
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/ffi
@nodejs-github-botnodejs-github-bot
added

ffi
Issues and PRs related to experimental Foreign Function Interface support.
needs-ci
PRs that need a full CI run.
labels
Aug 10, 2026
@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@codecov
codecovBot
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/ffi-shared-buffer.js33.33%24 Missing ⚠️
src/node_ffi.cc66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65184 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01% 
==========================================
Files 760 760 Lines 248526 248530 +4 Branches 46886 46895 +9 ==========================================
+ Hits 224439 224478 +39 + Misses 15515 15465 -50 - Partials 8572 8587 +15 
Files with missing linesCoverage Δ
lib/internal/ffi/fast-api.js94.80% <100.00%> (+0.02%)⬆️
src/node_ffi.cc70.73% <66.66%> (ø)
lib/internal/ffi-shared-buffer.js55.57% <33.33%> (+0.16%)⬆️
... and 29 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@trivikrtrivikr
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75753/
@trivikr
trivikr
marked this pull request as draft
August 11, 2026 01:15
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/
not ok 3 ffi/test-ffi-dynamic-library --- duration_ms: 800.27300 severity: fail exitcode: 1 stack: |- Test failure: 'FFI functions are not constructible' Location: test/ffi/test-ffi-dynamic-library.js:70:1 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: true !== false at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12) at Test.runInAsyncScope (node:async_hooks:227:14) at Test.run (node:internal/test_runner/test:1397:25) at Test.processPendingSubtests (node:internal/test_runner/test:969:18) at Test.postRun (node:internal/test_runner/test:1537:19) at Test.run (node:internal/test_runner/test:1462:12) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: true, expected: false, operator: 'strictEqual', diff: 'simple' } (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) ...
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
edd2a79 to
317ff65CompareAugust 11, 2026 02:41
@trivikr
trivikr
marked this pull request as ready for review
August 11, 2026 02:41
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.
AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().
Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.
I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.
@trivikrtrivikr
changed the title
ffi: keep wrapped functions non-constructibleffi: keep FFI functions non-constructibleAug 11, 2026
@trivikr
ffi: keep FFI functions non-constructible
4c9023c
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
317ff65 to
4c9023cCompareAugust 11, 2026 02:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75766/
@trivikrtrivikr
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 8f6c69f
into
nodejs:mainAug 17, 2026

67 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
Landed in 8f6c69f
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
630a0b3
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
9024ec2
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees


No one assigned


Labels

ffiIssues and PRs related to experimental Foreign Function Interface support.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible


3 participants

@trivikr@nodejs-github-bot@ShogunPanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ffi: keep FFI functions non-constructible - #65184
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Aug 17, 2026
Merged
ffi: keep FFI functions non-constructible#65184
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Conversation
@trivikr
@trivikrtrivikr
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes: #65183
Use concise method functions for Fast API and shared-buffer wrappers, and create native fallback functions with ConstructorBehavior::kThrow, so FFI functions remain non-constructible on all invocation paths.
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/ffi
@nodejs-github-botnodejs-github-bot
added

ffi
Issues and PRs related to experimental Foreign Function Interface support.
needs-ci
PRs that need a full CI run.
labels
Aug 10, 2026
@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@codecov
codecovBot
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/ffi-shared-buffer.js33.33%24 Missing ⚠️
src/node_ffi.cc66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65184 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01% 
==========================================
Files 760 760 Lines 248526 248530 +4 Branches 46886 46895 +9 ==========================================
+ Hits 224439 224478 +39 + Misses 15515 15465 -50 - Partials 8572 8587 +15 
Files with missing linesCoverage Δ
lib/internal/ffi/fast-api.js94.80% <100.00%> (+0.02%)⬆️
src/node_ffi.cc70.73% <66.66%> (ø)
lib/internal/ffi-shared-buffer.js55.57% <33.33%> (+0.16%)⬆️
... and 29 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@trivikrtrivikr
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75753/
@trivikr
trivikr
marked this pull request as draft
August 11, 2026 01:15
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/
not ok 3 ffi/test-ffi-dynamic-library --- duration_ms: 800.27300 severity: fail exitcode: 1 stack: |- Test failure: 'FFI functions are not constructible' Location: test/ffi/test-ffi-dynamic-library.js:70:1 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: true !== false at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12) at Test.runInAsyncScope (node:async_hooks:227:14) at Test.run (node:internal/test_runner/test:1397:25) at Test.processPendingSubtests (node:internal/test_runner/test:969:18) at Test.postRun (node:internal/test_runner/test:1537:19) at Test.run (node:internal/test_runner/test:1462:12) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: true, expected: false, operator: 'strictEqual', diff: 'simple' } (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) ...
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
edd2a79 to
317ff65CompareAugust 11, 2026 02:41
@trivikr
trivikr
marked this pull request as ready for review
August 11, 2026 02:41
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.
AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().
Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.
I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.
@trivikrtrivikr
changed the title
ffi: keep wrapped functions non-constructibleffi: keep FFI functions non-constructibleAug 11, 2026
@trivikr
ffi: keep FFI functions non-constructible
4c9023c
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
317ff65 to
4c9023cCompareAugust 11, 2026 02:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75766/
@trivikrtrivikr
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 8f6c69f
into
nodejs:mainAug 17, 2026

67 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
Landed in 8f6c69f
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
630a0b3
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
9024ec2
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees


No one assigned


Labels

ffiIssues and PRs related to experimental Foreign Function Interface support.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible


3 participants

@trivikr@nodejs-github-bot@ShogunPanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ffi: keep FFI functions non-constructible - #65184
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Aug 17, 2026
Merged
ffi: keep FFI functions non-constructible#65184
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Conversation
@trivikr
@trivikrtrivikr
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes: #65183
Use concise method functions for Fast API and shared-buffer wrappers, and create native fallback functions with ConstructorBehavior::kThrow, so FFI functions remain non-constructible on all invocation paths.
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/ffi
@nodejs-github-botnodejs-github-bot
added

ffi
Issues and PRs related to experimental Foreign Function Interface support.
needs-ci
PRs that need a full CI run.
labels
Aug 10, 2026
@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@codecov
codecovBot
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/ffi-shared-buffer.js33.33%24 Missing ⚠️
src/node_ffi.cc66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65184 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01% 
==========================================
Files 760 760 Lines 248526 248530 +4 Branches 46886 46895 +9 ==========================================
+ Hits 224439 224478 +39 + Misses 15515 15465 -50 - Partials 8572 8587 +15 
Files with missing linesCoverage Δ
lib/internal/ffi/fast-api.js94.80% <100.00%> (+0.02%)⬆️
src/node_ffi.cc70.73% <66.66%> (ø)
lib/internal/ffi-shared-buffer.js55.57% <33.33%> (+0.16%)⬆️
... and 29 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@trivikrtrivikr
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75753/
@trivikr
trivikr
marked this pull request as draft
August 11, 2026 01:15
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/
not ok 3 ffi/test-ffi-dynamic-library --- duration_ms: 800.27300 severity: fail exitcode: 1 stack: |- Test failure: 'FFI functions are not constructible' Location: test/ffi/test-ffi-dynamic-library.js:70:1 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: true !== false at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12) at Test.runInAsyncScope (node:async_hooks:227:14) at Test.run (node:internal/test_runner/test:1397:25) at Test.processPendingSubtests (node:internal/test_runner/test:969:18) at Test.postRun (node:internal/test_runner/test:1537:19) at Test.run (node:internal/test_runner/test:1462:12) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: true, expected: false, operator: 'strictEqual', diff: 'simple' } (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) ...
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
edd2a79 to
317ff65CompareAugust 11, 2026 02:41
@trivikr
trivikr
marked this pull request as ready for review
August 11, 2026 02:41
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.
AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().
Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.
I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.
@trivikrtrivikr
changed the title
ffi: keep wrapped functions non-constructibleffi: keep FFI functions non-constructibleAug 11, 2026
@trivikr
ffi: keep FFI functions non-constructible
4c9023c
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
317ff65 to
4c9023cCompareAugust 11, 2026 02:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75766/
@trivikrtrivikr
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 8f6c69f
into
nodejs:mainAug 17, 2026

67 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
Landed in 8f6c69f
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
630a0b3
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
9024ec2
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees


No one assigned


Labels

ffiIssues and PRs related to experimental Foreign Function Interface support.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible


3 participants

@trivikr@nodejs-github-bot@ShogunPanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ffi: keep FFI functions non-constructible - #65184
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Aug 17, 2026
Merged
ffi: keep FFI functions non-constructible#65184
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
trivikr:ffi-constructible-native-functions
Conversation
@trivikr
@trivikrtrivikr
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fixes: #65183
Use concise method functions for Fast API and shared-buffer wrappers, and create native fallback functions with ConstructorBehavior::kThrow, so FFI functions remain non-constructible on all invocation paths.
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/ffi
@nodejs-github-botnodejs-github-bot
added

ffi
Issues and PRs related to experimental Foreign Function Interface support.
needs-ci
PRs that need a full CI run.
labels
Aug 10, 2026
@trivikrtrivikr
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@codecov
codecovBot
commented
Aug 10, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
❌ Patch coverage is 48.97959% with 25 lines in your changes missing coverage. Please review.

✅ Project coverage is 90.32%. Comparing base (a576f1c) to head (4c9023c).
⚠️ Report is 3 commits behind head on main.
Files with missing linesPatch %Lines
lib/internal/ffi-shared-buffer.js33.33%24 Missing ⚠️
src/node_ffi.cc66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65184 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01% 
==========================================
Files 760 760 Lines 248526 248530 +4 Branches 46886 46895 +9 ==========================================
+ Hits 224439 224478 +39 + Misses 15515 15465 -50 - Partials 8572 8587 +15 
Files with missing linesCoverage Δ
lib/internal/ffi/fast-api.js94.80% <100.00%> (+0.02%)⬆️
src/node_ffi.cc70.73% <66.66%> (ø)
lib/internal/ffi-shared-buffer.js55.57% <33.33%> (+0.16%)⬆️
... and 29 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@trivikrtrivikr
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75753/
@trivikr
trivikr
marked this pull request as draft
August 11, 2026 01:15
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
Converted to draft since test-ffi-dynamic-library is failing in https://ci.nodejs.org/job/node-test-commit-aix/64326/
not ok 3 ffi/test-ffi-dynamic-library --- duration_ms: 800.27300 severity: fail exitcode: 1 stack: |- Test failure: 'FFI functions are not constructible' Location: test/ffi/test-ffi-dynamic-library.js:70:1 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: true !== false at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-power9/test/ffi/test-ffi-dynamic-library.js:77:12) at Test.runInAsyncScope (node:async_hooks:227:14) at Test.run (node:internal/test_runner/test:1397:25) at Test.processPendingSubtests (node:internal/test_runner/test:969:18) at Test.postRun (node:internal/test_runner/test:1537:19) at Test.run (node:internal/test_runner/test:1462:12) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Test.processPendingSubtests (node:internal/test_runner/test:969:7) { generatedMessage: true, code: 'ERR_ASSERTION', actual: true, expected: false, operator: 'strictEqual', diff: 'simple' } (node:31457608) ExperimentalWarning: FFI is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) ...
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
edd2a79 to
317ff65CompareAugust 11, 2026 02:41
@trivikr
trivikr
marked this pull request as ready for review
August 11, 2026 02:41
@trivikr
trivikr
commented
Aug 11, 2026

Copy link


Copy Markdown

MemberAuthor
The AIX failure occurred because AIX uses neither of the JavaScript wrapper paths updated in the original commit.
AIX/PowerPC is excluded from the Fast API path because there is no PPC64 big-endian trampoline emitter. The shared-buffer path is also disabled on big-endian platforms. Consequently, AIX falls back to the generic native function created with v8::Function::New().
Function::New() defaults to ConstructorBehavior::kAllow, so the fallback function had its own prototype and remained constructible. Since it had no Fast API or shared-buffer metadata, it was returned without a JavaScript wrapper.
I amended the commit to create the generic fallback and shared-buffer slow-path functions with ConstructorBehavior::kThrow. The concise-method changes still ensure that JavaScript wrappers are non-constructible, while the C++ change covers native fallback paths such as AIX.
@trivikrtrivikr
changed the title
ffi: keep wrapped functions non-constructibleffi: keep FFI functions non-constructibleAug 11, 2026
@trivikr
ffi: keep FFI functions non-constructible
4c9023c
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@trivikr
trivikrforce-pushed
the
ffi-constructible-native-functions
branch
from
317ff65 to
4c9023cCompareAugust 11, 2026 02:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 11, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75766/
@trivikrtrivikr
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 8f6c69f
into
nodejs:mainAug 17, 2026

67 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
Landed in 8f6c69f
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 17, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
630a0b3
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@trivikr@aduh95
ffi: keep FFI functions non-constructible
9024ec2
Use concise method functions for Fast API and shared-buffer wrappers,
and create native fallback functions with ConstructorBehavior::kThrow,
so FFI functions remain non-constructible on all invocation paths.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #65184Fixes: #65183
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees


No one assigned


Labels

ffiIssues and PRs related to experimental Foreign Function Interface support.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible


3 participants

@trivikr@nodejs-github-bot@ShogunPanda