[v24.x] backport embedding tests to v24.x#65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

[v24.x] backport embedding tests to v24.x #65219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c091cdc
build,test: add tests for binary linked with shared libnode
joyeecheung Jan 28, 2026
f3038b1
test: split test-embedding.js and run tests in parallel
joyeecheung Feb 8, 2026
6f1831e
fixup! build,test: add tests for binary linked with shared libnode
joyeecheung Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions node.gyp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1511,6 +1511,61 @@
],
}, # embedtest

{
'target_name': 'shared_embedtest',
'type': 'executable',

'dependencies': [
'<(node_lib_target_name)',
],

# Don't depend on node.gypi - it otherwise links to
# the static libraries and resolve symbols at build time.
'include_dirs': [
'deps/v8/include',
],

'sources': [
'test/embedding/shared_embedtest.cc',
],
'conditions': [
[ 'node_shared=="true"', {
'defines': [
'USING_V8_SHARED',
'USING_V8_PLATFORM_SHARED',
],
'defines!': [
'BUILDING_V8_PLATFORM_SHARED=1',
'BUILDING_V8_SHARED=1',
],
}, {
# Only test shared embedding when Node is built as shared library.
'type': 'none',
}],
# Only test platforms known to work.
['OS not in "mac win linux"', {
'type': 'none',
}],
['OS=="win"', {
'libraries': [
'Dbghelp.lib',
'winmm.lib',
'Ws2_32.lib',
],
}],
['OS=="mac"', {
'xcode_settings': {
'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
}
}],
['OS=="linux"', {
'ldflags': [
'-Wl,-rpath,\\$$ORIGIN'
],
}],
],
}, # shared_embedtest

{
'target_name': 'overlapped-checker',
'type': 'executable',
Expand Down
11 changes: 11 additions & 0 deletions test/common/index.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
!process.env.NODE_SKIP_CRYPTO;

Expand DownExpand Up@@ -923,6 +925,13 @@ function sleepSync(ms) {
Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
if (isWindows) {
binary += '.exe';
}
return path.join(path.dirname(process.execPath), binary);
}

const common = {
allowGlobals,
buildType,
Expand DownExpand Up@@ -967,6 +976,7 @@ const common = {
printSkipMessage,
pwdCommand,
requireNoPackageJSONAbove,
resolveBuiltBinary,
runWithInvalidFD,
skip,
skipIf32Bits,
Expand All@@ -975,6 +985,7 @@ const common = {
skipIfSQLiteMissing,
spawnPromisified,
sleepSync,
usesSharedLibrary,

get enoughTestMem() {
return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down
58 changes: 58 additions & 0 deletions test/embedding/shared_embedtest.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable final : public cppgc::GarbageCollected<Wrappable> {
public:
void Trace(cppgc::Visitor* visitor) const {}
};

int main(int argc, char* argv[]) {
std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
v8::V8::InitializePlatform(platform.get());
cppgc::InitializeProcess(platform->GetPageAllocator());
v8::V8::Initialize();

auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator =
v8::ArrayBuffer::Allocator::NewDefaultAllocator();
create_params.cpp_heap = heap.release();

v8::Isolate* isolate = v8::Isolate::New(create_params);
{
v8::Isolate::Scope isolate_scope(isolate);
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = v8::Context::New(isolate);
v8::Context::Scope context_scope(context);

v8::Local<v8::Object> obj = v8::Object::New(isolate);
Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
isolate->GetCppHeap()->GetAllocationHandle());
v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
isolate, obj, wrappable);
v8::Local<v8::String> source =
v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
v8::Local<v8::Script> script =
v8::Script::Compile(context, source).ToLocalChecked();
v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
v8::String::Utf8Value utf8(isolate, result);
printf("%s\n", *utf8);
}

isolate->Dispose();
cppgc::ShutdownProcess();
v8::V8::Dispose();
v8::V8::DisposePlatform();
delete create_params.array_buffer_allocator;

return 0;
}
17 changes: 17 additions & 0 deletions test/embedding/test-embedding-create-require-fs.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Tests that createRequire() works correctly with local fs in embedded environments.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const fixtures = require('../common/fixtures');
const { spawnSyncAndExit } = require('../common/child_process');

const fixturePath = JSON.stringify(fixtures.path('exit.js'));
spawnSyncAndExit(
common.resolveBuiltBinary('embedtest'),
[`require(${fixturePath})`, 92],
{
status: 92,
signal: null,
});
15 changes: 15 additions & 0 deletions test/embedding/test-embedding-create-require-internal.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
'use strict';

// Tests that createRequire() from embedded environments still cannot access internals.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
common.resolveBuiltBinary('embedtest'),
['require("lib/internal/test/binding")'],
{
status: 1,
signal: null,
});
27 changes: 27 additions & 0 deletions test/embedding/test-embedding-disable-node-env-vars.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
'use strict';

// Tests node::ProcessInitializationFlags::kDisableNodeOptionsEnv works correctly.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');
const os = require('os');

if (process.config.variables.node_without_node_options) {
common.skip('NODE_REPL_EXTERNAL_MODULE cannot be tested with --without-node-options');
}

const embedtest = common.resolveBuiltBinary('embedtest');
spawnSyncAndExit(
embedtest,
['require("os")'],
{
env: {
...process.env,
'NODE_REPL_EXTERNAL_MODULE': 'fs',
},
},
{
status: 9,
signal: null,
stderr: `${embedtest}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
});
14 changes: 14 additions & 0 deletions test/embedding/test-embedding-exit-code.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
'use strict';

// Tests that process.exitCode works correctly in embedded environments.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
common.resolveBuiltBinary('embedtest'),
['process.exitCode = 8'],
{
status: 8,
signal: null,
});
16 changes: 16 additions & 0 deletions test/embedding/test-embedding-load-environment-basic.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
'use strict';

// Tests node::LoadEnvironment() with main_script_source_utf8 works.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
embedtest,
['console.log(42)'],
{
trim: true,
stdout: '42',
});
17 changes: 17 additions & 0 deletions test/embedding/test-embedding-load-environment-utf8.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Test node::LoadEnvironment() works with non-ASCII source code. The variable
// comes from embedtest.cc.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
embedtest,
['console.log(embedVars.nön_ascıı)'],
{
trim: true,
stdout: '🏳️‍🌈',
});
50 changes: 50 additions & 0 deletions test/embedding/test-embedding-snapshot-as-file.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests node::EmbedderSnapshotData::FromFile() works correctly.
// The snapshot is created in embedtest.cc.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
spawnSyncAndAssert,
spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
`eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
'arg1', 'arg2',
];
const snapshotBlobArgs = [
'--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the --embedder-snapshot-as-file flag.
spawnSyncAndExitWithoutError(
embedtest,
['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-as-file', '--embedder-snapshot-create'],
{ cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
embedtest,
['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
{ cwd: tmpdir.path },
{
stdout(output) {
assert.deepStrictEqual(JSON.parse(output), {
originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
currentArgv: [embedtest, ...runSnapshotExecArgs],
});
return true;
},
});
50 changes: 50 additions & 0 deletions test/embedding/test-embedding-snapshot-basic.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests snapshot support in embedded environments.
// See embedtest.cc for the API usage.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
spawnSyncAndAssert,
spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
`eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
'arg1', 'arg2',
];
const snapshotBlobArgs = [
'--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the default flags.
spawnSyncAndExitWithoutError(
embedtest,
['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
{ cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
embedtest,
['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
{ cwd: tmpdir.path },
{
stdout(output) {
assert.deepStrictEqual(JSON.parse(output), {
originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
currentArgv: [embedtest, ...runSnapshotExecArgs],
});
return true;
},
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[v24.x] backport embedding tests to v24.x#65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

joyeecheung
wants to merge
3
commits into

from

 Closed


[v24.x] backport embedding tests to v24.x
#65219
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c091cdc

build,test: add tests for binary linked with shared libnode


joyeecheung Jan 28, 2026
f3038b1

test: split test-embedding.js and run tests in parallel


joyeecheung Feb 8, 2026
6f1831e

fixup! build,test: add tests for binary linked with shared libnode


joyeecheung Aug 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
node.gyp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1511,6 +1511,61 @@
 ],
 }, # embedtest

 {
 'target_name': 'shared_embedtest',
 'type': 'executable',

 'dependencies': [
 '<(node_lib_target_name)',
 ],

 # Don't depend on node.gypi - it otherwise links to
 # the static libraries and resolve symbols at build time.
 'include_dirs': [
 'deps/v8/include',
 ],

 'sources': [
 'test/embedding/shared_embedtest.cc',
 ],
 'conditions': [
 [ 'node_shared=="true"', {
 'defines': [
 'USING_V8_SHARED',
 'USING_V8_PLATFORM_SHARED',
 ],
 'defines!': [
 'BUILDING_V8_PLATFORM_SHARED=1',
 'BUILDING_V8_SHARED=1',
 ],
 }, {
 # Only test shared embedding when Node is built as shared library.
 'type': 'none',
 }],
 # Only test platforms known to work.
 ['OS not in "mac win linux"', {
 'type': 'none',
 }],
 ['OS=="win"', {
 'libraries': [
 'Dbghelp.lib',
 'winmm.lib',
 'Ws2_32.lib',
 ],
 }],
 ['OS=="mac"', {
 'xcode_settings': {
 'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
 }
 }],
 ['OS=="linux"', {
 'ldflags': [
 '-Wl,-rpath,\\$$ORIGIN'
 ],
 }],
 ],
 }, # shared_embedtest

 {
 'target_name': 'overlapped-checker',
 'type': 'executable',
Expand Down

11 changes: 11 additions & 0 deletions
test/common/index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
 !process.env.NODE_SKIP_CRYPTO;

Expand DownExpand Up@@ -923,6 +925,13 @@ function sleepSync(ms) {
 Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
 if (isWindows) {
 binary += '.exe';
 }
 return path.join(path.dirname(process.execPath), binary);
}

const common = {
 allowGlobals,
 buildType,
Expand DownExpand Up@@ -967,6 +976,7 @@ const common = {
 printSkipMessage,
 pwdCommand,
 requireNoPackageJSONAbove,
 resolveBuiltBinary,
 runWithInvalidFD,
 skip,
 skipIf32Bits,
Expand All@@ -975,6 +985,7 @@ const common = {
 skipIfSQLiteMissing,
 spawnPromisified,
 sleepSync,
 usesSharedLibrary,

 get enoughTestMem() {
 return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down

58 changes: 58 additions & 0 deletions
test/embedding/shared_embedtest.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable final : public cppgc::GarbageCollected<Wrappable> {
 public:
 void Trace(cppgc::Visitor* visitor) const {}
};

int main(int argc, char* argv[]) {
 std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
 v8::V8::InitializePlatform(platform.get());
 cppgc::InitializeProcess(platform->GetPageAllocator());
 v8::V8::Initialize();

 auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
 v8::Isolate::CreateParams create_params;
 create_params.array_buffer_allocator =
 v8::ArrayBuffer::Allocator::NewDefaultAllocator();
 create_params.cpp_heap = heap.release();

 v8::Isolate* isolate = v8::Isolate::New(create_params);
 {
 v8::Isolate::Scope isolate_scope(isolate);
 v8::HandleScope handle_scope(isolate);
 v8::Local<v8::Context> context = v8::Context::New(isolate);
 v8::Context::Scope context_scope(context);

 v8::Local<v8::Object> obj = v8::Object::New(isolate);
 Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
 isolate->GetCppHeap()->GetAllocationHandle());
 v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
 isolate, obj, wrappable);
 v8::Local<v8::String> source =
 v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
 v8::Local<v8::Script> script =
 v8::Script::Compile(context, source).ToLocalChecked();
 v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
 v8::String::Utf8Value utf8(isolate, result);
 printf("%s\n", *utf8);
 }

 isolate->Dispose();
 cppgc::ShutdownProcess();
 v8::V8::Dispose();
 v8::V8::DisposePlatform();
 delete create_params.array_buffer_allocator;

 return 0;
}

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-create-require-fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Tests that createRequire() works correctly with local fs in embedded environments.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const fixtures = require('../common/fixtures');
const { spawnSyncAndExit } = require('../common/child_process');

const fixturePath = JSON.stringify(fixtures.path('exit.js'));
spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 [`require(${fixturePath})`, 92],
 {
 status: 92,
 signal: null,
 });

15 changes: 15 additions & 0 deletions
test/embedding/test-embedding-create-require-internal.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
'use strict';

// Tests that createRequire() from embedded environments still cannot access internals.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['require("lib/internal/test/binding")'],
 {
 status: 1,
 signal: null,
 });

27 changes: 27 additions & 0 deletions
test/embedding/test-embedding-disable-node-env-vars.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
'use strict';

// Tests node::ProcessInitializationFlags::kDisableNodeOptionsEnv works correctly.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');
const os = require('os');

if (process.config.variables.node_without_node_options) {
 common.skip('NODE_REPL_EXTERNAL_MODULE cannot be tested with --without-node-options');
}

const embedtest = common.resolveBuiltBinary('embedtest');
spawnSyncAndExit(
 embedtest,
 ['require("os")'],
 {
 env: {
 ...process.env,
 'NODE_REPL_EXTERNAL_MODULE': 'fs',
 },
 },
 {
 status: 9,
 signal: null,
 stderr: `${embedtest}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
 });

14 changes: 14 additions & 0 deletions
test/embedding/test-embedding-exit-code.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
'use strict';

// Tests that process.exitCode works correctly in embedded environments.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['process.exitCode = 8'],
 {
 status: 8,
 signal: null,
 });

16 changes: 16 additions & 0 deletions
test/embedding/test-embedding-load-environment-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
'use strict';

// Tests node::LoadEnvironment() with main_script_source_utf8 works.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(42)'],
 {
 trim: true,
 stdout: '42',
 });

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-load-environment-utf8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Test node::LoadEnvironment() works with non-ASCII source code. The variable
// comes from embedtest.cc.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(embedVars.nön_ascıı)'],
 {
 trim: true,
 stdout: '🏳️‍🌈',
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-as-file.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests node::EmbedderSnapshotData::FromFile() works correctly.
// The snapshot is created in embedtest.cc.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the --embedder-snapshot-as-file flag.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-as-file', '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests snapshot support in embedded environments.
// See embedtest.cc for the API usage.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the default flags.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[v24.x] backport embedding tests to v24.x#65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

joyeecheung
wants to merge
3
commits into

from

 Closed


[v24.x] backport embedding tests to v24.x
#65219
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c091cdc

build,test: add tests for binary linked with shared libnode


joyeecheung Jan 28, 2026
f3038b1

test: split test-embedding.js and run tests in parallel


joyeecheung Feb 8, 2026
6f1831e

fixup! build,test: add tests for binary linked with shared libnode


joyeecheung Aug 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
node.gyp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1511,6 +1511,61 @@
 ],
 }, # embedtest

 {
 'target_name': 'shared_embedtest',
 'type': 'executable',

 'dependencies': [
 '<(node_lib_target_name)',
 ],

 # Don't depend on node.gypi - it otherwise links to
 # the static libraries and resolve symbols at build time.
 'include_dirs': [
 'deps/v8/include',
 ],

 'sources': [
 'test/embedding/shared_embedtest.cc',
 ],
 'conditions': [
 [ 'node_shared=="true"', {
 'defines': [
 'USING_V8_SHARED',
 'USING_V8_PLATFORM_SHARED',
 ],
 'defines!': [
 'BUILDING_V8_PLATFORM_SHARED=1',
 'BUILDING_V8_SHARED=1',
 ],
 }, {
 # Only test shared embedding when Node is built as shared library.
 'type': 'none',
 }],
 # Only test platforms known to work.
 ['OS not in "mac win linux"', {
 'type': 'none',
 }],
 ['OS=="win"', {
 'libraries': [
 'Dbghelp.lib',
 'winmm.lib',
 'Ws2_32.lib',
 ],
 }],
 ['OS=="mac"', {
 'xcode_settings': {
 'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
 }
 }],
 ['OS=="linux"', {
 'ldflags': [
 '-Wl,-rpath,\\$$ORIGIN'
 ],
 }],
 ],
 }, # shared_embedtest

 {
 'target_name': 'overlapped-checker',
 'type': 'executable',
Expand Down

11 changes: 11 additions & 0 deletions
test/common/index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
 !process.env.NODE_SKIP_CRYPTO;

Expand DownExpand Up@@ -923,6 +925,13 @@ function sleepSync(ms) {
 Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
 if (isWindows) {
 binary += '.exe';
 }
 return path.join(path.dirname(process.execPath), binary);
}

const common = {
 allowGlobals,
 buildType,
Expand DownExpand Up@@ -967,6 +976,7 @@ const common = {
 printSkipMessage,
 pwdCommand,
 requireNoPackageJSONAbove,
 resolveBuiltBinary,
 runWithInvalidFD,
 skip,
 skipIf32Bits,
Expand All@@ -975,6 +985,7 @@ const common = {
 skipIfSQLiteMissing,
 spawnPromisified,
 sleepSync,
 usesSharedLibrary,

 get enoughTestMem() {
 return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down

58 changes: 58 additions & 0 deletions
test/embedding/shared_embedtest.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable final : public cppgc::GarbageCollected<Wrappable> {
 public:
 void Trace(cppgc::Visitor* visitor) const {}
};

int main(int argc, char* argv[]) {
 std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
 v8::V8::InitializePlatform(platform.get());
 cppgc::InitializeProcess(platform->GetPageAllocator());
 v8::V8::Initialize();

 auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
 v8::Isolate::CreateParams create_params;
 create_params.array_buffer_allocator =
 v8::ArrayBuffer::Allocator::NewDefaultAllocator();
 create_params.cpp_heap = heap.release();

 v8::Isolate* isolate = v8::Isolate::New(create_params);
 {
 v8::Isolate::Scope isolate_scope(isolate);
 v8::HandleScope handle_scope(isolate);
 v8::Local<v8::Context> context = v8::Context::New(isolate);
 v8::Context::Scope context_scope(context);

 v8::Local<v8::Object> obj = v8::Object::New(isolate);
 Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
 isolate->GetCppHeap()->GetAllocationHandle());
 v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
 isolate, obj, wrappable);
 v8::Local<v8::String> source =
 v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
 v8::Local<v8::Script> script =
 v8::Script::Compile(context, source).ToLocalChecked();
 v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
 v8::String::Utf8Value utf8(isolate, result);
 printf("%s\n", *utf8);
 }

 isolate->Dispose();
 cppgc::ShutdownProcess();
 v8::V8::Dispose();
 v8::V8::DisposePlatform();
 delete create_params.array_buffer_allocator;

 return 0;
}

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-create-require-fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Tests that createRequire() works correctly with local fs in embedded environments.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const fixtures = require('../common/fixtures');
const { spawnSyncAndExit } = require('../common/child_process');

const fixturePath = JSON.stringify(fixtures.path('exit.js'));
spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 [`require(${fixturePath})`, 92],
 {
 status: 92,
 signal: null,
 });

15 changes: 15 additions & 0 deletions
test/embedding/test-embedding-create-require-internal.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
'use strict';

// Tests that createRequire() from embedded environments still cannot access internals.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['require("lib/internal/test/binding")'],
 {
 status: 1,
 signal: null,
 });

27 changes: 27 additions & 0 deletions
test/embedding/test-embedding-disable-node-env-vars.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
'use strict';

// Tests node::ProcessInitializationFlags::kDisableNodeOptionsEnv works correctly.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');
const os = require('os');

if (process.config.variables.node_without_node_options) {
 common.skip('NODE_REPL_EXTERNAL_MODULE cannot be tested with --without-node-options');
}

const embedtest = common.resolveBuiltBinary('embedtest');
spawnSyncAndExit(
 embedtest,
 ['require("os")'],
 {
 env: {
 ...process.env,
 'NODE_REPL_EXTERNAL_MODULE': 'fs',
 },
 },
 {
 status: 9,
 signal: null,
 stderr: `${embedtest}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
 });

14 changes: 14 additions & 0 deletions
test/embedding/test-embedding-exit-code.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
'use strict';

// Tests that process.exitCode works correctly in embedded environments.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['process.exitCode = 8'],
 {
 status: 8,
 signal: null,
 });

16 changes: 16 additions & 0 deletions
test/embedding/test-embedding-load-environment-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
'use strict';

// Tests node::LoadEnvironment() with main_script_source_utf8 works.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(42)'],
 {
 trim: true,
 stdout: '42',
 });

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-load-environment-utf8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Test node::LoadEnvironment() works with non-ASCII source code. The variable
// comes from embedtest.cc.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(embedVars.nön_ascıı)'],
 {
 trim: true,
 stdout: '🏳️‍🌈',
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-as-file.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests node::EmbedderSnapshotData::FromFile() works correctly.
// The snapshot is created in embedtest.cc.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the --embedder-snapshot-as-file flag.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-as-file', '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests snapshot support in embedded environments.
// See embedtest.cc for the API usage.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the default flags.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[v24.x] backport embedding tests to v24.x#65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

joyeecheung
wants to merge
3
commits into

from

 Closed


[v24.x] backport embedding tests to v24.x
#65219
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c091cdc

build,test: add tests for binary linked with shared libnode


joyeecheung Jan 28, 2026
f3038b1

test: split test-embedding.js and run tests in parallel


joyeecheung Feb 8, 2026
6f1831e

fixup! build,test: add tests for binary linked with shared libnode


joyeecheung Aug 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
node.gyp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1511,6 +1511,61 @@
 ],
 }, # embedtest

 {
 'target_name': 'shared_embedtest',
 'type': 'executable',

 'dependencies': [
 '<(node_lib_target_name)',
 ],

 # Don't depend on node.gypi - it otherwise links to
 # the static libraries and resolve symbols at build time.
 'include_dirs': [
 'deps/v8/include',
 ],

 'sources': [
 'test/embedding/shared_embedtest.cc',
 ],
 'conditions': [
 [ 'node_shared=="true"', {
 'defines': [
 'USING_V8_SHARED',
 'USING_V8_PLATFORM_SHARED',
 ],
 'defines!': [
 'BUILDING_V8_PLATFORM_SHARED=1',
 'BUILDING_V8_SHARED=1',
 ],
 }, {
 # Only test shared embedding when Node is built as shared library.
 'type': 'none',
 }],
 # Only test platforms known to work.
 ['OS not in "mac win linux"', {
 'type': 'none',
 }],
 ['OS=="win"', {
 'libraries': [
 'Dbghelp.lib',
 'winmm.lib',
 'Ws2_32.lib',
 ],
 }],
 ['OS=="mac"', {
 'xcode_settings': {
 'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
 }
 }],
 ['OS=="linux"', {
 'ldflags': [
 '-Wl,-rpath,\\$$ORIGIN'
 ],
 }],
 ],
 }, # shared_embedtest

 {
 'target_name': 'overlapped-checker',
 'type': 'executable',
Expand Down

11 changes: 11 additions & 0 deletions
test/common/index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
 !process.env.NODE_SKIP_CRYPTO;

Expand DownExpand Up@@ -923,6 +925,13 @@ function sleepSync(ms) {
 Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
 if (isWindows) {
 binary += '.exe';
 }
 return path.join(path.dirname(process.execPath), binary);
}

const common = {
 allowGlobals,
 buildType,
Expand DownExpand Up@@ -967,6 +976,7 @@ const common = {
 printSkipMessage,
 pwdCommand,
 requireNoPackageJSONAbove,
 resolveBuiltBinary,
 runWithInvalidFD,
 skip,
 skipIf32Bits,
Expand All@@ -975,6 +985,7 @@ const common = {
 skipIfSQLiteMissing,
 spawnPromisified,
 sleepSync,
 usesSharedLibrary,

 get enoughTestMem() {
 return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down

58 changes: 58 additions & 0 deletions
test/embedding/shared_embedtest.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable final : public cppgc::GarbageCollected<Wrappable> {
 public:
 void Trace(cppgc::Visitor* visitor) const {}
};

int main(int argc, char* argv[]) {
 std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
 v8::V8::InitializePlatform(platform.get());
 cppgc::InitializeProcess(platform->GetPageAllocator());
 v8::V8::Initialize();

 auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
 v8::Isolate::CreateParams create_params;
 create_params.array_buffer_allocator =
 v8::ArrayBuffer::Allocator::NewDefaultAllocator();
 create_params.cpp_heap = heap.release();

 v8::Isolate* isolate = v8::Isolate::New(create_params);
 {
 v8::Isolate::Scope isolate_scope(isolate);
 v8::HandleScope handle_scope(isolate);
 v8::Local<v8::Context> context = v8::Context::New(isolate);
 v8::Context::Scope context_scope(context);

 v8::Local<v8::Object> obj = v8::Object::New(isolate);
 Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
 isolate->GetCppHeap()->GetAllocationHandle());
 v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
 isolate, obj, wrappable);
 v8::Local<v8::String> source =
 v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
 v8::Local<v8::Script> script =
 v8::Script::Compile(context, source).ToLocalChecked();
 v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
 v8::String::Utf8Value utf8(isolate, result);
 printf("%s\n", *utf8);
 }

 isolate->Dispose();
 cppgc::ShutdownProcess();
 v8::V8::Dispose();
 v8::V8::DisposePlatform();
 delete create_params.array_buffer_allocator;

 return 0;
}

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-create-require-fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Tests that createRequire() works correctly with local fs in embedded environments.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const fixtures = require('../common/fixtures');
const { spawnSyncAndExit } = require('../common/child_process');

const fixturePath = JSON.stringify(fixtures.path('exit.js'));
spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 [`require(${fixturePath})`, 92],
 {
 status: 92,
 signal: null,
 });

15 changes: 15 additions & 0 deletions
test/embedding/test-embedding-create-require-internal.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
'use strict';

// Tests that createRequire() from embedded environments still cannot access internals.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['require("lib/internal/test/binding")'],
 {
 status: 1,
 signal: null,
 });

27 changes: 27 additions & 0 deletions
test/embedding/test-embedding-disable-node-env-vars.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
'use strict';

// Tests node::ProcessInitializationFlags::kDisableNodeOptionsEnv works correctly.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');
const os = require('os');

if (process.config.variables.node_without_node_options) {
 common.skip('NODE_REPL_EXTERNAL_MODULE cannot be tested with --without-node-options');
}

const embedtest = common.resolveBuiltBinary('embedtest');
spawnSyncAndExit(
 embedtest,
 ['require("os")'],
 {
 env: {
 ...process.env,
 'NODE_REPL_EXTERNAL_MODULE': 'fs',
 },
 },
 {
 status: 9,
 signal: null,
 stderr: `${embedtest}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
 });

14 changes: 14 additions & 0 deletions
test/embedding/test-embedding-exit-code.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
'use strict';

// Tests that process.exitCode works correctly in embedded environments.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['process.exitCode = 8'],
 {
 status: 8,
 signal: null,
 });

16 changes: 16 additions & 0 deletions
test/embedding/test-embedding-load-environment-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
'use strict';

// Tests node::LoadEnvironment() with main_script_source_utf8 works.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(42)'],
 {
 trim: true,
 stdout: '42',
 });

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-load-environment-utf8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Test node::LoadEnvironment() works with non-ASCII source code. The variable
// comes from embedtest.cc.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(embedVars.nön_ascıı)'],
 {
 trim: true,
 stdout: '🏳️‍🌈',
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-as-file.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests node::EmbedderSnapshotData::FromFile() works correctly.
// The snapshot is created in embedtest.cc.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the --embedder-snapshot-as-file flag.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-as-file', '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests snapshot support in embedded environments.
// See embedtest.cc for the API usage.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the default flags.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[v24.x] backport embedding tests to v24.x#65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

joyeecheung
wants to merge
3
commits into

from

 Closed


[v24.x] backport embedding tests to v24.x
#65219
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c091cdc

build,test: add tests for binary linked with shared libnode


joyeecheung Jan 28, 2026
f3038b1

test: split test-embedding.js and run tests in parallel


joyeecheung Feb 8, 2026
6f1831e

fixup! build,test: add tests for binary linked with shared libnode


joyeecheung Aug 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
node.gyp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1511,6 +1511,61 @@
 ],
 }, # embedtest

 {
 'target_name': 'shared_embedtest',
 'type': 'executable',

 'dependencies': [
 '<(node_lib_target_name)',
 ],

 # Don't depend on node.gypi - it otherwise links to
 # the static libraries and resolve symbols at build time.
 'include_dirs': [
 'deps/v8/include',
 ],

 'sources': [
 'test/embedding/shared_embedtest.cc',
 ],
 'conditions': [
 [ 'node_shared=="true"', {
 'defines': [
 'USING_V8_SHARED',
 'USING_V8_PLATFORM_SHARED',
 ],
 'defines!': [
 'BUILDING_V8_PLATFORM_SHARED=1',
 'BUILDING_V8_SHARED=1',
 ],
 }, {
 # Only test shared embedding when Node is built as shared library.
 'type': 'none',
 }],
 # Only test platforms known to work.
 ['OS not in "mac win linux"', {
 'type': 'none',
 }],
 ['OS=="win"', {
 'libraries': [
 'Dbghelp.lib',
 'winmm.lib',
 'Ws2_32.lib',
 ],
 }],
 ['OS=="mac"', {
 'xcode_settings': {
 'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
 }
 }],
 ['OS=="linux"', {
 'ldflags': [
 '-Wl,-rpath,\\$$ORIGIN'
 ],
 }],
 ],
 }, # shared_embedtest

 {
 'target_name': 'overlapped-checker',
 'type': 'executable',
Expand Down

11 changes: 11 additions & 0 deletions
test/common/index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
 !process.env.NODE_SKIP_CRYPTO;

Expand DownExpand Up@@ -923,6 +925,13 @@ function sleepSync(ms) {
 Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
 if (isWindows) {
 binary += '.exe';
 }
 return path.join(path.dirname(process.execPath), binary);
}

const common = {
 allowGlobals,
 buildType,
Expand DownExpand Up@@ -967,6 +976,7 @@ const common = {
 printSkipMessage,
 pwdCommand,
 requireNoPackageJSONAbove,
 resolveBuiltBinary,
 runWithInvalidFD,
 skip,
 skipIf32Bits,
Expand All@@ -975,6 +985,7 @@ const common = {
 skipIfSQLiteMissing,
 spawnPromisified,
 sleepSync,
 usesSharedLibrary,

 get enoughTestMem() {
 return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down

58 changes: 58 additions & 0 deletions
test/embedding/shared_embedtest.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable final : public cppgc::GarbageCollected<Wrappable> {
 public:
 void Trace(cppgc::Visitor* visitor) const {}
};

int main(int argc, char* argv[]) {
 std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
 v8::V8::InitializePlatform(platform.get());
 cppgc::InitializeProcess(platform->GetPageAllocator());
 v8::V8::Initialize();

 auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
 v8::Isolate::CreateParams create_params;
 create_params.array_buffer_allocator =
 v8::ArrayBuffer::Allocator::NewDefaultAllocator();
 create_params.cpp_heap = heap.release();

 v8::Isolate* isolate = v8::Isolate::New(create_params);
 {
 v8::Isolate::Scope isolate_scope(isolate);
 v8::HandleScope handle_scope(isolate);
 v8::Local<v8::Context> context = v8::Context::New(isolate);
 v8::Context::Scope context_scope(context);

 v8::Local<v8::Object> obj = v8::Object::New(isolate);
 Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
 isolate->GetCppHeap()->GetAllocationHandle());
 v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
 isolate, obj, wrappable);
 v8::Local<v8::String> source =
 v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
 v8::Local<v8::Script> script =
 v8::Script::Compile(context, source).ToLocalChecked();
 v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
 v8::String::Utf8Value utf8(isolate, result);
 printf("%s\n", *utf8);
 }

 isolate->Dispose();
 cppgc::ShutdownProcess();
 v8::V8::Dispose();
 v8::V8::DisposePlatform();
 delete create_params.array_buffer_allocator;

 return 0;
}

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-create-require-fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Tests that createRequire() works correctly with local fs in embedded environments.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const fixtures = require('../common/fixtures');
const { spawnSyncAndExit } = require('../common/child_process');

const fixturePath = JSON.stringify(fixtures.path('exit.js'));
spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 [`require(${fixturePath})`, 92],
 {
 status: 92,
 signal: null,
 });

15 changes: 15 additions & 0 deletions
test/embedding/test-embedding-create-require-internal.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
'use strict';

// Tests that createRequire() from embedded environments still cannot access internals.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['require("lib/internal/test/binding")'],
 {
 status: 1,
 signal: null,
 });

27 changes: 27 additions & 0 deletions
test/embedding/test-embedding-disable-node-env-vars.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
'use strict';

// Tests node::ProcessInitializationFlags::kDisableNodeOptionsEnv works correctly.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');
const os = require('os');

if (process.config.variables.node_without_node_options) {
 common.skip('NODE_REPL_EXTERNAL_MODULE cannot be tested with --without-node-options');
}

const embedtest = common.resolveBuiltBinary('embedtest');
spawnSyncAndExit(
 embedtest,
 ['require("os")'],
 {
 env: {
 ...process.env,
 'NODE_REPL_EXTERNAL_MODULE': 'fs',
 },
 },
 {
 status: 9,
 signal: null,
 stderr: `${embedtest}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
 });

14 changes: 14 additions & 0 deletions
test/embedding/test-embedding-exit-code.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
'use strict';

// Tests that process.exitCode works correctly in embedded environments.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['process.exitCode = 8'],
 {
 status: 8,
 signal: null,
 });

16 changes: 16 additions & 0 deletions
test/embedding/test-embedding-load-environment-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
'use strict';

// Tests node::LoadEnvironment() with main_script_source_utf8 works.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(42)'],
 {
 trim: true,
 stdout: '42',
 });

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-load-environment-utf8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Test node::LoadEnvironment() works with non-ASCII source code. The variable
// comes from embedtest.cc.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(embedVars.nön_ascıı)'],
 {
 trim: true,
 stdout: '🏳️‍🌈',
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-as-file.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests node::EmbedderSnapshotData::FromFile() works correctly.
// The snapshot is created in embedtest.cc.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the --embedder-snapshot-as-file flag.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-as-file', '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests snapshot support in embedded environments.
// See embedtest.cc for the API usage.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the default flags.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[v24.x] backport embedding tests to v24.x#65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

joyeecheung
wants to merge
3
commits into

from

 Closed


[v24.x] backport embedding tests to v24.x
#65219
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c091cdc

build,test: add tests for binary linked with shared libnode


joyeecheung Jan 28, 2026
f3038b1

test: split test-embedding.js and run tests in parallel


joyeecheung Feb 8, 2026
6f1831e

fixup! build,test: add tests for binary linked with shared libnode


joyeecheung Aug 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
node.gyp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1511,6 +1511,61 @@
 ],
 }, # embedtest

 {
 'target_name': 'shared_embedtest',
 'type': 'executable',

 'dependencies': [
 '<(node_lib_target_name)',
 ],

 # Don't depend on node.gypi - it otherwise links to
 # the static libraries and resolve symbols at build time.
 'include_dirs': [
 'deps/v8/include',
 ],

 'sources': [
 'test/embedding/shared_embedtest.cc',
 ],
 'conditions': [
 [ 'node_shared=="true"', {
 'defines': [
 'USING_V8_SHARED',
 'USING_V8_PLATFORM_SHARED',
 ],
 'defines!': [
 'BUILDING_V8_PLATFORM_SHARED=1',
 'BUILDING_V8_SHARED=1',
 ],
 }, {
 # Only test shared embedding when Node is built as shared library.
 'type': 'none',
 }],
 # Only test platforms known to work.
 ['OS not in "mac win linux"', {
 'type': 'none',
 }],
 ['OS=="win"', {
 'libraries': [
 'Dbghelp.lib',
 'winmm.lib',
 'Ws2_32.lib',
 ],
 }],
 ['OS=="mac"', {
 'xcode_settings': {
 'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
 }
 }],
 ['OS=="linux"', {
 'ldflags': [
 '-Wl,-rpath,\\$$ORIGIN'
 ],
 }],
 ],
 }, # shared_embedtest

 {
 'target_name': 'overlapped-checker',
 'type': 'executable',
Expand Down

11 changes: 11 additions & 0 deletions
test/common/index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
 !process.env.NODE_SKIP_CRYPTO;

Expand DownExpand Up@@ -923,6 +925,13 @@ function sleepSync(ms) {
 Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
 if (isWindows) {
 binary += '.exe';
 }
 return path.join(path.dirname(process.execPath), binary);
}

const common = {
 allowGlobals,
 buildType,
Expand DownExpand Up@@ -967,6 +976,7 @@ const common = {
 printSkipMessage,
 pwdCommand,
 requireNoPackageJSONAbove,
 resolveBuiltBinary,
 runWithInvalidFD,
 skip,
 skipIf32Bits,
Expand All@@ -975,6 +985,7 @@ const common = {
 skipIfSQLiteMissing,
 spawnPromisified,
 sleepSync,
 usesSharedLibrary,

 get enoughTestMem() {
 return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down

58 changes: 58 additions & 0 deletions
test/embedding/shared_embedtest.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable final : public cppgc::GarbageCollected<Wrappable> {
 public:
 void Trace(cppgc::Visitor* visitor) const {}
};

int main(int argc, char* argv[]) {
 std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
 v8::V8::InitializePlatform(platform.get());
 cppgc::InitializeProcess(platform->GetPageAllocator());
 v8::V8::Initialize();

 auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
 v8::Isolate::CreateParams create_params;
 create_params.array_buffer_allocator =
 v8::ArrayBuffer::Allocator::NewDefaultAllocator();
 create_params.cpp_heap = heap.release();

 v8::Isolate* isolate = v8::Isolate::New(create_params);
 {
 v8::Isolate::Scope isolate_scope(isolate);
 v8::HandleScope handle_scope(isolate);
 v8::Local<v8::Context> context = v8::Context::New(isolate);
 v8::Context::Scope context_scope(context);

 v8::Local<v8::Object> obj = v8::Object::New(isolate);
 Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
 isolate->GetCppHeap()->GetAllocationHandle());
 v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
 isolate, obj, wrappable);
 v8::Local<v8::String> source =
 v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
 v8::Local<v8::Script> script =
 v8::Script::Compile(context, source).ToLocalChecked();
 v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
 v8::String::Utf8Value utf8(isolate, result);
 printf("%s\n", *utf8);
 }

 isolate->Dispose();
 cppgc::ShutdownProcess();
 v8::V8::Dispose();
 v8::V8::DisposePlatform();
 delete create_params.array_buffer_allocator;

 return 0;
}

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-create-require-fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Tests that createRequire() works correctly with local fs in embedded environments.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const fixtures = require('../common/fixtures');
const { spawnSyncAndExit } = require('../common/child_process');

const fixturePath = JSON.stringify(fixtures.path('exit.js'));
spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 [`require(${fixturePath})`, 92],
 {
 status: 92,
 signal: null,
 });

15 changes: 15 additions & 0 deletions
test/embedding/test-embedding-create-require-internal.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
'use strict';

// Tests that createRequire() from embedded environments still cannot access internals.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['require("lib/internal/test/binding")'],
 {
 status: 1,
 signal: null,
 });

27 changes: 27 additions & 0 deletions
test/embedding/test-embedding-disable-node-env-vars.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
'use strict';

// Tests node::ProcessInitializationFlags::kDisableNodeOptionsEnv works correctly.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');
const os = require('os');

if (process.config.variables.node_without_node_options) {
 common.skip('NODE_REPL_EXTERNAL_MODULE cannot be tested with --without-node-options');
}

const embedtest = common.resolveBuiltBinary('embedtest');
spawnSyncAndExit(
 embedtest,
 ['require("os")'],
 {
 env: {
 ...process.env,
 'NODE_REPL_EXTERNAL_MODULE': 'fs',
 },
 },
 {
 status: 9,
 signal: null,
 stderr: `${embedtest}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
 });

14 changes: 14 additions & 0 deletions
test/embedding/test-embedding-exit-code.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
'use strict';

// Tests that process.exitCode works correctly in embedded environments.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['process.exitCode = 8'],
 {
 status: 8,
 signal: null,
 });

16 changes: 16 additions & 0 deletions
test/embedding/test-embedding-load-environment-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
'use strict';

// Tests node::LoadEnvironment() with main_script_source_utf8 works.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(42)'],
 {
 trim: true,
 stdout: '42',
 });

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-load-environment-utf8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Test node::LoadEnvironment() works with non-ASCII source code. The variable
// comes from embedtest.cc.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(embedVars.nön_ascıı)'],
 {
 trim: true,
 stdout: '🏳️‍🌈',
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-as-file.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests node::EmbedderSnapshotData::FromFile() works correctly.
// The snapshot is created in embedtest.cc.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the --embedder-snapshot-as-file flag.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-as-file', '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests snapshot support in embedded environments.
// See embedtest.cc for the API usage.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the default flags.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[v24.x] backport embedding tests to v24.x#65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

joyeecheung
wants to merge
3
commits into

from

 Closed


[v24.x] backport embedding tests to v24.x
#65219
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c091cdc

build,test: add tests for binary linked with shared libnode


joyeecheung Jan 28, 2026
f3038b1

test: split test-embedding.js and run tests in parallel


joyeecheung Feb 8, 2026
6f1831e

fixup! build,test: add tests for binary linked with shared libnode


joyeecheung Aug 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
node.gyp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1511,6 +1511,61 @@
 ],
 }, # embedtest

 {
 'target_name': 'shared_embedtest',
 'type': 'executable',

 'dependencies': [
 '<(node_lib_target_name)',
 ],

 # Don't depend on node.gypi - it otherwise links to
 # the static libraries and resolve symbols at build time.
 'include_dirs': [
 'deps/v8/include',
 ],

 'sources': [
 'test/embedding/shared_embedtest.cc',
 ],
 'conditions': [
 [ 'node_shared=="true"', {
 'defines': [
 'USING_V8_SHARED',
 'USING_V8_PLATFORM_SHARED',
 ],
 'defines!': [
 'BUILDING_V8_PLATFORM_SHARED=1',
 'BUILDING_V8_SHARED=1',
 ],
 }, {
 # Only test shared embedding when Node is built as shared library.
 'type': 'none',
 }],
 # Only test platforms known to work.
 ['OS not in "mac win linux"', {
 'type': 'none',
 }],
 ['OS=="win"', {
 'libraries': [
 'Dbghelp.lib',
 'winmm.lib',
 'Ws2_32.lib',
 ],
 }],
 ['OS=="mac"', {
 'xcode_settings': {
 'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
 }
 }],
 ['OS=="linux"', {
 'ldflags': [
 '-Wl,-rpath,\\$$ORIGIN'
 ],
 }],
 ],
 }, # shared_embedtest

 {
 'target_name': 'overlapped-checker',
 'type': 'executable',
Expand Down

11 changes: 11 additions & 0 deletions
test/common/index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
 !process.env.NODE_SKIP_CRYPTO;

Expand DownExpand Up@@ -923,6 +925,13 @@ function sleepSync(ms) {
 Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
 if (isWindows) {
 binary += '.exe';
 }
 return path.join(path.dirname(process.execPath), binary);
}

const common = {
 allowGlobals,
 buildType,
Expand DownExpand Up@@ -967,6 +976,7 @@ const common = {
 printSkipMessage,
 pwdCommand,
 requireNoPackageJSONAbove,
 resolveBuiltBinary,
 runWithInvalidFD,
 skip,
 skipIf32Bits,
Expand All@@ -975,6 +985,7 @@ const common = {
 skipIfSQLiteMissing,
 spawnPromisified,
 sleepSync,
 usesSharedLibrary,

 get enoughTestMem() {
 return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down

58 changes: 58 additions & 0 deletions
test/embedding/shared_embedtest.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable final : public cppgc::GarbageCollected<Wrappable> {
 public:
 void Trace(cppgc::Visitor* visitor) const {}
};

int main(int argc, char* argv[]) {
 std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
 v8::V8::InitializePlatform(platform.get());
 cppgc::InitializeProcess(platform->GetPageAllocator());
 v8::V8::Initialize();

 auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
 v8::Isolate::CreateParams create_params;
 create_params.array_buffer_allocator =
 v8::ArrayBuffer::Allocator::NewDefaultAllocator();
 create_params.cpp_heap = heap.release();

 v8::Isolate* isolate = v8::Isolate::New(create_params);
 {
 v8::Isolate::Scope isolate_scope(isolate);
 v8::HandleScope handle_scope(isolate);
 v8::Local<v8::Context> context = v8::Context::New(isolate);
 v8::Context::Scope context_scope(context);

 v8::Local<v8::Object> obj = v8::Object::New(isolate);
 Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
 isolate->GetCppHeap()->GetAllocationHandle());
 v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
 isolate, obj, wrappable);
 v8::Local<v8::String> source =
 v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
 v8::Local<v8::Script> script =
 v8::Script::Compile(context, source).ToLocalChecked();
 v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
 v8::String::Utf8Value utf8(isolate, result);
 printf("%s\n", *utf8);
 }

 isolate->Dispose();
 cppgc::ShutdownProcess();
 v8::V8::Dispose();
 v8::V8::DisposePlatform();
 delete create_params.array_buffer_allocator;

 return 0;
}

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-create-require-fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Tests that createRequire() works correctly with local fs in embedded environments.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const fixtures = require('../common/fixtures');
const { spawnSyncAndExit } = require('../common/child_process');

const fixturePath = JSON.stringify(fixtures.path('exit.js'));
spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 [`require(${fixturePath})`, 92],
 {
 status: 92,
 signal: null,
 });

15 changes: 15 additions & 0 deletions
test/embedding/test-embedding-create-require-internal.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
'use strict';

// Tests that createRequire() from embedded environments still cannot access internals.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['require("lib/internal/test/binding")'],
 {
 status: 1,
 signal: null,
 });

27 changes: 27 additions & 0 deletions
test/embedding/test-embedding-disable-node-env-vars.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
'use strict';

// Tests node::ProcessInitializationFlags::kDisableNodeOptionsEnv works correctly.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');
const os = require('os');

if (process.config.variables.node_without_node_options) {
 common.skip('NODE_REPL_EXTERNAL_MODULE cannot be tested with --without-node-options');
}

const embedtest = common.resolveBuiltBinary('embedtest');
spawnSyncAndExit(
 embedtest,
 ['require("os")'],
 {
 env: {
 ...process.env,
 'NODE_REPL_EXTERNAL_MODULE': 'fs',
 },
 },
 {
 status: 9,
 signal: null,
 stderr: `${embedtest}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
 });

14 changes: 14 additions & 0 deletions
test/embedding/test-embedding-exit-code.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
'use strict';

// Tests that process.exitCode works correctly in embedded environments.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['process.exitCode = 8'],
 {
 status: 8,
 signal: null,
 });

16 changes: 16 additions & 0 deletions
test/embedding/test-embedding-load-environment-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
'use strict';

// Tests node::LoadEnvironment() with main_script_source_utf8 works.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(42)'],
 {
 trim: true,
 stdout: '42',
 });

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-load-environment-utf8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Test node::LoadEnvironment() works with non-ASCII source code. The variable
// comes from embedtest.cc.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(embedVars.nön_ascıı)'],
 {
 trim: true,
 stdout: '🏳️‍🌈',
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-as-file.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests node::EmbedderSnapshotData::FromFile() works correctly.
// The snapshot is created in embedtest.cc.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the --embedder-snapshot-as-file flag.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-as-file', '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests snapshot support in embedded environments.
// See embedtest.cc for the API usage.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the default flags.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[v24.x] backport embedding tests to v24.x#65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

joyeecheung
wants to merge
3
commits into

from

 Closed


[v24.x] backport embedding tests to v24.x
#65219
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
c091cdc

build,test: add tests for binary linked with shared libnode


joyeecheung Jan 28, 2026
f3038b1

test: split test-embedding.js and run tests in parallel


joyeecheung Feb 8, 2026
6f1831e

fixup! build,test: add tests for binary linked with shared libnode


joyeecheung Aug 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
node.gyp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1511,6 +1511,61 @@
 ],
 }, # embedtest

 {
 'target_name': 'shared_embedtest',
 'type': 'executable',

 'dependencies': [
 '<(node_lib_target_name)',
 ],

 # Don't depend on node.gypi - it otherwise links to
 # the static libraries and resolve symbols at build time.
 'include_dirs': [
 'deps/v8/include',
 ],

 'sources': [
 'test/embedding/shared_embedtest.cc',
 ],
 'conditions': [
 [ 'node_shared=="true"', {
 'defines': [
 'USING_V8_SHARED',
 'USING_V8_PLATFORM_SHARED',
 ],
 'defines!': [
 'BUILDING_V8_PLATFORM_SHARED=1',
 'BUILDING_V8_SHARED=1',
 ],
 }, {
 # Only test shared embedding when Node is built as shared library.
 'type': 'none',
 }],
 # Only test platforms known to work.
 ['OS not in "mac win linux"', {
 'type': 'none',
 }],
 ['OS=="win"', {
 'libraries': [
 'Dbghelp.lib',
 'winmm.lib',
 'Ws2_32.lib',
 ],
 }],
 ['OS=="mac"', {
 'xcode_settings': {
 'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
 }
 }],
 ['OS=="linux"', {
 'ldflags': [
 '-Wl,-rpath,\\$$ORIGIN'
 ],
 }],
 ],
 }, # shared_embedtest

 {
 'target_name': 'overlapped-checker',
 'type': 'executable',
Expand Down

11 changes: 11 additions & 0 deletions
test/common/index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
 !process.env.NODE_SKIP_CRYPTO;

Expand DownExpand Up@@ -923,6 +925,13 @@ function sleepSync(ms) {
 Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
 if (isWindows) {
 binary += '.exe';
 }
 return path.join(path.dirname(process.execPath), binary);
}

const common = {
 allowGlobals,
 buildType,
Expand DownExpand Up@@ -967,6 +976,7 @@ const common = {
 printSkipMessage,
 pwdCommand,
 requireNoPackageJSONAbove,
 resolveBuiltBinary,
 runWithInvalidFD,
 skip,
 skipIf32Bits,
Expand All@@ -975,6 +985,7 @@ const common = {
 skipIfSQLiteMissing,
 spawnPromisified,
 sleepSync,
 usesSharedLibrary,

 get enoughTestMem() {
 return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down

58 changes: 58 additions & 0 deletions
test/embedding/shared_embedtest.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable final : public cppgc::GarbageCollected<Wrappable> {
 public:
 void Trace(cppgc::Visitor* visitor) const {}
};

int main(int argc, char* argv[]) {
 std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
 v8::V8::InitializePlatform(platform.get());
 cppgc::InitializeProcess(platform->GetPageAllocator());
 v8::V8::Initialize();

 auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
 v8::Isolate::CreateParams create_params;
 create_params.array_buffer_allocator =
 v8::ArrayBuffer::Allocator::NewDefaultAllocator();
 create_params.cpp_heap = heap.release();

 v8::Isolate* isolate = v8::Isolate::New(create_params);
 {
 v8::Isolate::Scope isolate_scope(isolate);
 v8::HandleScope handle_scope(isolate);
 v8::Local<v8::Context> context = v8::Context::New(isolate);
 v8::Context::Scope context_scope(context);

 v8::Local<v8::Object> obj = v8::Object::New(isolate);
 Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
 isolate->GetCppHeap()->GetAllocationHandle());
 v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
 isolate, obj, wrappable);
 v8::Local<v8::String> source =
 v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
 v8::Local<v8::Script> script =
 v8::Script::Compile(context, source).ToLocalChecked();
 v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
 v8::String::Utf8Value utf8(isolate, result);
 printf("%s\n", *utf8);
 }

 isolate->Dispose();
 cppgc::ShutdownProcess();
 v8::V8::Dispose();
 v8::V8::DisposePlatform();
 delete create_params.array_buffer_allocator;

 return 0;
}

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-create-require-fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Tests that createRequire() works correctly with local fs in embedded environments.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const fixtures = require('../common/fixtures');
const { spawnSyncAndExit } = require('../common/child_process');

const fixturePath = JSON.stringify(fixtures.path('exit.js'));
spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 [`require(${fixturePath})`, 92],
 {
 status: 92,
 signal: null,
 });

15 changes: 15 additions & 0 deletions
test/embedding/test-embedding-create-require-internal.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
'use strict';

// Tests that createRequire() from embedded environments still cannot access internals.
// The createRequire() call is in embedtest.cc.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['require("lib/internal/test/binding")'],
 {
 status: 1,
 signal: null,
 });

27 changes: 27 additions & 0 deletions
test/embedding/test-embedding-disable-node-env-vars.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
'use strict';

// Tests node::ProcessInitializationFlags::kDisableNodeOptionsEnv works correctly.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');
const os = require('os');

if (process.config.variables.node_without_node_options) {
 common.skip('NODE_REPL_EXTERNAL_MODULE cannot be tested with --without-node-options');
}

const embedtest = common.resolveBuiltBinary('embedtest');
spawnSyncAndExit(
 embedtest,
 ['require("os")'],
 {
 env: {
 ...process.env,
 'NODE_REPL_EXTERNAL_MODULE': 'fs',
 },
 },
 {
 status: 9,
 signal: null,
 stderr: `${embedtest}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
 });

14 changes: 14 additions & 0 deletions
test/embedding/test-embedding-exit-code.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
'use strict';

// Tests that process.exitCode works correctly in embedded environments.

const common = require('../common');
const { spawnSyncAndExit } = require('../common/child_process');

spawnSyncAndExit(
 common.resolveBuiltBinary('embedtest'),
 ['process.exitCode = 8'],
 {
 status: 8,
 signal: null,
 });

16 changes: 16 additions & 0 deletions
test/embedding/test-embedding-load-environment-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
'use strict';

// Tests node::LoadEnvironment() with main_script_source_utf8 works.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(42)'],
 {
 trim: true,
 stdout: '42',
 });

17 changes: 17 additions & 0 deletions
test/embedding/test-embedding-load-environment-utf8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
'use strict';

// Test node::LoadEnvironment() works with non-ASCII source code. The variable
// comes from embedtest.cc.

const common = require('../common');
const { spawnSyncAndAssert } = require('../common/child_process');

const embedtest = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
 embedtest,
 ['console.log(embedVars.nön_ascıı)'],
 {
 trim: true,
 stdout: '🏳️‍🌈',
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-as-file.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests node::EmbedderSnapshotData::FromFile() works correctly.
// The snapshot is created in embedtest.cc.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the --embedder-snapshot-as-file flag.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-as-file', '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });

50 changes: 50 additions & 0 deletions
test/embedding/test-embedding-snapshot-basic.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
'use strict';

// Tests snapshot support in embedded environments.
// See embedtest.cc for the API usage.

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fixtures = require('../common/fixtures');

const {
 spawnSyncAndAssert,
 spawnSyncAndExitWithoutError,
} = require('../common/child_process');

const snapshotFixture = fixtures.path('snapshot', 'echo-args.js');
const embedtest = common.resolveBuiltBinary('embedtest');

const buildSnapshotExecArgs = [
 `eval(require("fs").readFileSync(${JSON.stringify(snapshotFixture)}, "utf8"))`,
 'arg1', 'arg2',
];
const snapshotBlobArgs = [
 '--embedder-snapshot-blob', tmpdir.resolve('embedder-snapshot.blob'),
];

const runSnapshotExecArgs = ['arg3', 'arg4'];

tmpdir.refresh();

// Build the snapshot with the default flags.
spawnSyncAndExitWithoutError(
 embedtest,
 ['--', ...buildSnapshotExecArgs, ...snapshotBlobArgs, '--embedder-snapshot-create'],
 { cwd: tmpdir.path });

// Run the snapshot and check the serialized and refreshed argv values.
spawnSyncAndAssert(
 embedtest,
 ['--', ...runSnapshotExecArgs, ...snapshotBlobArgs ],
 { cwd: tmpdir.path },
 {
 stdout(output) {
 assert.deepStrictEqual(JSON.parse(output), {
 originalArgv: [embedtest, '__node_anonymous_main', ...buildSnapshotExecArgs],
 currentArgv: [embedtest, ...runSnapshotExecArgs],
 });
 return true;
 },
 });
Loading
Loading