test: wait for FFI background optimization by trivikr · Pull Request #65300 · nodejs/node

trivikr · 2026-08-15T05:53:52Z

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.

Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.

Assisted-by: codex:gpt-5.6-sol

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol

nodejs-github-bot · 2026-08-15T05:53:57Z

Review requested:

@nodejs/ffi

nodejs-github-bot · 2026-08-15T05:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75856/

github-actions · 2026-08-15T07:01:04Z

Fast-track has been requested by @trivikr. Please 👍 to approve.

codecov · 2026-08-15T07:24:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (4551732) to head (46e3f30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02% 
==========================================
Files 751 751 Lines 250235 250235 Branches 47305 47303 -2 ==========================================
+ Hits 225987 226044 +57 + Misses 15619 15566 -53 + Partials 8629 8625 -4

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-08-15T17:44:01Z

Removed request-ci as it was run manually in #65300 (comment)

gurgunday

lgtm

trivikr · 2026-08-15T17:51:06Z

For some reason, the stress test is not detecting the test file for PR.

In main

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validationTAP version 131..1ok 1 ffi/test-ffi-fast-integer-validation --- duration_ms: 413.13500 ...All tests passed.

https://ci.nodejs.org/job/node-stress-single-test/828

For PR

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ‎ffi/test-ffi-fast-integer-validationNo tests to run.+ NOK=1+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'1 OK: 0 NOT OK: 1 TOTAL: 1000+ tap2junit -i test1.tap -o test1.xmlTraceback (most recent call last): File "/home/iojs/venv/bin/tap2junit", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main convert( File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert result = parse(name or input_file, data, package) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse tap_parser.parse(data) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse self._parse(io.StringIO(source)) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse match = RE_VERSION.match(non_empty_lines[0]) ~~~~~~~~~~~~~~~^^^IndexError: list index out of range+ true

https://ci.nodejs.org/job/node-stress-single-test/829

I've confirmed by running the test locally though

100 runs at -j8.

5 crashes in main
0 crashes in PR

nodejs-github-bot · 2026-08-15T18:20:36Z

Landed in c55fa12

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

trivikr · 2026-08-15T05:53:52Z

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.

Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.

Assisted-by: codex:gpt-5.6-sol

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol

nodejs-github-bot · 2026-08-15T05:53:57Z

Review requested:

@nodejs/ffi

nodejs-github-bot · 2026-08-15T05:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75856/

github-actions · 2026-08-15T07:01:04Z

Fast-track has been requested by @trivikr. Please 👍 to approve.

codecov · 2026-08-15T07:24:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (4551732) to head (46e3f30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02% 
==========================================
Files 751 751 Lines 250235 250235 Branches 47305 47303 -2 ==========================================
+ Hits 225987 226044 +57 + Misses 15619 15566 -53 + Partials 8629 8625 -4

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-08-15T17:44:01Z

Removed request-ci as it was run manually in #65300 (comment)

gurgunday

lgtm

trivikr · 2026-08-15T17:51:06Z

For some reason, the stress test is not detecting the test file for PR.

In main

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validationTAP version 131..1ok 1 ffi/test-ffi-fast-integer-validation --- duration_ms: 413.13500 ...All tests passed.

https://ci.nodejs.org/job/node-stress-single-test/828

For PR

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ‎ffi/test-ffi-fast-integer-validationNo tests to run.+ NOK=1+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'1 OK: 0 NOT OK: 1 TOTAL: 1000+ tap2junit -i test1.tap -o test1.xmlTraceback (most recent call last): File "/home/iojs/venv/bin/tap2junit", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main convert( File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert result = parse(name or input_file, data, package) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse tap_parser.parse(data) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse self._parse(io.StringIO(source)) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse match = RE_VERSION.match(non_empty_lines[0]) ~~~~~~~~~~~~~~~^^^IndexError: list index out of range+ true

https://ci.nodejs.org/job/node-stress-single-test/829

I've confirmed by running the test locally though

100 runs at -j8.

5 crashes in main
0 crashes in PR

nodejs-github-bot · 2026-08-15T18:20:36Z

Landed in c55fa12

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

trivikr · 2026-08-15T05:53:52Z

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.

Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.

Assisted-by: codex:gpt-5.6-sol

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol

nodejs-github-bot · 2026-08-15T05:53:57Z

Review requested:

@nodejs/ffi

nodejs-github-bot · 2026-08-15T05:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75856/

github-actions · 2026-08-15T07:01:04Z

Fast-track has been requested by @trivikr. Please 👍 to approve.

codecov · 2026-08-15T07:24:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (4551732) to head (46e3f30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02% 
==========================================
Files 751 751 Lines 250235 250235 Branches 47305 47303 -2 ==========================================
+ Hits 225987 226044 +57 + Misses 15619 15566 -53 + Partials 8629 8625 -4

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-08-15T17:44:01Z

Removed request-ci as it was run manually in #65300 (comment)

gurgunday

lgtm

trivikr · 2026-08-15T17:51:06Z

For some reason, the stress test is not detecting the test file for PR.

In main

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validationTAP version 131..1ok 1 ffi/test-ffi-fast-integer-validation --- duration_ms: 413.13500 ...All tests passed.

https://ci.nodejs.org/job/node-stress-single-test/828

For PR

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ‎ffi/test-ffi-fast-integer-validationNo tests to run.+ NOK=1+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'1 OK: 0 NOT OK: 1 TOTAL: 1000+ tap2junit -i test1.tap -o test1.xmlTraceback (most recent call last): File "/home/iojs/venv/bin/tap2junit", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main convert( File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert result = parse(name or input_file, data, package) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse tap_parser.parse(data) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse self._parse(io.StringIO(source)) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse match = RE_VERSION.match(non_empty_lines[0]) ~~~~~~~~~~~~~~~^^^IndexError: list index out of range+ true

https://ci.nodejs.org/job/node-stress-single-test/829

I've confirmed by running the test locally though

100 runs at -j8.

5 crashes in main
0 crashes in PR

nodejs-github-bot · 2026-08-15T18:20:36Z

Landed in c55fa12

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

trivikr · 2026-08-15T05:53:52Z

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.

Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.

Assisted-by: codex:gpt-5.6-sol

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol

nodejs-github-bot · 2026-08-15T05:53:57Z

Review requested:

@nodejs/ffi

nodejs-github-bot · 2026-08-15T05:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75856/

github-actions · 2026-08-15T07:01:04Z

Fast-track has been requested by @trivikr. Please 👍 to approve.

codecov · 2026-08-15T07:24:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (4551732) to head (46e3f30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02% 
==========================================
Files 751 751 Lines 250235 250235 Branches 47305 47303 -2 ==========================================
+ Hits 225987 226044 +57 + Misses 15619 15566 -53 + Partials 8629 8625 -4

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-08-15T17:44:01Z

Removed request-ci as it was run manually in #65300 (comment)

gurgunday

lgtm

trivikr · 2026-08-15T17:51:06Z

For some reason, the stress test is not detecting the test file for PR.

In main

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validationTAP version 131..1ok 1 ffi/test-ffi-fast-integer-validation --- duration_ms: 413.13500 ...All tests passed.

https://ci.nodejs.org/job/node-stress-single-test/828

For PR

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ‎ffi/test-ffi-fast-integer-validationNo tests to run.+ NOK=1+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'1 OK: 0 NOT OK: 1 TOTAL: 1000+ tap2junit -i test1.tap -o test1.xmlTraceback (most recent call last): File "/home/iojs/venv/bin/tap2junit", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main convert( File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert result = parse(name or input_file, data, package) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse tap_parser.parse(data) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse self._parse(io.StringIO(source)) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse match = RE_VERSION.match(non_empty_lines[0]) ~~~~~~~~~~~~~~~^^^IndexError: list index out of range+ true

https://ci.nodejs.org/job/node-stress-single-test/829

I've confirmed by running the test locally though

100 runs at -j8.

5 crashes in main
0 crashes in PR

nodejs-github-bot · 2026-08-15T18:20:36Z

Landed in c55fa12

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

trivikr · 2026-08-15T05:53:52Z

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.

Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.

Assisted-by: codex:gpt-5.6-sol

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol

nodejs-github-bot · 2026-08-15T05:53:57Z

Review requested:

@nodejs/ffi

nodejs-github-bot · 2026-08-15T05:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75856/

github-actions · 2026-08-15T07:01:04Z

Fast-track has been requested by @trivikr. Please 👍 to approve.

codecov · 2026-08-15T07:24:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (4551732) to head (46e3f30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02% 
==========================================
Files 751 751 Lines 250235 250235 Branches 47305 47303 -2 ==========================================
+ Hits 225987 226044 +57 + Misses 15619 15566 -53 + Partials 8629 8625 -4

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-08-15T17:44:01Z

Removed request-ci as it was run manually in #65300 (comment)

gurgunday

lgtm

trivikr · 2026-08-15T17:51:06Z

For some reason, the stress test is not detecting the test file for PR.

In main

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validationTAP version 131..1ok 1 ffi/test-ffi-fast-integer-validation --- duration_ms: 413.13500 ...All tests passed.

https://ci.nodejs.org/job/node-stress-single-test/828

For PR

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ‎ffi/test-ffi-fast-integer-validationNo tests to run.+ NOK=1+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'1 OK: 0 NOT OK: 1 TOTAL: 1000+ tap2junit -i test1.tap -o test1.xmlTraceback (most recent call last): File "/home/iojs/venv/bin/tap2junit", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main convert( File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert result = parse(name or input_file, data, package) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse tap_parser.parse(data) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse self._parse(io.StringIO(source)) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse match = RE_VERSION.match(non_empty_lines[0]) ~~~~~~~~~~~~~~~^^^IndexError: list index out of range+ true

https://ci.nodejs.org/job/node-stress-single-test/829

I've confirmed by running the test locally though

100 runs at -j8.

5 crashes in main
0 crashes in PR

nodejs-github-bot · 2026-08-15T18:20:36Z

Landed in c55fa12

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

trivikr · 2026-08-15T05:53:52Z

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.

Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.

Assisted-by: codex:gpt-5.6-sol

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol

nodejs-github-bot · 2026-08-15T05:53:57Z

Review requested:

@nodejs/ffi

nodejs-github-bot · 2026-08-15T05:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75856/

github-actions · 2026-08-15T07:01:04Z

Fast-track has been requested by @trivikr. Please 👍 to approve.

codecov · 2026-08-15T07:24:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (4551732) to head (46e3f30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02% 
==========================================
Files 751 751 Lines 250235 250235 Branches 47305 47303 -2 ==========================================
+ Hits 225987 226044 +57 + Misses 15619 15566 -53 + Partials 8629 8625 -4

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-08-15T17:44:01Z

Removed request-ci as it was run manually in #65300 (comment)

gurgunday

lgtm

trivikr · 2026-08-15T17:51:06Z

For some reason, the stress test is not detecting the test file for PR.

In main

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validationTAP version 131..1ok 1 ffi/test-ffi-fast-integer-validation --- duration_ms: 413.13500 ...All tests passed.

https://ci.nodejs.org/job/node-stress-single-test/828

For PR

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ‎ffi/test-ffi-fast-integer-validationNo tests to run.+ NOK=1+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'1 OK: 0 NOT OK: 1 TOTAL: 1000+ tap2junit -i test1.tap -o test1.xmlTraceback (most recent call last): File "/home/iojs/venv/bin/tap2junit", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main convert( File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert result = parse(name or input_file, data, package) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse tap_parser.parse(data) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse self._parse(io.StringIO(source)) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse match = RE_VERSION.match(non_empty_lines[0]) ~~~~~~~~~~~~~~~^^^IndexError: list index out of range+ true

https://ci.nodejs.org/job/node-stress-single-test/829

I've confirmed by running the test locally though

100 runs at -j8.

5 crashes in main
0 crashes in PR

nodejs-github-bot · 2026-08-15T18:20:36Z

Landed in c55fa12

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

trivikr · 2026-08-15T05:53:52Z

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.

Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.

Assisted-by: codex:gpt-5.6-sol

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol

nodejs-github-bot · 2026-08-15T05:53:57Z

Review requested:

@nodejs/ffi

nodejs-github-bot · 2026-08-15T05:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75856/

github-actions · 2026-08-15T07:01:04Z

Fast-track has been requested by @trivikr. Please 👍 to approve.

codecov · 2026-08-15T07:24:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (4551732) to head (46e3f30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02% 
==========================================
Files 751 751 Lines 250235 250235 Branches 47305 47303 -2 ==========================================
+ Hits 225987 226044 +57 + Misses 15619 15566 -53 + Partials 8629 8625 -4

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-08-15T17:44:01Z

Removed request-ci as it was run manually in #65300 (comment)

gurgunday

lgtm

trivikr · 2026-08-15T17:51:06Z

For some reason, the stress test is not detecting the test file for PR.

In main

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validationTAP version 131..1ok 1 ffi/test-ffi-fast-integer-validation --- duration_ms: 413.13500 ...All tests passed.

https://ci.nodejs.org/job/node-stress-single-test/828

For PR

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ‎ffi/test-ffi-fast-integer-validationNo tests to run.+ NOK=1+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'1 OK: 0 NOT OK: 1 TOTAL: 1000+ tap2junit -i test1.tap -o test1.xmlTraceback (most recent call last): File "/home/iojs/venv/bin/tap2junit", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main convert( File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert result = parse(name or input_file, data, package) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse tap_parser.parse(data) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse self._parse(io.StringIO(source)) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse match = RE_VERSION.match(non_empty_lines[0]) ~~~~~~~~~~~~~~~^^^IndexError: list index out of range+ true

https://ci.nodejs.org/job/node-stress-single-test/829

I've confirmed by running the test locally though

100 runs at -j8.

5 crashes in main
0 crashes in PR

nodejs-github-bot · 2026-08-15T18:20:36Z

Landed in c55fa12

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

trivikr · 2026-08-15T05:53:52Z

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures.

Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference.

Assisted-by: codex:gpt-5.6-sol

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol

nodejs-github-bot · 2026-08-15T05:53:57Z

Review requested:

@nodejs/ffi

nodejs-github-bot · 2026-08-15T05:55:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75856/

github-actions · 2026-08-15T07:01:04Z

Fast-track has been requested by @trivikr. Please 👍 to approve.

codecov · 2026-08-15T07:24:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (4551732) to head (46e3f30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65300 +/- ##
==========================================
+ Coverage 90.30% 90.33% +0.02% 
==========================================
Files 751 751 Lines 250235 250235 Branches 47305 47303 -2 ==========================================
+ Hits 225987 226044 +57 + Misses 15619 15566 -53 + Partials 8629 8625 -4

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr · 2026-08-15T17:44:01Z

Removed request-ci as it was run manually in #65300 (comment)

gurgunday

lgtm

trivikr · 2026-08-15T17:51:06Z

For some reason, the stress test is not detecting the test file for PR.

In main

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ffi/test-ffi-fast-integer-validationTAP version 131..1ok 1 ffi/test-ffi-fast-integer-validation --- duration_ms: 413.13500 ...All tests passed.

https://ci.nodejs.org/job/node-stress-single-test/828

For PR

+ /home/iojs/venv/bin/python3.12 tools/test.py -p tap --logfile test1.tap --mode=release ‎ffi/test-ffi-fast-integer-validationNo tests to run.+ NOK=1+ echo '1 OK: 0 NOT OK: 1 TOTAL: 1000'1 OK: 0 NOT OK: 1 TOTAL: 1000+ tap2junit -i test1.tap -o test1.xmlTraceback (most recent call last): File "/home/iojs/venv/bin/tap2junit", line 8, in <module> sys.exit(main()) ^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 94, in main convert( File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 68, in convert result = parse(name or input_file, data, package) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/__main__.py", line 58, in parse tap_parser.parse(data) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 237, in parse self._parse(io.StringIO(source)) File "/home/iojs/venv/lib/python3.12/site-packages/tap2junit/tap13.py", line 107, in _parse match = RE_VERSION.match(non_empty_lines[0]) ~~~~~~~~~~~~~~~^^^IndexError: list index out of range+ true

https://ci.nodejs.org/job/node-stress-single-test/829

I've confirmed by running the test locally though

100 runs at -j8.

5 crashes in main
0 crashes in PR

nodejs-github-bot · 2026-08-15T18:20:36Z

Landed in c55fa12

The pointer range test creates multiple closures from the same function literals and explicitly requests synchronous optimization. V8 can also schedule concurrent recompilation for those closures. Wait for background optimization before closing the dynamic library so compiler jobs cannot outlive the fast FFI metadata they reference. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65300 Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20%22test-ffi-fast-integer-validation%22 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 15, 2026

trivikr added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Aug 15, 2026

trivikr added the ffi Issues and PRs related to experimental Foreign Function Interface support. label Aug 15, 2026

trivikr requested review from ShogunPanda and mcollina August 15, 2026 07:00

trivikr added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 15, 2026

avivkeller approved these changes Aug 15, 2026
View reviewed changes

avivkeller added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 15, 2026

trivikr removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2026

gurgunday approved these changes Aug 15, 2026
View reviewed changes

trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2026

nodejs-github-bot merged commit c55fa12 into nodejs:mainAug 15, 2026
107 of 108 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2026

trivikr deleted the test-ffi-fast-integer-validation branch August 16, 2026 16:01

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged