stream: avoid duplicated endReadableNT scheduling - #65310

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:stream-dedupe-endreadable-tick
Aug 23, 2026
Merged

stream: avoid duplicated endReadableNT scheduling#65310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mcollina:stream-dedupe-endreadable-tick

Conversation

@mcollina

@mcollinamcollina commented Aug 15, 2026

Copy link
Copy Markdown
Member

Calling read() on an ended stream multiple times before the microtask queue drains scheduled one endReadableNT tick per call, since the only guard (endEmitted) is set inside the tick itself. A hello-world HTTP server was scheduling it four times per request while dumping the unread request body.

Add a kEndScheduled flag, armed on scheduling and cleared when the tick runs. It must be cleared unconditionally: undestroy() resets endEmitted through the state descriptors but cannot reach this flag, and a stale value would block 'end' after a net.Socket reconnect.

Benchmarks vs main: streams/finished.js readable +10.45% (99.9% confidence), no significant regressions across the streams suite; ~+1-3% on HTTP server benchmarks (10 → 7 nextTicks per request).

@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to Node.js streams. labels Aug 15, 2026
@codecov

codecovBot commented Aug 15, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (347e266) to head (4ccbe5e).
⚠️ Report is 251 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #65310 +/- ##
==========================================
- Coverage 90.30% 90.12% -0.18% 
==========================================
Files 759 752 -7 Lines 248294 251576 +3282 Branches 46860 47263 +403 ==========================================
+ Hits 224220 226737 +2517 - Misses 15516 16178 +662 - Partials 8558 8661 +103
Files with missing linesCoverage Δ
lib/internal/streams/readable.js96.56% <100.00%> (-0.72%)⬇️

... and 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
stream: avoid duplicated endReadableNT scheduling
4ccbe5e
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 16, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75878/

@mcollina
mcollinaforce-pushed the stream-dedupe-endreadable-tick branch from 4c33258 to 4ccbe5eCompareAugust 16, 2026 20:46
@ronagronag added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 19, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 19, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-16T08:13:00Z: https://ci.nodejs.org/job/node-test-pull-request/75878/
- Querying data for job/node-test-pull-request/75878/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90607/
✔ Data downloaded
✘ 23 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32254812825

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 19, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76092/

@mcollinamcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 21, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-20T23:59:20Z: https://ci.nodejs.org/job/node-test-pull-request/76092/
- Querying data for job/node-test-pull-request/76092/
✔ Build data downloaded
✘ Last Jenkins CI still running
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32435803605

@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76115/

@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76170/

@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76177/

@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76193/

@mcollinamcollina added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 82babee into nodejs:mainAug 23, 2026
87 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Landed in 82babee

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
9e59a62
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
c42fbcc
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
70e41cd
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@mcollina
mcollina deleted the stream-dedupe-endreadable-tick branch August 29, 2026 06:13
@mcollinamcollina mentioned this pull request Sep 2, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@ronagronagronag approved these changes

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@ShogunPanda@jasnell@ronag
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
stream: avoid duplicated endReadableNT scheduling - #65310
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Aug 23, 2026
Merged
stream: avoid duplicated endReadableNT scheduling#65310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Conversation
@mcollina
@mcollinamcollina
commented
Aug 15, 2026

Copy link


Copy Markdown

Member
Calling read() on an ended stream multiple times before the microtask queue drains scheduled one endReadableNT tick per call, since the only guard (endEmitted) is set inside the tick itself. A hello-world HTTP server was scheduling it four times per request while dumping the unread request body.
Add a kEndScheduled flag, armed on scheduling and cleared when the tick runs. It must be cleared unconditionally: undestroy() resets endEmitted through the state descriptors but cannot reach this flag, and a stale value would block 'end' after a net.Socket reconnect.
Benchmarks vs main: streams/finished.js readable +10.45% (99.9% confidence), no significant regressions across the streams suite; ~+1-3% on HTTP server benchmarks (10 → 7 nextTicks per request).
@nodejs-github-bot
nodejs-github-bot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
stream
Issues and PRs related to Node.js streams.
labels
Aug 15, 2026
@codecov
codecovBot
commented
Aug 15, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (347e266) to head (4ccbe5e).
⚠️ Report is 251 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65310 +/- ##
==========================================
- Coverage 90.30% 90.12% -0.18% 
==========================================
Files 759 752 -7 Lines 248294 251576 +3282 Branches 46860 47263 +403 ==========================================
+ Hits 224220 226737 +2517 - Misses 15516 16178 +662 - Partials 8558 8661 +103 
Files with missing linesCoverage Δ
lib/internal/streams/readable.js96.56% <100.00%> (-0.72%)⬇️
... and 178 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mcollina
stream: avoid duplicated endReadableNT scheduling
4ccbe5e
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@ronagronag
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 16, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 16, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75878/
@mcollina
mcollinaforce-pushed
the
stream-dedupe-endreadable-tick
branch
from
4c33258 to
4ccbe5eCompareAugust 16, 2026 20:46
@ronagronag
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-16T08:13:00Z: https://ci.nodejs.org/job/node-test-pull-request/75878/
- Querying data for job/node-test-pull-request/75878/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90607/
✔ Data downloaded
✘ 23 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32254812825
@mcollinamcollina
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 19, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76092/
@mcollinamcollina
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 21, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-20T23:59:20Z: https://ci.nodejs.org/job/node-test-pull-request/76092/
- Querying data for job/node-test-pull-request/76092/
✔ Build data downloaded
✘ Last Jenkins CI still running
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32435803605
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76115/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76170/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76177/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76193/
@mcollinamcollina
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 82babee
into
nodejs:mainAug 23, 2026

87 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 23, 2026

Copy link


Copy Markdown

Collaborator
Landed in 82babee
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
9e59a62
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
c42fbcc
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
70e41cd
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@mcollina
mcollina
deleted the

stream-dedupe-endreadable-tick

branch
August 29, 2026 06:13
@mcollinamcollina
mentioned this pull request
Sep 2, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@ronagronagronag approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@ShogunPanda@jasnell@ronag

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
stream: avoid duplicated endReadableNT scheduling - #65310
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Aug 23, 2026
Merged
stream: avoid duplicated endReadableNT scheduling#65310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Conversation
@mcollina
@mcollinamcollina
commented
Aug 15, 2026

Copy link


Copy Markdown

Member
Calling read() on an ended stream multiple times before the microtask queue drains scheduled one endReadableNT tick per call, since the only guard (endEmitted) is set inside the tick itself. A hello-world HTTP server was scheduling it four times per request while dumping the unread request body.
Add a kEndScheduled flag, armed on scheduling and cleared when the tick runs. It must be cleared unconditionally: undestroy() resets endEmitted through the state descriptors but cannot reach this flag, and a stale value would block 'end' after a net.Socket reconnect.
Benchmarks vs main: streams/finished.js readable +10.45% (99.9% confidence), no significant regressions across the streams suite; ~+1-3% on HTTP server benchmarks (10 → 7 nextTicks per request).
@nodejs-github-bot
nodejs-github-bot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
stream
Issues and PRs related to Node.js streams.
labels
Aug 15, 2026
@codecov
codecovBot
commented
Aug 15, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (347e266) to head (4ccbe5e).
⚠️ Report is 251 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65310 +/- ##
==========================================
- Coverage 90.30% 90.12% -0.18% 
==========================================
Files 759 752 -7 Lines 248294 251576 +3282 Branches 46860 47263 +403 ==========================================
+ Hits 224220 226737 +2517 - Misses 15516 16178 +662 - Partials 8558 8661 +103 
Files with missing linesCoverage Δ
lib/internal/streams/readable.js96.56% <100.00%> (-0.72%)⬇️
... and 178 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mcollina
stream: avoid duplicated endReadableNT scheduling
4ccbe5e
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@ronagronag
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 16, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 16, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75878/
@mcollina
mcollinaforce-pushed
the
stream-dedupe-endreadable-tick
branch
from
4c33258 to
4ccbe5eCompareAugust 16, 2026 20:46
@ronagronag
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-16T08:13:00Z: https://ci.nodejs.org/job/node-test-pull-request/75878/
- Querying data for job/node-test-pull-request/75878/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90607/
✔ Data downloaded
✘ 23 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32254812825
@mcollinamcollina
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 19, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76092/
@mcollinamcollina
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 21, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-20T23:59:20Z: https://ci.nodejs.org/job/node-test-pull-request/76092/
- Querying data for job/node-test-pull-request/76092/
✔ Build data downloaded
✘ Last Jenkins CI still running
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32435803605
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76115/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76170/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76177/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76193/
@mcollinamcollina
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 82babee
into
nodejs:mainAug 23, 2026

87 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 23, 2026

Copy link


Copy Markdown

Collaborator
Landed in 82babee
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
9e59a62
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
c42fbcc
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
70e41cd
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@mcollina
mcollina
deleted the

stream-dedupe-endreadable-tick

branch
August 29, 2026 06:13
@mcollinamcollina
mentioned this pull request
Sep 2, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@ronagronagronag approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@ShogunPanda@jasnell@ronag

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
stream: avoid duplicated endReadableNT scheduling - #65310
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Aug 23, 2026
Merged
stream: avoid duplicated endReadableNT scheduling#65310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Conversation
@mcollina
@mcollinamcollina
commented
Aug 15, 2026

Copy link


Copy Markdown

Member
Calling read() on an ended stream multiple times before the microtask queue drains scheduled one endReadableNT tick per call, since the only guard (endEmitted) is set inside the tick itself. A hello-world HTTP server was scheduling it four times per request while dumping the unread request body.
Add a kEndScheduled flag, armed on scheduling and cleared when the tick runs. It must be cleared unconditionally: undestroy() resets endEmitted through the state descriptors but cannot reach this flag, and a stale value would block 'end' after a net.Socket reconnect.
Benchmarks vs main: streams/finished.js readable +10.45% (99.9% confidence), no significant regressions across the streams suite; ~+1-3% on HTTP server benchmarks (10 → 7 nextTicks per request).
@nodejs-github-bot
nodejs-github-bot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
stream
Issues and PRs related to Node.js streams.
labels
Aug 15, 2026
@codecov
codecovBot
commented
Aug 15, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (347e266) to head (4ccbe5e).
⚠️ Report is 251 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65310 +/- ##
==========================================
- Coverage 90.30% 90.12% -0.18% 
==========================================
Files 759 752 -7 Lines 248294 251576 +3282 Branches 46860 47263 +403 ==========================================
+ Hits 224220 226737 +2517 - Misses 15516 16178 +662 - Partials 8558 8661 +103 
Files with missing linesCoverage Δ
lib/internal/streams/readable.js96.56% <100.00%> (-0.72%)⬇️
... and 178 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mcollina
stream: avoid duplicated endReadableNT scheduling
4ccbe5e
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@ronagronag
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 16, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 16, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75878/
@mcollina
mcollinaforce-pushed
the
stream-dedupe-endreadable-tick
branch
from
4c33258 to
4ccbe5eCompareAugust 16, 2026 20:46
@ronagronag
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-16T08:13:00Z: https://ci.nodejs.org/job/node-test-pull-request/75878/
- Querying data for job/node-test-pull-request/75878/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90607/
✔ Data downloaded
✘ 23 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32254812825
@mcollinamcollina
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 19, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76092/
@mcollinamcollina
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 21, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-20T23:59:20Z: https://ci.nodejs.org/job/node-test-pull-request/76092/
- Querying data for job/node-test-pull-request/76092/
✔ Build data downloaded
✘ Last Jenkins CI still running
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32435803605
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76115/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76170/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76177/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76193/
@mcollinamcollina
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 82babee
into
nodejs:mainAug 23, 2026

87 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 23, 2026

Copy link


Copy Markdown

Collaborator
Landed in 82babee
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
9e59a62
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
c42fbcc
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
70e41cd
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@mcollina
mcollina
deleted the

stream-dedupe-endreadable-tick

branch
August 29, 2026 06:13
@mcollinamcollina
mentioned this pull request
Sep 2, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@ronagronagronag approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@ShogunPanda@jasnell@ronag

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
stream: avoid duplicated endReadableNT scheduling - #65310
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Aug 23, 2026
Merged
stream: avoid duplicated endReadableNT scheduling#65310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Conversation
@mcollina
@mcollinamcollina
commented
Aug 15, 2026

Copy link


Copy Markdown

Member
Calling read() on an ended stream multiple times before the microtask queue drains scheduled one endReadableNT tick per call, since the only guard (endEmitted) is set inside the tick itself. A hello-world HTTP server was scheduling it four times per request while dumping the unread request body.
Add a kEndScheduled flag, armed on scheduling and cleared when the tick runs. It must be cleared unconditionally: undestroy() resets endEmitted through the state descriptors but cannot reach this flag, and a stale value would block 'end' after a net.Socket reconnect.
Benchmarks vs main: streams/finished.js readable +10.45% (99.9% confidence), no significant regressions across the streams suite; ~+1-3% on HTTP server benchmarks (10 → 7 nextTicks per request).
@nodejs-github-bot
nodejs-github-bot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
stream
Issues and PRs related to Node.js streams.
labels
Aug 15, 2026
@codecov
codecovBot
commented
Aug 15, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (347e266) to head (4ccbe5e).
⚠️ Report is 251 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65310 +/- ##
==========================================
- Coverage 90.30% 90.12% -0.18% 
==========================================
Files 759 752 -7 Lines 248294 251576 +3282 Branches 46860 47263 +403 ==========================================
+ Hits 224220 226737 +2517 - Misses 15516 16178 +662 - Partials 8558 8661 +103 
Files with missing linesCoverage Δ
lib/internal/streams/readable.js96.56% <100.00%> (-0.72%)⬇️
... and 178 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mcollina
stream: avoid duplicated endReadableNT scheduling
4ccbe5e
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@ronagronag
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 16, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 16, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75878/
@mcollina
mcollinaforce-pushed
the
stream-dedupe-endreadable-tick
branch
from
4c33258 to
4ccbe5eCompareAugust 16, 2026 20:46
@ronagronag
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-16T08:13:00Z: https://ci.nodejs.org/job/node-test-pull-request/75878/
- Querying data for job/node-test-pull-request/75878/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90607/
✔ Data downloaded
✘ 23 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32254812825
@mcollinamcollina
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 19, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76092/
@mcollinamcollina
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 21, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-20T23:59:20Z: https://ci.nodejs.org/job/node-test-pull-request/76092/
- Querying data for job/node-test-pull-request/76092/
✔ Build data downloaded
✘ Last Jenkins CI still running
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32435803605
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76115/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76170/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76177/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76193/
@mcollinamcollina
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 82babee
into
nodejs:mainAug 23, 2026

87 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 23, 2026

Copy link


Copy Markdown

Collaborator
Landed in 82babee
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
9e59a62
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
c42fbcc
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
70e41cd
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@mcollina
mcollina
deleted the

stream-dedupe-endreadable-tick

branch
August 29, 2026 06:13
@mcollinamcollina
mentioned this pull request
Sep 2, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@ronagronagronag approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@ShogunPanda@jasnell@ronag

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
stream: avoid duplicated endReadableNT scheduling - #65310
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Aug 23, 2026
Merged
stream: avoid duplicated endReadableNT scheduling#65310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Conversation
@mcollina
@mcollinamcollina
commented
Aug 15, 2026

Copy link


Copy Markdown

Member
Calling read() on an ended stream multiple times before the microtask queue drains scheduled one endReadableNT tick per call, since the only guard (endEmitted) is set inside the tick itself. A hello-world HTTP server was scheduling it four times per request while dumping the unread request body.
Add a kEndScheduled flag, armed on scheduling and cleared when the tick runs. It must be cleared unconditionally: undestroy() resets endEmitted through the state descriptors but cannot reach this flag, and a stale value would block 'end' after a net.Socket reconnect.
Benchmarks vs main: streams/finished.js readable +10.45% (99.9% confidence), no significant regressions across the streams suite; ~+1-3% on HTTP server benchmarks (10 → 7 nextTicks per request).
@nodejs-github-bot
nodejs-github-bot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
stream
Issues and PRs related to Node.js streams.
labels
Aug 15, 2026
@codecov
codecovBot
commented
Aug 15, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (347e266) to head (4ccbe5e).
⚠️ Report is 251 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65310 +/- ##
==========================================
- Coverage 90.30% 90.12% -0.18% 
==========================================
Files 759 752 -7 Lines 248294 251576 +3282 Branches 46860 47263 +403 ==========================================
+ Hits 224220 226737 +2517 - Misses 15516 16178 +662 - Partials 8558 8661 +103 
Files with missing linesCoverage Δ
lib/internal/streams/readable.js96.56% <100.00%> (-0.72%)⬇️
... and 178 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mcollina
stream: avoid duplicated endReadableNT scheduling
4ccbe5e
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@ronagronag
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 16, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 16, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75878/
@mcollina
mcollinaforce-pushed
the
stream-dedupe-endreadable-tick
branch
from
4c33258 to
4ccbe5eCompareAugust 16, 2026 20:46
@ronagronag
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-16T08:13:00Z: https://ci.nodejs.org/job/node-test-pull-request/75878/
- Querying data for job/node-test-pull-request/75878/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90607/
✔ Data downloaded
✘ 23 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32254812825
@mcollinamcollina
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 19, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76092/
@mcollinamcollina
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 21, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-20T23:59:20Z: https://ci.nodejs.org/job/node-test-pull-request/76092/
- Querying data for job/node-test-pull-request/76092/
✔ Build data downloaded
✘ Last Jenkins CI still running
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32435803605
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76115/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76170/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76177/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76193/
@mcollinamcollina
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 82babee
into
nodejs:mainAug 23, 2026

87 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 23, 2026

Copy link


Copy Markdown

Collaborator
Landed in 82babee
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
9e59a62
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
c42fbcc
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
70e41cd
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@mcollina
mcollina
deleted the

stream-dedupe-endreadable-tick

branch
August 29, 2026 06:13
@mcollinamcollina
mentioned this pull request
Sep 2, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@ronagronagronag approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@ShogunPanda@jasnell@ronag

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
stream: avoid duplicated endReadableNT scheduling - #65310
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Aug 23, 2026
Merged
stream: avoid duplicated endReadableNT scheduling#65310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Conversation
@mcollina
@mcollinamcollina
commented
Aug 15, 2026

Copy link


Copy Markdown

Member
Calling read() on an ended stream multiple times before the microtask queue drains scheduled one endReadableNT tick per call, since the only guard (endEmitted) is set inside the tick itself. A hello-world HTTP server was scheduling it four times per request while dumping the unread request body.
Add a kEndScheduled flag, armed on scheduling and cleared when the tick runs. It must be cleared unconditionally: undestroy() resets endEmitted through the state descriptors but cannot reach this flag, and a stale value would block 'end' after a net.Socket reconnect.
Benchmarks vs main: streams/finished.js readable +10.45% (99.9% confidence), no significant regressions across the streams suite; ~+1-3% on HTTP server benchmarks (10 → 7 nextTicks per request).
@nodejs-github-bot
nodejs-github-bot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
stream
Issues and PRs related to Node.js streams.
labels
Aug 15, 2026
@codecov
codecovBot
commented
Aug 15, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (347e266) to head (4ccbe5e).
⚠️ Report is 251 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65310 +/- ##
==========================================
- Coverage 90.30% 90.12% -0.18% 
==========================================
Files 759 752 -7 Lines 248294 251576 +3282 Branches 46860 47263 +403 ==========================================
+ Hits 224220 226737 +2517 - Misses 15516 16178 +662 - Partials 8558 8661 +103 
Files with missing linesCoverage Δ
lib/internal/streams/readable.js96.56% <100.00%> (-0.72%)⬇️
... and 178 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mcollina
stream: avoid duplicated endReadableNT scheduling
4ccbe5e
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@ronagronag
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 16, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 16, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75878/
@mcollina
mcollinaforce-pushed
the
stream-dedupe-endreadable-tick
branch
from
4c33258 to
4ccbe5eCompareAugust 16, 2026 20:46
@ronagronag
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-16T08:13:00Z: https://ci.nodejs.org/job/node-test-pull-request/75878/
- Querying data for job/node-test-pull-request/75878/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90607/
✔ Data downloaded
✘ 23 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32254812825
@mcollinamcollina
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 19, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76092/
@mcollinamcollina
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 21, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-20T23:59:20Z: https://ci.nodejs.org/job/node-test-pull-request/76092/
- Querying data for job/node-test-pull-request/76092/
✔ Build data downloaded
✘ Last Jenkins CI still running
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32435803605
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76115/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76170/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76177/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76193/
@mcollinamcollina
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 82babee
into
nodejs:mainAug 23, 2026

87 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 23, 2026

Copy link


Copy Markdown

Collaborator
Landed in 82babee
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
9e59a62
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
c42fbcc
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
70e41cd
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@mcollina
mcollina
deleted the

stream-dedupe-endreadable-tick

branch
August 29, 2026 06:13
@mcollinamcollina
mentioned this pull request
Sep 2, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@ronagronagronag approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@ShogunPanda@jasnell@ronag

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
stream: avoid duplicated endReadableNT scheduling - #65310
Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Aug 23, 2026
Merged
stream: avoid duplicated endReadableNT scheduling#65310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom 
mcollina:stream-dedupe-endreadable-tick
Conversation
@mcollina
@mcollinamcollina
commented
Aug 15, 2026

Copy link


Copy Markdown

Member
Calling read() on an ended stream multiple times before the microtask queue drains scheduled one endReadableNT tick per call, since the only guard (endEmitted) is set inside the tick itself. A hello-world HTTP server was scheduling it four times per request while dumping the unread request body.
Add a kEndScheduled flag, armed on scheduling and cleared when the tick runs. It must be cleared unconditionally: undestroy() resets endEmitted through the state descriptors but cannot reach this flag, and a stale value would block 'end' after a net.Socket reconnect.
Benchmarks vs main: streams/finished.js readable +10.45% (99.9% confidence), no significant regressions across the streams suite; ~+1-3% on HTTP server benchmarks (10 → 7 nextTicks per request).
@nodejs-github-bot
nodejs-github-bot
commented
Aug 15, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/streams
@nodejs-github-botnodejs-github-bot
added

needs-ci
PRs that need a full CI run.
stream
Issues and PRs related to Node.js streams.
labels
Aug 15, 2026
@codecov
codecovBot
commented
Aug 15, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.12%. Comparing base (347e266) to head (4ccbe5e).
⚠️ Report is 251 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #65310 +/- ##
==========================================
- Coverage 90.30% 90.12% -0.18% 
==========================================
Files 759 752 -7 Lines 248294 251576 +3282 Branches 46860 47263 +403 ==========================================
+ Hits 224220 226737 +2517 - Misses 15516 16178 +662 - Partials 8558 8661 +103 
Files with missing linesCoverage Δ
lib/internal/streams/readable.js96.56% <100.00%> (-0.72%)⬇️
... and 178 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@mcollina
stream: avoid duplicated endReadableNT scheduling
4ccbe5e
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@ronagronag
added

request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
labels
Aug 16, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 16, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75878/
@mcollina
mcollinaforce-pushed
the
stream-dedupe-endreadable-tick
branch
from
4c33258 to
4ccbe5eCompareAugust 16, 2026 20:46
@ronagronag
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 19, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 19, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 19, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-16T08:13:00Z: https://ci.nodejs.org/job/node-test-pull-request/75878/
- Querying data for job/node-test-pull-request/75878/
✔ Build data downloaded
- Querying failures of job/node-test-commit/90607/
✔ Data downloaded
✘ 23 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32254812825
@mcollinamcollina
added

request-ci
Add this label to start a Jenkins CI on a PR.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 19, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76092/
@mcollinamcollina
added
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 21, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65310
✔ Done loading data for nodejs/node/pull/65310
----------------------------------- PR info ------------------------------------
Title stream: avoid duplicated endReadableNT scheduling (#65310)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:stream-dedupe-endreadable-tick -> nodejs:main
Labels stream, author ready, needs-ci, commit-queue
Commits 1
- stream: avoid duplicated endReadableNT scheduling
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 15 Aug 2026 20:35:50 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4944843305
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4945590565
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/65310#pullrequestreview-4969779696
✘ GitHub CI failed with status: FAILURE
ℹ Last Full PR CI on 2026-08-20T23:59:20Z: https://ci.nodejs.org/job/node-test-pull-request/76092/
- Querying data for job/node-test-pull-request/76092/
✔ Build data downloaded
✘ Last Jenkins CI still running
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32435803605
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76115/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76170/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 21, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76177/
@nodejs-github-bot
nodejs-github-bot
commented
Aug 22, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/76193/
@mcollinamcollina
added

commit-queue
PRs queued for automated landing through the Commit Queue.
and removed

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
labels
Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 82babee
into
nodejs:mainAug 23, 2026

87 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 23, 2026

Copy link


Copy Markdown

Collaborator
Landed in 82babee
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 23, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
9e59a62
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
c42fbcc
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@mcollina@aduh95
stream: avoid duplicated endReadableNT scheduling
70e41cd
Calling read() on an ended stream multiple times before the microtask
queue drains scheduled one endReadableNT tick per call, as the only
guard was endEmitted, which is set inside the tick itself. A hello-world
HTTP server was scheduling it four times per request while dumping the
unread request body.
Introduce a kEndScheduled flag armed when the tick is scheduled and
cleared when it runs. Clearing it unconditionally matters for reused
sockets: undestroy() resets endEmitted through the state descriptors
but cannot reach this flag, and a stale value would block the 'end'
event after a net.Socket reconnect.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65310
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@mcollina
mcollina
deleted the

stream-dedupe-endreadable-tick

branch
August 29, 2026 06:13
@mcollinamcollina
mentioned this pull request
Sep 2, 2026
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@jasnelljasnelljasnell approved these changes
@ronagronagronag approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.needs-ciPRs that need a full CI run.streamIssues and PRs related to Node.js streams.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina@nodejs-github-bot@ShogunPanda@jasnell@ronag