Uh oh!
There was an error while loading. Please reload this page.
doc: note that v8 options work with both dashes and underscores - #6532
Merged
Fishrock123 merged 2 commits intoMay 9, 2016
Merged
Conversation
benjamingr
commented
May 2, 2016
Member
TIL, LGTM minus the line wrap. |
Fishrock123force-pushed
the
doc-v8-options-dash-underscore
branch
from
May 9, 2016 15:18
d698f28 to
6145681CompareFishrock123
commented
May 9, 2016
ContributorAuthor
@benjamingr & @jasnell lgty? |
benjamingr
commented
May 9, 2016
Member
Yea, go right ahead :) |
Member
There was a problem hiding this comment.
nit: it's likely not worth noting but --stack-trace_limit and --stack_trace-limit are also equivalent.
jasnell
commented
May 9, 2016
Member
Looks fine. |
This adds docs to the man page and online cli docs that v8 options can be used with either dashes or underscores. Refs: nodejs#6377 (comment) PR-URL: nodejs#6532 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#6532 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123force-pushed
the
doc-v8-options-dash-underscore
branch
from
May 9, 2016 16:43
6145681 to
4b107d0Compareevanlucas pushed a commit
that referenced
this pull request
May 17, 2016
This adds docs to the man page and online cli docs that v8 options can be used with either dashes or underscores. Refs: #6377 (comment) PR-URL: #6532 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit
that referenced
this pull request
May 17, 2016
PR-URL: #6532 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
see #6377 (comment)
This adds docs to the man page and online cli docs that v8 options can be used with either.
r=@nodejs/documentation