fs: use sized reads for large files in readFileUtf8 - #65328

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads
Aug 24, 2026
Merged

fs: use sized reads for large files in readFileUtf8#65328
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads

Conversation

@codebytere

@codebyterecodebytere commented Aug 16, 2026

Copy link
Copy Markdown
Member

fs.readFileSync(path, 'utf8') gets +19…42 % on 4 MiB files and +60…231 % on 256 KiB files, with small files untouched, by reading large files into one right-sized buffer instead of 8 KiB at a time.

fs/readfile-utf8-fastpath.js source='path' content='ascii' size=262144 *** 231.14 % ±2.91%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=262144 *** 60.16 % ±0.93%
fs/readfile-utf8-fastpath.js source='path' content='ascii' size=4194304 *** 41.86 % ±5.85%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=4194304 *** 19.06 % ±2.92%
fs/readfile-utf8-fastpath.js source='fd' * size=4194304 *** +22…27 %
fs/readfile-utf8-fastpath.js * * size≤16384 0…+2 %
fs/readFileSync.js (1 KiB) ~0 % n.s.

(Linux x64, 30 runs. A 300 KB file goes from 39 syscalls to 5.)

ReadFileUtf8 - behind readFileSync(…, 'utf8') and therefore every CommonJS module load - read in 8 KiB read()s, appending each to a std::string. Files that fit the first 8 KiB read behave exactly as before. Once a read fills the stack buffer, the rest goes straight into one heap buffer: a 64 KiB step first (so files up to 64 KiB take the same reads as today and no fstat), then sized from fstat() if that fills too, with geometric growth as the fallback. The size is only an allocation hint - reading continues until read() returns 0, so procfs/sysfs and concurrently changing files behave as before and StringBytes::Encode() sees exactly the bytes read. Allocation failure throws ERR_MEMORY_ALLOCATION_FAILED.

Tests:test-fs-readfilesync-utf8-sizes.js (new): equals readFileSync(path).toString('utf8') around every internal boundary (0 … 8 MiB+5) with multi-byte characters straddling chunk edges; by fd from start / at EOF / mid-file; binary input; /proc/self/maps and friends; EISDIR. fs, module and require suites pass.


Disclosure: the code, test, measurements and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch 2 times, most recently from 39c515d to ff70ea5CompareAugust 16, 2026 20:30
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (30bff4a) to head (60bf6b9).
⚠️ Report is 149 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc78.26%2 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65328 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.03% 
==========================================
Files 752 751 -1 Lines 251568 252570 +1002 Branches 47270 47526 +256 ==========================================
+ Hits 226759 227604 +845 - Misses 16168 16247 +79 - Partials 8641 8719 +78 
Files with missing linesCoverage Δ
src/node_file.cc74.10% <78.26%> (-0.10%)⬇️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 17, 2026
@codebytere
codebytere requested a review from aduh95August 17, 2026 10:31
@codebyterecodebytere added the needs-ci PRs that need a full CI run. label Aug 17, 2026
@codebytere
codebytere requested review from anonrig and avivkeller and removed request for RafaelGSSAugust 19, 2026 08:55
Comment threadsrc/node_file.cc Outdated
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from ff70ea5 to d47ea46CompareAugust 20, 2026 17:18

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from d47ea46 to f6970e8CompareAugust 22, 2026 14:46
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from f6970e8 to 60bf6b9CompareAugust 22, 2026 18:39
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebyterecodebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 18fb35a into nodejs:mainAug 24, 2026
68 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 18fb35a

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Aug 26, 2026
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to file-system APIs and the fs module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere@nodejs-github-bot@mcollina@anonrig
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fs: use sized reads for large files in readFileUtf8 - #65328

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads
Aug 24, 2026
Merged

fs: use sized reads for large files in readFileUtf8#65328
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads

Conversation

@codebytere

@codebyterecodebytere commented Aug 16, 2026

Copy link
Copy Markdown
Member

fs.readFileSync(path, 'utf8') gets +19…42 % on 4 MiB files and +60…231 % on 256 KiB files, with small files untouched, by reading large files into one right-sized buffer instead of 8 KiB at a time.

fs/readfile-utf8-fastpath.js source='path' content='ascii' size=262144 *** 231.14 % ±2.91%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=262144 *** 60.16 % ±0.93%
fs/readfile-utf8-fastpath.js source='path' content='ascii' size=4194304 *** 41.86 % ±5.85%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=4194304 *** 19.06 % ±2.92%
fs/readfile-utf8-fastpath.js source='fd' * size=4194304 *** +22…27 %
fs/readfile-utf8-fastpath.js * * size≤16384 0…+2 %
fs/readFileSync.js (1 KiB) ~0 % n.s.

(Linux x64, 30 runs. A 300 KB file goes from 39 syscalls to 5.)

ReadFileUtf8 - behind readFileSync(…, 'utf8') and therefore every CommonJS module load - read in 8 KiB read()s, appending each to a std::string. Files that fit the first 8 KiB read behave exactly as before. Once a read fills the stack buffer, the rest goes straight into one heap buffer: a 64 KiB step first (so files up to 64 KiB take the same reads as today and no fstat), then sized from fstat() if that fills too, with geometric growth as the fallback. The size is only an allocation hint - reading continues until read() returns 0, so procfs/sysfs and concurrently changing files behave as before and StringBytes::Encode() sees exactly the bytes read. Allocation failure throws ERR_MEMORY_ALLOCATION_FAILED.

Tests:test-fs-readfilesync-utf8-sizes.js (new): equals readFileSync(path).toString('utf8') around every internal boundary (0 … 8 MiB+5) with multi-byte characters straddling chunk edges; by fd from start / at EOF / mid-file; binary input; /proc/self/maps and friends; EISDIR. fs, module and require suites pass.


Disclosure: the code, test, measurements and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch 2 times, most recently from 39c515d to ff70ea5CompareAugust 16, 2026 20:30
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (30bff4a) to head (60bf6b9).
⚠️ Report is 149 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc78.26%2 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65328 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.03% 
==========================================
Files 752 751 -1 Lines 251568 252570 +1002 Branches 47270 47526 +256 ==========================================
+ Hits 226759 227604 +845 - Misses 16168 16247 +79 - Partials 8641 8719 +78 
Files with missing linesCoverage Δ
src/node_file.cc74.10% <78.26%> (-0.10%)⬇️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 17, 2026
@codebytere
codebytere requested a review from aduh95August 17, 2026 10:31
@codebyterecodebytere added the needs-ci PRs that need a full CI run. label Aug 17, 2026
@codebytere
codebytere requested review from anonrig and avivkeller and removed request for RafaelGSSAugust 19, 2026 08:55
Comment threadsrc/node_file.cc Outdated
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from ff70ea5 to d47ea46CompareAugust 20, 2026 17:18

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from d47ea46 to f6970e8CompareAugust 22, 2026 14:46
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from f6970e8 to 60bf6b9CompareAugust 22, 2026 18:39
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebyterecodebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 18fb35a into nodejs:mainAug 24, 2026
68 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 18fb35a

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Aug 26, 2026
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to file-system APIs and the fs module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere@nodejs-github-bot@mcollina@anonrig
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fs: use sized reads for large files in readFileUtf8 - #65328

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads
Aug 24, 2026
Merged

fs: use sized reads for large files in readFileUtf8#65328
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads

Conversation

@codebytere

@codebyterecodebytere commented Aug 16, 2026

Copy link
Copy Markdown
Member

fs.readFileSync(path, 'utf8') gets +19…42 % on 4 MiB files and +60…231 % on 256 KiB files, with small files untouched, by reading large files into one right-sized buffer instead of 8 KiB at a time.

fs/readfile-utf8-fastpath.js source='path' content='ascii' size=262144 *** 231.14 % ±2.91%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=262144 *** 60.16 % ±0.93%
fs/readfile-utf8-fastpath.js source='path' content='ascii' size=4194304 *** 41.86 % ±5.85%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=4194304 *** 19.06 % ±2.92%
fs/readfile-utf8-fastpath.js source='fd' * size=4194304 *** +22…27 %
fs/readfile-utf8-fastpath.js * * size≤16384 0…+2 %
fs/readFileSync.js (1 KiB) ~0 % n.s.

(Linux x64, 30 runs. A 300 KB file goes from 39 syscalls to 5.)

ReadFileUtf8 - behind readFileSync(…, 'utf8') and therefore every CommonJS module load - read in 8 KiB read()s, appending each to a std::string. Files that fit the first 8 KiB read behave exactly as before. Once a read fills the stack buffer, the rest goes straight into one heap buffer: a 64 KiB step first (so files up to 64 KiB take the same reads as today and no fstat), then sized from fstat() if that fills too, with geometric growth as the fallback. The size is only an allocation hint - reading continues until read() returns 0, so procfs/sysfs and concurrently changing files behave as before and StringBytes::Encode() sees exactly the bytes read. Allocation failure throws ERR_MEMORY_ALLOCATION_FAILED.

Tests:test-fs-readfilesync-utf8-sizes.js (new): equals readFileSync(path).toString('utf8') around every internal boundary (0 … 8 MiB+5) with multi-byte characters straddling chunk edges; by fd from start / at EOF / mid-file; binary input; /proc/self/maps and friends; EISDIR. fs, module and require suites pass.


Disclosure: the code, test, measurements and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch 2 times, most recently from 39c515d to ff70ea5CompareAugust 16, 2026 20:30
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (30bff4a) to head (60bf6b9).
⚠️ Report is 149 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc78.26%2 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65328 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.03% 
==========================================
Files 752 751 -1 Lines 251568 252570 +1002 Branches 47270 47526 +256 ==========================================
+ Hits 226759 227604 +845 - Misses 16168 16247 +79 - Partials 8641 8719 +78 
Files with missing linesCoverage Δ
src/node_file.cc74.10% <78.26%> (-0.10%)⬇️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 17, 2026
@codebytere
codebytere requested a review from aduh95August 17, 2026 10:31
@codebyterecodebytere added the needs-ci PRs that need a full CI run. label Aug 17, 2026
@codebytere
codebytere requested review from anonrig and avivkeller and removed request for RafaelGSSAugust 19, 2026 08:55
Comment threadsrc/node_file.cc Outdated
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from ff70ea5 to d47ea46CompareAugust 20, 2026 17:18

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from d47ea46 to f6970e8CompareAugust 22, 2026 14:46
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from f6970e8 to 60bf6b9CompareAugust 22, 2026 18:39
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebyterecodebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 18fb35a into nodejs:mainAug 24, 2026
68 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 18fb35a

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Aug 26, 2026
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to file-system APIs and the fs module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere@nodejs-github-bot@mcollina@anonrig
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fs: use sized reads for large files in readFileUtf8 - #65328

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads
Aug 24, 2026
Merged

fs: use sized reads for large files in readFileUtf8#65328
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads

Conversation

@codebytere

@codebyterecodebytere commented Aug 16, 2026

Copy link
Copy Markdown
Member

fs.readFileSync(path, 'utf8') gets +19…42 % on 4 MiB files and +60…231 % on 256 KiB files, with small files untouched, by reading large files into one right-sized buffer instead of 8 KiB at a time.

fs/readfile-utf8-fastpath.js source='path' content='ascii' size=262144 *** 231.14 % ±2.91%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=262144 *** 60.16 % ±0.93%
fs/readfile-utf8-fastpath.js source='path' content='ascii' size=4194304 *** 41.86 % ±5.85%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=4194304 *** 19.06 % ±2.92%
fs/readfile-utf8-fastpath.js source='fd' * size=4194304 *** +22…27 %
fs/readfile-utf8-fastpath.js * * size≤16384 0…+2 %
fs/readFileSync.js (1 KiB) ~0 % n.s.

(Linux x64, 30 runs. A 300 KB file goes from 39 syscalls to 5.)

ReadFileUtf8 - behind readFileSync(…, 'utf8') and therefore every CommonJS module load - read in 8 KiB read()s, appending each to a std::string. Files that fit the first 8 KiB read behave exactly as before. Once a read fills the stack buffer, the rest goes straight into one heap buffer: a 64 KiB step first (so files up to 64 KiB take the same reads as today and no fstat), then sized from fstat() if that fills too, with geometric growth as the fallback. The size is only an allocation hint - reading continues until read() returns 0, so procfs/sysfs and concurrently changing files behave as before and StringBytes::Encode() sees exactly the bytes read. Allocation failure throws ERR_MEMORY_ALLOCATION_FAILED.

Tests:test-fs-readfilesync-utf8-sizes.js (new): equals readFileSync(path).toString('utf8') around every internal boundary (0 … 8 MiB+5) with multi-byte characters straddling chunk edges; by fd from start / at EOF / mid-file; binary input; /proc/self/maps and friends; EISDIR. fs, module and require suites pass.


Disclosure: the code, test, measurements and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch 2 times, most recently from 39c515d to ff70ea5CompareAugust 16, 2026 20:30
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (30bff4a) to head (60bf6b9).
⚠️ Report is 149 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc78.26%2 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65328 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.03% 
==========================================
Files 752 751 -1 Lines 251568 252570 +1002 Branches 47270 47526 +256 ==========================================
+ Hits 226759 227604 +845 - Misses 16168 16247 +79 - Partials 8641 8719 +78 
Files with missing linesCoverage Δ
src/node_file.cc74.10% <78.26%> (-0.10%)⬇️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 17, 2026
@codebytere
codebytere requested a review from aduh95August 17, 2026 10:31
@codebyterecodebytere added the needs-ci PRs that need a full CI run. label Aug 17, 2026
@codebytere
codebytere requested review from anonrig and avivkeller and removed request for RafaelGSSAugust 19, 2026 08:55
Comment threadsrc/node_file.cc Outdated
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from ff70ea5 to d47ea46CompareAugust 20, 2026 17:18

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from d47ea46 to f6970e8CompareAugust 22, 2026 14:46
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from f6970e8 to 60bf6b9CompareAugust 22, 2026 18:39
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebyterecodebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 18fb35a into nodejs:mainAug 24, 2026
68 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 18fb35a

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Aug 26, 2026
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to file-system APIs and the fs module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere@nodejs-github-bot@mcollina@anonrig
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fs: use sized reads for large files in readFileUtf8 - #65328

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads
Aug 24, 2026
Merged

fs: use sized reads for large files in readFileUtf8#65328
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads

Conversation

@codebytere

@codebyterecodebytere commented Aug 16, 2026

Copy link
Copy Markdown
Member

fs.readFileSync(path, 'utf8') gets +19…42 % on 4 MiB files and +60…231 % on 256 KiB files, with small files untouched, by reading large files into one right-sized buffer instead of 8 KiB at a time.

fs/readfile-utf8-fastpath.js source='path' content='ascii' size=262144 *** 231.14 % ±2.91%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=262144 *** 60.16 % ±0.93%
fs/readfile-utf8-fastpath.js source='path' content='ascii' size=4194304 *** 41.86 % ±5.85%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=4194304 *** 19.06 % ±2.92%
fs/readfile-utf8-fastpath.js source='fd' * size=4194304 *** +22…27 %
fs/readfile-utf8-fastpath.js * * size≤16384 0…+2 %
fs/readFileSync.js (1 KiB) ~0 % n.s.

(Linux x64, 30 runs. A 300 KB file goes from 39 syscalls to 5.)

ReadFileUtf8 - behind readFileSync(…, 'utf8') and therefore every CommonJS module load - read in 8 KiB read()s, appending each to a std::string. Files that fit the first 8 KiB read behave exactly as before. Once a read fills the stack buffer, the rest goes straight into one heap buffer: a 64 KiB step first (so files up to 64 KiB take the same reads as today and no fstat), then sized from fstat() if that fills too, with geometric growth as the fallback. The size is only an allocation hint - reading continues until read() returns 0, so procfs/sysfs and concurrently changing files behave as before and StringBytes::Encode() sees exactly the bytes read. Allocation failure throws ERR_MEMORY_ALLOCATION_FAILED.

Tests:test-fs-readfilesync-utf8-sizes.js (new): equals readFileSync(path).toString('utf8') around every internal boundary (0 … 8 MiB+5) with multi-byte characters straddling chunk edges; by fd from start / at EOF / mid-file; binary input; /proc/self/maps and friends; EISDIR. fs, module and require suites pass.


Disclosure: the code, test, measurements and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch 2 times, most recently from 39c515d to ff70ea5CompareAugust 16, 2026 20:30
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (30bff4a) to head (60bf6b9).
⚠️ Report is 149 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc78.26%2 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65328 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.03% 
==========================================
Files 752 751 -1 Lines 251568 252570 +1002 Branches 47270 47526 +256 ==========================================
+ Hits 226759 227604 +845 - Misses 16168 16247 +79 - Partials 8641 8719 +78 
Files with missing linesCoverage Δ
src/node_file.cc74.10% <78.26%> (-0.10%)⬇️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 17, 2026
@codebytere
codebytere requested a review from aduh95August 17, 2026 10:31
@codebyterecodebytere added the needs-ci PRs that need a full CI run. label Aug 17, 2026
@codebytere
codebytere requested review from anonrig and avivkeller and removed request for RafaelGSSAugust 19, 2026 08:55
Comment threadsrc/node_file.cc Outdated
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from ff70ea5 to d47ea46CompareAugust 20, 2026 17:18

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from d47ea46 to f6970e8CompareAugust 22, 2026 14:46
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from f6970e8 to 60bf6b9CompareAugust 22, 2026 18:39
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebyterecodebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 18fb35a into nodejs:mainAug 24, 2026
68 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 18fb35a

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Aug 26, 2026
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to file-system APIs and the fs module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere@nodejs-github-bot@mcollina@anonrig
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fs: use sized reads for large files in readFileUtf8 - #65328

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads
Aug 24, 2026
Merged

fs: use sized reads for large files in readFileUtf8#65328
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads

Conversation

@codebytere

@codebyterecodebytere commented Aug 16, 2026

Copy link
Copy Markdown
Member

fs.readFileSync(path, 'utf8') gets +19…42 % on 4 MiB files and +60…231 % on 256 KiB files, with small files untouched, by reading large files into one right-sized buffer instead of 8 KiB at a time.

fs/readfile-utf8-fastpath.js source='path' content='ascii' size=262144 *** 231.14 % ±2.91%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=262144 *** 60.16 % ±0.93%
fs/readfile-utf8-fastpath.js source='path' content='ascii' size=4194304 *** 41.86 % ±5.85%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=4194304 *** 19.06 % ±2.92%
fs/readfile-utf8-fastpath.js source='fd' * size=4194304 *** +22…27 %
fs/readfile-utf8-fastpath.js * * size≤16384 0…+2 %
fs/readFileSync.js (1 KiB) ~0 % n.s.

(Linux x64, 30 runs. A 300 KB file goes from 39 syscalls to 5.)

ReadFileUtf8 - behind readFileSync(…, 'utf8') and therefore every CommonJS module load - read in 8 KiB read()s, appending each to a std::string. Files that fit the first 8 KiB read behave exactly as before. Once a read fills the stack buffer, the rest goes straight into one heap buffer: a 64 KiB step first (so files up to 64 KiB take the same reads as today and no fstat), then sized from fstat() if that fills too, with geometric growth as the fallback. The size is only an allocation hint - reading continues until read() returns 0, so procfs/sysfs and concurrently changing files behave as before and StringBytes::Encode() sees exactly the bytes read. Allocation failure throws ERR_MEMORY_ALLOCATION_FAILED.

Tests:test-fs-readfilesync-utf8-sizes.js (new): equals readFileSync(path).toString('utf8') around every internal boundary (0 … 8 MiB+5) with multi-byte characters straddling chunk edges; by fd from start / at EOF / mid-file; binary input; /proc/self/maps and friends; EISDIR. fs, module and require suites pass.


Disclosure: the code, test, measurements and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch 2 times, most recently from 39c515d to ff70ea5CompareAugust 16, 2026 20:30
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (30bff4a) to head (60bf6b9).
⚠️ Report is 149 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc78.26%2 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65328 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.03% 
==========================================
Files 752 751 -1 Lines 251568 252570 +1002 Branches 47270 47526 +256 ==========================================
+ Hits 226759 227604 +845 - Misses 16168 16247 +79 - Partials 8641 8719 +78 
Files with missing linesCoverage Δ
src/node_file.cc74.10% <78.26%> (-0.10%)⬇️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 17, 2026
@codebytere
codebytere requested a review from aduh95August 17, 2026 10:31
@codebyterecodebytere added the needs-ci PRs that need a full CI run. label Aug 17, 2026
@codebytere
codebytere requested review from anonrig and avivkeller and removed request for RafaelGSSAugust 19, 2026 08:55
Comment threadsrc/node_file.cc Outdated
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from ff70ea5 to d47ea46CompareAugust 20, 2026 17:18

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from d47ea46 to f6970e8CompareAugust 22, 2026 14:46
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from f6970e8 to 60bf6b9CompareAugust 22, 2026 18:39
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebyterecodebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 18fb35a into nodejs:mainAug 24, 2026
68 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 18fb35a

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Aug 26, 2026
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to file-system APIs and the fs module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere@nodejs-github-bot@mcollina@anonrig
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fs: use sized reads for large files in readFileUtf8 - #65328

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads
Aug 24, 2026
Merged

fs: use sized reads for large files in readFileUtf8#65328
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads

Conversation

@codebytere

@codebyterecodebytere commented Aug 16, 2026

Copy link
Copy Markdown
Member

fs.readFileSync(path, 'utf8') gets +19…42 % on 4 MiB files and +60…231 % on 256 KiB files, with small files untouched, by reading large files into one right-sized buffer instead of 8 KiB at a time.

fs/readfile-utf8-fastpath.js source='path' content='ascii' size=262144 *** 231.14 % ±2.91%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=262144 *** 60.16 % ±0.93%
fs/readfile-utf8-fastpath.js source='path' content='ascii' size=4194304 *** 41.86 % ±5.85%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=4194304 *** 19.06 % ±2.92%
fs/readfile-utf8-fastpath.js source='fd' * size=4194304 *** +22…27 %
fs/readfile-utf8-fastpath.js * * size≤16384 0…+2 %
fs/readFileSync.js (1 KiB) ~0 % n.s.

(Linux x64, 30 runs. A 300 KB file goes from 39 syscalls to 5.)

ReadFileUtf8 - behind readFileSync(…, 'utf8') and therefore every CommonJS module load - read in 8 KiB read()s, appending each to a std::string. Files that fit the first 8 KiB read behave exactly as before. Once a read fills the stack buffer, the rest goes straight into one heap buffer: a 64 KiB step first (so files up to 64 KiB take the same reads as today and no fstat), then sized from fstat() if that fills too, with geometric growth as the fallback. The size is only an allocation hint - reading continues until read() returns 0, so procfs/sysfs and concurrently changing files behave as before and StringBytes::Encode() sees exactly the bytes read. Allocation failure throws ERR_MEMORY_ALLOCATION_FAILED.

Tests:test-fs-readfilesync-utf8-sizes.js (new): equals readFileSync(path).toString('utf8') around every internal boundary (0 … 8 MiB+5) with multi-byte characters straddling chunk edges; by fd from start / at EOF / mid-file; binary input; /proc/self/maps and friends; EISDIR. fs, module and require suites pass.


Disclosure: the code, test, measurements and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch 2 times, most recently from 39c515d to ff70ea5CompareAugust 16, 2026 20:30
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (30bff4a) to head (60bf6b9).
⚠️ Report is 149 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc78.26%2 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65328 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.03% 
==========================================
Files 752 751 -1 Lines 251568 252570 +1002 Branches 47270 47526 +256 ==========================================
+ Hits 226759 227604 +845 - Misses 16168 16247 +79 - Partials 8641 8719 +78 
Files with missing linesCoverage Δ
src/node_file.cc74.10% <78.26%> (-0.10%)⬇️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 17, 2026
@codebytere
codebytere requested a review from aduh95August 17, 2026 10:31
@codebyterecodebytere added the needs-ci PRs that need a full CI run. label Aug 17, 2026
@codebytere
codebytere requested review from anonrig and avivkeller and removed request for RafaelGSSAugust 19, 2026 08:55
Comment threadsrc/node_file.cc Outdated
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from ff70ea5 to d47ea46CompareAugust 20, 2026 17:18

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from d47ea46 to f6970e8CompareAugust 22, 2026 14:46
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from f6970e8 to 60bf6b9CompareAugust 22, 2026 18:39
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebyterecodebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 18fb35a into nodejs:mainAug 24, 2026
68 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 18fb35a

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Aug 26, 2026
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to file-system APIs and the fs module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere@nodejs-github-bot@mcollina@anonrig
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fs: use sized reads for large files in readFileUtf8 - #65328

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads
Aug 24, 2026
Merged

fs: use sized reads for large files in readFileUtf8#65328
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:perf/fs-readfile-utf8-sized-reads

Conversation

@codebytere

@codebyterecodebytere commented Aug 16, 2026

Copy link
Copy Markdown
Member

fs.readFileSync(path, 'utf8') gets +19…42 % on 4 MiB files and +60…231 % on 256 KiB files, with small files untouched, by reading large files into one right-sized buffer instead of 8 KiB at a time.

fs/readfile-utf8-fastpath.js source='path' content='ascii' size=262144 *** 231.14 % ±2.91%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=262144 *** 60.16 % ±0.93%
fs/readfile-utf8-fastpath.js source='path' content='ascii' size=4194304 *** 41.86 % ±5.85%
fs/readfile-utf8-fastpath.js source='path' content='utf8_mixed' size=4194304 *** 19.06 % ±2.92%
fs/readfile-utf8-fastpath.js source='fd' * size=4194304 *** +22…27 %
fs/readfile-utf8-fastpath.js * * size≤16384 0…+2 %
fs/readFileSync.js (1 KiB) ~0 % n.s.

(Linux x64, 30 runs. A 300 KB file goes from 39 syscalls to 5.)

ReadFileUtf8 - behind readFileSync(…, 'utf8') and therefore every CommonJS module load - read in 8 KiB read()s, appending each to a std::string. Files that fit the first 8 KiB read behave exactly as before. Once a read fills the stack buffer, the rest goes straight into one heap buffer: a 64 KiB step first (so files up to 64 KiB take the same reads as today and no fstat), then sized from fstat() if that fills too, with geometric growth as the fallback. The size is only an allocation hint - reading continues until read() returns 0, so procfs/sysfs and concurrently changing files behave as before and StringBytes::Encode() sees exactly the bytes read. Allocation failure throws ERR_MEMORY_ALLOCATION_FAILED.

Tests:test-fs-readfilesync-utf8-sizes.js (new): equals readFileSync(path).toString('utf8') around every internal boundary (0 … 8 MiB+5) with multi-byte characters straddling chunk edges; by fd from start / at EOF / mid-file; binary input; /proc/self/maps and friends; EISDIR. fs, module and require suites pass.


Disclosure: the code, test, measurements and this description were written by Claude Code, directed and reviewed by @codebytere.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch 2 times, most recently from 39c515d to ff70ea5CompareAugust 16, 2026 20:30
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (30bff4a) to head (60bf6b9).
⚠️ Report is 149 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc78.26%2 Missing and 8 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #65328 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.03% 
==========================================
Files 752 751 -1 Lines 251568 252570 +1002 Branches 47270 47526 +256 ==========================================
+ Hits 226759 227604 +845 - Misses 16168 16247 +79 - Partials 8641 8719 +78 
Files with missing linesCoverage Δ
src/node_file.cc74.10% <78.26%> (-0.10%)⬇️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 17, 2026
@codebytere
codebytere requested a review from aduh95August 17, 2026 10:31
@codebyterecodebytere added the needs-ci PRs that need a full CI run. label Aug 17, 2026
@codebytere
codebytere requested review from anonrig and avivkeller and removed request for RafaelGSSAugust 19, 2026 08:55
Comment threadsrc/node_file.cc Outdated
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from ff70ea5 to d47ea46CompareAugust 20, 2026 17:18

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@codebyterecodebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from d47ea46 to f6970e8CompareAugust 22, 2026 14:46
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere
codebytereforce-pushed the perf/fs-readfile-utf8-sized-reads branch from f6970e8 to 60bf6b9CompareAugust 22, 2026 18:39
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codebyterecodebytere added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Aug 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 18fb35a into nodejs:mainAug 24, 2026
68 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 18fb35a

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 24, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@panvapanva mentioned this pull request Aug 26, 2026
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
fs.readFileSync(path, 'utf8') read the whole file in 8 KiB read() calls
appended to a std::string, i.e. one syscall and a potential
reallocation per 8 KiB (an 8 MiB file took ~1400 read() calls).
Keep the exact old sequence for small files (one read into the 8 KiB
stack buffer, one read reporting EOF). Once a read fills the stack
buffer, read the rest directly into one heap buffer sized from fstat()
(plus one byte so that the EOF read does not force growth), growing
geometrically only when the size is unavailable or wrong. The size is
only an allocation hint: reading continues until read() reports EOF,
so procfs/sysfs files, FIFOs, files that change while being read and
file descriptors positioned mid-file behave as before, and the bytes
handed to StringBytes::Encode() are exactly the ones read.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65328
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to file-system APIs and the fs module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere@nodejs-github-bot@mcollina@anonrig