Uh oh!
There was an error while loading. Please reload this page.
url: speed up URLSearchParams - #65363
Merged
nodejs-github-bot merged 2 commits intoAug 22, 2026
Merged
Conversation
nodejs-github-bot
commented
Aug 18, 2026
Collaborator
Review requested:
|
This was referenced Aug 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #65363 +/- ##
==========================================
- Coverage 90.31% 90.11% -0.20%
==========================================
Files 751 752 +1 Lines 249956 251862 +1906 Branches 47204 47356 +152 ==========================================
+ Hits 225745 226969 +1224 - Misses 15612 16235 +623 - Partials 8599 8658 +59
🚀 New features to boost your workflow:
|
jasnell
previously requested changes
Aug 18, 2026
jasnell
left a comment
Member
There was a problem hiding this comment.
AI agents are not permitted to use Signed-off-by
cursorBotforce-pushed
the
cursor/url-searchparams-performance-603e
branch
from
August 18, 2026 11:39
1423a66 to
e18874eCompareanonrig
commented
Aug 18, 2026
MemberAuthor
Removed the |
cursorBotforce-pushed
the
cursor/url-searchparams-performance-603e
branch
from
August 18, 2026 12:49
e18874e to
9863db8CompareParse query strings with indexOf instead of a per-character state machine, skip ToString when values are already strings, cache toString() until the list mutates, and join serialized pairs. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor
Leave lone '%' and non-hex percent sequences intact so serialization matches the previous parser, and use native indexOf/slice/push on the query-string hot path. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor
cursorBotforce-pushed
the
cursor/url-searchparams-performance-603e
branch
3 times, most recently
from
August 18, 2026 18:43
18331fb to
eb812acCompare| } | ||
| const out = []; | ||
| // Native indexOf/slice/push outperform primordials on this tight loop. | ||
| const encoded = qs.indexOf('+', i) !== -1 || qs.indexOf('%', i) !== -1; |
Member
There was a problem hiding this comment.
nit:
Suggested change
| constencoded=qs.indexOf('+',i)!==-1||qs.indexOf('%',i)!==-1; | |
| consthasPlus=qs.indexOf('+',i)!==-1; | |
| consthasPercent=qs.indexOf('%',i)!==-1; | |
| constencoded=hasPlus||hasPercent; |
Comment on lines
+38
to
+40
| } | ||
| { |
Member
There was a problem hiding this comment.
We can add edge case for fast path change?, &&&, a=%2F%20b, a=%E2%82%AC, a=%c3%28
Suggested change
| } | |
| { | |
| } | |
| { | |
| constparams=newURLSearchParams('?'); | |
| assert.deepStrictEqual([...params],[]); | |
| assert.strictEqual(params.toString(),''); | |
| } | |
| { | |
| constparams=newURLSearchParams('&&&'); | |
| assert.deepStrictEqual([...params],[]); | |
| assert.strictEqual(params.toString(),''); | |
| } | |
| { | |
| constparams=newURLSearchParams('a=%2F%20b'); | |
| assert.strictEqual(params.get('a'),'/ b'); | |
| assert.strictEqual(params.toString(),'a=%2F+b'); | |
| } | |
| { | |
| constparams=newURLSearchParams('a=%E2%82%AC'); | |
| assert.strictEqual(params.get('a'),'€'); | |
| assert.strictEqual(params.toString(),'a=%E2%82%AC'); | |
| } | |
| { | |
| constparams=newURLSearchParams('a=%c3%28'); | |
| assert.strictEqual(params.get('a'),'%c3%28'); | |
| assert.strictEqual(params.toString(),'a=%25c3%2528'); | |
| } | |
| { |
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Aug 21, 2026
Collaborator
avivkeller
approved these changes
Aug 21, 2026
nodejs-github-bot
commented
Aug 21, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65363 ✔ Done loading data for nodejs/node/pull/65363 ----------------------------------- PR info ------------------------------------ Title url: speed up URLSearchParams (#65363) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch anonrig:cursor/url-searchparams-performance-603e -> nodejs:main Labels whatwg-url, needs-ci, commit-queue, commit-queue-squash Commits 2 - url: speed up URLSearchParams - url: only percent-decode complete %HH sequences Committers 1 - Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 18 Aug 2026 01:38:00 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65363#pullrequestreview-4988761883 ✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/65363#pullrequestreview-4996082466 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65363#pullrequestreview-4996124171 ✘ GitHub CI is still running ℹ Last Full PR CI on 2026-08-21T15:26:43Z: https://ci.nodejs.org/job/node-test-pull-request/76158/ - Querying data for job/node-test-pull-request/76158/ ✔ Build data downloaded ✘ Last Jenkins CI still running -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/32519106371 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Aug 22, 2026
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Aug 22, 2026
Collaborator
Landed in 4b3bba5 |
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
Parse query strings with indexOf instead of a per-character state machine, skip ToString when values are already strings, cache toString() until the list mutates, and join serialized pairs. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor PR-URL: #65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
Parse query strings with indexOf instead of a per-character state machine, skip ToString when values are already strings, cache toString() until the list mutates, and join serialized pairs. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor PR-URL: #65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
Parse query strings with indexOf instead of a per-character state machine, skip ToString when values are already strings, cache toString() until the list mutates, and join serialized pairs. Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Assisted-by: Cursor PR-URL: #65363 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speeds up WHATWG
URLSearchParamswithout changing observable behavior.Independent of the
new URL()parse PR (#65361).What changed
&/=withindexOfinstead of a per-character state machine. When the input has no+or%, each component is a slice of the original string. Percent-decoding still runs only when a complete%HHsequence exists, so lone%and fake sequences like%©stay intact.`${value}`when the value is already a string (constructor,append/get/set/has/delete).toString()until the list mutates; join encoded pairs instead of repeated+=.test/parallel/test-whatwg-url-searchparams-fast-path.jscovers leading?, empty pairs,+/ percent-decoding, invalid%, mutation cache invalidation, copy constructor isolation, record/sequence init, unpaired surrogates, and fake percent-encoding.Tests
test/parallel/test-whatwg-url-custom-searchparams*.jsplus the new fast-path filetest/wpt/test-url.js: 5107 passed, 0 unexpected failuresLocal benches
Same binary family, both run with
--no-node-snapshot(new JS is not in the V8 snapshot). Rates in ops/s:new URLSearchParams(string)noencodenew URLSearchParams(string)encodemanynew URLSearchParams(iterable)toString()noencode (repeated)toString()encodemany (repeated)get()has()The large
toString()jump is the serialization cache: the common “build params, stringify many times / readURL.href” path no longer re-encodes an unchanged list.Ada already has a C
url_search_paramsAPI. This keeps the implementation in JS to avoid a JS/C++ call on everyget/append.Assisted-by: Cursor