build: add simdutf dir to include path in GN build by codebytere · Pull Request #65382 · nodejs/node

codebytere · 2026-08-18T14:12:33Z

The GN build defaults node_simdutf_path to //third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it as third_party/simdutf/simdutf.h), so the unqualified #include "simdutf.h" in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves.

This adds get_label_info(node_simdutf_path, "dir") to node_internal_config, which libnode and node_cctest already use, and to node_js2c's include_dirs. get_label_info rather than the raw string so a value like //foo/bar:simdutf still resolves to a directory.

There's no GN CI in this repo; i checked this in an embedder build.

Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot · 2026-08-18T19:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75972/

nodejs-github-bot · 2026-08-19T13:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75992/

nodejs-github-bot · 2026-08-20T14:19:33Z

Landed in 5ba7e05

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65382 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere · 2026-08-18T14:12:33Z

The GN build defaults node_simdutf_path to //third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it as third_party/simdutf/simdutf.h), so the unqualified #include "simdutf.h" in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves.

This adds get_label_info(node_simdutf_path, "dir") to node_internal_config, which libnode and node_cctest already use, and to node_js2c's include_dirs. get_label_info rather than the raw string so a value like //foo/bar:simdutf still resolves to a directory.

There's no GN CI in this repo; i checked this in an embedder build.

Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot · 2026-08-18T19:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75972/

nodejs-github-bot · 2026-08-19T13:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75992/

nodejs-github-bot · 2026-08-20T14:19:33Z

Landed in 5ba7e05

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65382 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere · 2026-08-18T14:12:33Z

The GN build defaults node_simdutf_path to //third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it as third_party/simdutf/simdutf.h), so the unqualified #include "simdutf.h" in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves.

This adds get_label_info(node_simdutf_path, "dir") to node_internal_config, which libnode and node_cctest already use, and to node_js2c's include_dirs. get_label_info rather than the raw string so a value like //foo/bar:simdutf still resolves to a directory.

There's no GN CI in this repo; i checked this in an embedder build.

Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot · 2026-08-18T19:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75972/

nodejs-github-bot · 2026-08-19T13:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75992/

nodejs-github-bot · 2026-08-20T14:19:33Z

Landed in 5ba7e05

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65382 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere · 2026-08-18T14:12:33Z

The GN build defaults node_simdutf_path to //third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it as third_party/simdutf/simdutf.h), so the unqualified #include "simdutf.h" in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves.

This adds get_label_info(node_simdutf_path, "dir") to node_internal_config, which libnode and node_cctest already use, and to node_js2c's include_dirs. get_label_info rather than the raw string so a value like //foo/bar:simdutf still resolves to a directory.

There's no GN CI in this repo; i checked this in an embedder build.

Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot · 2026-08-18T19:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75972/

nodejs-github-bot · 2026-08-19T13:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75992/

nodejs-github-bot · 2026-08-20T14:19:33Z

Landed in 5ba7e05

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65382 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere · 2026-08-18T14:12:33Z

The GN build defaults node_simdutf_path to //third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it as third_party/simdutf/simdutf.h), so the unqualified #include "simdutf.h" in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves.

This adds get_label_info(node_simdutf_path, "dir") to node_internal_config, which libnode and node_cctest already use, and to node_js2c's include_dirs. get_label_info rather than the raw string so a value like //foo/bar:simdutf still resolves to a directory.

There's no GN CI in this repo; i checked this in an embedder build.

Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot · 2026-08-18T19:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75972/

nodejs-github-bot · 2026-08-19T13:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75992/

nodejs-github-bot · 2026-08-20T14:19:33Z

Landed in 5ba7e05

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65382 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere · 2026-08-18T14:12:33Z

The GN build defaults node_simdutf_path to //third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it as third_party/simdutf/simdutf.h), so the unqualified #include "simdutf.h" in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves.

This adds get_label_info(node_simdutf_path, "dir") to node_internal_config, which libnode and node_cctest already use, and to node_js2c's include_dirs. get_label_info rather than the raw string so a value like //foo/bar:simdutf still resolves to a directory.

There's no GN CI in this repo; i checked this in an embedder build.

Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot · 2026-08-18T19:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75972/

nodejs-github-bot · 2026-08-19T13:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75992/

nodejs-github-bot · 2026-08-20T14:19:33Z

Landed in 5ba7e05

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65382 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere · 2026-08-18T14:12:33Z

The GN build defaults node_simdutf_path to //third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it as third_party/simdutf/simdutf.h), so the unqualified #include "simdutf.h" in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves.

This adds get_label_info(node_simdutf_path, "dir") to node_internal_config, which libnode and node_cctest already use, and to node_js2c's include_dirs. get_label_info rather than the raw string so a value like //foo/bar:simdutf still resolves to a directory.

There's no GN CI in this repo; i checked this in an embedder build.

Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot · 2026-08-18T19:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75972/

nodejs-github-bot · 2026-08-19T13:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75992/

nodejs-github-bot · 2026-08-20T14:19:33Z

Landed in 5ba7e05

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65382 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere · 2026-08-18T14:12:33Z

The GN build defaults node_simdutf_path to //third_party/simdutf, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path (Chromium code includes it as third_party/simdutf/simdutf.h), so the unqualified #include "simdutf.h" in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves.

This adds get_label_info(node_simdutf_path, "dir") to node_internal_config, which libnode and node_cctest already use, and to node_js2c's include_dirs. get_label_info rather than the raw string so a value like //foo/bar:simdutf still resolves to a directory.

There's no GN CI in this repo; i checked this in an embedder build.

Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot · 2026-08-18T19:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75972/

nodejs-github-bot · 2026-08-19T13:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75992/

nodejs-github-bot · 2026-08-20T14:19:33Z

Landed in 5ba7e05

The GN build defaults `node_simdutf_path` to `//third_party/simdutf`, the copy that ships in a Chromium checkout. That target doesn't put its own directory on the include path, so the unqualified `#include "simdutf.h"` in libnode, node_js2c and node_cctest doesn't resolve unless the embedder adds the directory themselves. Add `get_label_info(node_simdutf_path, "dir")` to `node_internal_config` (used by libnode and node_cctest) and to node_js2c's `include_dirs`. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65382 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere requested a review from anonrig August 18, 2026 14:15

anonrig approved these changes Aug 18, 2026
View reviewed changes

codebytere mentioned this pull request Aug 18, 2026
build: replace the simdutf chromium patch with an electron-side include shim electron/electron#52958
Closed
3 tasks

codebytere force-pushed the build-gn-simdutf-include branch from 64cd05c to 857e40cCompare August 18, 2026 14:48

codebytere added embedding Issues and PRs related to embedding Node.js in another project. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

jasnell approved these changes Aug 18, 2026
View reviewed changes

codebytere added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 19, 2026

nodejs-github-bot merged commit 5ba7e05 into nodejs:mainAug 20, 2026
73 of 74 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 27, 2026