doc: clarify socket destroyed behavior by dayun6530 · Pull Request #65395 · nodejs/node

dayun6530 · 2026-08-19T06:34:45Z

Clarify the socket.destroyed documentation to reflect that a destroyed
net.Socket can be reused by calling socket.connect() again.

The previous wording could be read as if no further data transfer were ever
possible after destruction, while the socket can be reconnected and used again.

Fixes: #57367

Tests: make lint-md

nodejs-github-bot · 2026-08-19T06:34:50Z

Review requested:

@nodejs/net

daeyeon

node/doc/api/net.md

Lines 1446 to 1456 in 449b950

### `socket.destroy([error])`
<!-- YAML
added: v0.1.90
-->
*`error` {Object} 
* Returns: {net.Socket} 
 Ensures that no more I/O activity happens on this socket. 
 Destroys the stream and closes the connection. 

Could we also clarify socket.destroy() similarly? Its current wording could imply that the Socket object is permanently unusable.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 · 2026-08-20T04:38:02Z

Thanks! I updated the wording as suggested and also clarified socket.destroy().

nodejs-github-bot · 2026-08-21T13:39:58Z

Landed in c5d4ae6

Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

dayun6530 · 2026-08-19T06:34:45Z

Clarify the socket.destroyed documentation to reflect that a destroyed
net.Socket can be reused by calling socket.connect() again.

The previous wording could be read as if no further data transfer were ever
possible after destruction, while the socket can be reconnected and used again.

Fixes: #57367

Tests: make lint-md

nodejs-github-bot · 2026-08-19T06:34:50Z

Review requested:

@nodejs/net

daeyeon

node/doc/api/net.md

Lines 1446 to 1456 in 449b950

### `socket.destroy([error])`
<!-- YAML
added: v0.1.90
-->
*`error` {Object} 
* Returns: {net.Socket} 
 Ensures that no more I/O activity happens on this socket. 
 Destroys the stream and closes the connection. 

Could we also clarify socket.destroy() similarly? Its current wording could imply that the Socket object is permanently unusable.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 · 2026-08-20T04:38:02Z

Thanks! I updated the wording as suggested and also clarified socket.destroy().

nodejs-github-bot · 2026-08-21T13:39:58Z

Landed in c5d4ae6

Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

dayun6530 · 2026-08-19T06:34:45Z

Clarify the socket.destroyed documentation to reflect that a destroyed
net.Socket can be reused by calling socket.connect() again.

The previous wording could be read as if no further data transfer were ever
possible after destruction, while the socket can be reconnected and used again.

Fixes: #57367

Tests: make lint-md

nodejs-github-bot · 2026-08-19T06:34:50Z

Review requested:

@nodejs/net

daeyeon

node/doc/api/net.md

Lines 1446 to 1456 in 449b950

### `socket.destroy([error])`
<!-- YAML
added: v0.1.90
-->
*`error` {Object} 
* Returns: {net.Socket} 
 Ensures that no more I/O activity happens on this socket. 
 Destroys the stream and closes the connection. 

Could we also clarify socket.destroy() similarly? Its current wording could imply that the Socket object is permanently unusable.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 · 2026-08-20T04:38:02Z

Thanks! I updated the wording as suggested and also clarified socket.destroy().

nodejs-github-bot · 2026-08-21T13:39:58Z

Landed in c5d4ae6

Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

dayun6530 · 2026-08-19T06:34:45Z

Clarify the socket.destroyed documentation to reflect that a destroyed
net.Socket can be reused by calling socket.connect() again.

The previous wording could be read as if no further data transfer were ever
possible after destruction, while the socket can be reconnected and used again.

Fixes: #57367

Tests: make lint-md

nodejs-github-bot · 2026-08-19T06:34:50Z

Review requested:

@nodejs/net

daeyeon

node/doc/api/net.md

Lines 1446 to 1456 in 449b950

### `socket.destroy([error])`
<!-- YAML
added: v0.1.90
-->
*`error` {Object} 
* Returns: {net.Socket} 
 Ensures that no more I/O activity happens on this socket. 
 Destroys the stream and closes the connection. 

Could we also clarify socket.destroy() similarly? Its current wording could imply that the Socket object is permanently unusable.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 · 2026-08-20T04:38:02Z

Thanks! I updated the wording as suggested and also clarified socket.destroy().

nodejs-github-bot · 2026-08-21T13:39:58Z

Landed in c5d4ae6

Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

dayun6530 · 2026-08-19T06:34:45Z

Clarify the socket.destroyed documentation to reflect that a destroyed
net.Socket can be reused by calling socket.connect() again.

The previous wording could be read as if no further data transfer were ever
possible after destruction, while the socket can be reconnected and used again.

Fixes: #57367

Tests: make lint-md

nodejs-github-bot · 2026-08-19T06:34:50Z

Review requested:

@nodejs/net

daeyeon

node/doc/api/net.md

Lines 1446 to 1456 in 449b950

### `socket.destroy([error])`
<!-- YAML
added: v0.1.90
-->
*`error` {Object} 
* Returns: {net.Socket} 
 Ensures that no more I/O activity happens on this socket. 
 Destroys the stream and closes the connection. 

Could we also clarify socket.destroy() similarly? Its current wording could imply that the Socket object is permanently unusable.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 · 2026-08-20T04:38:02Z

Thanks! I updated the wording as suggested and also clarified socket.destroy().

nodejs-github-bot · 2026-08-21T13:39:58Z

Landed in c5d4ae6

Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

dayun6530 · 2026-08-19T06:34:45Z

Clarify the socket.destroyed documentation to reflect that a destroyed
net.Socket can be reused by calling socket.connect() again.

The previous wording could be read as if no further data transfer were ever
possible after destruction, while the socket can be reconnected and used again.

Fixes: #57367

Tests: make lint-md

nodejs-github-bot · 2026-08-19T06:34:50Z

Review requested:

@nodejs/net

daeyeon

node/doc/api/net.md

Lines 1446 to 1456 in 449b950

### `socket.destroy([error])`
<!-- YAML
added: v0.1.90
-->
*`error` {Object} 
* Returns: {net.Socket} 
 Ensures that no more I/O activity happens on this socket. 
 Destroys the stream and closes the connection. 

Could we also clarify socket.destroy() similarly? Its current wording could imply that the Socket object is permanently unusable.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 · 2026-08-20T04:38:02Z

Thanks! I updated the wording as suggested and also clarified socket.destroy().

nodejs-github-bot · 2026-08-21T13:39:58Z

Landed in c5d4ae6

Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

dayun6530 · 2026-08-19T06:34:45Z

Clarify the socket.destroyed documentation to reflect that a destroyed
net.Socket can be reused by calling socket.connect() again.

The previous wording could be read as if no further data transfer were ever
possible after destruction, while the socket can be reconnected and used again.

Fixes: #57367

Tests: make lint-md

nodejs-github-bot · 2026-08-19T06:34:50Z

Review requested:

@nodejs/net

daeyeon

node/doc/api/net.md

Lines 1446 to 1456 in 449b950

### `socket.destroy([error])`
<!-- YAML
added: v0.1.90
-->
*`error` {Object} 
* Returns: {net.Socket} 
 Ensures that no more I/O activity happens on this socket. 
 Destroys the stream and closes the connection. 

Could we also clarify socket.destroy() similarly? Its current wording could imply that the Socket object is permanently unusable.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 · 2026-08-20T04:38:02Z

Thanks! I updated the wording as suggested and also clarified socket.destroy().

nodejs-github-bot · 2026-08-21T13:39:58Z

Landed in c5d4ae6

Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

dayun6530 · 2026-08-19T06:34:45Z

Clarify the socket.destroyed documentation to reflect that a destroyed
net.Socket can be reused by calling socket.connect() again.

The previous wording could be read as if no further data transfer were ever
possible after destruction, while the socket can be reconnected and used again.

Fixes: #57367

Tests: make lint-md

nodejs-github-bot · 2026-08-19T06:34:50Z

Review requested:

@nodejs/net

daeyeon

node/doc/api/net.md

Lines 1446 to 1456 in 449b950

### `socket.destroy([error])`
<!-- YAML
added: v0.1.90
-->
*`error` {Object} 
* Returns: {net.Socket} 
 Ensures that no more I/O activity happens on this socket. 
 Destroys the stream and closes the connection. 

Could we also clarify socket.destroy() similarly? Its current wording could imply that the Socket object is permanently unusable.

Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 · 2026-08-20T04:38:02Z

Thanks! I updated the wording as suggested and also clarified socket.destroy().

nodejs-github-bot · 2026-08-21T13:39:58Z

Landed in c5d4ae6

Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

nodejs-github-bot added doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem. labels Aug 19, 2026

jasnell approved these changes Aug 20, 2026
View reviewed changes

daeyeon reviewed Aug 20, 2026
View reviewed changes

Comment threaddoc/api/net.md Outdated

daeyeon reviewed Aug 20, 2026
View reviewed changes

doc: clarify socket destroyed behavior
00b9e59
Signed-off-by: Dayun <dlekdbs6530@gmail.com>

dayun6530 force-pushed the doc/clarify-net-socket-destroy branch from 27070c9 to 00b9e59Compare August 20, 2026 04:29

daeyeon approved these changes Aug 20, 2026
View reviewed changes

daeyeon added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 20, 2026

nodejs-github-bot merged commit c5d4ae6 into nodejs:mainAug 21, 2026
22 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2026

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
doc: clarify socket destroyed behavior
e1fa4b4
Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

aduh95 pushed a commit that referenced this pull request Aug 25, 2026
doc: clarify socket destroyed behavior
96b91dc
Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

github-actionsBot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged

aduh95 pushed a commit that referenced this pull request Aug 27, 2026
doc: clarify socket destroyed behavior
35007d1
Signed-off-by: Dayun <dlekdbs6530@gmail.com> PR-URL: #65395Fixes: #57367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>