perf_hooks: add binary export/import to Histogram

[jasnell]

Stacks on: #65416

Pay attention only to the last two commits.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/tsc

[codecov]

Codecov Report

❌ Patch coverage is 85.02825% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00c80a8) to head (b784466).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/histogram.cc	83.90%	9 Missing and 43 partials ⚠️
lib/internal/histogram.js	96.55%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65434 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 751 751 Lines 253439 253789 +350 Branches 47730 47808 +78 ========================================
+ Hits 228448 228775 +327 + Misses 16256 16239 -17 - Partials 8735 8775 +40 

Files with missing lines	Coverage Δ
lib/perf_hooks.js	100.00% <100.00%> (ø)
src/histogram.h	72.72% <ø> (+4.30%)	⬆️
lib/internal/histogram.js	96.11% <96.55%> (+0.01%)	⬆️
src/histogram.cc	84.22% <83.90%> (-0.06%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[jasnell]

Notes for the notable change:

This PR gives Histogram a new binary interchange format

[legendecas]

require('node:perf_hooks').importHistogram(newUint8Array([0xa3,// map(3)0x01,0x1b,0,0,0x20,0,0,0,0,0,// 1 (lowest) = 2**450x02,0x1b,0,0,0x40,0,0,0,0,0,// 2 (highest) = 2**460x03,0x05,// 3 (figures) = 5]));

This still bypasses the checks and triggers assert on hdr_init retcode. I wonder if this check on hdr_init can be converted to be a JS error.

[jasnell]

Ugh. yeah, will have to make the validation more thorough.. will update shortly

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76472/

[mcollina]

lgtm

[jasnell]

Landed in 96b1293...7b6b21a

[jasnell]

Stacks on: #65416

Pay attention only to the last two commits.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/tsc

[codecov]

Codecov Report

❌ Patch coverage is 85.02825% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00c80a8) to head (b784466).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/histogram.cc	83.90%	9 Missing and 43 partials ⚠️
lib/internal/histogram.js	96.55%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65434 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 751 751 Lines 253439 253789 +350 Branches 47730 47808 +78 ========================================
+ Hits 228448 228775 +327 + Misses 16256 16239 -17 - Partials 8735 8775 +40 

Files with missing lines	Coverage Δ
lib/perf_hooks.js	100.00% <100.00%> (ø)
src/histogram.h	72.72% <ø> (+4.30%)	⬆️
lib/internal/histogram.js	96.11% <96.55%> (+0.01%)	⬆️
src/histogram.cc	84.22% <83.90%> (-0.06%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[jasnell]

Notes for the notable change:

This PR gives Histogram a new binary interchange format

[legendecas]

require('node:perf_hooks').importHistogram(newUint8Array([0xa3,// map(3)0x01,0x1b,0,0,0x20,0,0,0,0,0,// 1 (lowest) = 2**450x02,0x1b,0,0,0x40,0,0,0,0,0,// 2 (highest) = 2**460x03,0x05,// 3 (figures) = 5]));

This still bypasses the checks and triggers assert on hdr_init retcode. I wonder if this check on hdr_init can be converted to be a JS error.

[jasnell]

Ugh. yeah, will have to make the validation more thorough.. will update shortly

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76472/

[mcollina]

lgtm

[jasnell]

Landed in 96b1293...7b6b21a

[jasnell]

Stacks on: #65416

Pay attention only to the last two commits.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/tsc

[codecov]

Codecov Report

❌ Patch coverage is 85.02825% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00c80a8) to head (b784466).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/histogram.cc	83.90%	9 Missing and 43 partials ⚠️
lib/internal/histogram.js	96.55%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65434 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 751 751 Lines 253439 253789 +350 Branches 47730 47808 +78 ========================================
+ Hits 228448 228775 +327 + Misses 16256 16239 -17 - Partials 8735 8775 +40 

Files with missing lines	Coverage Δ
lib/perf_hooks.js	100.00% <100.00%> (ø)
src/histogram.h	72.72% <ø> (+4.30%)	⬆️
lib/internal/histogram.js	96.11% <96.55%> (+0.01%)	⬆️
src/histogram.cc	84.22% <83.90%> (-0.06%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[jasnell]

Notes for the notable change:

This PR gives Histogram a new binary interchange format

[legendecas]

require('node:perf_hooks').importHistogram(newUint8Array([0xa3,// map(3)0x01,0x1b,0,0,0x20,0,0,0,0,0,// 1 (lowest) = 2**450x02,0x1b,0,0,0x40,0,0,0,0,0,// 2 (highest) = 2**460x03,0x05,// 3 (figures) = 5]));

This still bypasses the checks and triggers assert on hdr_init retcode. I wonder if this check on hdr_init can be converted to be a JS error.

[jasnell]

Ugh. yeah, will have to make the validation more thorough.. will update shortly

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76472/

[mcollina]

lgtm

[jasnell]

Landed in 96b1293...7b6b21a

[jasnell]

Stacks on: #65416

Pay attention only to the last two commits.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/tsc

[codecov]

Codecov Report

❌ Patch coverage is 85.02825% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00c80a8) to head (b784466).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/histogram.cc	83.90%	9 Missing and 43 partials ⚠️
lib/internal/histogram.js	96.55%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65434 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 751 751 Lines 253439 253789 +350 Branches 47730 47808 +78 ========================================
+ Hits 228448 228775 +327 + Misses 16256 16239 -17 - Partials 8735 8775 +40 

Files with missing lines	Coverage Δ
lib/perf_hooks.js	100.00% <100.00%> (ø)
src/histogram.h	72.72% <ø> (+4.30%)	⬆️
lib/internal/histogram.js	96.11% <96.55%> (+0.01%)	⬆️
src/histogram.cc	84.22% <83.90%> (-0.06%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[jasnell]

Notes for the notable change:

This PR gives Histogram a new binary interchange format

[legendecas]

require('node:perf_hooks').importHistogram(newUint8Array([0xa3,// map(3)0x01,0x1b,0,0,0x20,0,0,0,0,0,// 1 (lowest) = 2**450x02,0x1b,0,0,0x40,0,0,0,0,0,// 2 (highest) = 2**460x03,0x05,// 3 (figures) = 5]));

This still bypasses the checks and triggers assert on hdr_init retcode. I wonder if this check on hdr_init can be converted to be a JS error.

[jasnell]

Ugh. yeah, will have to make the validation more thorough.. will update shortly

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76472/

[mcollina]

lgtm

[jasnell]

Landed in 96b1293...7b6b21a

[jasnell]

Stacks on: #65416

Pay attention only to the last two commits.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/tsc

[codecov]

Codecov Report

❌ Patch coverage is 85.02825% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00c80a8) to head (b784466).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/histogram.cc	83.90%	9 Missing and 43 partials ⚠️
lib/internal/histogram.js	96.55%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65434 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 751 751 Lines 253439 253789 +350 Branches 47730 47808 +78 ========================================
+ Hits 228448 228775 +327 + Misses 16256 16239 -17 - Partials 8735 8775 +40 

Files with missing lines	Coverage Δ
lib/perf_hooks.js	100.00% <100.00%> (ø)
src/histogram.h	72.72% <ø> (+4.30%)	⬆️
lib/internal/histogram.js	96.11% <96.55%> (+0.01%)	⬆️
src/histogram.cc	84.22% <83.90%> (-0.06%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[jasnell]

Notes for the notable change:

This PR gives Histogram a new binary interchange format

[legendecas]

require('node:perf_hooks').importHistogram(newUint8Array([0xa3,// map(3)0x01,0x1b,0,0,0x20,0,0,0,0,0,// 1 (lowest) = 2**450x02,0x1b,0,0,0x40,0,0,0,0,0,// 2 (highest) = 2**460x03,0x05,// 3 (figures) = 5]));

This still bypasses the checks and triggers assert on hdr_init retcode. I wonder if this check on hdr_init can be converted to be a JS error.

[jasnell]

Ugh. yeah, will have to make the validation more thorough.. will update shortly

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76472/

[mcollina]

lgtm

[jasnell]

Landed in 96b1293...7b6b21a

[jasnell]

Stacks on: #65416

Pay attention only to the last two commits.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/tsc

[codecov]

Codecov Report

❌ Patch coverage is 85.02825% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00c80a8) to head (b784466).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/histogram.cc	83.90%	9 Missing and 43 partials ⚠️
lib/internal/histogram.js	96.55%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65434 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 751 751 Lines 253439 253789 +350 Branches 47730 47808 +78 ========================================
+ Hits 228448 228775 +327 + Misses 16256 16239 -17 - Partials 8735 8775 +40 

Files with missing lines	Coverage Δ
lib/perf_hooks.js	100.00% <100.00%> (ø)
src/histogram.h	72.72% <ø> (+4.30%)	⬆️
lib/internal/histogram.js	96.11% <96.55%> (+0.01%)	⬆️
src/histogram.cc	84.22% <83.90%> (-0.06%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[jasnell]

Notes for the notable change:

This PR gives Histogram a new binary interchange format

[legendecas]

require('node:perf_hooks').importHistogram(newUint8Array([0xa3,// map(3)0x01,0x1b,0,0,0x20,0,0,0,0,0,// 1 (lowest) = 2**450x02,0x1b,0,0,0x40,0,0,0,0,0,// 2 (highest) = 2**460x03,0x05,// 3 (figures) = 5]));

This still bypasses the checks and triggers assert on hdr_init retcode. I wonder if this check on hdr_init can be converted to be a JS error.

[jasnell]

Ugh. yeah, will have to make the validation more thorough.. will update shortly

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76472/

[mcollina]

lgtm

[jasnell]

Landed in 96b1293...7b6b21a

[jasnell]

Stacks on: #65416

Pay attention only to the last two commits.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/tsc

[codecov]

Codecov Report

❌ Patch coverage is 85.02825% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00c80a8) to head (b784466).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/histogram.cc	83.90%	9 Missing and 43 partials ⚠️
lib/internal/histogram.js	96.55%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65434 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 751 751 Lines 253439 253789 +350 Branches 47730 47808 +78 ========================================
+ Hits 228448 228775 +327 + Misses 16256 16239 -17 - Partials 8735 8775 +40 

Files with missing lines	Coverage Δ
lib/perf_hooks.js	100.00% <100.00%> (ø)
src/histogram.h	72.72% <ø> (+4.30%)	⬆️
lib/internal/histogram.js	96.11% <96.55%> (+0.01%)	⬆️
src/histogram.cc	84.22% <83.90%> (-0.06%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[jasnell]

Notes for the notable change:

This PR gives Histogram a new binary interchange format

[legendecas]

require('node:perf_hooks').importHistogram(newUint8Array([0xa3,// map(3)0x01,0x1b,0,0,0x20,0,0,0,0,0,// 1 (lowest) = 2**450x02,0x1b,0,0,0x40,0,0,0,0,0,// 2 (highest) = 2**460x03,0x05,// 3 (figures) = 5]));

This still bypasses the checks and triggers assert on hdr_init retcode. I wonder if this check on hdr_init can be converted to be a JS error.

[jasnell]

Ugh. yeah, will have to make the validation more thorough.. will update shortly

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76472/

[mcollina]

lgtm

[jasnell]

Landed in 96b1293...7b6b21a

[jasnell]

Stacks on: #65416

Pay attention only to the last two commits.

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/tsc

[codecov]

Codecov Report

❌ Patch coverage is 85.02825% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (00c80a8) to head (b784466).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/histogram.cc	83.90%	9 Missing and 43 partials ⚠️
lib/internal/histogram.js	96.55%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65434 +/- ##
========================================
Coverage 90.13% 90.14% ========================================
Files 751 751 Lines 253439 253789 +350 Branches 47730 47808 +78 ========================================
+ Hits 228448 228775 +327 + Misses 16256 16239 -17 - Partials 8735 8775 +40 

Files with missing lines	Coverage Δ
lib/perf_hooks.js	100.00% <100.00%> (ø)
src/histogram.h	72.72% <ø> (+4.30%)	⬆️
lib/internal/histogram.js	96.11% <96.55%> (+0.01%)	⬆️
src/histogram.cc	84.22% <83.90%> (-0.06%)	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @jasnell.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

[jasnell]

Notes for the notable change:

This PR gives Histogram a new binary interchange format

[legendecas]

require('node:perf_hooks').importHistogram(newUint8Array([0xa3,// map(3)0x01,0x1b,0,0,0x20,0,0,0,0,0,// 1 (lowest) = 2**450x02,0x1b,0,0,0x40,0,0,0,0,0,// 2 (highest) = 2**460x03,0x05,// 3 (figures) = 5]));

This still bypasses the checks and triggers assert on hdr_init retcode. I wonder if this check on hdr_init can be converted to be a JS error.

[jasnell]

Ugh. yeah, will have to make the validation more thorough.. will update shortly

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76472/

[mcollina]

lgtm

[jasnell]

Landed in 96b1293...7b6b21a