Uh oh!
There was an error while loading. Please reload this page.
doc: improve onboarding extras formatting - #6548
Conversation
jasnell
commented
May 3, 2016
Two stray commits in here? |
There was a problem hiding this comment.
Would much prefer to make these all team references and begin moving away from specific individuals. Doing so has worked effectively for things like lts, documentation, streams, http, and crypto. For instance, I've created a @nodejs/buffer team as an example.
The downside to mentioning specific individuals is that it creates a disincentive for new collaborators to feel empowered to jump in and help with the reviews and puts too much emphasis and burden on specific individuals.
There was a problem hiding this comment.
For some areas, yes.
For other parts of core, I think this is still correct until the knowledge becomes more distilled and distributed as more people learn the codebase, and while that is something we should work towards it doesn't necessarily reflect reality.
There was a problem hiding this comment.
Having those teams be initially made up of the people listed here would meet the same objective, no?
Also, this should also list:
doc- @nodejs/documentation- anything LTS - @nodejs/lts
There was a problem hiding this comment.
@jasnell Will add those, could you come up with a better LTS description?
There was a problem hiding this comment.
I like the team approach, but do also see your pov @Fishrock123. I think we should definitely try to move towards having a team for each subsystem eventually.
There was a problem hiding this comment.
You can remove my name from testing as I'm on nodejs/testing and that's what people should be using IMO.
Fishrock123
commented
May 3, 2016
No, but I did have a stray commit in master which is why the base is now incorrect here, fixing. |
f50d7b8 to
0111f0fCompareFishrock123
commented
May 4, 2016
This was mostly to fix the formatting.. can we land this and then PR any additions after? I'm accepting, and had already previously accepted the list was not complete and we should probably get the collaborators to to fill it out more. It's designed to be a baseline guide for those new to the project to be able to CC at least some people. :) Also, perhaps it should be in one of the other documents, I'm not quite sure! |
evanlucas
commented
May 4, 2016
LGTM |
jasnell
commented
May 4, 2016
No objections, just want to make sure it's not left undone. |
0111f0f to
f643e94CompareFishrock123
commented
May 9, 2016
fffff this has that stupid |
f643e94 to
02a2926CompareFishrock123
commented
May 9, 2016
@jasnell lgty? |
jasnell
commented
May 9, 2016
Looks fine. |
benjamingr
commented
May 9, 2016
LGTM |
Fixes some formatting, improves some formatting, updates minor nits. Refs: nodejs#6655 PR-URL: nodejs#6548 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
02a2926 to
2fee506Comparemscdex
commented
May 9, 2016
FWIW explicitly mentioning me for |
Checklist
Affected core subsystem(s)
doc,meta
Description of change
Fixes some formatting, improves some formatting, updates minor nits.
I guess we should at some point do a call for who wants to be on the chart.